From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB1824305E; Mon, 14 Aug 2023 10:52:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86BB440A7F; Mon, 14 Aug 2023 10:52:34 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id D1EC24021F for ; Mon, 14 Aug 2023 10:52:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692003153; x=1723539153; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=2lT2SmHUo4nMkgYWPSM57UyZiRXjYdhP3PKyPZQl8KU=; b=fmISO4a5Og8Dw4x7VPLfFksz+hwTyZ6Zn5ozJIva14DfaCavnoKqZ2O8 AYf5lS4B/nmYrCTfFcs0ymVk/5RYDxDQNb5B9eVJypIBv5jYgaK8rku19 jVt9RtxHXFOMLqkqPyIhlpnzH+r2ukritKFof7zWyospU7BIsI8fc2AyZ EZIIjqKbttCOIV65meHufYIy3xWROMpGM9OMwGKcnKFcrF5TWMo1BQrll tU9W6p/Laxji6RGrP02rWw2pHgArB6z4tiJrA2ImP4a+khmNJG0DfaBn6 6ZhyPlw/q0EcUlx0RtHOhbnvSXUzQq55OU99/wQ04bdIoMBcerZ1AN6kc w==; X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="458357600" X-IronPort-AV: E=Sophos;i="6.01,172,1684825200"; d="scan'208";a="458357600" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 01:52:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="857007039" X-IronPort-AV: E=Sophos;i="6.01,172,1684825200"; d="scan'208";a="857007039" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 14 Aug 2023 01:52:31 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 14 Aug 2023 01:52:30 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 14 Aug 2023 01:52:30 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 14 Aug 2023 01:52:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mVKf184ggRN8KvsrIkAd9NFph+kwJ14XPyDk00MiRvMEuyzcdeAqMMprtnXTXHWQwNpKX6q8OjGflrHSZFBJEXE8hTGc5CCovazEcyb3EuvE5/yuYHYqvlV+ikSp+nk57jihZVXprze6mqPukv1MHPnViifaK7WWwqQ51VO9H6qZYOIkUdAgBIKCtYJyz/wFYPx3Z05Gy0btEFBN0xeFPGjSJrp8kzvKDA3VBWBcPpgmLDQgZuaD6v4W9YqaaJGzOz+Y2JG7QhChsE3QF1tdB9Z2DVbEz5j9K+3zdpsZ/snynzL9kh5OFmgu5sXRud0aZFYXFzK3VjrYi/Tk2JI/Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IK6cvpO5QCBV+qNb67qjnvgczUPC09onvUIxKVKVl64=; b=DMikAyy3DH7W6SQL3mq7i482MBio4TziRDvFTuFbi5CChzCMPyfY+FhgOvGKvEY1Em1cdx6XSGssMZF/UXR/ytP/88MU+clAiCuGwV2eXpnPcp1Nw9DTdOhzbemggc9hsJSGTuNw2uUBg/g6ZLHESeDbn4nbV4KfWEQm4hvzYab5tS6n+hID0fM/Q1M4wVc0XSnoICpHZwsyybUxRu6E2HQWNRtBBRjsMhSmbRfBz7hsI30hosUhgQWsAPij1DCfg9kKBjxo9T3Zcdphn0nHGL8WqjKHmFXxJYBjvkl8o0kpTGsT1X1JwkV8wAYQVJw/S1I4qTEbI/Eps53nY4fO8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW3PR11MB4649.namprd11.prod.outlook.com (2603:10b6:303:5b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.24; Mon, 14 Aug 2023 08:52:28 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6678.022; Mon, 14 Aug 2023 08:52:28 +0000 Date: Mon, 14 Aug 2023 09:52:23 +0100 From: Bruce Richardson To: Stephen Hemminger CC: "Varghese, Vipin" , "thomas@monjalon.net" , "dev@dpdk.org" , "Yigit, Ferruh" Subject: Re: [PATCH] usertools: suggest use of hwloc for new cpu Message-ID: References: <20230812005720.997-1-vipin.varghese@amd.com> <20230812080025.7626a94d@hermes.local> <20230813085201.719e7a73@hermes.local> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230813085201.719e7a73@hermes.local> X-ClientProxiedBy: DB7PR03CA0091.eurprd03.prod.outlook.com (2603:10a6:10:72::32) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW3PR11MB4649:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c15c6e9-ed37-4e30-700c-08db9ca3c9df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z7MXw2unUm+1z6e/JykqE7THPGO4TMawQrUOt692XOaU1OUgUPFT4yUjYwQsUNUFIKVGeV7TAz12yMs351I34VFnX83xxhGEiVEMHtAmfexAabILIADv0npkbJBqiD5XczUOpcyYvh/HC0dppf5qdShkvLp0c1MhCN0ajOxXBcvl97E0TiH0Z5OAiDNodkl8wSfCRcoyimxiODATa59+jaGbbA0iBLeHZZWYlwA3aDAxe7NAEo9tJiHqMubGC9wgnMlAkNzMMEqVvvIS02icssn6s+EWOGEd6/uRgB1Ir7zzfGiF58NNT5oQ7lv9xLw8qe03DcK6pjSQNoSzftThvy49misixo+Nm+ks5CoVQIzQQKpB0HAtKAONBMdJsWGv+g8RUDRHJ0tX4d09ofJLx/veC0q95Lfo4Q1vJFmo55x13yYNtelqgDxfG8OKEfEn82bGjvbYWN3ZTizc5bdbQPWJ9folv+tqxMnxeDQRx5g8azBlhd7dJcxDlZp7jAHtK9oyvQmUx8FVBG0SKqnK5eiHudq8mR9jDrZmA376aTrRiDVYKfHVHNKj3h2QAudn X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(376002)(346002)(136003)(366004)(39860400002)(186006)(1800799006)(451199021)(66899021)(6666004)(6512007)(6486002)(478600001)(54906003)(83380400001)(86362001)(4326008)(6506007)(26005)(316002)(2906002)(82960400001)(38100700002)(66946007)(66476007)(66556008)(41300700001)(44832011)(8676002)(5660300002)(8936002)(6916009); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7MHR2Ldaqf3sv+vkeq6T9C0G1+1vMxKsLgJchK0jfyiq08uDod73mmGpTUMg?= =?us-ascii?Q?uhprkfs6NqaUGPHDHwFA5UL7DejMjmnVYhctc+k7bt1Se3339nztj7wC/QH2?= =?us-ascii?Q?JrFaeUozlRKWNpYFXcpVDkdv3fm03nvp3h/MwmSHiKidCRMEZ8HYJJoN1AC2?= =?us-ascii?Q?VW5bsX+n14p/gOyVVKFMhc3qFMPJ4H+ARa4i3kNuuMvOKwPHeEPrsbqwggLf?= =?us-ascii?Q?9SOKkHRTvapybhdbVohPlmpmUVew/o+Tbu6xo6advMKEQjfM74v/iaWFMAq7?= =?us-ascii?Q?ORAnSp+JJBtw017NrxjnZUH883++FlK18Dxf0MuA7/mwMO41MiQjRU3SKGo6?= =?us-ascii?Q?RK5amND1YBs29mygV41M42a2+TmnExlWQmgwiwyQjrJ/CLzFNGxY3HL79cVS?= =?us-ascii?Q?+QUIAgH1/iWZSFZAecIj3/iH7VcrA/X4PphfTUm5C9YJLRqU3Xzx4Y0cC98o?= =?us-ascii?Q?yVskkh3Tqz4GDyMDgduc3Oxu4T/W6dbuN+mr/wbDdc4Hl+bR0G1PaWvonwFW?= =?us-ascii?Q?atGYVrjrQH6icn16z3vkBc/q6zwqhVJS7YiPEukSw/YMAA8Crjpa09ezUCR2?= =?us-ascii?Q?qcC9L3Dzd4BZ1QHiZcEj6P9KlttDWrvZWDcSKJdj4hHHXwzCJHB8yMsfxTht?= =?us-ascii?Q?JDt+VDjHkRzIC8xStm6TKTg19aakUzvg8QyaPEsYq0z94jxZ/tMyHUYH1wD+?= =?us-ascii?Q?tFay/PTNVcEE9GzNUELrSO3DSrF9EW7p3plX0BUW+oyIkzNohPICcq/w6vJO?= =?us-ascii?Q?FoQHrrSNCBfZ3yTIuN/x1CtQErO3Syv8IBrlL3J22zOf9sT61/o5YLHVx8Db?= =?us-ascii?Q?BgFegYa1kMx3pG7vj3wnXQFTlzOfw7d3hUPD11fPjcUerXZnAyA80cLB/jZ7?= =?us-ascii?Q?lOFqfCMvTmAYleGIifaN40Bf0KY4iMxVetI3+IhPky/E8ZtEmPiIqiAY+HqC?= =?us-ascii?Q?ypuDtLwymicSpawmXnqPrce2G7DT145DoZggO4gzbMFG/bzM4rsUGJsNEBg4?= =?us-ascii?Q?p2zKJy4V5tYAJ093pnYOGGP/6QrXC0i37YR33gRJClPG2vHYypu4TktAh+sm?= =?us-ascii?Q?y/FRjkdYEJmhtBtfTlXPYWoTm27lcH+Hrssc9ZDW+TXNifeTRBH1G4OigqFS?= =?us-ascii?Q?sdK5WKR80CvWU8ERzSgt7olkTnkSjLGJu7JTpWvQlKSOy+lxGfj1P/BojoAm?= =?us-ascii?Q?2gEvRLli6Mqpu8g0G2T42zzOLq0I6/5w418TKNdfNDfeJr9nQwXsTN04Cd1R?= =?us-ascii?Q?3ZSHSPc41kEN892BupDZCLXFkVfeSWSFjxdtncYg7UYkLpntzmdWZYK7aV6P?= =?us-ascii?Q?vD/EoJLzgj6vCWjCawfcinTyoU0/XR6i4lsVOQgKWIXcBBN+0BZeW89pzyUy?= =?us-ascii?Q?xJFCS6OaPLLCLkFM0mxKXzPmk5sb+2O5IhcTopP/u+9i6jK9TUcwOQ5HlsKc?= =?us-ascii?Q?QLav6sib6o+EDS70Byeap0FtARpvXbv2igjDgv/O6zFXUUnyNMYUdnQwM9wb?= =?us-ascii?Q?VzpFwLeqlYzZfRIJJ2iTKYqo5S9aaPxtIJIHyksXGcznqFxanZoGTGUtOjT9?= =?us-ascii?Q?TaT3uotzMP2Ou0+hZgUITxFAJwIv3hctgJBSI+Qsm30WGNO8TnC9KjXq4B5W?= =?us-ascii?Q?wQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1c15c6e9-ed37-4e30-700c-08db9ca3c9df X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 08:52:28.5749 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u2lAsGnuuNYKf0we1PzFBCynlL/2xP0Svhikp+QtpVLSxDWS9ba9yrDIXmcfc4NwMQJ0LJI3BeTOqvc3NPZJSxxAA8P3WLuW2vHHzPLZsNQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4649 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Aug 13, 2023 at 08:52:01AM -0700, Stephen Hemminger wrote: > On Sun, 13 Aug 2023 02:12:03 +0000 > "Varghese, Vipin" wrote: > > > > > > > On Sat, 12 Aug 2023 06:27:20 +0530 > > > Vipin Varghese wrote: > > > > > > > Most modern processor now supports numa by partitioning NUMA based on > > > > CPU-IO & Last Level Cache within the same socket. > > > > As per the discussion in mailing list, suggesting the make use of > > > > hw-loc for such scenarios. > > > > > > > > Signed-off-by: Vipin Varghese > > > > > > NAK, no scripting hwloc, it is ugly and creates a dependency that is not listed > > > in DPDK packaging. > > > > There is no calls to hwloc within in thescript. Hence not clear what does ` NAK, no scripting hwloc it is ugly and creates a dependency that is not listed in DPDK packaging.`. > > > > Requesting to cross check why NAK is shared for `print` as suggestion. Hence, I have disagree to this. > > Sorry, I misinterpreted what the print's were doing. > Better off not to list exact flags, the lstopo may change and user may want different > format anyway. > > How about something like this? > > > doc/guides/rel_notes/deprecation.rst | 5 +++++ > usertools/cpu_layout.py | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 317875c5054b..25a116900dfb 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -185,3 +185,8 @@ Deprecation Notices > will be deprecated and subsequently removed in DPDK 24.11 release. > Before this, the new port library API (functions rte_swx_port_*) > will gradually transition from experimental to stable status. > + > +* cpulayout: The CPU layout script is unable to deal with all the possible > + complexities of modern CPU topology. Other existing tools offer more > + features and do a better job with keeping up with innovations. > + Therefore it will be deprecated and removed in a future release. Does the script really do that bad a job? While I can understand us looking to recommend alternatives, I actually find the script in it's current form really handy - much more so than working out the exact flags for lstopo etc. Since it's not a large maintenance burden, I'd request we keep it around - while still recommending lstopo to users. /Bruce