From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA71543060; Mon, 14 Aug 2023 11:12:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6950740A7F; Mon, 14 Aug 2023 11:12:34 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 4F4524021F for ; Mon, 14 Aug 2023 11:12:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692004352; x=1723540352; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=o2G65vU10s5qJgE1DPR3fAskoaqA+l4TkZxcxQX5+80=; b=gLATpRsLoDS8CLNIIZVpigpOT8ZWCrDbhyREqfSZ69fi+s2knCc6NjF3 dnvBWKv16bai8DrmT3yw0mNDXgzLl1Bve3IXYwImJNHxL4Ylh/wYecZ/y QgYXE5heFnWYhm2BSDBu1w/R1QMgMQRUSVKQwvEJJz81RTGfl1yDHEW+Q rhS+PfNjUGLN8md4J2rClhvfB8u5ecqxA2cN7n60rbTjobZngyS1pVzjf 4X0S7DGctzgOtZDSUbvzGc52dnudpkY0oZfx0QjGfihkBXvc3/JsXF0Nh +YV+sh+1SrKdC72s6suR8OkCi/Tn5I3aVxAKdO0XQq3BJYzPfq1sXT3wz A==; X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="356961550" X-IronPort-AV: E=Sophos;i="6.01,172,1684825200"; d="scan'208";a="356961550" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 02:12:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="847565094" X-IronPort-AV: E=Sophos;i="6.01,172,1684825200"; d="scan'208";a="847565094" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 14 Aug 2023 02:12:24 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 14 Aug 2023 02:12:24 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 14 Aug 2023 02:12:23 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 14 Aug 2023 02:12:23 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 14 Aug 2023 02:12:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RcsMbM0queHH4/DfvNCyVbes6+e3brmfPfAu1rt9wn0BB6lMHRd/KqAYo4si5oRRQqy4ZvQP3rdZxmR2WOjX65kaelIYke6EL82UTt0Z/ex0gv2qGuHOB+ckv0sckOXgi5bJnA3Y7IXCONxZwbZX5wsIIfuuMWOrAT3+T8YYn60RK+f+8+XjAdsUj784HoAXYzkE8e+zADJ7gtMpyH3SXGp+R/OD3KDA3zSKthB7iHcDJVkBe3V4j8yPEXG99+EW+aDM4yTWjhUta8kjlVw9/kudke+t8dTHauZXuo0XMpkU0iE6mKnaAsgrHAS8PBOGLHYD4PirtoNXIACBh/N9Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d4pCpfZmLMrHi0YRsitrp9CgrT/jDWZbA88SpFPwNww=; b=FjZXHtdW7ilKIE80FA/6nWpGQTJMZYtDmwNFM4B/OhCOWOBzgRITMNIDIg/radkbSLAGHg+M/Dae8Jauw38EG48MGu2FNOVUloguUR/RGKqU8zuw8FFn7j8UKnoHIRm3EYxO7Q/IxWC2n3nYi0AX1IS93nOjWOlNlvwH6CkWv+6TsbRssKR2djWM3/gIe7FVsisG4vUpxfpOqR+00ine+62HQML0lN11vq+c3iIK48RgGbDixhYDA6xKcpvUOicGRF6oUweG7twzYqCq07s43B+WcQlYRx+iw+87/iCbAn18fTU8/bh9HOEkL52G3ktcKfIdZqLcZj1QA6MEx9x4Tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN0PR11MB6230.namprd11.prod.outlook.com (2603:10b6:208:3c5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.24; Mon, 14 Aug 2023 09:12:21 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6678.022; Mon, 14 Aug 2023 09:12:21 +0000 Date: Mon, 14 Aug 2023 10:12:15 +0100 From: Bruce Richardson To: Dmitry Kozlyuk CC: Tyler Retzlaff , , "Konstantin Ananyev" , , Subject: Re: [PATCH v4 1/4] build: unblock the use of the MSVC compiler Message-ID: References: <1674674707-3094-1-git-send-email-roretzla@linux.microsoft.com> <1691778287-15746-1-git-send-email-roretzla@linux.microsoft.com> <1691778287-15746-2-git-send-email-roretzla@linux.microsoft.com> <20230814120734.568741b4@sovereign> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230814120734.568741b4@sovereign> X-ClientProxiedBy: DU6P191CA0013.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:540::24) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN0PR11MB6230:EE_ X-MS-Office365-Filtering-Correlation-Id: 34e1b14c-7993-4bf3-115d-08db9ca690f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IAwjI1Hp9bKAk1uvt0wghlt7MrU9xJKUMaC5R7KMM2ElrJ/g0Kj8ZOAbblOYOm/wAMcv9r63Cjr9rMIsjv6sEYW2pGl+y4YVfsZmT2Y4aSpaU+Muouqd1p2Gs9AJz+AWd70ih7FeaAwqZrnW/3gMbz7z9i+o+yugramRColyoTskzrmCOpjh0hT8o8jY271X9dgWa0s4fn3M/HR3iWjGcBnjmBof9tN55CpSrCSNhGHhrlsSlRq+5G1TnHgRAvOUVM7+zCWM7IrcL0Ni1W8U1S2skbzFoQXdsQz2w0LKRQx6C+7avJHmB6vApbzUzmfkIvVXKV8xAz5gBmD0M2D+f6zMeZhlS0UAl5c7obfuGDybJlwCkBpXux0g6H5Kxcqf3l5tLvzYW1wYIJeN5DEvz6drUiTdDA/cZALqHz/VssRNFo0xSI/+Nj0x5pGrqgXTH2owq6uyyquoetXR0F101+X59JJPEwmuvDjA86RaGyFu6gYw9JhsrUFEMnk5bqhUKfCgJ7VtS5+DPO0agtP9gLFpADduiL0RO+Cge/LvTqPIFsjc8yNZzZimRDkCYFN+WWaVyyGEpb9C2DKtjlsdiP2cxneWiIPvS0+EU/TmltA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(376002)(366004)(136003)(39860400002)(346002)(186006)(451199021)(1800799006)(4326008)(8936002)(6512007)(86362001)(478600001)(8676002)(6506007)(6486002)(316002)(66946007)(54906003)(66556008)(41300700001)(6666004)(66476007)(6916009)(5660300002)(44832011)(26005)(66899021)(83380400001)(2906002)(38100700002)(82960400001)(460985005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Yg+gVuFWBG4ryUQVWdC3gK2QJpMUSkAh5IyDFeSihjZRHz7uDecDEBTIiQ4K?= =?us-ascii?Q?QDarM53X8hfo6S/k3OgQyic+WwUYtJfIzuiszSDgnEcsPbaacQ0i+Ty4KH2M?= =?us-ascii?Q?ak7vy2D81oUmla6Syl4nhUt7LAgcm5/tyR8plF7LBkxxSvHcAbs45hFYeHf8?= =?us-ascii?Q?xkRfw37U66/gctGun946KSF8fMoszq6vXuM2CSdbm97c1xG7FLDzEEeyez/z?= =?us-ascii?Q?o+WO6On5pYGb3Sv3phEifCA1OTkpkkFlfQuiLay/p+kzuD4uoSXZYtIFrLyZ?= =?us-ascii?Q?wlC2Z8tZdt4M8j9rmMFLa5rrV4wu7G6FQvnr/FKXUNUjyyUDP3YXjvMGXDvi?= =?us-ascii?Q?gqmbIkLcKbOXptodNvcy/6V4pj1myBm1IJRjbr0b6Eujb8rN3bZ/eREEfpvO?= =?us-ascii?Q?1Tgl8Lk53wf4E4CiX/to2m2a6/ZXCL64yslSnctgtt2wQpTWTH5EZyN8Q1nv?= =?us-ascii?Q?IYSNe+hxNm0O1j9kqVO2t0/ZXnUq2YacWvfNmS7ezZ6q5YGb9Ipw54stuTsi?= =?us-ascii?Q?YHbVcopS897Mdr26t4XIUOMY8EPD9wlhyNHJ7eOp1koqDi918KOlKYIWRhq+?= =?us-ascii?Q?R5qrX0v8X5h3UDPbTpSVstNwf2fiUiQman8fRaYNQS3M3VxzBENWJ3ZsL3/P?= =?us-ascii?Q?qFYNHX8VNrEZgGbe/SHdWLFUrPpekxUPvwtqIz0qVGRuFcLU/rzHsPubFqEW?= =?us-ascii?Q?ETf8WwBAL7a7oFRoZ0MNII1cO4ACjse36RSpRcoq5HTLnjTvf+J9rnnVN19x?= =?us-ascii?Q?Baxeq8yDhd3vZthrFYXO3dmZqNfsh94uIgEnxLm0k4/RiAV0BbX3hYAfaeEe?= =?us-ascii?Q?INZiRZ+G6LEp7/cJkq+p3gb4xh9YMKbsRkg3qpmAbQ/4bPTsl2OTpvVmHFhn?= =?us-ascii?Q?Cy+NqH3CfnMnQ/eQ2jl2DMlM0jE+7O9/eYsj/dGpzN5bFfqnjqN8sH36YyKj?= =?us-ascii?Q?QZ+wFKGGZYKARivKSFwONu2CRrIBFnVwb4IPUskts+e6bgSzouGJRpxPISBn?= =?us-ascii?Q?8aAhceKJ/b1Y+hSHMFyKcnRmFe0J76ZjjU7h126/c7PWsMkBB1t0C38vA/kr?= =?us-ascii?Q?XUI3Epf64kbuXQc/tWKUjeU/ANeg4W+eqc1It/qyWhO+jjrviUKQXEgwOkbT?= =?us-ascii?Q?TZnbABuwdKZ5Ofra9eBRV+tn9PEYC6y1j+ERRR5PUWlhh8xM4dLAIFcm7Jt1?= =?us-ascii?Q?MRfJmAO/ZCBQLr0HLTs9pW+x1OJbbGbR+puc1hJm1c4H7zoIHoAKdQDApX3C?= =?us-ascii?Q?A7E+rbvdh4zrn6gOdqynJ3zf/ptvOvRyf85p3qH7sTSwthpqG5l2xJviUAEm?= =?us-ascii?Q?Jkigwa3MEAz4iQ/9pGdGwBHQtSsQ/8dRX+AZhWddyCltjYZNCygOg8Zx0I3r?= =?us-ascii?Q?WJF6r5IYrf/JMgfQueq6iy8slbpXcodfYxRhA/QXkoV+mlloWYyWLNFJNZ2l?= =?us-ascii?Q?2+Y+4IxvEsj7VA7EYUw5bfcjAsWeD5feNYqbv/6cj+7Ezzd8EsiKcgCyh6xM?= =?us-ascii?Q?+gLbHgDoNk64vAiq9GGXCFZhyARBPtbCduN6rTDCKCllROmHHFYhlvGvahv8?= =?us-ascii?Q?NXhy9AEgeDPjErfNBmH1j9JNLxMhRO9PLQhbG68/OI9aqf+OWJbKRQ/bYUBl?= =?us-ascii?Q?+Q=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 34e1b14c-7993-4bf3-115d-08db9ca690f8 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 09:12:21.5474 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sDxwMGv9ZPhWbmiia/T2UOOk5t8fpMNGA0pK+NWnL+jRbLnQ1ncwt9bACGHEV+tftVQYjyz4+VzXAO9UFr56HjOqXGBdFzOr0gtEO1xWrp8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6230 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Aug 14, 2023 at 12:07:34PM +0300, Dmitry Kozlyuk wrote: > 2023-08-14 09:27 (UTC+0100), Bruce Richardson: > > On Fri, Aug 11, 2023 at 11:24:44AM -0700, Tyler Retzlaff wrote: > > > Detect when MSVC toolset is available and tweak toolchain arguments > > > where the meson build system offers no abstraction. > > > > > > Signed-off-by: Tyler Retzlaff > > > Acked-by: Bruce Richardson > > > --- > > > config/meson.build | 23 +++++++++++++++-------- > > > config/x86/meson.build | 10 ++++++---- > > > lib/meson.build | 13 ++++++++++--- > > > 3 files changed, 31 insertions(+), 15 deletions(-) > > > > > > diff --git a/config/meson.build b/config/meson.build > > > index d822371..b6c7d48 100644 > > > --- a/config/meson.build > > > +++ b/config/meson.build > > > @@ -16,7 +16,8 @@ endforeach > > > > > > # MS linker requires special treatment. > > > # TODO: use cc.get_linker_id() with Meson >= 0.54 > > > -is_ms_linker = is_windows and (cc.get_id() == 'clang') > > > +is_ms_compiler = is_windows and (cc.get_id() == 'msvc') > > > +is_ms_linker = is_windows and (cc.get_id() == 'clang' or is_ms_compiler) > > > > Question out of interest, what other linker option do we have on windows? > > When is the second part of this conditional false? > > MinGW: GCC + GNU ld (the second conditional is false) > Clang: clang + link.exe > MSVC: cl.exe + link.exe Thanks. I'd forgottena bout mingw!