From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2056343066; Mon, 14 Aug 2023 18:47:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5CDB432A7; Mon, 14 Aug 2023 18:47:23 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 2EEDC40A8A for ; Mon, 14 Aug 2023 18:47:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692031642; x=1723567642; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=3kzRFimTRu49d5nAVhtAVgLcjXgLooxiy/fd4o3iklA=; b=MeT3IJM/JpQDpRhc0J0Cd5O+xELIKqjj6zL/kQaJxnCHaqudtJ2fX7g1 p6eyb4u7DjqzC2kt3xtUyrTnFqHSYNBgb7QTYTX8Lr7VVUhfbeKyDDhSA IcYArBZVhEL39BHUEH1jTDky6c5mIKq/VPVZJzHiVKX9UK7uJS5RIwQOD /MgkK3foOUGqKYc4b3Rctt7uSIiEBrIU2fONT0EJHInZfMc2iy3lXhD4r ftXjkZEn7gYvJfQNQ7et+3uBK2CmyAVljd6IjXgQ0yG7gOZ40p5p1BHBo S9HBiij5TECdDpOU+dKf7opADzVJLx3LC8lvJTV6a8sEQzL2n4vOoYMDW w==; X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="357048028" X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; d="scan'208";a="357048028" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 09:47:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="733517663" X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; d="scan'208";a="733517663" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 14 Aug 2023 09:47:00 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 14 Aug 2023 09:47:01 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 14 Aug 2023 09:47:01 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 14 Aug 2023 09:46:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZAo25lbkP79nuvDRIdEDD/brCen78/OkSL+nTqb7Ee48+ZBJNnztVSIccuMHsl9nWFHiBiroj5eqegyA+Dx6O7cSz7EbjQ51g2RDDxtG6W/fVH2FArgeo/M05QJCFy43UKxvjPhSrpi0CKpdkpyXyP5wdD8rFWNrMU97fgMGuE8gHmL5PmduxCWGjbHseysYK2lHCI3HCGbaulylTPFikpNt5Bxh/1kNIUrH5HDKly9R0Hk0bNxOCuDDAT9CYzWFSK+PiIKawDOoxCB46oFJ+gntSSinRnEksDbEu6HocKkOrb2cGnwLqvs9AGuLltQZELLg9jdvvsBKmzDLvbOHxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=igXvSH/gHYwi3epzODxMoZ3mmzsGD/4xb7dKppN3HKY=; b=C/b/63r1tBf2efItTFCWw0AzM2MJSe59tPjG4EdIyhTLv6PeA312exIUzVI4pG4d7xJBjn6RpoBDBrUba+W1sLYu9Yx/KG8VWd9gZbnbeEKdCx+7/IjYnLAnBMowiPcf/eWPA4LeDx72mpj44888uXyIuZB70k/L+LF/xh2aG0mpoVNCsYkalBnhXRVEuWC1ABPox7EmUOiNRKrqmcpV9zujSNHSlaY+HKb02lBcQgSnp+cIWBngGi2fh2LLtPsHw4/VbrIxGn8Tvt3w+aTshfkVVkejE1RmIkCJe2yanntZlbFrNpmMZuMNK6K+5jZ97x/lNtcJYYw7fcLkbf8m9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB8210.namprd11.prod.outlook.com (2603:10b6:610:163::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.24; Mon, 14 Aug 2023 16:46:54 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6678.022; Mon, 14 Aug 2023 16:46:54 +0000 Date: Mon, 14 Aug 2023 17:46:48 +0100 From: Bruce Richardson To: Tyler Retzlaff CC: , Konstantin Ananyev , , Subject: Re: [PATCH v4 4/4] build: enable MSVC specific compiler options Message-ID: References: <1674674707-3094-1-git-send-email-roretzla@linux.microsoft.com> <1691778287-15746-1-git-send-email-roretzla@linux.microsoft.com> <1691778287-15746-5-git-send-email-roretzla@linux.microsoft.com> <20230814161053.GA10752@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230814161053.GA10752@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-ClientProxiedBy: DB9PR01CA0009.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB8210:EE_ X-MS-Office365-Filtering-Correlation-Id: 2dc68e17-6a10-4290-8bea-08db9ce61103 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Zlx3m+XEXWL6dl1BFv7cDOT3AK1+ohvGNvey2SGrO8uQLPogzjM1FPP0A+eqZGhMDFQ7QXGYt15uCoWhJxwpkmN2+7JSbo7K/jDdq2lHmQdNrXswit+f0gJgKAV144hHU47qWutSfQTbjSgx85+uN6IDGIYdnbuCI/LurO0jUZjT9HpB1RZG7Si6FVhWGm1r45Hz+O2aUSIjyifrWjW9w07FcHBfywSCOOr+lKzw3/LZUZGeribQA7iMk2HS+mpg65TdNjlq6nKEZFMmg0uYGeNhiUT0aWWDJOwruJjihH91epvG555OrnqVpQfhvrrnoGkbVsswuw+b0RCcu2AbW7ZHCpsatzx5XuEPnskjpUNcoohR3r6y0uexbk/93cd0QKTPRPjqNjVBDA2Wk0rBcwlDkIUAzBq5gyL6fdlCT0yiy/sdjwsu0j5TUb7WMxEPOonn1xFu/Q7KJGnw71YzUYr0oQzLnsU3DHU+PTuFlV8k7+j9xNKVQdIzPaAqc7zEEz88n2sakaDOqA5zmecWVDAAekJVWSAipYue4A1tKhWLrYF+OHgj8RpUBNPwkPDBVmKv/U0yqtAdHnkZagiMenmRd3prlaPCz6Y8LIYX3C4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(396003)(366004)(346002)(376002)(39860400002)(1800799006)(186006)(451199021)(6512007)(6486002)(6506007)(6666004)(478600001)(83380400001)(26005)(2906002)(5660300002)(41300700001)(66556008)(6916009)(316002)(66946007)(66476007)(44832011)(8936002)(4326008)(8676002)(86362001)(38100700002)(82960400001)(66899021)(21314003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9tFcEqqLSZ8grlB/XMIXPA+7q9WPlJ7GA0Hf3yEEVN7bGjVoGzOw9wiwt7sK?= =?us-ascii?Q?Fh8iHhHECbYO5x9MXsrm061I+TFJMigD8d3BD58/4uDM5hCJSy1DXTdMFyD5?= =?us-ascii?Q?nA6TWjjibZxy/FBf5uXSUJLHkPdyNGeynxX2/IvWrUU+KDpXh4KUNoSuuTsr?= =?us-ascii?Q?7/ULWN7prXPqhzAHydL17BRr3KCu0EWgxiD9rIrR70BpEk/l2dbK/zKz2FM1?= =?us-ascii?Q?tOgVfpt4KZbphQnb63AddTsX9ZUDM/nW0zEBmzCD7Dm2bxMg1jFgyLMop/Ro?= =?us-ascii?Q?JqarZg2OynQLkJKeAMeBpFox97eXECycEuaYc99y0oiqz32JsSY+H4nB2oc6?= =?us-ascii?Q?Zeb+YFdL9j6xxkGHmcpqLEtk5tRw3ZoSvkpISd0X5NjzZfwGXFmac9UetyVL?= =?us-ascii?Q?630/HTFQnyTdniiK/Z6bQPI8k3Pm8Yokl9iqD15yWjJAdTTu98Pq6dNJ2cTP?= =?us-ascii?Q?ddzV2nBpizmnk0HcP1dt0ZLUozYpja4N9nTQLUc85JtjsWwQDINvBAu24wwb?= =?us-ascii?Q?rKnKIeKSntMyATuI5Ix8/mpKTVRiTVSy/caNVuDmzCoZcD1L3BSo6/kK0xu7?= =?us-ascii?Q?9uvmanJZTmvCDthkvgL5Eluls+zzn18YHwNeRWNBouJCQBuRc/AEVZp+Qmjy?= =?us-ascii?Q?63g+7rZECWT7cIhDwPGPGm0/lpAiU/O7sRPUf/B3F8cDybmhb18wtpANe9id?= =?us-ascii?Q?QRUspRp8PKCJslyy2Y2oqtDDQMdEEv2JKnIjdW5gwA6PHVZZfjUfZLtasm8b?= =?us-ascii?Q?R27FF+gAAk2r/39HBFztRIC0bZQNAJE8Mnkfe1EvriYHNr4EKKiP+7fEJItj?= =?us-ascii?Q?uuUePHyyzA0wwTD9X9OY5cvR9wFpvf1cneft3rVDBomzqKvU4dc+qoTEiBny?= =?us-ascii?Q?mwTDV8+Kqnv75JhyoaEEmOSOAZZsOQl7St/0G4RupUmGwuRLdG72iTJUc8P7?= =?us-ascii?Q?SNqFaSkv2V6yien3B5RldMVM2/PHoMJDCf9xXWTgh9YAZJ6DkWczHkrYnxPZ?= =?us-ascii?Q?PBqciS6cG8h2IkXlgO3iHpgnC4geHQYa6tSNC6LZGPI+b5Dp597OUqwd2YD1?= =?us-ascii?Q?iNK48an+9ebZFDVKCS6aWcT+AnyDCRKU6htqAfj0wQRCMnbKFgE2iK6/Iz62?= =?us-ascii?Q?jz+psJy8eagLb2P0RkM4jR1HFqPdCCNWuOUqZUqPPQRehfbbu0HIyypeHTMa?= =?us-ascii?Q?tfS4J7QE50wazD+5XL/83KJuvCV6DDWpNkgxXz/lkjceMtl1o/YkkE2LT3HT?= =?us-ascii?Q?pgsiWC41YRPsgIcFHszZCjblq9vHXbzkJzNuUV9VHh73V1rMYI26i/w3FULC?= =?us-ascii?Q?Ds5xPOf/GLksq4ROxIH48r9dD8wvCoMB9+LSgXaJLpyeJGMjtP43xUA1MSCO?= =?us-ascii?Q?weRID3fg8KI6iwLmrX5ablMgdI5RxUutXoxjpmYwjyNkP8O9DWdnpnQGWrUu?= =?us-ascii?Q?d93uqaKCdTUKAaTEGJaD0X2on+xEb/imy6fAlLdj0ct0Sgk50Dyd9rg3XU/l?= =?us-ascii?Q?baCIXA9PGrVaHYIM4fs0RbzLLE8owDZTQyHER1pRSWbl9aTJwShgVLthB/U8?= =?us-ascii?Q?ftLn3ZbmgfRceyh3/VioLY9cuPBYYEJZ/AiZryowXImFk0bfULnBHNgSz5at?= =?us-ascii?Q?OQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2dc68e17-6a10-4290-8bea-08db9ce61103 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 16:46:54.7022 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bjAw2MEZTrhw47eYhenMqVT/CwpAVz+TKfCtSIayS0P/Pxnvi0QZznAPmXPrtY+5M5sXAyBGA6aHSCcoEcnNsnZV3oeqFUYZODSa2kARMa8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8210 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Aug 14, 2023 at 09:10:53AM -0700, Tyler Retzlaff wrote: > On Mon, Aug 14, 2023 at 09:30:20AM +0100, Bruce Richardson wrote: > > On Fri, Aug 11, 2023 at 11:24:47AM -0700, Tyler Retzlaff wrote: > > > * Enable optional use of C11 atomics support. * Enable use of C23 > > > typeof operator. * Explicitly force intrinsics when building with > > > MSVC. * Disable MSVC C runtime checks. > > > > > > Signed-off-by: Tyler Retzlaff > > > > Acked-by: Bruce Richardson > > > > If there is going to be a lot of this type of special handling for > > MSVC, we could look to add a separate config/msvc (and config/gcc-like) > > directory with separate meson.build files for the different toolchains. > > Might help centralize all such definitions in one place rather than > > having conditionals everywhere. > > i think that would probably be a good idea. it would untangle the > toolchain detail from the flow of the build files. > > i don't propose introducing it in this series but when this is merged i > would like to reach out and get your thoughts on how to properly set up a > config/toolchain-xxx. in addition to the compiler flags and definitions > below it would be good to suppress (for now) warnings until i have an > opportunity to evaluate and address the code raising them. > Agree on not requiring it for this set. I'm not exactly sure how to split up the toolchain files, especially given that gcc and clang (and other llvm-based compilers like icx) are so very, very similar in what we have to do for them. It would be very wasteful to have individual toolchain files for each one, duplicating lots of settings. That's why my initial suggestion was for msvc and "gcc-like" compilers. Any suggestions for a better name for the latter, welcome! :-)