From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4DC943080; Wed, 16 Aug 2023 12:56:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4BEA443251; Wed, 16 Aug 2023 12:56:40 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id D9BA540EF0; Wed, 16 Aug 2023 12:56:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692183399; x=1723719399; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=A8Lz+hJ6PRErnSpbBMvEK4OY7alh1iS6TLU2YxN3v8o=; b=aHTispU1JmZaYFnxtTD0u0BgiSb+KIh5FpfMaaCj1vXZ+NJgUb/iFS3/ TZoznbdnilVQZwumlbI+lX9ejT3Nwtufi9fL53LrJ5AmEE43vq+ulVJ+L tWLZO3/8xqCc3D/YFCvJ0/tEVZOf6MkqkF7vm1AWV2au2w9+e8H6BY5kK vfm6W3dFi1tYlDIh3/elvKYYeXuROMwNMKxF4wuDkny69t/VtZ7LOftBH X7FROIagpZ2b1fs2SiB6U8XJnZhRWm9hL4xSxTN7F9mQqg9u0xau8A4Uq kilgNvi3hfV/blESR0E18vtMpTrN9eW6ZSULJyFynFy4m/154LSXBnkPN Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="371409403" X-IronPort-AV: E=Sophos;i="6.01,176,1684825200"; d="scan'208";a="371409403" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2023 03:56:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="1064792109" X-IronPort-AV: E=Sophos;i="6.01,176,1684825200"; d="scan'208";a="1064792109" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga005.fm.intel.com with ESMTP; 16 Aug 2023 03:56:37 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 16 Aug 2023 03:56:37 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 16 Aug 2023 03:56:37 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 16 Aug 2023 03:56:37 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 16 Aug 2023 03:56:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FMvpPCsWeg8mARoHTmA3oqrbc/+M4bPyAydftzaxX8E88DP5o8iJk926ptP1LBPSzFgeV+5P9Y1wbbsv2sqaliWUc/Bx5gfttOg8JgSoxvty5npiao1C6jMS5W93Df7ZsS9AimwF2p4MEMVQWQyHv2VDvPI8NyVPNkk/Ms5OvIefG4rw7/nXyxRxCJXnewvlGNJkWjB4xSV8Csr80FiIRrqoV6ZQADkoZBMvbw4fOKy4RoE/mbF3KRrNxJow5FuvQV8GLSkMEIpY1lkvZ+VM7CYPmwMJqVB98nsfT4vfEBwPQr+YQ8Jm37rwz4gH0hSZz1kkOzBHvdrtMXvT2NW0CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gKt7Z0f2g5hh5t7/BjS859C7iUUMMHzncOGW0Or1uNk=; b=Z0m48gue3ShLgKotRy6m1fSSzR4cVSm0xd4rJ5u42NELwizpG7fSnnr6YUlpPJm2dU2mUYlu1vRYD63Wez/sZBmv2Ie4PSQldLpimN3VMy0FV8ByVxj5wzWSbpxWyTTNbpd/KViDWlevPT9IJWTVigGjYQ+6rI6Wkr31EFjx6Hs7k2QZEh1g6vRrPXiHIozc3P0hVIXZ17DW/YTY7akSGX0UeW+3WDWUHidnPnbyMfE/63e4Mya03zxyrN0NVxAkHVsaLuqlisncnP72pjRu18iK4DCx1U3UETupLVI2iaG9v4PS0Bh+gD1aSk0zvWP3tEugBoz9W3sRFMHnU98rRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH0PR11MB8141.namprd11.prod.outlook.com (2603:10b6:610:18a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.29; Wed, 16 Aug 2023 10:56:35 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6678.025; Wed, 16 Aug 2023 10:56:34 +0000 Date: Wed, 16 Aug 2023 11:56:28 +0100 From: Bruce Richardson To: Patrick Robb CC: , , Morten =?iso-8859-1?Q?Br=F8rup?= Subject: Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix Message-ID: References: <20230721115125.55137-1-bruce.richardson@intel.com> <20230815151053.996469-1-bruce.richardson@intel.com> <20230815151053.996469-5-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DUZPR01CA0235.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b5::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH0PR11MB8141:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ae6347f-dc0c-4b45-f702-08db9e477505 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iwL/m63Jd9Ssw53wtNHStKhTgfpYDQkPR3JLdZhDwqfX//rOJQ3zThelIg4f7ndVj1yf0s3VhKax7LkFeG+cTzKRjaK/cd+07lbnU5G0bEZiFpn/zeR6pvTiQ/Un4BRLISxIMvufnlXb/KTitNvgYgdLCx8jap3blSLMcR2+xNXo4LV/P0x/U7aPh6YwFXWWtXQqH6kIFL9KHiiav9A18+5nN/JPjARtrpA3yaKL94YNLpxNW+usLNuyaZ4JvBM0TmkNHaEJuQi8miEQTGVuANI7qIC+KIeHSMvLOVqDgrKEJyyIdsrGXu2RcM8jJZ0WixgmHnVTHvAxQoZKgKgzUBw+U+o8tqAXN/ThAGWno2LQaHp6nGbG5NT42G0635fFunhRCUoBClUFvZ9nqkBI3KBE9xNQZp2qpnyIkR85Mp4+XrD7D0hIBERqmi4FkJK7Lc1FR0giDHNyEWkDcvfAWJ1mpw/Fv7aEmZwhWrXqwkNK/NpcWacJ9qk/alRV18YRvy8j3evo6wQC/S/1ZFCLTR+oL0XMHeVoh7PRgLzQFJ/7Ws73VpVT1YVrTiuyJczz X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(396003)(136003)(366004)(346002)(376002)(1800799009)(451199024)(186009)(316002)(6916009)(66946007)(66476007)(66556008)(41300700001)(5660300002)(44832011)(38100700002)(8676002)(4326008)(8936002)(82960400001)(2906002)(83380400001)(26005)(478600001)(86362001)(6512007)(6506007)(6666004)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eW4cIFRDsINe6+8XZ7S11dubFNDCjQcrrZiJ2RKxawUesyuW0+bpXOZAevfz?= =?us-ascii?Q?hXYkbgPNAPTRzl7nZFG5Z1KcvneY7PCKGSrQWnm5rRYY6AG3iP1dUIdCkCNv?= =?us-ascii?Q?JHf0xGGTkEDlsFZO2ymYYllRj5xB8AwXJ3YDPHfSHGbeRYlntE3D+NcmxC1m?= =?us-ascii?Q?A2vF2ccnQ0xjd8G3zzurNH/smetaN2H7HuLoJcfgf3Ru7If3uKBkJIRvMX2g?= =?us-ascii?Q?3+0OmaM8oyAF0mNkgjUlBlfLX0VUkWsVO4VyOEbVPE6BkZsUfbsqQIXOyVId?= =?us-ascii?Q?xiFA86zBg1vx3U8TWOtObu82KnlNCJ9GuQVtJub3L/MfxOMBtmhCaza4Az1y?= =?us-ascii?Q?+CNeq/VcF77WS6yp4fG+RSJznmw50Wq5oWHueqgunG+o8x7+PhUMIHCKvvXt?= =?us-ascii?Q?4ELa+Ul8C+ThAJR/aHhMM7XAia/KZ13FVdnS9ms6qezXi2DZ7NrOO31IbBxw?= =?us-ascii?Q?+JCE9bLEB+YxE6auwbluMtTR6843DR/tSajiTHWpBwRpaKuDrvDq29Wq3YUN?= =?us-ascii?Q?0NPENMKioAkY7ft+thNNCPaYpP8ikNQTnDP0xHAQ1494vegViT6pa+8BBybF?= =?us-ascii?Q?QGEZO4XWMjacZ9J3LflJ9dJU8+5AYG8nLIFkGO+blwr8MzxzgrNj00vkSZC0?= =?us-ascii?Q?AhNgPainx0PvUtjn97A05zQbNOerZ5Y/RwoZlTdevss9HNsreBf1iZPor06x?= =?us-ascii?Q?sOeVRZyDK6jSEyjJtlr8zpOgdR4baCw2/bk9vlOLP+o3OSpu1S+lP8K3mtyb?= =?us-ascii?Q?wnFQAmEU0Z7zMp6Zl4klIdNqmBMNmJbHdru3pTzyuSbCA3tpEwwDIFc17J7T?= =?us-ascii?Q?d2HbF8BS7NO5t7xBPpLxlVRjYCRyObwtpIqpq9/GBhtvijnkat0PNKZdp9wZ?= =?us-ascii?Q?iroexQ71bdnHaopQ67fZAB+kFx4iDx45SKjqyGA3RtwiI4AHBs2JYGSLwHmZ?= =?us-ascii?Q?wF4/EfnObe+KdlOqwUeHCzSxuEuGky/7x2V0OgD0aqNY7XWoo1keQ+++07bk?= =?us-ascii?Q?BrWJXGatClNqqkI15FqfxrgC3qDC8kp1f9kNdjG8/srVKccnIQeV+0MQd0Zg?= =?us-ascii?Q?wWhH49NyWotOn8HDDkGUOgv572rLK4Mk42KWI5z8OzU3wlDWJcNB7OsKUurf?= =?us-ascii?Q?m1WLY6FujPW/SgE6fQwTaqTLqf9pcoGMFVTzDRJpECvu0H0TkCS3rG76MYFG?= =?us-ascii?Q?+Ogj+UWTY4i7PRjsffTs2GwTQ/Mhsm42vXX7h9l5D4m3b9UahDiBd/Qm5mCa?= =?us-ascii?Q?1tQiMEThzwvm5FEq107Gt+7iRLMsF+ZhTxhCF0pKy0h4EfjmK4q/VqRkuSzD?= =?us-ascii?Q?xDGX+8HnNBIRY3I2tlcWnTpMQrFbtVoC1lVSIlWweYZyOqkWh0nmhidHSun1?= =?us-ascii?Q?TIL/QdGjau1o7rQr+U9sLbphEq/Pt1sDGdTSw/vYXTPFoB8AysKCVQDy86dZ?= =?us-ascii?Q?92GoVpEax8/CS0N4T2/iRalevvrg/Pxn29VNP2ItJOX7M+Kjj+5LFZXenyvA?= =?us-ascii?Q?SYxquyCNjQqSN5rGBbo0KBTQzHED7y0dw3UYLvoyyPYPypjvo5j3uz7tPjTC?= =?us-ascii?Q?dWE3j0FquVIaUpyjJ6iqU1qIRHw3Xd1URxCCeP4m+GIm4pVJPosoDgfB2PoV?= =?us-ascii?Q?7Q=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2ae6347f-dc0c-4b45-f702-08db9e477505 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2023 10:56:34.8441 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lKNNEhZhSgBC+ZsdJ/y/qyopT0RT0NMKbONTrOa3R3G2e3cfHZTL+cH+POUr0TCtziUf9hhmjEKrwwp7RFvbnCXAbtlEHNSOKMOp4l7EqxU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8141 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 15, 2023 at 03:05:08PM -0400, Patrick Robb wrote: > Adam from our team just raised something important about this patch and > UNH CI which I missed during the RFC discussion. > Presently, eal_flags_file_prefix_autotest fails on arm tx2 systems (arm > people are aware of this, they think it might be a memory leak from > mlx5 driver), so at their request we are disabling this unit test (on > arm only) for them for the time being. This failure was discovered when > we were initially standing up arm unit testing on tx2 servers earlier > this year - previously there was no coverage for this. We do this > filtering by going through the /app/test/meson.build file and resetting > the eal_flags_file_prefix_autotest line to an empty string. This > process is broken by your patch series. Again, I'm sorry I didn't catch > this concern when discussing it during the RFC. This is why you are not > getting unit test results for arm64, we can't run unit tests given the > changes in this patch. If this is a (semi)permanent issue, would it not be better to actually patch in the disabling of this test into the test sources, i.e. if ARM64 have the test return TEST_SKIPPED? > Your refactor likely means that going forward, we will no longer be > able to tailor the fast test suite (or any suite) per vendor request. > That might actually be a good thing. In any case, if this is merged > now, it is going to put the tree in a state where our CI doesn't run > any unit testing on ARM. I don't know how close this patch series is to > possibly hitting mainline, but, if possible, can that be delayed, > pending us figuring out how we will respond to this situation? There is at least one more issue I am aware of with this set - the failing mempool tests - which needs to be fixed, so there will be at least one more version. If this is likely a common occurrance where we need to disable one particular test for a particular platform, would it be worth designing such a feature into the rework. For example, it should be fairly easy to have the testname-extraction script read a blocklist from the environment, and omit informing meson of those test cases. Would that work? /Bruce