From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAA9B43080; Wed, 16 Aug 2023 15:45:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6698043254; Wed, 16 Aug 2023 15:45:34 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 76E9A40ED9; Wed, 16 Aug 2023 15:45:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692193528; x=1723729528; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=7TpnOgUWxY2wnapwnkXQxZIhqZ7TThA+ZPdJxodv/RQ=; b=WAUi1gvhXeO7k9G//SyTpbQriqTdxe8dsnPCihPwcXHHkCEbMQcufZjx zXG2iVPQA6tQ718vPCRPddY2vg9JcA1vug3hXvQ2rHbDYHMJ16JKYZNBV NVZwgIbPbDFx+Q8eHnu0b5riHvnVkVdaTyI1zuofSBlKCnVnCpYvNo7Gj 7gHs8T136FB8xoTd43uiqZbmTZg/e3EnFueQ6WpvHIQYgam1D5hKJdnsO HvjsvtybEG5bdrYi68jDBMwFpTDbCy8/uGQoMjDAU1jc27tfo73Owt1c8 HJn/J87M2kyYrjZpCboGGMlz4w9/RAIBUXkPmNmaBVLERxkiwYW8gdXhi w==; X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="438882802" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="438882802" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2023 06:44:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="1064825826" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="1064825826" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 16 Aug 2023 06:44:27 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 16 Aug 2023 06:44:27 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 16 Aug 2023 06:44:27 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 16 Aug 2023 06:44:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IJkVWHW6tPWpJ/qPJTznlLOIOJIFtXm0k4KydFyYCJc9BpEkh+/yJ/U6grm+ERJuaZ0PdmSKMbJE5TcdjvjemBj2nPUF71D1DEYKYaoSs/RCnjK/mWhq56TEe9ZPpq9aLLWRePEh4ubr7kSKQwPoZ+Zlv1dfLu0P+E8HK4qp7w2zJ9+YAsZtPd4Utiz+5PMoAKbBpFD2p8EoTfaNBi9te3zDe0kwji9KojIpn/q52ZisPXAZGPXOJJ3sJQe7QYw3Mznd68ZtCy62x+/C42IMV3aEGe9xSzPiik7C/NbGfzCRTvecEEuaKZJ8q3py6inoe2ZYvJ9xPhsd8nsxr3uC1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cPrCG3tV/BWoGkoajc/NHsd+i1LIhMyqBLQ253E46R0=; b=LWundt5CyBNlEQwQmi3oswJpe+5iZgVNkJIySRS6LLVOyAaxRT3rb+GvnxRSH3e+puxSs4ZmBHTK0GEcyqog7gnRNPjS3xpvEzgAz0Dc0Os2A8Y4xFSM2BDhe9KlNoQqOrtvypN8+hvpm90Nxp3pHsS+o3lb92/sIiLSMAx9TU2y/pikWsZD6FpOTryA/Oy0zdJvgmQND50WQdzvrhRY4ILIXCv5DJnY/syYJLFwDkcAr6zJOFppd3YERigiS9/bM+5InZunw+ULknJJxXJNb3K3/qdrwBSxBu+sZdZSb6K5NkS6AXHpEjmN3cB1r+peWDC+JwE5EIfHRg0nc9akng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN0PR11MB6086.namprd11.prod.outlook.com (2603:10b6:208:3ce::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.26; Wed, 16 Aug 2023 13:44:24 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6678.025; Wed, 16 Aug 2023 13:44:24 +0000 Date: Wed, 16 Aug 2023 14:44:17 +0100 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: Olivier Matz , David Marchand , , Subject: Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros Message-ID: References: <20230721115125.55137-1-bruce.richardson@intel.com> <20230815151053.996469-1-bruce.richardson@intel.com> <20230815151053.996469-6-bruce.richardson@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D87B09@smartserver.smartshare.dk> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87B09@smartserver.smartshare.dk> X-ClientProxiedBy: DUZPR01CA0192.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b6::15) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN0PR11MB6086:EE_ X-MS-Office365-Filtering-Correlation-Id: bacbfeed-d37e-4781-0858-08db9e5ee6b1 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0TyAwK/t4+yernfJs6ofwuWCVYeLMB4F+jyD4wPOlu/otehC7yVxHEcE90gLNkxOfHo5vSnmGo9Sj/TMJPK+EzN3s3vYDa62jctmiOCBVMNOV+cOtUVGJCoix0o1nhOhMfUE99JV11rLJrkD3JHwT686VsWEums5/q9NemU6VS7rYrabASqwD6XwL4Q9rZtgbHK3iv7MdNxRhq92k1icxzTzjdxv563W98AxndYUJN8ZuBl++U9QBw5YK2ksM1pfhBsmcYVIHTUWoeQ7wtVAGCtfEASLjivszDUTDJraJQqmHwzwCjSNQ01ITKigYpMPdY7rxd4Hc3BC/9d16Ig1gq+AD5LOOFDcK339KX0ZuYLCvHCjFHHn23eLZPEKr7RKyE2zJNnSGFIIih84qpMirYHtVxCs1mNnxwauOtMURmdbV7xnIXVh67ex9Vwt08MU9aay9jzYfxC357ZB9T7p+hoJG9cHJMf15CIMGPK8E2iHKWjS7wvWPXaElr76JAK7s/QJzVl70tINRoJjnUWakOhuLehOA0bMUUvdI9RXJNP1iZGoBDkrzvSphlwnudLT X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(346002)(366004)(376002)(136003)(1800799009)(451199024)(186009)(316002)(54906003)(6916009)(66946007)(66476007)(66556008)(41300700001)(5660300002)(44832011)(66574015)(38100700002)(8676002)(4326008)(8936002)(82960400001)(2906002)(83380400001)(26005)(478600001)(86362001)(6512007)(53546011)(6506007)(6666004)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0syY28veHFObkVqVi9oK0QwTHptbjQwS2RZTU5tTnhlWTgyNVFWSWM3WUZ3?= =?utf-8?B?VjA4NFBNWGVBZk1BQ21QYnBXRGJBT1BMRlVpNTFvOU84VnEzZ2tSMGVFSE9l?= =?utf-8?B?eTdlMmNxWTFkYjlHYWtqNkVQM2xqck83OU45ZVRLaVYremdOeHhPUlFKNTBG?= =?utf-8?B?eU9TOUQvWlAxVjZrSFo0dVlUOHhpRTlrR0c5eDF4NFlDV0lObWVJcWZTZkVJ?= =?utf-8?B?V09xa2t5bUM1WGl6d01FL0YzU3RVeHJwOVZZRWR6ZVNQWTI0WXdsUzg4TVQ5?= =?utf-8?B?UXZZUUdlaTFob0pUTjJsUXh3SXdhVUlPcjhlV0poQk1CRWx3Q3FjSEVEU3px?= =?utf-8?B?MStZb0NhVW9hTDcwY0NseG1xdEFrdmVSWmh2QklicXZjMnBuaTByL1k1eWtH?= =?utf-8?B?eU4wVWxwOHd4L2E0eCtHd3lud29CVXhVVVhqRmpzbXZybW03MUo0SHl1TWt3?= =?utf-8?B?MEE5MTVsVncycXZwdXc4bGZ2czBROXpGaUR6dHExT1ZKUjBXcjFxb3UwNElU?= =?utf-8?B?U2VDeU45Qi91UDB2dmJWUDZldUt4RTN1WmdseENrMTB0aWJqbzNhMkZmRU1Y?= =?utf-8?B?ejZtdjU2ODViMjBYWmtGbXpOR1lNckVhWHNTZGFub2ZTbTh2cTNBTWE3aTRp?= =?utf-8?B?a0ZiTWR0ZTN1RWQ4NzdzSTBYK0YvRnRTT3RtU01ZY2VxT2w3QWg0QVNMMnhm?= =?utf-8?B?WWhCVjdUMXAxWjlXRjdZRE9yZW1nbkV4bHVMcHZaYkZnRTJWVDlkaTZ4cnZU?= =?utf-8?B?S0dhNUg4a01CWUpIMzlGc1JpOTBlMVdmTHJJbUtvU2lPbkc0QWlwdTVDTDR5?= =?utf-8?B?TUJEUXZDbVBDS2pyRUVla2lZSVBqa0ZZS3VFSVg5RWUyc3AzcnlIL2l4Nitr?= =?utf-8?B?dFMveXNvSVVuYnVXL09oTGdtM2RFUFdaY2xJdE9xWGVKdzc1M2NzZ0UwNlFp?= =?utf-8?B?RzZ5emQyL1ZyM2xEUXFPR1ZKZ2l0YXFVYXhpbnBBdjBkNWtCTmFiMkU4UERE?= =?utf-8?B?VVB1VVc5dCtQakJ0bng5bkhEc280dWFKNHQvWkpwVjRwY3A2ZjkwYmkzMXBX?= =?utf-8?B?WUZlSU9uUDhtdUNyTmxPZDJ2YlZjMU1lR1ovcFRMdjNjYk9PbERrQyszUm1D?= =?utf-8?B?VEh4cUE1VTkwKzEvZnQwaTkxOXF0ai8zV3lIT2F5TDRwcXpYZDBObkRKenRK?= =?utf-8?B?bmt6UTgxZVBnKzZqZnNyYmoxTW1Qb2FHZ1ZZNkY1L3pmM0FONTZHYVRIYUxN?= =?utf-8?B?QUZZY2lxWXRXYWhSejBBcXhCVVFYR1oySERrdXhsdEd6bTBwZTFuM1k0MWM4?= =?utf-8?B?blJMZk1GWTQ3WXExSXJiSjFGUFpseXpjNlYwdXpCNzNHSFBWQW16TzR3OE5x?= =?utf-8?B?enVNdjhXMHBTbVplUEhPUDlObVVTZHNMbmFWaFd2NGNNeHdPdzcrZ2lxbGkz?= =?utf-8?B?YXhCY24vR3ZBTHd5V3ZOb2N0OWJDek9oYnBiM214aXZPTjJEczZhWldUeU5q?= =?utf-8?B?UmFDa0NTQmxnNUpkcERSTXN5T1ExZVdWMW1jdE56c1FNQmJxU1RLREpZZ2hO?= =?utf-8?B?VmpMUkI1QjNoM2xNY3NyT1RXaHBza2p3QlIzVEF3NUNWMkswUEI5WHpEaWt0?= =?utf-8?B?MDA4VWo5eFlVKytDRDB2SVM0WTlzS2hRQjB2UVZmQmw1NFNUZVYvY0huQlo0?= =?utf-8?B?M2xkeFI0amtwTmV4cGxwZVRqakpjazBWSSt4V29WY2EyTlhXb2FFb2lqaE04?= =?utf-8?B?N0xJSWV5NURhR2JZZUV2eURQZGpLRGlUbHo3YnBuNnMyTWRBcFAzdjBnRnZ1?= =?utf-8?B?Z2ZKQlNGTitpOUNZamg3VUEwMTFzRXFXNlVScGsvVmY1bE1xSFQwWUY1K3VZ?= =?utf-8?B?S1NWUjB0TmFJL1ZsL1pkUlhqeko4SWRmQjVTMjFidkNzcHZTWE4xSmZ0MWk0?= =?utf-8?B?S1AwNlZvd1ZzOGx2c0pIcWg5RkVnQXd0eVJVZ1dMdkNGWlVUZFdGSjBYSUVz?= =?utf-8?B?K3N4N2k4ZThjS2trNTZpc1BoZU8rVHRrZ3Vpd0wya1BMcy84aER4OHNZREkz?= =?utf-8?B?QmpEeGNOT0pPUGY2TCttNWhUdERWYUQzaC9DU1ArZHZFZmdTWHZjMGFUY0Rl?= =?utf-8?B?WVF1Y25WcER3anN2YkdGUm1NYjNYM1F0NU85b2JSNjF5V2Y4UmVsNzR4ZzYy?= =?utf-8?B?MWc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: bacbfeed-d37e-4781-0858-08db9e5ee6b1 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2023 13:44:23.9719 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WOaUk+qdkyoDo0jpQlVq+JzAbghwQHN7yLVzA97Ekrsb1/Tafbmyc1liA8nw4lTM7vEG8KtxmoAepnPWgA7gf2xQ/vfFN/gl+wJzV+0sSZw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6086 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Aug 16, 2023 at 03:35:47PM +0200, Morten Brørup wrote: > > From: Olivier Matz [mailto:olivier.matz@6wind.com] > > Sent: Wednesday, 16 August 2023 15.17 > > > > Hi, > > > > On Wed, Aug 16, 2023 at 01:33:46PM +0100, Bruce Richardson wrote: > > > On Wed, Aug 16, 2023 at 01:40:41PM +0200, David Marchand wrote: > > > > On Wed, Aug 16, 2023 at 1:15 PM David Marchand > > > > wrote: > > > > > > > > > > On Wed, Aug 16, 2023 at 1:02 PM Bruce Richardson > > > > > wrote: > > > > > > These lines here seem to be exposing a bug in the mempool unit tests > > for > > > > > > shared builds, which is why we have a CI failure. > > > > > > > > > > > > The mempool unit tests use the mempool "create_empty" API, and then > > call > > > > > > the populate APIs to finish setting up the mempool. However, the > > > > > > create_empty API does not explicitly configure a particular set of > > mempool > > > > > > ops for the new mempool, leaving the ops field at 0. This means that > > unless > > > > > > the app explicitly sets other ops, the mempool will use the ops from > > > > > > whatever driver registers itself first. This occurs even when the > > driver is > > > > > > unsuitable, e.g. on my Intel system, the dpaa2 is first on the list, > > > > > > leading to failures in setting up and using the mempool. > > > > > > > > > > Hum, it sounds like a bug to me. > > > > > The dpaa2 driver should not be registered as the default (or here, > > > > > default platform) mempool. > > > > > Other mempool drivers ensure that required hw is available, I guess > > > > > dpaa2 is missing some check. > > > > > > > > Ok, re-reading your last comment, I agree it looks like an issue in > > > > the unit test itself. > > > > Copying Olivier. > > > > > > > No, I think it's not a bug in the test, but rather in the mempool. > > > Unfortunately, I think the concept of the "default" driver for mempools > > > seems to exist only when using the mbuf library to create mempools. Even > > > then, the default mempool is different from what the first entry in the > > > list is. That's the fundamental issue here, we are using the zero-eth entry > > > in the ops list, rather than a default one. > > > > Yes, Bruce is right. > > > > As discussed off-list with David, moving rte_mempool_set_ops_byname() from > > rte_mempool_create() to rte_mempool_create_empty() would ensure that the ring > > driver is the default (and taking flags into account). > > I took a look at the mempool library source code, and reached the same conclusion. > > Your suggested fix is also supported by the documentation of the "flags" parameter to rte_mempool_create_empty(), which - by referring to the "flags" parameter to rte_mempool_create() - says that the mempool ops will be set depending on the RTE_MEMPOOL_F_[S|M][P_PUT|C_GET] flags. > > It should probably be flagged as a bug and backported to stable releases. > Yep. David has kindly done up a patch to fix this, and I'm rolling it into the v6 of this set. /Bruce