From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA76341B29; Mon, 28 Aug 2023 12:29:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E1884026D; Mon, 28 Aug 2023 12:29:58 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id AAAFD4021E for ; Mon, 28 Aug 2023 12:29:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693218596; x=1724754596; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=kgamtkaH3jq2H6TBEookx3amqJetDOElpCLl2m/Gens=; b=aA5SyFCB5lOzyTzGj2Vrg/haQJ/vB3Y7xmxs+XJvMtZ2FQ5WQRQ3z80B IX4ScKNdVjzyqECKjbkYERKybw0R8zKbYDniS7GV414pfsHOuqIi+7jPk DB1H4xbeCK4mKObnIsL7/4mGSI/efxsyGka6wM/Tk2OH26vwqglKOMvm9 Fn8Wnqw90SDPHPm3VW3V2HX2OS4KWEVj7eWRtOc1qAzOCiETIMa+Jp1iQ ZBrEfZq1OcD/O5789Di3os8e20Q6TMnakUWprUINRMFiuimGww0y1iLpl C7dedXFIyYBL1OIWNanpO4oqRc66vdBG3gM7dLmnuWfzAw85nF0j612Pp A==; X-IronPort-AV: E=McAfee;i="6600,9927,10815"; a="360065106" X-IronPort-AV: E=Sophos;i="6.02,207,1688454000"; d="scan'208";a="360065106" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2023 03:29:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10815"; a="912007230" X-IronPort-AV: E=Sophos;i="6.02,207,1688454000"; d="scan'208";a="912007230" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga005.jf.intel.com with ESMTP; 28 Aug 2023 03:29:54 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 28 Aug 2023 03:29:53 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 28 Aug 2023 03:29:53 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 28 Aug 2023 03:29:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FrOLJlUAbtsGvqzDw9AaHpH/y4kxxGJ/dAzpUnzhwF+GH+bGpZ/aF5z0G6Eor5wq1is4fKUU7jK9Mr/fHAQ1WWp6APIyjs4/lQxpFhd4HnARBD+g5YTMJyLi08dT1q1OGBoQDZ1lq+hpQ7KK9CbuJ8faYIBg/IftY/DQnXvZxeOx97XosxlUtDbX2bFw17h0A2LETXBr0ro2BuKKkduEsbMOnzC52kd12GQMCG4UUqHdl0jhIWzG+5eAvaq1bcXJPOsJ+u6BW5zoW2I+I6pH/NK1uFRl35RzD2Ar8dKuRwlRcJfNPzoar/g88cEeuydvDFiUMqIVjA1IVj3EPwu8jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GKMCwX+Bwvb4XkTt5NE1/lib1kfR1Geb0yX/21NHT9o=; b=MqGZyCenohhEELkYen0Joq2aPabrJSNPg7nUbvq8onM3Ur24hdsWhv8tHuB8jOqeub0g4+bD0kX7gKwnG0Lc0kOkuvF6KFSALcPA3Sht4eGAC+hkEJ9o6m1vkjO1zOTuCkf2sl1T3IwUHiGYdYnfBRr/9O8oDkpZfcXUXTCnfEbipb/Ytjk2X5EEAesOpmKJsVzwaLstbPTo7+gENTF2aY4b7pLVLNL0Qx6njVw1Ka8z1MDKinr/rasOD3baDMKivVID782MThiRkcfP2im8nm1V1NrDPy8muXyrYd9pmLdTd8qLqe2GWpfLvZHXJWekmNgu3VYwUDFiz1rfkpqMdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA0PR11MB4623.namprd11.prod.outlook.com (2603:10b6:806:95::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.34; Mon, 28 Aug 2023 10:29:50 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6699.034; Mon, 28 Aug 2023 10:29:49 +0000 Date: Mon, 28 Aug 2023 11:29:43 +0100 From: Bruce Richardson To: David Marchand CC: , , Subject: Re: [PATCH] eal/x86: fix build on systems with WAITPKG support Message-ID: References: <20230825152850.1107690-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0285.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b7::23) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA0PR11MB4623:EE_ X-MS-Office365-Filtering-Correlation-Id: d053f89b-b57d-47d0-b41c-08dba7b1b517 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +xyUG/Tq5WeyE/HH3sNYZjUHxtwUcIcUjEt+vW/bLFtPHGggjg5KcoxViFPxWuR+S2TIjutGDazJwqTpMbG4w15Ewt62K235tovlOvv5wLqSDHZZ6a8Ic03eeaBvQmwoBeR3KPugPXAJyMD4V0eptnYlno26VKVvSBz+FTiUsp/+qTsdQ6vtJ+NE0BH++N+dLKtXySA9025qZRa7TLUr6IYmZ61UeUWGdpDCW5SgF1Ho4G3BioTSOxFkWDqrLjUvQTurlapGJnfAgh1sXHOp2KFiZ5KyNEGp666uXyBiVnRwNePFdbA54Hgo5BpWt4DsCTLylc+PxnXwl6QTGafa6q5zfhHYNgsPK8VAY8AXFmWYxd6jQi1b8jvyeeJlYIdvxEV/rfqXn3PY/ZpHhPB99Movuw+s4duxFZu8EkkntBhON1ys4fH2rAVEdhGO5zfwehHoPUr8vlSzIYY0qfoUc2Z/Pf6qCN1LcRdZEg74OtyNOuVOYpKeTpsHhEL1eKTrbmeSZlmTWgJmMQT9hdgoYnehM1b3L1XBNVk9mdBrYsQeonIk1XLAvehByHAviqEx X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(366004)(39860400002)(346002)(376002)(396003)(1800799009)(186009)(451199024)(6666004)(53546011)(6506007)(6486002)(6512007)(2906002)(5660300002)(86362001)(44832011)(82960400001)(316002)(38100700002)(4326008)(8676002)(8936002)(41300700001)(66946007)(66556008)(66476007)(6916009)(478600001)(83380400001)(26005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QTNicDhnRG9UbGxzTnZ4NHp4RXJMbEdIOExWTHZCaDVmMWpPeEdQM1RIVG80?= =?utf-8?B?bHdPQ2dVd3FUd0tFR2xHaWYvSEJjYmUxa2dZb1hqS1RGcHdMSW8yTEZLa0FK?= =?utf-8?B?bHpjYzhNUWRMcCtXMkJBZGFCamlmamVEdjFXZnRkOE1xMTdhdzdXOHJJaGpv?= =?utf-8?B?SldTNnFVajRsZ0EzQ0xuUHhneFVBTmF0ektLT2Z1ZjllRmRVVCtra2ZKcGZO?= =?utf-8?B?ejhnck12QThyb3I0YnVVeUFCS3ljU1o4RklTd2lKbW9vVnpYRXptUUprNFdC?= =?utf-8?B?eDBITnlsc1BMTDFUNmdWN2xwVjA4a05YclJLQVdhSjZpSVB5MlNZZFZ5cDBP?= =?utf-8?B?djNnT3RpOGtDbmt6cmx1Sm4zTjZrU1VkRExENHZvWjVKUnVnTmNWSElaVkNl?= =?utf-8?B?endRaEtWODlXOElBZlY5UFNZdFlDcHhYdmM2K0dvbytDd284djlxVVBIOXZC?= =?utf-8?B?dzEwQnYwUTZiWEVDSldIaWNsdFpxZWpZdlQyVzdsRnRVQXFIU3p1L1Q1SG5y?= =?utf-8?B?Rm44U3ZvdFRkaElISTNHdHp0RGJXeWZPTVBtNlVVbE8vSlRxN1RKWkZqMDhY?= =?utf-8?B?SkZ0aFk5Um85NGtudGlWVE5Idnd3c1VocjErcUd5K0FEbEZtZkprSEtRTlZ4?= =?utf-8?B?dW5vOHo3TGljUklmWVR1aXk3TTE4bWpMV21nWHVlM1d6RjJidFF4a0ZUZ3BV?= =?utf-8?B?cm0xdVpHTFNCUlV0ZE8wS2ZudHJBWTRSdHNRVGRCQUc1d2JaUG9FVm0wMWZU?= =?utf-8?B?eUsxT3BTQzloVjFLMUk1NmlPTnErd0gySURvdUtMWWExQWJSY1BSdVh2d0wx?= =?utf-8?B?TjZoWndFaTh3cU54ZmZDZGV0NDcrRUpJU2hNd01IL0ZZa2RqWU5jc2RFRGx3?= =?utf-8?B?aGhGS3l5N3paL3ZYa0RYNk5PdHI0bUdqZytjbGZ1cE0zMVlUTytQaDJ3ZkVw?= =?utf-8?B?S3EvUGV2SnlRTUQ4UnZyQk9UNVBJZTQyVGRaUWZGaFJkV2ExWjMrbzFXNmNz?= =?utf-8?B?aDk1UFVDSG5xUUhkVUp5M2QwcVJHNkUzRTlab1hMb0xxNTJTMUUvVjlSMWJq?= =?utf-8?B?SHJDejFVQzVBN25XQllCRHpsdFFSVVp3YVo5RUpvcElyS01STFd5RnkrVnpo?= =?utf-8?B?eGJNeU9INXEvVUFKRk1kMXFVaFNzM05MWk1uKy9pcVVvay8yY2Jya0FSV2Nr?= =?utf-8?B?aG1RajZBTnNlNEUzTS9DcEZNcXBVZE1xTFRQRXBFeWpBRXUvRGtVclZ5UjRo?= =?utf-8?B?azQ1bldYalovbnJDM0VSMFpCaE9PbGVyQ0wwTThMS2lWZ1VUVGZkZ3NzcWYw?= =?utf-8?B?dkd3T2hLdVhNaG1KU3cwM2w1MzdFOW4zeVNpR2x2bG9BVEUyRE5Dc3pTQ1or?= =?utf-8?B?M3o1UytBM3JwZklKUEk1emZFRHlRVUJocHZoMG1xb2JEd1owVytoYStEczAv?= =?utf-8?B?MWlTVk1ONVBmNnZjY1E0Z3E2c2dCc3VTSTdZSnQrVWNGcm5yOVp4R2xIbnhs?= =?utf-8?B?anAyYkxKS2x3dDY4UHNSa3BoNnFkZFUzNHd5ck1NRktGRmR5dXAzQWJOU3JS?= =?utf-8?B?bUQrZzlCWFh1TFZXN2RMQ3JabnlMTjhObkM5d1hXZTY5MXJHZFJEWU5Xd1Rt?= =?utf-8?B?WFh0dUdVVEFsN2lJVW1NRitpVzFDOGJuN3Y1MDNxNnZzNG94MktZMEJ1S0dK?= =?utf-8?B?aHlFRndTMTZtUzUvRkNZY3VwQmcrR0tLQU1yUmdReFpnRnBZSjdwZ1RVU05p?= =?utf-8?B?cUIwRkd1SWdCa0RKb2h1SHQ2ZzhoRC85V1VLdFFSdGNKdmNmU2xmcTNYdEVm?= =?utf-8?B?QnJEWkF3ekJVQkJZVXI1a1kydGFQSUc4V3BicEo2bmQrTzBYNTU1cUZIcFAz?= =?utf-8?B?VDJWdlROWElSeDM3OWE2NlRGOWFQUmtRY2ErSDlyTE50aDBkU2w1NFBuOEd4?= =?utf-8?B?Mk15aHJYWG13T3JGOUZhNHBUeFVIOUxMNzY3cHZ6TXQzU1dBS2lFNmQzYkRJ?= =?utf-8?B?RTNQZTdxYS81MlZ1QnFQcTBzWkJQd3RwZThKRlRITTlqWXlmaHVudnA0L3J0?= =?utf-8?B?cmVpMXFHWW91T0p3Y3BpeTVtRENJdkhocFpycjdJZjYwLzRkalNXMFh2Zkhy?= =?utf-8?B?L0VrL1NIMzVuZFJsY2ZNMjVCYXhKUTRUZ2JVdnN6NTJqRW5HZk8ydlg4Q1Vs?= =?utf-8?B?TEE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: d053f89b-b57d-47d0-b41c-08dba7b1b517 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2023 10:29:49.4761 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1U60vtR180Y8E1hmVMu9kFom2EGRht8+3eREyZqk9T0JgIGqS+vUEl0sZPSkbCERebQ+OI8feQdkRLt8KAEYkHV0aXq+cJGR/gQpT5btyWY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4623 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Aug 28, 2023 at 11:29:05AM +0200, David Marchand wrote: > On Fri, Aug 25, 2023 at 5:29 PM Bruce Richardson > wrote: > > > > When doing a build for a system with WAITPKG support and a modern > > compiler, we get build errors for the "_umonitor" intrinsic, due to the > > casting away of the "volatile" on the parameter. > > > > ../lib/eal/x86/rte_power_intrinsics.c: In function 'rte_power_monitor': > > ../lib/eal/x86/rte_power_intrinsics.c:113:22: error: passing argument 1 > > of '_umonitor' discards 'volatile' qualifier from pointer target type > > [-Werror=discarded-qualifiers] > > 113 | _umonitor(pmc->addr); > > | ~~~^~~~~~ > > > > We can avoid this issue by using RTE_PTR_ADD(..., 0) to cast the pointer > > through "uintptr_t" and thereby remove the volatile without warning. > > As Morten, I prefer an explicit cast (keeping your comments) as it > seems we are exploiting an implementation detail of RTE_PTR_ADD. > Ok, I'll do a respin with explicit cast. > > > We also ensure comments are correct for each leg of the > > ifdef..else..endif block. > > Thanks.. I had fixed other places but I have missed this one. > > > > > > Fixes: 60943c04f3bc ("eal/x86: use intrinsics for power management") > > Cc: roretzla@linux.microsoft.com > > > > Signed-off-by: Bruce Richardson > > --- > > lib/eal/x86/rte_power_intrinsics.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/lib/eal/x86/rte_power_intrinsics.c b/lib/eal/x86/rte_power_intrinsics.c > > index 4066d1392e..4f0404bfb8 100644 > > --- a/lib/eal/x86/rte_power_intrinsics.c > > +++ b/lib/eal/x86/rte_power_intrinsics.c > > @@ -103,15 +103,15 @@ rte_power_monitor(const struct rte_power_monitor_cond *pmc, > > rte_spinlock_lock(&s->lock); > > s->monitor_addr = pmc->addr; > > > > - /* > > - * we're using raw byte codes for now as only the newest compiler > > - * versions support this instruction natively. > > - */ > > - > > /* set address for UMONITOR */ > > #if defined(RTE_TOOLCHAIN_MSVC) || defined(__WAITPKG__) > > - _umonitor(pmc->addr); > > + /* use RTE_PTR_ADD to cast away "volatile" when using the intrinsic */ > > + _umonitor(RTE_PTR_ADD(pmc->addr, 0)); > > #else > > + /* > > + * we're using raw byte codes for compiler versions which > > + * don't support this instruction natively. > > + */ > > asm volatile(".byte 0xf3, 0x0f, 0xae, 0xf7;" > > : > > : "D"(pmc->addr)); > > Tested-by: David Marchand > > An additional question, would Intel CI catch such issue? > Or was it caught only because you are blessed with bleeding edge hw? :-) > Not sure. I would hope so, though. /Bruce