From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FA6F41FDD; Thu, 31 Aug 2023 15:58:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E343F40285; Thu, 31 Aug 2023 15:58:43 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 62B514027B for ; Thu, 31 Aug 2023 15:58:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693490322; x=1725026322; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=zy0fUG5NmuXEu1j8OCB7Ks+vNPwDD1mIla5vqGkRvsI=; b=IdHDarHyqeW0T6FatxGguHN4BAvXX/H3/tXI5CfQ3UcTY0we5ZNNMKfQ Pj+IywK6JNg9QtsFgyDHmI6EJOO0rhG1fi4fUuT1MmfWxba0CH3JO7ymk YJUaCIk2p5bajtac2E0KhyCvjymgGu1h3G+AGNFQMXdUEumpyui8bbJua biIYqjxse3y9Bj20/o2uSGxNsi/NX2Np3O9Y4Gpx+gVy6dInOYAzZjJG9 8fQ7iQIaLuLX36k2as3JTiRz3YOIFJhC08jm3KemcWVHerdDW3NDh+J1T kuEI5nxTHhPJ5hMofno5vaJQz7LcgH5h3my+n/h4g2yDJH2ua/UxVNtU6 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10818"; a="378688115" X-IronPort-AV: E=Sophos;i="6.02,216,1688454000"; d="scan'208";a="378688115" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2023 06:58:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10818"; a="986239237" X-IronPort-AV: E=Sophos;i="6.02,216,1688454000"; d="scan'208";a="986239237" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 31 Aug 2023 06:58:40 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 31 Aug 2023 06:58:39 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 31 Aug 2023 06:58:39 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 31 Aug 2023 06:58:39 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 31 Aug 2023 06:58:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W7xTGaBijK4cHu/YOdSR8LHXbU/zol8mjAMj3DBQKNVTc1iroR8Wv6r51NSd61K9ew61R0XPUVrkH9CMDbO4sg26RJrrHTA0wHo/Jgq+wTxanR6AjfOApfRLsZ44wTfg5uNXphuXhzecOVM36O2uxdXo9g5VGXlCFrFTXyvQ4yisVniI5iCrMO36znBNBrUYDifdmzixRL9WD5pW2fXvuq0nJe/p+WJJkprWmvKJ0NQdWUtdQ21g+EtUobcHB7AiNv0543Akom8WpQWl9YPr9Nvcwfx0brUOb0x0dYszXHea/w69gMch+d1FcoE/UfUi/+ZMdllj96yK2F8Rk27r3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OQBnYmPQ88EwEyj8xPn2RpL3whqsC6vUVheW9D9ReKE=; b=evSNmvhoxmuNVSDcKBgEZONjY7AIKpJdYseVSU6+8fZy0CDlCN900Nt8tjPvtNNGi3Q6U85YqN8MyLWzpQEAs6K9BSiOY0vOmWKYE4RNilMPln/Ph1FBZLj4DMqyScRaOLWgcv7k8FdZUQG1AZ8Dif7obAiZV1oDr7XFSeXIq2ylE8+rGmXlYzg6gDzFB2OkGdmMqrtl7Y29Mmdtoa+Rzd8qFwDGwmwsijIeir1SWi4dL5NDaw8sHz4XoXtDdo413MPg1G71/1MM2r1RwbxW/lcLslbqvJNIwN0O8NHSuZFiab68HkGBkXcBTUvLbO2fTBKvLT9krFKtMc1AlQf81A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB7595.namprd11.prod.outlook.com (2603:10b6:510:27a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.18; Thu, 31 Aug 2023 13:58:37 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6745.020; Thu, 31 Aug 2023 13:58:36 +0000 Date: Thu, 31 Aug 2023 14:58:28 +0100 From: Bruce Richardson To: , CC: Thomas Monjalon Subject: Re: [PATCH v3] app/test: add support for skipping tests Message-ID: References: <20230817105851.501947-1-bruce.richardson@intel.com> <20230831101806.317042-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230831101806.317042-1-bruce.richardson@intel.com> X-ClientProxiedBy: DU6P191CA0027.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:53f::27) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB7595:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f94e05b-c8b1-4a5f-e734-08dbaa2a5f16 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uEEhtv25XVamz2sHLLwSAB9gswabPeIEF7vT4rcxxTXZV+seDK1oovLymzTgGtkfCn8diIIWhUYC/O/DsS6QBumsgKkPaVPCfgtzkbHzV0P79yMzk8SbO9zMxD5jwSahKsCJ9xqtJwmB5m5zFYgdWu/qaCVuPpuG4aR8RUP8YM9BXnhdfATGPwWLhJCgxR+YLdkQoMJSM0BM5sx4sheLqosRTiI49WCRGiSFF8TF+7Lm6VatwNeVmOekc0N/LtzE/hAa474/Fg2cikJpFg7x3xaj3rKX8Cf40L7lg1jiniCjTlX6KY9BOTRMf5WsvzWhFazPos+sBvDm0ed4USY4iKyjRdF8Oqn2Hv6Odr0Ky69REiOu4fcsI1PvUnAEEBkesWCaMZc/2gwx6o25f17YfdgZ2v85x90HLSW9JD19e9ViQu9K0AVJ97mQOuBQr5601Zq3ladaMzBwfozhiTNfoDUmc9mhW0goy7yA/LCx566vUv7vJv0sfhzWxcHuFtyaAJuPHH8lwz1YnVvye1ZW/EyiaW+5VPHNLGn92c9U4N5tOjGJPZkupPdvfqQAHbR+Cf64BU19/VDnM5d3Pq6vVuPYYPT/Fr33Rvf26rATvk0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(136003)(39860400002)(346002)(376002)(186009)(1800799009)(451199024)(8936002)(6506007)(6666004)(6486002)(6512007)(86362001)(38100700002)(82960400001)(26005)(5660300002)(478600001)(2906002)(41300700001)(66556008)(4326008)(66946007)(83380400001)(44832011)(316002)(66476007)(8676002)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OBbLzWfZsLTwRBaLoG4jQQNDL7HPpk2F9yXJsS8K0ooE/xgGOyrjck56VCLu?= =?us-ascii?Q?Diav3rhsk9uuWY+ErUZ6A5eGTQ2eYKcaLhOu1WpSQdzqZHqUP+ydhyBPTmM6?= =?us-ascii?Q?fRoH8Pksq9XBs87P48gZq2WTIzDqobVXu40ls3/uxuR2BE/0R2HqUkU+Jlva?= =?us-ascii?Q?2aFZkuuzm1ACJjtVSLNOb/kP2r5h81NU/SIJuNS8NBE2/4rQZ0y/3MsgEoL2?= =?us-ascii?Q?+zEaYul/ACzsRMTYlQQAQO9jpfyRKHk3/25tVuHnVcrIdjIesQV1Uh5sIj5D?= =?us-ascii?Q?TjzLkraTrUBR8LtElzgsDqzdCP37E5RIqyAIBOqb8Z+F7ylXxfH4R2cvH1JL?= =?us-ascii?Q?B03pmpPyVd/ty3lXfc+tDxEvksJEVNSPRdFf/dxkmDedIKY9L4dzaNLVic1k?= =?us-ascii?Q?hDL/AXw3vsslMLBc6iizo3C11cnX9VmWwqZlw/3zi76WcvKZgNlEbKRfge3O?= =?us-ascii?Q?/Ou1iQElvk2MWAOfukxib23axqJLfTXoFRTpummkF8p6O5I4hDGuh8GbCG+f?= =?us-ascii?Q?LFilIdIp5ZBqCtmlFC/2Jl9ewtzD4K13P2KaVZSgFsxEffiBcJmWQgwGmJ2E?= =?us-ascii?Q?O7Xzz5V7TFiqiyFXKQP5mJL4b8gmtadcxstWTTYsB7cCVYMsKXj1eLTztkTi?= =?us-ascii?Q?QnKl5AdwvUsf/4BGLnN6apLad87f93DlFMMFEjx9M6kWPHFU44/iNpN3bRcA?= =?us-ascii?Q?3dXKYJktdkfPPGtQCv6CA4va4MO+TFNx0o7Mxz2gzSrfyapv0Y8MBp/+31G8?= =?us-ascii?Q?DWsQvJkKxB7LccZVrMK7EYK4F1Eekk+OlOkRHuK5g8OvTlHJkWZYMuZaKbAT?= =?us-ascii?Q?ivarPDO9t7qUersTQ2XO2SeYeSAcNk/PXzrg3O1FEdWamFu8Dk3SRilzVszi?= =?us-ascii?Q?7pqcTTWTszA6ITKZhUmPzs8WhL8ivgO59oqvylemi38+m5BV9VCom/3mmHeX?= =?us-ascii?Q?p0GA71pZsyMlvUDtvAUgZsi0oQKb8esZA7UG9GELSkIFwEId4XP4qMi2OKZo?= =?us-ascii?Q?W2LQBCKBwkas7G43KNLfIbMDq8Ywvijo/gzMeS4K75oC1sfiCiScTNG61hdj?= =?us-ascii?Q?J6rZ8WEpckPiIZtn3SM3olTymoKKOH2xARgUQXmYwWOPBpo0m0kccAxOqsDn?= =?us-ascii?Q?DBD2jGRmGeENrjEhuq5Ya8ci2yLyY/5JkW4NXntsQYFLGMb6sEtfQNwFejPe?= =?us-ascii?Q?DZ0Pyw/kDC6ny1BvHR/azxbHgI8AVvLp5HsWlqIbm+ZG8pKFipPfBgpIGtxN?= =?us-ascii?Q?iqygo/Kq7rC00ZvytLxWVC0Nm+lzQnl/uLvZbY7dciF1xpaTUxQeguKUOp7j?= =?us-ascii?Q?Ru2Yh2m2a+yQWN9DXLO/QJzLbGJvGA7r4ujUMz5eIltYsUxmz8Jzpf3di5+N?= =?us-ascii?Q?WRj3U8i0UVRelLOcGg5f10XHpcULUS6vlMy/FixiZmACVeaIa0+TXIVnQJ4+?= =?us-ascii?Q?Sgrh3ZWm08eMh+saZb7bWhs0JT0WHHgR1ZxYR7527g9wg08CEO0B8yFltpik?= =?us-ascii?Q?XAh2pu6wWq8+897uphMC45C+WDSeaEhCuJbhbk9Xnss/6dZKww5CdApGL+c1?= =?us-ascii?Q?3gV3UPa6ZIfwVVwOsQBbbb3EQlatCXYwv1tByPMROvz60tpUhj5I3nucNuqT?= =?us-ascii?Q?3A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2f94e05b-c8b1-4a5f-e734-08dbaa2a5f16 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2023 13:58:36.6058 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pEyGo8oSWDWTu+cRg56xXunqyEWGKHRR0+Rq9SgAf1NeCBto7sVaI4cBssd7rITjbO5M6GTYGOZqtAJnmXGyb0u0Ap83nsoBMORGj7uV3rw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7595 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 31, 2023 at 11:18:06AM +0100, Bruce Richardson wrote: > When called from automated tools, like meson test, it is often useful to > skip tests in a test suite, without having to alter the test build. To > do so, we add support for DPDK_TEST_SKIP environment variable, where one > can provide a comma-separated list of tests. When the test binary is > called to run one of the tests on the list via either cmdline parameter > or environment variable (as done with meson test), the test will not > actually be run, but will be reported skipped. > > Example run: > $ DPDK_TEST_SKIP=dump_devargs,dump_ring meson test --suite=debug-tests > ... > 1/9 DPDK:debug-tests / dump_devargs SKIP 1.11s > 2/9 DPDK:debug-tests / dump_log_types OK 1.06s > 3/9 DPDK:debug-tests / dump_malloc_heaps OK 1.11s > 4/9 DPDK:debug-tests / dump_malloc_stats OK 1.07s > 5/9 DPDK:debug-tests / dump_mempool OK 1.11s > 6/9 DPDK:debug-tests / dump_memzone OK 1.06s > 7/9 DPDK:debug-tests / dump_physmem OK 1.13s > 8/9 DPDK:debug-tests / dump_ring SKIP 1.04s > 9/9 DPDK:debug-tests / dump_struct_sizes OK 1.10s > > Ok: 7 > Expected Fail: 0 > Fail: 0 > Unexpected Pass: 0 > Skipped: 2 > Timeout: 0 > > Signed-off-by: Bruce Richardson > Acked-by: Thomas Monjalon > +Tyler I see this set is failing CI checks due to breaking Windows builds. The issue seems to be the use of the "strdup" function. I notice in the log library, that we have a "#define strdup _strdup" macro. Since strdup is fairly common, widespread function, I think we should consider a more general approach to it. Tyler, looking for your input here: should we just globally define strdup as _strdup for windows in DPDK? Alternatively, some googling indicates that there is the "_CRT_NONSTDC_NO_DEPRECATE" define which could be used to enable a whole range of POSIX functions. Should we, or could we, just set this to ease porting of code over? I'd hate each of our C files to have a bunch of duplicated #defines at the start to prefix standard unix functions with "_"s. Thoughts? /Bruce