From: Bruce Richardson <bruce.richardson@intel.com>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH 1/2] event/sw: add selftest for ordered history list
Date: Thu, 31 Aug 2023 18:10:56 +0100 [thread overview]
Message-ID: <ZPDJoHJO/056NYjc@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20230831164736.2472671-1-harry.van.haaren@intel.com>
On Thu, Aug 31, 2023 at 05:47:35PM +0100, Harry van Haaren wrote:
> This commit adds a unit test for an issue identified
> where ordered history-list entries are not correctly
> cleared when the returned event is of op RELEASE type.
>
> The result of the history-list bug is that a future event
> which re-uses that history-list slot, but has an op type
> of FORWARD will incorrectly be reordered.
>
> The existing unit-tests did not cover the RELEASE of an
> ORDERED queue, and then stress-test the history-list by
> iterating HIST_LIST times afterwards.
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
Hi Harry,
having the test first is good for showing up the bug, but won't that mean
that our unit tests are broken until after the second patch is applied? If
so, I suggest reversing the order of the series so the tests always return
clean. [If no V2 necessary, the order can maybe be switched on apply]
/Bruce
prev parent reply other threads:[~2023-08-31 17:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 16:47 Harry van Haaren
2023-08-31 16:47 ` [PATCH 2/2] event/sw: fix ordering corruption with op release Harry van Haaren
2023-09-04 16:37 ` Bruce Richardson
2023-09-08 16:22 ` Van Haaren, Harry
2023-09-14 10:58 ` [PATCH v2 1/2] " Harry van Haaren
2023-09-14 10:58 ` [PATCH v2 2/2] event/sw: add selftest for ordered history list Harry van Haaren
2023-09-14 11:13 ` Bruce Richardson
2023-10-02 10:58 ` [PATCH v3 1/2] event/sw: fix ordering corruption with op release Harry van Haaren
2023-10-02 10:58 ` [PATCH v3 2/2] event/sw: add selftest for ordered history list Harry van Haaren
2023-10-03 6:38 ` [PATCH v3 1/2] event/sw: fix ordering corruption with op release Jerin Jacob
2023-09-14 11:12 ` [PATCH v2 " Bruce Richardson
2023-08-31 17:10 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPDJoHJO/056NYjc@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).