From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C027842214; Thu, 31 Aug 2023 19:14:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1F9440292; Thu, 31 Aug 2023 19:14:54 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 465FD4027B for ; Thu, 31 Aug 2023 19:14:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693502091; x=1725038091; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=hYLLGKdmShN6h0TkEbTDRSt38K6vTHcQ0NDhg+LjP1M=; b=YLkW11RTgKUAADGSmPwOVLm2awxLpCXYyDOllXJRo5fzxPjBvGfEQ96B BxOhIj0rW5zZ6nUko5eS3yMoH6xhcdnxPZydaSrIZjKltjq5Jf5J9ePNN q4poy1+/ocEDQPOqyPON+rveraG9ZZ5WpKm5n3pTUfB0K3brbhdinKY98 JFxziPC//QDX8P2NkWwNaMkWxWYwaPKQH79ZGPVzDmhB7n2cwmu0lFeQ0 Gqj+cSBENaKLFtHzpCSyD33+mCFQeEt36OUd5xJOb6r8pRqcESjgE4HSd hMG7OLEntuoXPqlo0qssaZAUfA8q+GpNTZ/aB/qJ8YDAe2U+kvECeEljn Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="379798353" X-IronPort-AV: E=Sophos;i="6.02,217,1688454000"; d="scan'208";a="379798353" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2023 10:11:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="733187161" X-IronPort-AV: E=Sophos;i="6.02,217,1688454000"; d="scan'208";a="733187161" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 31 Aug 2023 10:11:04 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 31 Aug 2023 10:11:03 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 31 Aug 2023 10:11:03 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 31 Aug 2023 10:11:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gzQ0GMIbaoeHDYC3iyFXqRVSDeW0diVuHkLEqN52sfiGFkTQsoQr7CrdzLVK8vicJ0HjWTuiRL1vFEzDHc6wTbju2qmBIsFjWrf+4S0k+0e/m/XVRSoTfWOmQS6yqcu/2RSqi31Ct992EW5LNakAZNE7YVXjlyXV2H6Jhj8ELDvoJn2Y9mFXtjBG2Spx2dVOogDs/rZHgzUm/5bt96i5qTWO64KAINDVaH07sNsT+UKTGCl/bIz5jjGE7WVNAr+amuDN9Mw3hBZqDlrDEjuXGpiYxe0Xgy33c6tezEIspeMDPiKDHV1Bk1aro2AgxjDnoGVM21l7MviMnIJggVAqyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TZ3iVG/IQQiFOALxmJyyS/CQ8oScqmhABuGllPZJnzM=; b=mjWW7OE4RTDvF9k8CNppekz/Q2/Qm/EZloaFEEAiFWFLeoNDJCEgUVjxtcAGczwfN1+Gk9ayLQuySbjGD8uzBb+RKHQaveLBkBWhJ8C1lYHXTf+6BwbrxteHTC4eIU1iIpqngzA5yMfqqjNBd7mab+bJTBeTmEwN07G1iG6PNFocQFHAynfVU0FDMmh6+Vmz+tmf43osGlEkyS3cIWkSdRTzlkS+BqwxVOWESCotW7vmt+YOmLNM/j+3+L0J3/hKU8dalnSJ+EJCxddccHqZTOG2Ti0HGSygoKL71kwMNUgxt1UnNjkE1tV/HQ3YyBhQSfg5roUkl7pjsk+1zRAtrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN2PR11MB4598.namprd11.prod.outlook.com (2603:10b6:208:26f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.22; Thu, 31 Aug 2023 17:11:01 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6745.020; Thu, 31 Aug 2023 17:11:01 +0000 Date: Thu, 31 Aug 2023 18:10:56 +0100 From: Bruce Richardson To: Harry van Haaren CC: Subject: Re: [PATCH 1/2] event/sw: add selftest for ordered history list Message-ID: References: <20230831164736.2472671-1-harry.van.haaren@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230831164736.2472671-1-harry.van.haaren@intel.com> X-ClientProxiedBy: DB7PR05CA0059.eurprd05.prod.outlook.com (2603:10a6:10:2e::36) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN2PR11MB4598:EE_ X-MS-Office365-Filtering-Correlation-Id: 59a0dbd8-e70c-4990-e25d-08dbaa45407e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oCrPOHMDO6M3YcfsLwQ7Ej8RmJarbASZnPw46ZMs/ANPOBvoZs1JgGuB+YkETA0nHcnZciIcQHvXp0xE7+kB1z8s9WsUfpbWrfMp16SkON+DWprw7aq2yN1GUn4+5+m8m1J25F95t7GwzAfEQpvX+ZuYc8Xl2NGdiYjtMj/nXNIkDygwcibE467cM+3uAR775JxBztQUoC5YG2filVR+USGQXtn7yWrNVaKgzRuNrGx5ieHmnsUxHIvqfABfUmFwrHIH9iEYcqPh7hPk6LuaaahdRWoPpD/sc9RX7MvYGn0xgHinlEhPzAe0OFSZ1PylpcQfgd5MQZ6ARegkmA3tnnQ7+bt/S+6Ink22v7vVpQi8uAEgMzhojRD8Poy9Cx4t9WFFa/EJRLzEVi0egladmokzQIRbgwhlEMWPQMQwEaytx3wL908PV/eTK+ReoMdoZB0vpMxztrZ/L91F9usF/csBf4aX3oke3cVRL4KvezSe1BM9H+frzHmsv+FL9deR+hcP/I7uiu1CucCnXoX4t9eU2lkKjjXAt/bHxt8CWByffmEoNN/rmrsPN3luaXDO X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(39860400002)(136003)(396003)(366004)(376002)(1800799009)(186009)(451199024)(86362001)(66476007)(6512007)(66556008)(41300700001)(66946007)(2906002)(6636002)(316002)(4326008)(6862004)(8936002)(8676002)(44832011)(26005)(5660300002)(4744005)(83380400001)(38100700002)(82960400001)(6666004)(478600001)(6506007)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?b+cYgHezQe4thUjc5UVH8sRcAs2L5BFrqy2cia/V5k9H6isy9NGmlWraXgf5?= =?us-ascii?Q?b9CJXOhAGl5etiR4U1UFgYiweOE0C6iSN966aujysXKvfcDOFR3154aP0vTr?= =?us-ascii?Q?j4/PUlYBBRxUQhZeSNkhD/TfaW4P0+k5T4yDFk4cP1VZSj9rRZKgvqh3pu4n?= =?us-ascii?Q?bAENSZlOrbABUQp5tiBOZCv3f3W1+ieCO8iLKHWXltdrmxRei/7j76YpAeRT?= =?us-ascii?Q?Up+cc+GLQKWPE95EZdjxw0gSp5RS8WNANMKGMRVPBpn5feziCzmbZcJlI0up?= =?us-ascii?Q?e1uiVG14tChCX7OIx9yJYR3d7asb7zn5VSkmI9EFhJYg7m2LCk2rdHFfyH4Z?= =?us-ascii?Q?fdTDH4V8+Bg/sJlxa4NtbeCE5IK5oxasnEKhsloC8ynLMR4vRRrJBvhGbTui?= =?us-ascii?Q?nLeyoBhQnC8fxyXcD9949gw2BenUpCX/1eQsl/c2mb3f20C9slMVOL2ojO0u?= =?us-ascii?Q?/08RqoES5wAJQXxXElYcfvGcQtZBWbrDHlSpAfvnZG43totQgmqVra3EMbts?= =?us-ascii?Q?WU/jmiB7wTnGvDUZz1mu6iqW9l2fD6OttpccsXZfa80vCU3cGDyuu+Qruls4?= =?us-ascii?Q?A/QBgQKydVrAgSxURdOpkYcWaMKzaDpi6rhVHvAEO8IhOASWTOn2N0nRfr9E?= =?us-ascii?Q?tKiCKpRsLWUgeA71LIBhzfWulGMrUmDMj+/jDRKH85xkTM4kbBGAh5JbPWiI?= =?us-ascii?Q?CV+ih89GZb/UgC39iILFqfy4MHtMs8AAWNDd7I9l9hUq4xc/yNOvY46EJhCH?= =?us-ascii?Q?UTtVG/dkTXTlMSxsp4XAA+480jVzAR8Bsb8SAM9XfJr22/HzDH2jDjBq9vEl?= =?us-ascii?Q?vrrulK0JjIIktiCqVXrUDL7rWuqZbLsREQA2YGKgSIVwKEaTk+VSvoPvRan2?= =?us-ascii?Q?WtNEe2Ii0G2wvGjzHbG5Ul+mBvO8M5rijhDTnsLOucPXPFXadJFO2eScUEtA?= =?us-ascii?Q?j6QWh26PSJm+8SPvmX1kUDVyOSNax0V3Pye739Rde8bVwB6M6l7fypqi6ktG?= =?us-ascii?Q?uenlzsxg4DYHJR3f7XgPuKztHsyrc9+awj5qvotL2ahFxVI9NgkTrVCVLIJ6?= =?us-ascii?Q?eRKg+5kncbeYBRgj9LkL/PwHqE9Riej9+5OM50y4tuCtEciBkkVh+B2cX9xp?= =?us-ascii?Q?DJ+oDVxQJ7NFoxLq2zm5KSJWDOR5X7KOddyy9Vbeq481ylBfwcbXHct2x+/b?= =?us-ascii?Q?3eFm/EuDru9K2eIVwKdm/X6YsHmY866an3P1Ao1LXUo4O91S6xCvZf51JTjj?= =?us-ascii?Q?JBW65gRqk2jGh5wHEtW5WK04DRKATUiqnmyC/PvEi0edEYAwVIS2jhKr4Vmi?= =?us-ascii?Q?5sHBhuhC6i8VJEpoAV6cA5eYol9baXMg1I2YHRClWeatkmz4TOKfKKvZFytM?= =?us-ascii?Q?WtHrkshBOIgBt72BauCH3mCStH/0h4pHA83zViWyeM7fLQ1mkCMRn00hzA0D?= =?us-ascii?Q?DoR0ygTsdDOE6SYXFVfj0jgt5j/5ftfqBY23l2PblxFTCsCcpju4fKrirz4j?= =?us-ascii?Q?zlYBlLKYXRkXvjPsgUipX3HNIPerL0O2AeVrUJIi34eYkaT/o83rLY9E6F6Y?= =?us-ascii?Q?pbAe7WGplRnMLZiJ6WueMnneq0UrFRquqKPO11CE/uS47J5PaSWybNQmlCi+?= =?us-ascii?Q?XA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 59a0dbd8-e70c-4990-e25d-08dbaa45407e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2023 17:11:01.6221 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gIMjcrhh2B/2SzR8ErcMIhCbTUqk/ChwMPbf8F503bRoXUO2422Bks8oNttRv4AQl8C0F2YaFiQ2AiHB843MCgmEUv5pEMEpGQmlUUu/6/U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4598 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 31, 2023 at 05:47:35PM +0100, Harry van Haaren wrote: > This commit adds a unit test for an issue identified > where ordered history-list entries are not correctly > cleared when the returned event is of op RELEASE type. > > The result of the history-list bug is that a future event > which re-uses that history-list slot, but has an op type > of FORWARD will incorrectly be reordered. > > The existing unit-tests did not cover the RELEASE of an > ORDERED queue, and then stress-test the history-list by > iterating HIST_LIST times afterwards. > > Signed-off-by: Harry van Haaren > --- Hi Harry, having the test first is good for showing up the bug, but won't that mean that our unit tests are broken until after the second patch is applied? If so, I suggest reversing the order of the series so the tests always return clean. [If no V2 necessary, the order can maybe be switched on apply] /Bruce