From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D87842278; Fri, 1 Sep 2023 16:44:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A4CD40285; Fri, 1 Sep 2023 16:44:51 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id CF89B4014F for ; Fri, 1 Sep 2023 16:44:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693579488; x=1725115488; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=cQTJtJGHhFLJ/LGhx7udacwmTEOdb0/Sp5HCbJfsufU=; b=JZZ2nWuscSum0dvslcQCesN3vU7S4x2gACsMwPEnnwceGQbr+4Arat9D blbOTZ/xsLNgKWY7ihtcnNV3yldbpWZ9cpGndf8O9n+h/A70aNCUu9Hu6 08TRk72LFxkFXE45Vs5dMOC0ZBrrvb3nejnhh50cpVUxS2L7DTO+JJzMO RxRzl/jG/VJu7myZjT7yShbHy1oJxqTluvKQZQDxa3IibrcFPq4lypg9d XrKhgnSFWdySu0zQYBQuNYyvKA1g4lVc0iowVyIic0Iz34YRbOoeLTZXN IRlt25r3pFIu8gmQcaUASEfnD+nqTnSmwhGcjHPSVhpYmpI2Ry0OcaoS6 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="356544253" X-IronPort-AV: E=Sophos;i="6.02,219,1688454000"; d="scan'208";a="356544253" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2023 07:44:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="743128378" X-IronPort-AV: E=Sophos;i="6.02,219,1688454000"; d="scan'208";a="743128378" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Sep 2023 07:44:47 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 1 Sep 2023 07:44:46 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 1 Sep 2023 07:44:46 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 1 Sep 2023 07:44:46 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 1 Sep 2023 07:44:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YDBdBie4+Jimr29mw22ogvodGc6lI7vl/7KF+1g3M6+HJtTzVPK7hCB0lBtUZ7vaOx3HgDOgjP6E8v87WiBjmMpcr8k+L3tgarlmVQpEpWrub/6f3CI/ttey1+LbR74afDGtwwqBckTVbMCxeWs5WKqwIyfqcuE0TQBgNbg6YSJfuMg6c4+YeaLYQrET1E7hxSkcwbQtDUH49f1q9TQ2DXnhQeaZX/h81CIgP3AchY2qtqHXUkKFQx5nyFjHUrbRcn0ntxhShwsDnPNQ7udLH8Io6TenY6Z7PtY/OUduf53grfbo5zlaEs8FMwTxWhFOznpOtIQn7FvL3Ox2JpX2iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DgqiBd20tKa5alvnPxxZ0FVEjyA+IWZPLFmMPgb8NaE=; b=dGFimLVCB9rlO5e12aK0WfT6rrG8XdG8o+YzTXdwEluX1uXEF8g9VAkqMHNIKsMjOrt3qTHlr+Rod7x0poCA/aYSdry9FCt+t8flFuMIYbtRi2nbjLD1xJOHAbv/m30OydX+C4EfmNhv44HSdTa9gU11wgokPXRrjgxph+v1JqZUTZmC83w/dlqvGGn7jYUmEUmBZUGb9LAGjGBjPxgS8uJuRDVs4ZqxM0+q2VAXk6gQgQCS1cnzppt0e/iRfuzfcnK5YvwmvBGSdH2BzyT/gh5cp5+nd8vKZi44xKTPOGMhQtocb8HJvPLG3zsqQ4OyM16qAY8ba7FJn/9Q/P6KCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS7PR11MB6295.namprd11.prod.outlook.com (2603:10b6:8:95::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.20; Fri, 1 Sep 2023 14:44:44 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6745.026; Fri, 1 Sep 2023 14:44:44 +0000 Date: Fri, 1 Sep 2023 15:44:37 +0100 From: Bruce Richardson To: David Marchand CC: Subject: Re: [PATCH 1/2] build: fail if explicitly requested lib is unbuildable Message-ID: References: <20230901142332.588856-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU6P191CA0065.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:53e::27) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS7PR11MB6295:EE_ X-MS-Office365-Filtering-Correlation-Id: b88ad386-acba-43a9-ab94-08dbaaf9fb10 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g/SsNZCdJmyOW2Pfdb1eUWuZobEtrKWNO+p+2up+jR5phHwPyPwEgFd8pzjsb/4bb6ixB0zu2Rlpfg17oefB9JanPLB15Ui3tQAT9sg2JgIO7cYDTfMImge/RLSMjd9o595fSot+ObpAFdrOGQ++pZ17k6/XGOW7EZYN3vgQ7hxRD4otV++688X0VaoXVh1BIJkeg7d0ZsDt9acq5osrjks1d1LQJZfbE8SF7X0G/eoRJhmVz+4t2+QL2yvvb4vEv5nvRqggBi2LAQVeCbxd0/QvaHLHEVBz1Z8MKmgygEsvL2yeKejz1CTT/MJnV18vTeIb03NGc409YOEyrrKBC1teY5EpERbHZ1j+bIQLMUmM7iy1hUE7mhXnIE9cwaJaEwOkvH30Ghm/YEX8Oo4d8F+U9RaPsDQInxX/Gpz5ENiW83K4pHBZWx2Zq88kYQAGJzsISx4U8dRZW1bEkV2wr3zMN6rhKFe/3J2lltwNsa+KRZua6ENRsUjBPr5akXfjkJcWc9PqDI9K6Vrvif0qddG4cMyx5aDvJ+gKiHdHPu4B+a/Y0YhctFy7ih5qkbuc X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(376002)(39860400002)(346002)(136003)(186009)(1800799009)(451199024)(8676002)(8936002)(4326008)(86362001)(44832011)(5660300002)(2906002)(478600001)(38100700002)(26005)(83380400001)(6666004)(6512007)(316002)(6506007)(6486002)(6916009)(66476007)(66556008)(53546011)(82960400001)(66946007)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWFEOU0zYlUycVBaRUo1NzBPK3ZyWGRLa1ZWSGRhRWJtSElzbk1VZ1BrY0Jo?= =?utf-8?B?cHVnL3ZmU2NoQ0RQanJ0dlBzYXJiS2NqN1d1aUFxWW55QThjQ2szbWl4c3Nv?= =?utf-8?B?cnFJQlg2alBlVVg2RUF5MC9ZWkNZcnJzRkcyQ0hHWC9UaGVzV3IzOTVyaEpP?= =?utf-8?B?cElCRldOTElSYnJVampVMVp5a2laaXBYUnJLcURCK0RLVU8vcjNLSndCSTV0?= =?utf-8?B?OFBES0N4Vm8ra2FFZjFyTE1FWEVkTVBGczB3UG1GTGQzM1dxZVM5a2JuY2Ft?= =?utf-8?B?anpIRkJWOXJNMkJpY2JoaFIwTXVLK2JUaVRpZytEM3VKa0JWdkllNVlyNVRP?= =?utf-8?B?SXA1TUE2djBQYnF3Tytpc0syalZOc2w2TFVYL0UzVWcxV1I1ZGV4QU9aWXR4?= =?utf-8?B?UDdwYVlaTFg3YkNWU1dyVW5mL2t2Zm5vL3dHMDNEa2NCVzFTRGlMaldKUTN6?= =?utf-8?B?MmNVR2QwclFuTk1VWjdyb1Zjdkw1UkdZMDQya2ZpOHRyN0xSd2FVWmcwUnQ2?= =?utf-8?B?eDJFcmtNMEZqajN3YVRIeTE1SGEwLzJTeENRaUtkTkJuaWc5WnFIWkluSlcr?= =?utf-8?B?YkhvL1RDZkhWc0ZaUVhvOTJUZTV2TGRUV1JLRFRzZDBRL0NBWDFHeXRWMUpk?= =?utf-8?B?bFRaRFhPUVNYbFpSSDBwc0hWc2hwM25GUW9sOTYybkFyeHBsOTJJSHJiMkIz?= =?utf-8?B?MFVHN2I5ajFsdUhNakxNMWRMZWJNakpDQmZMdERISzhiVHlFbVU0OStCVWdC?= =?utf-8?B?cnU0TDRSSFUxbGtXa21rZE9vRURWdjRydnFRU1RqYWJYcnVseGFBNnNUY2RN?= =?utf-8?B?eDBaRmZvT1poamJBSUJRM3hiMDYveUI5QjAvZXNSc0J3cWVWRXZPeElmamhp?= =?utf-8?B?ZHZuOXZvcTNqZGczTkJuSm1hbFhsR1FYM1Rtb2VJanA1MUJ3cllSS0xGREtP?= =?utf-8?B?R0xDcnhFK01hSjRXUnhnZENFWnNzOHBFOEIrMVVTai9oamJIYXRhWGI1KzhJ?= =?utf-8?B?MGVIQkJ4U2lZRjQ0dXlFU1hEUHM5c3hpM3FFMld3SUFrWUlCdUlVbWpETFlZ?= =?utf-8?B?ekMrTDluQytoVFhvaXdJMlB5cWJ2WVZCQVJ5dmFYR2ZZOTU5eTZ6aFlpZXpI?= =?utf-8?B?NkJKaTFvZk5OaW9LYk5haTJ6RFp4K2xNeTdNK04yc0ZHNG9tZnhjYzY2djds?= =?utf-8?B?VUZoTTJ6NGEvRTI1QzJDb2dMZnh6UDBVMEhpeHhndmZXdW9qeXJMbHIxamlk?= =?utf-8?B?Tjd6dEFlOXR2dXl5WDlNNVhFMGlJUkNjanZnd0FSWHhYaDFjdXVwNFY2SXZn?= =?utf-8?B?anBwZEczNlRzQVFlTGpSdFJFUHdVS2pFeXVGdVExRjgrV0lrUEJQTFpCWnRV?= =?utf-8?B?cDNnbDd1VzBLdVQ5bXl0NzUvb0JoVjl6MkhqVVo2ZVVyeEFNOFo0MjVZUTdm?= =?utf-8?B?UjZzcDM0dGxOcXAvVzJtN09FZkhHSnYvTWV0c0V2elBGdU9icG9XWms2alBy?= =?utf-8?B?M1lqTEs2REVxSHovSVl6bTJNdENJTk1VRmI2TStxZCtqZGRGZ0pxSG55Zzdq?= =?utf-8?B?a1lTQytMT1JvcEk0eFY1aUZISWxiN2FmK0NFanhWeEFXUENUMlcyaGIzVVBv?= =?utf-8?B?bzB2MERDN0xPODNtYmNpOE9JR3ZkbW9aMkpoT0g2WmpNNWZqSHpzMTcvVzRr?= =?utf-8?B?YUVuK0pJeXZrZ09PUXJnUW94UDc5RlFId2pnQzc2M25rZWwzTHFYTWk2enJx?= =?utf-8?B?WGpmNGZXekNLN3hadkZQRDdMRzVNUUJCQUcwL1VUR3ROSjJzV0srVVc2MFFS?= =?utf-8?B?RG93MURkc0xvdlY2ZjNSZ3FmUFp3ZGVJVHlrd3dpQlBiTlRvcXJ3cnNLZG1O?= =?utf-8?B?bng1MTlxYkl1b3BFSHpyVkVubnJ6Q2dmRE5GdFFCZUlaQ2RaMU5xd21rMG9w?= =?utf-8?B?aGE4Qk50dnR5azZnZW10UzBjVmNRTXh1VzQwTy9SOEhaZENnRFk0b0VkSk54?= =?utf-8?B?cEJaUlhpcm5raGdmUlJqMEZZSkFaSUtONkpSZ29Xdm40Y05SZklKQUlXakQ3?= =?utf-8?B?Q3Q4YzFOUmZ3Q1F2K0hVbFpCd1FaVGVJNFdIRllhN1dRY09jNnJ4VXZsRUpP?= =?utf-8?B?MVF0UVpZb004RGJNNzlwUjFoWDZLSytaRlU1clZ0Ulpna2RZSHp3L2E1aE9G?= =?utf-8?B?cXc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: b88ad386-acba-43a9-ab94-08dbaaf9fb10 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2023 14:44:44.0867 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: REScwtHguyexZbw0vOJWv6i8u41/xWE8JytXd6vUvXANzw+cPZ/aptZwEHQBtxyFoVZSzf2RUg8YHIn/KBj0ozxRWO2ZwyfKx2QFeRZQ0Ow= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6295 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 01, 2023 at 04:30:56PM +0200, David Marchand wrote: > On Fri, Sep 1, 2023 at 4:29 PM David Marchand wrote: > > > > On Fri, Sep 1, 2023 at 4:23 PM Bruce Richardson > > wrote: > > > > > > When the user passes a list of desired libraries to build via the > > > "enable_libs" option, the expectation is that those libraries should be > > > part of the build. However, if those libs have either external or > > > internal dependencies, they still may be silently disabled, for example: > > > running "meson setup -Denable_libs=security build" will successfully > > > run, but the security lib will not be configured as "cryptodev" is > > > missing. > > > > > > We can fix this by setting a flag to indicate when the libraries are > > > specified via an enable_libs flag. If so, then we error out when a > > > library is unbuildable, giving a suitable error message. For the above > > > example case, the "meson setup" run fails with: > > > > > > Message: Disabling security [lib/security]: missing internal dependency "cryptodev" > > > > > > lib/meson.build:218:16: ERROR: Problem encountered: Cannot build explicitly requested lib "security". > > > Please add missing dependency "cryptodev" to "enable_libs" option > > > > > > Signed-off-by: Bruce Richardson > > > > I remember setting a enable_drivers=net/af_xdp on a system lacking > > libbpf-devel and not getting warned about its absence. > > So I suspect enable_drivers is affected by the same issue. > > Arf sorry, did not see it was a two patch series :-). > No problem. At least your response confirms to me that this is indeed a common issue, that could do with a solution. As I explain in patch 2, fixing for drivers is a little trickier than for libs, as for drivers we really need to take account of wildcards to avoid breaking people's existing builds. [Or, at minimum, my own builds! :-)]. BTW: while we could look to handle wildcards for libs, I think their use is probably much more limited there, and I decided to go with the simplest possible solution instead. /Bruce