From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93EA842278; Fri, 1 Sep 2023 17:00:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71C3440285; Fri, 1 Sep 2023 17:00:22 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 9F0734014F; Fri, 1 Sep 2023 17:00:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693580421; x=1725116421; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=SLZxtUNTX6eG5/xUyfFouzU0xRMU46RagOPmn2wJGzQ=; b=lyZIDI5rigdD1F8XwxuDuLBqQVAC1uCY92WtT1KExLN8UhE6rOKIpXPt PuF3673g6gO9Mt+BqKhg1/t5yMhHGyVJRyVr7sDLMHoXfUGC3xT3Gq0X2 QFEJSQcJECKoNGwfj2ec5nBU5L7Ovp/wCOlnPPtD5yweVdNXUBnr2gy+e /7E3DropZpATgdIGNUNl0f4mKBf6HIX7O+Zi56JUKhWnwPtWM/+PkVqQf fUccbKA6Tr7jSvmFGPCig48c7lFsardKSFT/TeZ4BV9YZ+Jed6cfvb67p 0Sk2vq0YNx9kws9RR2SX6g9HIHLKhuDwp5DZXQr1ZOOSkF1XwChscPvcU A==; X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="375138344" X-IronPort-AV: E=Sophos;i="6.02,220,1688454000"; d="scan'208";a="375138344" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2023 08:00:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="913712574" X-IronPort-AV: E=Sophos;i="6.02,220,1688454000"; d="scan'208";a="913712574" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Sep 2023 08:00:12 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 1 Sep 2023 08:00:11 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 1 Sep 2023 08:00:11 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 1 Sep 2023 08:00:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YRKEqNX6qdFIb5aYB7oMf1kDEVyRx/Z8+WW3q6jpQThyPUU51lQOHJvzfRnb3NejSNgEf7W88ZkYUeOJIxTnZPkkpUdz+p23xdLmY2L6F8hSSPwtGMyswZO1bB3DCwSDtSZ5nOZZkr86AALRBb59UmXAWomKJWnVnH18XU/4/A0Vo9yFqL0GLyOjm6MzE8R4P7KvxGgIaKRfPxKH4scRIKDMHkba390rY+OVs75cysWWQPowIn7uuLtCOh1iRwUoo/kpVq7LU0VzV2umUKwWPpRZHzs2LcXyYuOZBuM3yb8whbfSiBpJ8QhD/ZhCvG2c7SshoSvRpnRZi5gNxrBuLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YT50XaxAoZj4vwCefBlGF7ATAl5nH+UxB8qWsIOCdZY=; b=ITeOt5Xjfam9B+hwDi38oyjEHO7wUeILrtbudoBwo3WbhkWgrIDuWHsnA2gORJaX/qBxGCtK37A90Xy0gwCR8EDH6un00pvnLlarGQjZxD6k/sjOoH//a8+n+75yY4bktGDl6W3I430IiX54gyALcdSOLMckX/ounxEu4NRsFywVdAm/6LURJE6vP8fSyyTcp0XVeGzIQKuKWVynZrpirMr03+lycYuBcuhp0BNT3F+6QJW9B7Mv1ZKKSsVBLoGpPYhMRUhiq890UCdT8nB0PmFh+WvY+gtRFrKxdna8PaIIJNTJ7i7gtHPqSv3aHIOjyC7OR8WUZ7+huP3+J+HhkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB5423.namprd11.prod.outlook.com (2603:10b6:5:39b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.23; Fri, 1 Sep 2023 15:00:06 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6745.026; Fri, 1 Sep 2023 15:00:05 +0000 Date: Fri, 1 Sep 2023 15:59:57 +0100 From: Bruce Richardson To: , David Christensen CC: , , Chenbo Xia , David Marchand Subject: Re: [PATCH 1/3] vhost: fix build for powerpc Message-ID: References: <20230831121058.725577-1-bruce.richardson@intel.com> <20230831121058.725577-2-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230831121058.725577-2-bruce.richardson@intel.com> X-ClientProxiedBy: DBBPR09CA0035.eurprd09.prod.outlook.com (2603:10a6:10:d4::23) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB5423:EE_ X-MS-Office365-Filtering-Correlation-Id: 607bb854-ed88-4d91-fb3a-08dbaafc2001 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pqFW8eCY9a2ZyKnqc7kdrqadZTC0sAOetNX07Z+OUc1IKfD7LkLZcupCTB4BqDQg7V6DYBuZxwrRJOtso2pEhiyo7wF7slNIdGb4lqbSLRG+CNzAU/6KdwLsoG9X9eNZalNxjy7ah7faniNj7t95MqyuFo9LVGg1dwANsR9n3JMOmZVMAVvo4vDkHDBJCER7CtxpjU4gGzcb0cq7LFBllUihFpqcyX6/IKPY260hMy/k3E9tNXNXJN49ERnRJtu3EgxX1ehG4raTpIZ+HdcjwJ/XLgKqu3piwZZLVwWEhKKfo9Xt8cX5wOJR7gS0MQD5r1ZNhpK4MVpnakfviNYJATyB4jgi4u3upW2VFBifZXjTxL2HIefQKhOp/H57nepSzhWZtknbbL7X53a3nN/92PtmtOZT23DPia/EWY7LNd6b/1AHozU7B6XBR0JoK7RxBa5BjBbCcyt8JrvmtRkIHjOy/hjCULLUbsa1qLqplxS1Uxx1lhm9Z3HxGZvCVdOaY8XPjfoe+m7HKmp4XHPkGoPRS422szgSImWk/fJo7AaxyXkl1z0UWHEp+50MUHzl X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(346002)(136003)(39860400002)(366004)(186009)(1800799009)(451199024)(2906002)(6916009)(316002)(41300700001)(5660300002)(44832011)(8676002)(4326008)(8936002)(86362001)(6666004)(478600001)(83380400001)(26005)(6506007)(6486002)(6512007)(66946007)(82960400001)(38100700002)(66556008)(54906003)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDVsSW83WHltMU5pTlVBZVVBTDNzMG9Fc3kxaEVKMVp4b1puaHB2N2o0MVdM?= =?utf-8?B?S1dkbVRJdno1Q1hnQWVwbUZEUk1pMm9JWUl2blNBUzFacFZDYXZBeXVmdW8z?= =?utf-8?B?a0F2RmNET3RhcStIZUx5TjlDK0lqNWFac2lsb1ZQSDBQS0g0clAveGhQLytQ?= =?utf-8?B?WWFmWktSejZwZW9KZ21Tbmc1T1c3dGI2LzBKMjJCcVJEV2hYQW1LL2Vpcmcy?= =?utf-8?B?ZUZsNTdQMHpmcGJLblJORWxsSW1abkYwQ3p0enF4QlpGalBQTDQyWTJPZjBt?= =?utf-8?B?NCtxdUJFekhVMzFTVFhMeHhreGtkYU9kMU4yd3hmaW5LekJYRGJTbm02c0VT?= =?utf-8?B?SWovTFoxZWZoSS9UTnludTE5UitpOEh0a2NtdHRvSktkdFZIWnJIM3hKcVIx?= =?utf-8?B?VC9xVnVxMmRsNFhXWnNFVWU5WG5xaUxrMTVPbXhNd25NSnFZV0FNbjZjVk9o?= =?utf-8?B?Z2JvL3FwOFVsaVJjTmo5MlFWTC9xV1FKM1NxUzdVdWRza254M2VuMlQ1alcz?= =?utf-8?B?bUswS2xVWnQrcG81aGtHK1VoakZvR3FvRldwaXRQVTl5QndiL0k4MDVOdGRB?= =?utf-8?B?RFlzV1RhbUNzUElHUlpvbmVCMGVMOHJTZ1ZpNjJydGpzMG05VUl4dm9SNG5S?= =?utf-8?B?NnhWbVR5aGRCT3lTRVB4SmtFMzVzV2MxLzE2R0hOSXFSQ04rdWdXVXluK2Y5?= =?utf-8?B?b0FZcXlUbk9yYnNlb1pOc3BiSGszbGx4WXBObTUwUHdoQjBnTGZQbXhsWWl3?= =?utf-8?B?S003ZFlVNXJSVG9xMFF2RjR0SldSS3BvaVd0aUhJWlNOYUVMLzBsR3FDeWk4?= =?utf-8?B?UUhrYitMSy9YdXpJeVZwUllablNOQWFnSW56NmVrZHVTY29ZdHlHSWx2bFJU?= =?utf-8?B?c1NQWXNRQ0ZMY1dXMnRaK3ZqSXNNWkRIL0F5TUVIelRHb0F4TUEzNERSZzFK?= =?utf-8?B?d0h0NkdkZzJaKzUrZDRmVnlNalhTUHppRkpCVkFSdGw0ZHoxb1ZtcnU5OS9H?= =?utf-8?B?Z0VSbXhnZXBIdlJjQzYrR3BBcHlWUEFBR3FwWkJHZFRCNndxQk5CcEZoSGFu?= =?utf-8?B?TS9odWx6eW9nckdzOTVxQWc0N1hzSm11c2s0MXZiYkhaRGxhZU9TZSttQXhO?= =?utf-8?B?V2RFUlBuQmxWaDMyM0hQM2Q0c0tBUzNiOVFxeGlJM3B6YnpseVYyNXF1M25s?= =?utf-8?B?T2ttQjI4Tm9lTEt2UVQ1eXVIb0FmWXJ4VGJUV2M4cWZQdmYzOTViZU1wN1dD?= =?utf-8?B?a2c5dDR6UFhQcXR5MGViaGhXcWRocGNWQXZmbW90TSsrSW12dmdGdHFydXhO?= =?utf-8?B?N3oxTXJuUzFPVEgrYnhEUkdlRGNjSTFRZEl0ZkpEZkFUcjJ6SDFjblNXeG9R?= =?utf-8?B?VWpnaDd0clJobXFVUE1IdVFwOWZHL3cxbk1hbXhHNGF1QTNFVzBvTWdROGpl?= =?utf-8?B?MEJJYXBUdy8wdmt2MTgzcm5iaEZQaFRyeXlKeVRJTTNjK1pVektCSDZQWUZD?= =?utf-8?B?bmR0UDAwV2FDOEVxVDE0VEhlcXhuS1p5ODNpS2wrdEpna3ZSV1NnMEIyMCtz?= =?utf-8?B?VjVsUTNkU0c5TkppenRONGxZaDVaNS9qbVlHd2xROEhVeFF2NDhCa01iV042?= =?utf-8?B?dHZHZmVjc0hCZDNXTnlaZWtKaHNoL3A3WFJjUE95YUJYSndQU0dIbk1jTzAr?= =?utf-8?B?bzR4OExXRFdJZXZsSTE5MWl4UXFXUi9FRlpnbFU4NXdQVm1FSnErSU5sbzdN?= =?utf-8?B?cncrNXZ1R0JBdXlObzQyaEVMd2VJT0tsdkwxZTdNbTY3azJvdzlMU01maEJa?= =?utf-8?B?ZnBsL1ljU3g0aWJYQVU0MkZZUmRZZWlYTUNjL291RWNQZHVGR3pCNWhlKzZm?= =?utf-8?B?UzNXamRHT2ZCWDdHN1phbkQ3SUpMdUhkQ0Y0RXp1TkVJTVpEYUdvSFNQOHdG?= =?utf-8?B?N2t5R0trc29QWHpNaUxleXZ1MWtMeVlrb1ZPWERXTW1LU3ZRWFlyemFRM2lY?= =?utf-8?B?MHE1OUJXODhmelA0dytPcGVaVlpCMk12RS9adklGVndJalRnZjhzUjlORDlW?= =?utf-8?B?ckxOUFhBT09vc2JaaVB2Z2JzT1RsTjB1UFhyUTFKc3JkRUp5U0loY3grTkcw?= =?utf-8?B?ZDY1Smt6VVpuZ3RudHpJa2w5M0x0emppcDBQWEZiL0RaYndCWnRReERGSWl1?= =?utf-8?B?Snc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 607bb854-ed88-4d91-fb3a-08dbaafc2001 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2023 15:00:05.0956 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4regt3uaQ5Zjegtdh4x54JfFFzMra4Wt5DQNPDijpuciLvysGCNZbEji1t7CHMAUf2litmy5E6raZ6+SC9aTNXv+qdA5amNswrC9Ef5OJjw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5423 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org +PPC maintainer On Thu, Aug 31, 2023 at 01:10:56PM +0100, Bruce Richardson wrote: > When building on Ubuntu using the packaged powerpc compiler[1], a > warning is issued about the print format of the __u64 values. > > ../../lib/vhost/vduse.c: In function ‘vduse_vring_setup’: > ../../lib/vhost/vhost.h:676:17: error: format ‘%llx’ expects argument of > type ‘long long unsigned int’, but argument 5 has type ‘__u64’ {aka > ‘long unsigned int’} [-Werror=format=] > 676 | "VHOST_CONFIG: (%s) " fmt, prefix, ##args) > | ^~~~~~~~~~~~~~~~~~~~~ > > Changing the format specifier to %lx, or to use PRIx64 breaks other > builds, so the safest solution is to explicitly typecast the printed > values to match the format string. > > [1] powerpc64le-linux-gnu-gcc (Ubuntu 12.3.0-1ubuntu1~23.04) 12.3.0 > > Fixes: a9120db8b98b ("vhost: add VDUSE device startup") > Cc: maxime.coquelin@redhat.com > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson > --- > lib/vhost/vduse.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c > index 73ed424232..e2b6d35d37 100644 > --- a/lib/vhost/vduse.c > +++ b/lib/vhost/vduse.c > @@ -162,9 +162,12 @@ vduse_vring_setup(struct virtio_net *dev, unsigned int index) > > VHOST_LOG_CONFIG(dev->ifname, INFO, "VQ %u info:\n", index); > VHOST_LOG_CONFIG(dev->ifname, INFO, "\tnum: %u\n", vq_info.num); > - VHOST_LOG_CONFIG(dev->ifname, INFO, "\tdesc_addr: %llx\n", vq_info.desc_addr); > - VHOST_LOG_CONFIG(dev->ifname, INFO, "\tdriver_addr: %llx\n", vq_info.driver_addr); > - VHOST_LOG_CONFIG(dev->ifname, INFO, "\tdevice_addr: %llx\n", vq_info.device_addr); > + VHOST_LOG_CONFIG(dev->ifname, INFO, "\tdesc_addr: %llx\n", > + (unsigned long long)vq_info.desc_addr); > + VHOST_LOG_CONFIG(dev->ifname, INFO, "\tdriver_addr: %llx\n", > + (unsigned long long)vq_info.driver_addr); > + VHOST_LOG_CONFIG(dev->ifname, INFO, "\tdevice_addr: %llx\n", > + (unsigned long long)vq_info.device_addr); > VHOST_LOG_CONFIG(dev->ifname, INFO, "\tavail_idx: %u\n", vq_info.split.avail_index); > VHOST_LOG_CONFIG(dev->ifname, INFO, "\tready: %u\n", vq_info.ready); > > -- > 2.39.2 >