From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E44FF424EE; Mon, 4 Sep 2023 11:12:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB970402AF; Mon, 4 Sep 2023 11:12:21 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 53106400EF for ; Mon, 4 Sep 2023 11:12:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693818740; x=1725354740; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=yJi7c0wXhue20yVw8ABBSlXxvKPHP83LalILFOsArWw=; b=ivHFsk/KMp/5pHHVd8ss39Knq8Yab7qPqvEuh8qp4jNIRke9EVQv/JoD FBaDPdUQkDAy0AUstAYD9cmt8vRjcSbTiEJkup7b7VfgH6YdrYjhzclIo AGVyA44qcvkr5v8inP0NEdbCwnCqKL5bxOiOv5uVhu512dURqqNAD7fC+ oOEtT7CQFzLzPdD+jaGq2YJC+I6CS3nsdV81RO+7BOsIgGvm9e3uNffVq JPW+EbYnCjDlTV5FlcG0fchW+skcKUx35kWzglqG8byP0WTZd0vYNvqFC VTnjxN7TIOXUNQO50l5xKVfU65Nvd/3YYACpHqFrDJ73GRa6V4Wqn7Lge Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="407554161" X-IronPort-AV: E=Sophos;i="6.02,226,1688454000"; d="scan'208";a="407554161" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 02:12:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="864267525" X-IronPort-AV: E=Sophos;i="6.02,226,1688454000"; d="scan'208";a="864267525" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Sep 2023 02:12:18 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 4 Sep 2023 02:12:18 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 4 Sep 2023 02:12:17 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 4 Sep 2023 02:12:17 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 4 Sep 2023 02:12:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QYt5ZK5hjs7K13CWj4pwJq5kJ0VlRPwpdo4cr1FAe0EspPIGCkBLIBiWlX2z0ddq7VZtyh8riFyOCDjAFp5plb3/Wzj9L6bdv+S1AcIo1QAdLGr6OeBMJK6zWorDHp6Q4I5+nXnNU8zuxDoCP7i1oD2nw3fMZX5x3JebyStedilLRD62eOg8gAR4QgCMC5RnHNhi/fcG3KbFKaWa8gPq8KdF/wVKdR2SrBGxB0j3y1nRISw4GtPo06vdypwxxwOiwa5UYxtyuDRYeljcSdUfL9t1dSMy1tjFWgmXZYUo6nQEDLDl5DuqDnpqbkq9yi95SZIhTHDFFzEnCNZNjCeC8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6sAR7r8JWhYFXnrRIW+MkQZ5iPR61GS126L3CV73Yms=; b=Yu4ua3boWM4IC0OYv8fVR9EY9FKQ1uTajzEYirhESa0UtLi3DVArUhmfdef1QQfG9ooa4n9Df5FMjUki2u6kdgCBY/+zO2KokuRCx4eCkqecfGbuKSKMyhOSMpup0s7JvHcoNQv4g/4q799V1fBPHQ70IVqImXja5OEe5c18WJ1F43HmYZjx0BqmoS+vBiz0do6Gn2TnOdho65j3X7FnF6Alh28fQAkZto+KGD6H6y/I6FckleDbHYRCZ+9ibSIxST+/WeTh+mm1Mr3hSfo0dLAPHZCaFNjiYgC1OS9cPEqGHDd73n2k8gNh8zykMiEV18QMWnqN1qCclgTH3pYzSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7829.namprd11.prod.outlook.com (2603:10b6:8:f1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.20; Mon, 4 Sep 2023 09:12:14 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6745.030; Mon, 4 Sep 2023 09:12:14 +0000 Date: Mon, 4 Sep 2023 10:12:07 +0100 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: , , , , , , , Subject: Re: [PATCH] clarify purpose of empty cache lines Message-ID: References: <20230904084349.12044-1-mb@smartsharesystems.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230904084349.12044-1-mb@smartsharesystems.com> X-ClientProxiedBy: DU2PR04CA0335.eurprd04.prod.outlook.com (2603:10a6:10:2b4::11) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7829:EE_ X-MS-Office365-Filtering-Correlation-Id: 362d64fa-1f03-4120-ccab-08dbad270785 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MiHkOb85VjHiG49X1evargXeiTIDKXDhrXOlon2MWFoScj/i7/QcLrIlJkE1POkoc00Gyrh+TMVw1sGCcV7yj1vWWYenaz5Gw5RqwQZw5tvi40AFkIaENdKlc7S8a+xw/Z1wRJ0Y6nupgGhO9BO+8K4/e+fQlwl77mKLVWNn9OrZ4IjfJzfViOyH8gL9b7vkIDXwP1wYob9YV0q0mrh58gufdVEnMOykI782VtdTrxPDRU17EM2/kJf1MWvtN4f9XazQ4q73rTd04sTBCIQERWuHJ2JRKOF09Vt8jyt20emw7acBg3lKlwK8LYK49f+4dTto+ABxhj0XjlzW0JkzWkYx7MB59MZ1GmT4mueSN0tVGQ88dORGEVgriCp0oGaIwoYUSoyAfnb8RbnqunhWCssSPeI4YSCs2umlJYvfQLe0O7lEk2QL8IYpVLATdGHB1sTnBC3SUW+UN4WdsSptB2z2cd596GNXDc7tOawIXsBACH60eMeoYCp0BG7Megtu5CoCNb6zsUzlS/WxkmclvwfQkm+7xe7vmzOH3dRZO6Y= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(39860400002)(136003)(376002)(366004)(186009)(451199024)(1800799009)(41300700001)(4326008)(44832011)(86362001)(8676002)(5660300002)(8936002)(6486002)(6666004)(83380400001)(6506007)(26005)(6512007)(966005)(2906002)(478600001)(4744005)(38100700002)(6916009)(66556008)(82960400001)(316002)(66476007)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?RLpk7+yJZrFM7QnnVeQg3caFjdv3iWiED0YygSPmdoobHM37O7fiwFUHIP?= =?iso-8859-1?Q?qM9U0wwziXssmnVHF1WDNUxqKDicRobFlTf6BvEKTXMjSH/ANOpB6ElfGT?= =?iso-8859-1?Q?PFfAo3Fm3M51BydJGw9skgaeQ5vX3YgkRQujpGBiuI0MGyrZQbO5FAAQ8/?= =?iso-8859-1?Q?VaCxAux/l4Wp8kXi8wDExbnLQZwDmyIr3SINTTwmB9CitAZI2nXVfaM4bC?= =?iso-8859-1?Q?YSk+Bem1a/skCvNz7sE37dWNMLjyGTPM68tOkr8lxji2TGHMtkcHERSD+w?= =?iso-8859-1?Q?98Xzr4wFTJGVOWLhQp0OD4aoOH/I2IZ23TUCFgo+yeMGe3SQPps9/xTqSa?= =?iso-8859-1?Q?L8ai8eiyJbrP4UnFapNTFZmtg5Qa0AMs+XqEDriL61aJ8pUtNiLO3zn+aq?= =?iso-8859-1?Q?cVySz43osFTxOwFw2X2nllJlfWKmmmpmoPITuG7l3LIXZUbyt2f9zVaeyp?= =?iso-8859-1?Q?tf8WUUnGmJ8yW8B630PbSLWmHIYeEJmFU9hhopyfjsDNgW091FUdmbowPU?= =?iso-8859-1?Q?r9L5URZousPZClU0gQ5NRqLHNWfpr8vBxnxpldnLrH7gWAy6lcN5klpJvX?= =?iso-8859-1?Q?RF3el50xiCrViTBHExEwTpQXnOPM0suDepSyQrBU+deWnSRFwx0CndCfaK?= =?iso-8859-1?Q?ERJKSx+MgY42MWIRQcGiIO0IkTRwY8+rwiWAZbBYpo94h9JR8Gx6ELwQfl?= =?iso-8859-1?Q?S3nRnFzNch4j9nJnSWfir9CuQpq5Ft9/U8/g5tWBOjucLUcf6LDkSonhrR?= =?iso-8859-1?Q?SDhhpxZD3deOdsA0AgGbyy69yvz++LjIjJ0pbo1lhXAaV0oxIAq0hdqLUQ?= =?iso-8859-1?Q?4SNtdnUwq23tZjpUN9LOJZuAb4pxHLDiIvL87wb9410GHtwY04gtGsgd2m?= =?iso-8859-1?Q?KJn+HHvoM/bW1bDRPj99+A9z/uuuDYJ+2lz428O82lRlL0Y5XsneNcP1pv?= =?iso-8859-1?Q?AJd5voUJK5z6a5tWgnW4pt4bErkqQF5eKzptXVJuu7wTKjYEKQhE0ieWTp?= =?iso-8859-1?Q?k52cfMPTDzkk0/3aY8e14CeEKGVYcjr9Suh8wN3EwMCqJrwe/MccBW5wtm?= =?iso-8859-1?Q?/56UJbcXZrY+F1mq4/cZfAoGE8VjXOqrg/RG15ODHcAFxuq1VhtDdBG9qN?= =?iso-8859-1?Q?U2+zCikr8wXDNJz9Ss8jdN78KdQgt03epmIulcAWVHy/p8m/H5oTw9MsOn?= =?iso-8859-1?Q?uTUG77ABLV2TmeI8htSCtrR5J1DAQ8qIDKxat6IoYg+K828eyOM3sukr77?= =?iso-8859-1?Q?7aw7+nFVH792DeJGdFNq4S3hC3oMPGsY8p6TDoi7aMIkISx3JcesU4fGZL?= =?iso-8859-1?Q?/JrVqFNbXF4TVn5JbFdnki8xDpeY/kllgLBMVTIFGdq84a6U2jf7vMPq8h?= =?iso-8859-1?Q?5gg2GvrTQlnntzQ68zlc/d2Bii5aQ0Za1h81cjqsU/2fBO0fgqb1NQEXtE?= =?iso-8859-1?Q?s2AYW+HMKZLlDAoij26xpaeTd48Wyw/8FUpujIO8uxkIErxqZQ9+3/iaje?= =?iso-8859-1?Q?IURDi9Sp5J6/+hDRlEhVxGQ2BNiVIkSyd4m82bmGwB3LqKIKgqIPtaDB8Q?= =?iso-8859-1?Q?rVUM0sYpQOMciforxe0BDBqbfziqyR5gP8N1lAVhQd+Sa0+kpD50+QOKkR?= =?iso-8859-1?Q?gEpKR6agsxyShjorcTxY69UIWitMKYpa8ZaM8Boi+by7C9D6ilPSVGoA?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 362d64fa-1f03-4120-ccab-08dbad270785 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2023 09:12:14.6915 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YpGfa36Olq7mCXwmNPLsNO01lT9PIigJOU4K4uT8Teg6EKaUJ+VrscG+9FayyRD7NUUUDCzu9Dd8nifUgneQxasSFxk5gQi1AdOiSXwz0X8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7829 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 04, 2023 at 10:43:49AM +0200, Morten Brørup wrote: > This patch introduces the generic RTE_CACHE_GUARD macro into the EAL, and > replaces vaguely described empty cache lines in the rte_ring structure > with this macro. > > Although the implementation of the rte_ring structure assumes that the > hardware speculatively prefetches 1 cache line, this number can be changed > at build time by modifying RTE_CACHE_GUARD_LINES in rte_config.h. > > The background and the RFC was discussed in this thread: > http://inbox.dpdk.org/dev/98CBD80474FA8B44BF855DF32C47DC35D87B39@smartserver.smartshare.dk/ > > Signed-off-by: Morten Brørup > --- Seems fine to me. Acked-by: Bruce Richardson