From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D8C942595; Thu, 14 Sep 2023 11:53:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 06B0140293; Thu, 14 Sep 2023 11:53:24 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id BBABF40289 for ; Thu, 14 Sep 2023 11:53:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694685202; x=1726221202; h=date:from:to:subject:message-id:references:in-reply-to: mime-version; bh=buNrEP56YqAPSr39yKjZ8onzZ1mHgDKGmKxMee4etSU=; b=BigTCPmaVg0JySfhXI8GziXVMElMpaK7gfcpx58KfQscYBo77mS28MiO 2BPAIVDb8pKF4Cs1SbDMpJR13bOShRKyIArUP3js67/RRplZTwChXQRTZ PUiFYc0LdRaqD7EYhujcuHF0bHXhz7v6q1Zbcj0F92/a1CEvJckZCZZpa 6+S6J9Bst6Nc9u/EbNauysd+S9pOB/kxZzPI6ihwEET8Vb1Lw3WHhQIsM rBTufnX7kCzj92w875tCdRZMX2W2KEUigqwxKK5zwDvySnRwPbEuRoEpA P8yxsYlXBGswnT3rrs3Af/B5jmyjT8HlzD2wzlWzjLP4IOiuMGTpHqsfr g==; X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="369179600" X-IronPort-AV: E=Sophos;i="6.02,145,1688454000"; d="scan'208";a="369179600" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 02:53:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="779565960" X-IronPort-AV: E=Sophos;i="6.02,145,1688454000"; d="scan'208";a="779565960" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Sep 2023 02:53:19 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 14 Sep 2023 02:53:19 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 14 Sep 2023 02:53:18 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Thu, 14 Sep 2023 02:53:18 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Thu, 14 Sep 2023 02:53:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Td1mNeN3/9qo72rqTDMFsCOkmZCa1aw7xC3OowQzSBFJX6p0sCWFLFijnrysjk5U9LCv7gkkV7nSGETksVdJC7zN05yfVIabm+1J/Fsay0v/0wNAMQn93pw45CjlbN0+s9mgiMbwiwtQ4N74uNjdHvH8D+j9t9c/D0srZrDZfmE0X54z5SSnH1w1AJiQnjzdMTAiqPf34G//QfwG64rS2koYMLRHzh13DF9BSzBYtFcPoVvi1zigKUeZqud4wMwD9CyCdM98//LLx7L743kuza8xRVDcsMsuCaLyYc3lu0UWLkjcYc1u8xZP/bL00l3tXjSWhYv+ERsn4QzyTUHuyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OpbL7iHZgo1E6c6maBxy17NV0meO6w0E7BYwJKbDqbc=; b=kKhmDp0+pZT6iWEprk2sAX/1ZPhg80UHUU/2WdWukqxjvcTjQvyTawXX9CMe4hmzyFOjJ5axagjB1lM4pXM9G5XYPupf4L/XwAL20emOrtBHhu6XIL6dPHzpFmEzChkL0n6X2xjax6yyEHkE2bMsn2TNvyspObYS/caSgkqxX4UIFmakAteM0Yo44rlO2yW88eoehmnVHL4Mi5o0pPAP/QoB6CIgU53Hir+KCBbIR5oopvgS8QEm3ASalRarmaxxmMkThzjfine3x8wJSTL0T3bcjQBYsb5p4+9VOmf4t/gRP4D+FaZmRjFX0gMwSvBYb7C7OEna44oHI3i0kB6JSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS7PR11MB5967.namprd11.prod.outlook.com (2603:10b6:8:72::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.36; Thu, 14 Sep 2023 09:53:17 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6768.029; Thu, 14 Sep 2023 09:53:17 +0000 Date: Thu, 14 Sep 2023 10:53:11 +0100 From: Bruce Richardson To: Subject: Re: [PATCH 1/2] build: fail if explicitly requested lib is unbuildable Message-ID: References: <20230901142332.588856-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230901142332.588856-1-bruce.richardson@intel.com> X-ClientProxiedBy: DUZPR01CA0223.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b4::10) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS7PR11MB5967:EE_ X-MS-Office365-Filtering-Correlation-Id: 231c0cb6-8001-4cac-6bdb-08dbb5086b70 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vh61bs38mZGsCQlzy2ZNIVNE91xC0YYDTP8qQ3u3nD/bOI1AcBUeVvq99pvocm9UFI0GewPF1OFJGA7QRH3PVP+uRjxtHs1FAC5xzRlnDZ3oU1fHNJt2G70qJYOeDK3+H5KylaMGtmYNHtqfXLhOGh+fo+z/2YCewtZ4ZJz0j5grNxg7rttN8hvoj4VeVC60m4xwSHFgQrTdNMLuUG+j2C2jn1mRUL3s7goF+ZZqfOE/rJYJK/Xg8L1a5bbd6xdez/LyNCBQuOrdVFhV1LUQUwugeQeYiAyUi2+mxqdcf7xQJA0uhmF8pJyh7EHB1CrqlV4nN5sQsfszAm+RDckon6n+I8kaKSS6+eFoijlP+hKLpsEC07+s5iLnZKcoLvhBRQp+czcI5blM2FRBSedLq+Y8IJcu4R8Nk0FjrfPj5BSCoNre48rKR2Lh4Q12nce4DvaPi+FbsqNm/MzH15FNWcn3ycKRGujx8fIWHwRZONUhhODYXAhqyaygcUTbxCFSPCWF0vAVQwFsBp0O2VwyJ7GLqpLZosxmf/x/XkmfVs33wqZYlgiUpTtkhBFGXFmg X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(39860400002)(396003)(376002)(136003)(346002)(451199024)(186009)(1800799009)(38100700002)(82960400001)(86362001)(44832011)(6486002)(66476007)(478600001)(5660300002)(6506007)(6666004)(8676002)(66556008)(8936002)(66946007)(2906002)(6512007)(83380400001)(6916009)(41300700001)(316002)(26005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tBQGUPecREbKGnIaOHHOuQs+uwYJ11rTkOpJn+8UY3DlIBCil3Z2UiOWspDE?= =?us-ascii?Q?obenY62H5dkl/J4gXcGEoagJ9D3yNEuCUTXDGTeRD3sMiianVdtDSlWsoEaK?= =?us-ascii?Q?gJiQUs4cQDjASRv6GhG24Bom4driWXgqzfj0BWEwv13PVy5NcRoP5FhncWF/?= =?us-ascii?Q?bDK7NHfydlHEYkzWQ+CsZlYlhtNXioIpEQyOI5xAieDNuCYI2KXk/FsYmOAA?= =?us-ascii?Q?mqody3l12dPZIRjxg0o8dpjwnRPsxNTi8yJuHkDR9pOtfSWHa/YjxOIfxybi?= =?us-ascii?Q?44Qb1dv+8QL9NgkknrvWh/rRUR3nI7sgU0xDSj6B5RQ9vWzf+G1G9NsD4NlJ?= =?us-ascii?Q?KOF3vunpyXfFYtt5PBWzAs0YtKpu0/RzAyPE2ILZzcypKPr1oBLem6RbMGm/?= =?us-ascii?Q?X83SeX3O6a2QrLpC9cWHxAPwPhZ7nMEhhPBXCxxM3+mDJf8vndTfYPd4dcdM?= =?us-ascii?Q?vGpqUn9SJJFaPrp7MaDimpA8unilO61kGmopKwmgvqoi+OzUnn5EswnvBEoe?= =?us-ascii?Q?u5ylzrUcRY4Ec/YbiAi5iZksE38bCv4Xs9ZUb69ow7KT72MiKWfh92s7mjTM?= =?us-ascii?Q?paupewIwAMAtl+qL5sZmZHloMPM1A3Z4wazggTItWCn3dAJ+LYQxdtYxBO2w?= =?us-ascii?Q?9WJMEB+4U0ArzFXoqA/4HIjcTCEhEN3j22uj6MG8amCGemN6CdPXjdNBvyH7?= =?us-ascii?Q?AYQPYVWdACx5W0DpigGKxqflOxl6mTkOm8/RVr+atKP1bHGQHWnlCyWckPqo?= =?us-ascii?Q?UETQprMluSz/+gsci4PgZxhdui+KPDNefctvVZG+eTHGu3SfexakBGczIkcd?= =?us-ascii?Q?lGclMYPJ6vt5PpUrSar76zSbU5C5heqp3wqKdnByr6vAB7qd5ljKSVKjMG3/?= =?us-ascii?Q?bBMjmbbU+9PQKgwEuXcW5HRAgu+P2ilXDuKp2sfuC5uLOdqb5MkjTenX+4HW?= =?us-ascii?Q?7hDOIQZ8eZ6wskr80ByX0zvczeJvjLx0iYDNvQLko4mHpQHMZ/U8V8El2BkJ?= =?us-ascii?Q?xu2ThH0JWdlK2/swzJa10N3NVG2HnwTZb5PRcxLdUxXAappqntWPUxKF4DTR?= =?us-ascii?Q?iqCxcT2CporRKFkBsMiE6tBS8Guf40mYeoge18brvUCfQfeMwu+DoMooXSNw?= =?us-ascii?Q?ikNW8d7cCJ7suGB07ADeBHOvUiBheZLkUu2vay9RPz1iyRc4isrI+y3sKaru?= =?us-ascii?Q?vjXZ8JLmDFOCrF3syDXdpm54SInVU8myY1xWDJjq5e4UlDKmGRmOrVaoGND2?= =?us-ascii?Q?Efd7dcZkfiuAAgWxZcoRiC4G+5edljGQqWFch0TvQNhDWmrshpoOieCf4YrP?= =?us-ascii?Q?hjN8itjwJlSYGKfZwT4smL4R3mC6A93d78/qAOVxh/FUnFHZ9cdS/WcLWPKY?= =?us-ascii?Q?zEBvF5sCH39M9jxh1zWNVa0YmR0rj+Q9o+MPKEY79tXrCmFgtHYKN3Wss2Yd?= =?us-ascii?Q?STk8cH1uNxilIu4wkYWcFwSucVb/fHdJNpqTBVxTBUAeyF4dwJ1aS1TmpJh2?= =?us-ascii?Q?2bsn3ZLllkhHT+m0diALBioDbzN4GanYKLw5UNBTxjQ4X25KgDiZ7NCF/VYi?= =?us-ascii?Q?vrXKABmRd90k4OwszymglH699gJ/Wj+ijLfqczsK9Vl2Qi53dPuIDNZehT8+?= =?us-ascii?Q?YA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 231c0cb6-8001-4cac-6bdb-08dbb5086b70 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 09:53:17.1092 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ku024CvDKmuxSJqNIwN27Ef+W186+Giarz/PDRdDkbs1EfSwpwj+C0aGjLuutRRfWRO4axJVuYfET4N+yhbpzK6LVSYAwWAmzUFxLS1dtLo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB5967 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Recheck-request: iol-unit-arm64-testing, iol-intel-Performance On Fri, Sep 01, 2023 at 03:23:31PM +0100, Bruce Richardson wrote: > When the user passes a list of desired libraries to build via the > "enable_libs" option, the expectation is that those libraries should be > part of the build. However, if those libs have either external or > internal dependencies, they still may be silently disabled, for example: > running "meson setup -Denable_libs=security build" will successfully > run, but the security lib will not be configured as "cryptodev" is > missing. > > We can fix this by setting a flag to indicate when the libraries are > specified via an enable_libs flag. If so, then we error out when a > library is unbuildable, giving a suitable error message. For the above > example case, the "meson setup" run fails with: > > Message: Disabling security [lib/security]: missing internal dependency "cryptodev" > > lib/meson.build:218:16: ERROR: Problem encountered: Cannot build explicitly requested lib "security". > Please add missing dependency "cryptodev" to "enable_libs" option > > Signed-off-by: Bruce Richardson > --- > lib/meson.build | 10 ++++++++++ > 1 file changed, 10 insertions(+) >