From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39F42425A3; Fri, 15 Sep 2023 10:21:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 06454402D7; Fri, 15 Sep 2023 10:21:46 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 037D740648 for ; Fri, 15 Sep 2023 10:21:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694766104; x=1726302104; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=h9hnBMy8XN4AQP9C9XcWGDllZrP2ossZIxuvf7ybybA=; b=fmAtHj+DfFUNFVZvj7mYfrUuk3o5+eVX0eoVhZZVSY5wDEbpO2ft0nXf FRDaLyjZPaQ3TryNJf99YRYN2LlQ/gKANh9X/r46CvuPz+V2f7+cKKtmb 1Z0/OLaYYgCrYjz0/XnEjO/FIUDaKoKittcDkzDXxSklnAJ3bcsHCutfX xTnT62QpmPn36/BzoikEOwRtoCU501+miZ+1ywJbBi03keRYU4sPPuoSO RoHNjXPCqwpDg2LvvNoUzhXbSx9cK5fhBdLtAhYP+ifvnI2PjR/f//r+8 63pXVetQmcHV9QBQaLIWsqVlg+ZmSSxT82e/sDBMeik2KjVino1fTPoCr Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="379111703" X-IronPort-AV: E=Sophos;i="6.02,148,1688454000"; d="scan'208";a="379111703" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2023 01:21:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="1075720188" X-IronPort-AV: E=Sophos;i="6.02,148,1688454000"; d="scan'208";a="1075720188" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Sep 2023 01:21:42 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 15 Sep 2023 01:21:42 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Fri, 15 Sep 2023 01:21:42 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.42) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Fri, 15 Sep 2023 01:21:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KsD+JaYPYDdIHWUa3uzNlooKYpbQH6V9gtXc2fyDXJnk4TCJUFRU7UFUMocUTkYD7B9uvHXR1u4dcuJzlTrJ7mWERPNJhqZcRDMVzBN3eSJ3qTCAcT1yot0vBbX7Oj3gML69D+NiuiPvpc8kjDL3fsJZALYEZ5S7xXi7V/73oWy8XCcWG3QtC0yYsRfOWaouENSf0+Ed8iDEicP65gULDddP6zNax/JpG67FpZYC+r1sp798B5RpJ6NIgFzCC+caLZOSqbaKbfi0+m5L6rudnUpjSSTweY2fLguoZiPXgVps+bcZc7Roye5gn7q1A1zWmtsON6PCCW1v5AhQSspRKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cmpjU9jTBzpsa15zrx3v9uKw12Q2vlRaiXn8xza19bY=; b=haGtBerMZ9u9CEzQ3uCMAGw2exiFUL2GduqzCluC6ydHuD26Tee+W3KKwOR0wt9te2t+HxoZz+EtJuGosETikGVu7iWEdZMnQjN/umlsRoHAFqPjDLbiMFBDuy4SPVEjiiRVvW/cGQgqxpEpRuYhQICOF3LknQz0GFWUVLGYQV4oo6ZNovm2sYzcN1n+Iy4UFpYhL20J2xs97OrXu6/IUhxm3HeJMxEbXeQS9BnC5/tHw3uflY82nTVkJuuwFDx3qOP6Jx9etx1hJjm4V0outwgFzK6AQStPjKU6D/4H29A8C0Ot690KtIaFQa/ZDKH64hWa4hv0aJvrJ0dIC3uniQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB8597.namprd11.prod.outlook.com (2603:10b6:510:304::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.20; Fri, 15 Sep 2023 08:21:39 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6768.029; Fri, 15 Sep 2023 08:21:39 +0000 Date: Fri, 15 Sep 2023 09:21:31 +0100 From: Bruce Richardson To: David Marchand CC: , Cristian Dumitrescu , Olivier Matz , Fan Zhang , Ashish Gupta , Akhil Goyal , Abhinandan Gujjar , Naga Harish K S V , Erik Gabriel Carrillo , Jerin Jacob , "Anatoly Burakov" , Kiran Kumar K , Nithin Dabilpuram , Zhirun Yan , Konstantin Ananyev , Vladimir Medvedkin , Reshma Pattan , Chas Williams , "Min Hu (Connor)" , Stephen Hemminger , "Anoob Joseph" , Volodymyr Fialko , "David Hunt" , Sachin Saxena , "Hemant Agrawal" , Honnappa Nagarahalli Subject: Re: Unit tests not defined in any test suite Message-ID: References: Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0160.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bd::20) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB8597:EE_ X-MS-Office365-Filtering-Correlation-Id: 87d30559-cd7e-4619-8938-08dbb5c4c8ff X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FE16IN0n1HNGEqUlNK1FsglErh/Auk/J28kf9hOJ0bOG9TWfHpqa3cbnHjVNMiwnPwH/ZAM2qBnNO7Pphw6cxZcxJjmFM50BtKHEXakSA+OQlyOpH/ahMBJlMdJxwizhZF1m7+saYtnGZ/BSTx6yAtZLLVGjhVWK4wUHmy1K2ZrfxsDLm2UkAXfG5nYgVRaRPj37ggVLtkRmHZOwTJX3oUJ7BCPzpbsW9rMW3hCMoWcGbumMgPqA15gTMYpZpL3/Jmujst55d20izfIjXm3snQpyeMz2L5JKDtTPefqot9ENtPIiAwwM2+AEAmzG8BjohwdQcb/9oOH2ol5UIxJOkS9WKzrgm1HHopkvWxcmPKW4dZLrxBQA9lDjMubAQesAAUfKAaDGra3PI9HsD3/uRbgtr/4AuXeOUPd36SfONGJ4fgyq9AxNj02XVSQgUc3b2SPRPJC4Oz2alpLtXALaalBh6ISZ0X2rKUCBS6lMcyhkFAqWcLhiM0PvUuSFPEVpmxD43ijK/mkHHlksAeghxCGZa4L8SIUEbs9FmuA8DaSiMIa0Omc2fD0ZycU0IJjr X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(376002)(396003)(346002)(366004)(136003)(451199024)(1800799009)(186009)(26005)(478600001)(6666004)(6512007)(6506007)(6486002)(53546011)(7416002)(2906002)(82960400001)(86362001)(54906003)(5660300002)(4326008)(8936002)(8676002)(41300700001)(66476007)(66556008)(66946007)(316002)(6916009)(44832011)(83380400001)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?byt0RjE4WjBEM29lanRlQ1RJZXAzdmhDOUd5bjlSN2tSbThSOXEwM0c2Vm9W?= =?utf-8?B?QmtIR1VGNzhTbmp4WmYrcXJLZmdzOVBEN29CWkIyQ3Jrc3BQYXg5ZXdLM1NG?= =?utf-8?B?dkdFd0gzYzFBUHMycGV5TUxNcEhOZlhYa0ZKdnNOdTRxNWkyNXNWMStTNUdB?= =?utf-8?B?am5JY0pvbDdVeXVjU2VBWVBTSVMvVWhZd0FQMG01ZEVFTTBCc3hLV25tS2V0?= =?utf-8?B?eUFvWm9NWUlwY1NzYmVrMUUxQkhjWkM3SENocXp0WkNMUXc2RGc4R3lsUEVD?= =?utf-8?B?dHUyLzNlcndMUWlRT3lPeStVeUlqdTVhbW1XK21XeCtId20vS1JuTEJFMlpa?= =?utf-8?B?VENlM0RNK0d0SU9JMDNlS1gzc2h0ZzBjU2dSbUgyNUd5NW1GRGw2MlZrTm0z?= =?utf-8?B?QVR0WGtPa3NTVHRrZTFVS1U1ZTM1M3dWSXZiOVlrS2pCTlpuRjk5dmdYUHp6?= =?utf-8?B?em9VN2liWDc3VDZQYlJDc0NLdExmWDFkZ3RBcE9QZnY1eENOQnQ2Ukg1b2Rl?= =?utf-8?B?bVBlYWZBR0Njd2I4QlRObXBPMVA3RmVpcm5LaWFyTDhOeG5sTmsvbEg5S0J1?= =?utf-8?B?dE1wWFZPS2wwcENBYjNvNWRTUGlycnE4OXhLdmgwdG1FSjRPYlVzdFdsajJL?= =?utf-8?B?N2k2RWRudFlRY21GL2dBbXduQ2NKNnN6ZzZnR2oxWFBHZ255NC9VREEyQXc0?= =?utf-8?B?VkNGcXVEUmxiMFF5YkMyVXA5VnRhUTVQcE5QYnZLUTZ3QVFPTmUrZEo2SzMy?= =?utf-8?B?SW9Wam0yaGhPZW95TWthTGNNN0R5Z28ycWEzWDZYWDUyc0pXMkxYOFFIU0E0?= =?utf-8?B?WGVzVG5KRjVzbWxFSGg5NFZIbzlLVXAxV3ZnMEU5T1Vrbmh3M21oWkxNVXNB?= =?utf-8?B?N3ZDQmxOeC9pYjdRUnlUTnNUNTU3NUpsNU00Q0xZWmNZTkl3ZVBWY2lkWmYw?= =?utf-8?B?ZXgyRFM3ZnYzUUJCZHB2ZFppT21TZ3VjUWlSQ3VDSkVqUndNblZxcUxlV1VY?= =?utf-8?B?TmlhVHdNTnRsb3NsNDhrZE5UOXlPMEt2VnJyaDV5TndMQ2RBL3ozcnZTaVJk?= =?utf-8?B?bEFnRmlidkw0UmhrUks0TU0rWVJpQ1NCU3E4d1lvdmViQndOUEovR1o1UG84?= =?utf-8?B?cjJGSll4bmN4N040bkVSVEdOUmJEWnEzYnh0RitzQVp2aTNQOVdSTExhUHEw?= =?utf-8?B?dmRxL2lOUmo2djNlRUd4Y2x1WExubmdxTGQ3MmJWRm1wV2hYWUxaczlpc1ZF?= =?utf-8?B?RHBzVFk0b2o3amw3aEhUVEIyUXd4V3UzU1k3d0pWYWNpZENOS2thVlVLZHpr?= =?utf-8?B?amhKZmRpSzVtSTdsZG5nYkhNMEhSNnEwbDZHOE9qRHFPcnNybE5rMTNkakpj?= =?utf-8?B?eDcxOWppZ21HakxHZnVGeXRzTGFOeTJvVTFQU0VaYWJpNldaU0luUHFCalVK?= =?utf-8?B?R1k5c2ZYcXA4bklwU29oKzlIZ2pHOTN3UkFBNm5QRi9PZkRtUnZjb0Y3MUxZ?= =?utf-8?B?bXZOdVBFdktLSTcwbjNucVFGTDNZd2kyVEVvR2pnR1VCcTdMRExGT0JtY1Vw?= =?utf-8?B?TFZLMUs4bnlralYxbXI4eHQ1a2R6dDBBYUJtaFhhaXNYK21KdGVwQTNhdlV0?= =?utf-8?B?ZFBmcGx2TTNaRCtRSmJod05ud3g4TExDMmJkSjIxQUhCeEo1djVvV01Ea2xT?= =?utf-8?B?VUdqa1dOdm1jdEhWc2hkYm1zbFZvUkFuQXlISlBhUCtSZlYydHhsdXJVTEpr?= =?utf-8?B?Tk9QYzRDN2Qyc21tbm13b0VuR2U1cWN5MFZrSllpZUQ1UWdyelFFOHRXWHov?= =?utf-8?B?TVFZTjg4ZEFLeXppKzNRVkRqSUhBb3BMd1I1SkpweElSYkhHZ2RvQndWYm8w?= =?utf-8?B?dFplTjVzUDdBUFBtdFhZYVN1NXhDc1p2NU9URTZkdlB1QTBPS3Q1M3NPT2ZT?= =?utf-8?B?QkpsZkpJWHRXbDlMbGo0WG41WW9wM2lhck1jMk1IU1BJamlqc2sxMXByOE1v?= =?utf-8?B?bGIrT09MOXMwUEFyT1FqY0VZZjQ2ekoxTlF3bU5xWXE3bWhuczdXK1ZEeEp3?= =?utf-8?B?Nlp4R1NvTVozQ09yTlp6cVpvRERHZ0FNRmZJQ1FYUW1pWko2RUNVSjU4ZGc3?= =?utf-8?B?eWFUODdINmIwci9Ub2V6WXRUMThQN3Q5LzFTdXUyWHhrVG9mcmNJd2hCV3ZJ?= =?utf-8?B?dXc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 87d30559-cd7e-4619-8938-08dbb5c4c8ff X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 08:21:39.5797 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p9Oi3fKMQEiuLBCwDRXMc6pAOwrA3XWX5VTSJLCQnsekQeXB0eEcMypcO/S0crMYPEpIftm+nQtbFROGf2RM3GoVgxAHBQGsX6g/wBX8tc8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8597 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 15, 2023 at 09:55:49AM +0200, David Marchand wrote: > Hello Bruce, > > On Thu, Sep 14, 2023 at 6:16 PM Bruce Richardson > wrote: > > > > Hi all, > > > > As part of the recent rework of the build of our unit test binary > > (dpdk-test), the individual autotests were updated in the source code to > > specify the test suite they belong to. The replacement of the > > registration macro was done automatically using the existing suite lists > > in the meson.build file, but following the replacement, it appears that > > there are quite a number of test cases which are not in any test suite - > > and as such as not being run automatically for patches in the IOL test > > lab. > > > > Below is a list of these test cases, and the files each is defined in. > > We should endeavour to ensure each test case is in a suite. Currently we > > have 3 suites - fast-test, perf-test, and driver-test, but more suites > > can be added as necessary. > > > > I've attempted to automatically identify the maintainers of the various > > tests using "get-maintainers" script - hence the list of those on CC. If > > possible, can each of you identify what test cases you may be maintainer > > for, and add them to a test suite, to help improve our test coverage. > > [Apologies for any mis-identifications] > > > > Thanks, > > /Bruce > > > > alarm_autotest (test_alarm.c) > > bitratestats_autotest (test_bitratestats.c) > > Those two tests above (and the one on the graph library) made me raise > an eyebrow as I remembered them being part of the fast-tests list. > I thought I had checked the tests lists before/after rework..., but > looking again I did not do this properly (the blame is on the > reviewers and commiters). > Blame also falls on my as patch author, my apologies. I missed the fact that the test lists given at the top of the old meson.build file were incomplete, and were added to by additional tests later down the file in the if/else blocks. [This is, after all, the main reason I did the rework, to make this more comprehensible, so I suppose my mistake helped prove the need :-) ] Apologies to those on the CC list for whom I have accidentally removed your test from the list. I'll work with David to get things fixed back the way they were, and then we can do a new audit list of tests. /Bruce