From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8256C42609; Tue, 19 Sep 2023 17:57:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E9834027F; Tue, 19 Sep 2023 17:57:24 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 28F6C40277 for ; Tue, 19 Sep 2023 17:57:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695139043; x=1726675043; h=date:from:to:subject:message-id:references:in-reply-to: mime-version; bh=LRI10id4P9psIiDrTn5uoFi911lVqlv6bwawnaqUvxE=; b=elG2zOhSEQpDhik8tmvca823lTLjxBnIx/BFb0D2JclXLQoJObcGzeGU Z6SggHXCqvsNhM23jUXWPAjZehktIFJOGpeROs6pzrkYjIFQMUqQmu5T+ OfEPJGOdw3JOQl4c6AB4GB+3YaupuPrUC4udbdKLsVlMZqVk4GaYZz7Q7 lyF3QlhIqZ7z/kdj7aMPlTJ6ZVXGiwij60BMag/mnJY6hp8jAPWB7oaNo OnwvFoYgQNIn1cTv5CEl6zGdTgPLcuenG05Fm1nHvbXuMklRh4gDRvhtM HLR/RsDydAjnt9JvTMJ7kRTDO92PDm8kCgRS8B/Uk2tUS8X454G6rrFoj Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="378872651" X-IronPort-AV: E=Sophos;i="6.02,160,1688454000"; d="scan'208";a="378872651" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 08:57:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="870012536" X-IronPort-AV: E=Sophos;i="6.02,160,1688454000"; d="scan'208";a="870012536" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Sep 2023 08:57:21 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 19 Sep 2023 08:57:21 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 19 Sep 2023 08:57:20 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 19 Sep 2023 08:57:20 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 19 Sep 2023 08:57:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DZiivDOMqJ1IfeqKvob5SqrbW/cHV8sUHF86LAM0UIsZTi8EAXkzrG0/FYFcWG7yAZ63gWiWp0/97TCg6pmjpRvxuK7gMFhaBX7MVkJLhVyhBahoZ/uJDft9kkkt8UjHaOulpwS61FZ9XW1lzbfZ3h2vyOBkys/IDk8rfM4dR+uO5ntVXTEs0sH2cMF56SDui6Cjg5fxRlCw/282EP3efK/iZiJj8zNFvmnJizerMZt8JSFhLBQaopdq3gNSfH1CEYRitUnYsF+KCfWVJcHQIRTLRou63uUNWK0BG05iIX2x/PNr6dPKQk1Fv2j2SzCwaq5XSp3AYWXnbs8eDR6nRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EHqTRDQVVcZfYshuhrWtLFPKGXFSMFj464owBpRvya0=; b=LDLaUuTYv2yGVuyrXnLpqzRTyWiVWi26OpUfNPbYSydP1PNObwI0Yf5lRtMqmk5Q5UesJyW9xUnaWxIK1s4B14laKpAx3xMzufM13UfmmsIp4VT28Mb2U+q9lkCCMXuAHcbcmjz8bjVKlfuvqzW/JjYElLJOkeYsNqKq29nUOe9/xCwTMV71DK7J0OHSAAUPF71K5429dy/B2cq9khPxIAsi9jcB7iDdJhLgSfjcaH6M5iLjrHJlPwVypEkAfA0Fp1qOT560YCV6YPo1DWZuoeV5g//1y9ygUuHJoLX0cWtxgQWN1JRY+flVeIB/2Uv7yr2MjLOP7NSwn3Ad+buLrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ0PR11MB4784.namprd11.prod.outlook.com (2603:10b6:a03:2da::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.28; Tue, 19 Sep 2023 15:57:13 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6768.029; Tue, 19 Sep 2023 15:57:13 +0000 Date: Tue, 19 Sep 2023 16:57:08 +0100 From: Bruce Richardson To: Subject: Re: [PATCH 1/2] build: fail if explicitly requested lib is unbuildable Message-ID: References: <20230901142332.588856-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230901142332.588856-1-bruce.richardson@intel.com> X-ClientProxiedBy: DUZPR01CA0074.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c2::20) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ0PR11MB4784:EE_ X-MS-Office365-Filtering-Correlation-Id: 0934e2bd-e3d7-47de-2044-08dbb92916f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n+nnBByFBaeLQEfOEYstnH7DSmczzedrq0Lz2VavtDeDkdpH2NZ0QfDicPsqbAhKW5LO0OlbaVkaWmApEGfogZULJ5mUT2r08xNf1X7PDfjXG1Nz0WrhoZvcBCfMFaCfQlbrAlPzqjLdoyBZC3JC9LN9jJy3afXaBm6XXl69ypwv1YjgD3tosdr2gtPYt0rq7SBT4bR1VZX9FczcPpjWm99Rq6n3RWxn7j9ankLnX0g5OEECRLT3LFwLsjnXaVkONYTtkP3ILvEEiBMqPcJ255YfDedPKe5OT4UJUr3aM1mMQ42bAyWHRLJsA0uREHU1VLXJJ/4WOCG30PRBz6nwPk+/sWLalFo5IcGliCuQIn17oxpBkwUkdmmuLTb2Yl//xTU2unlRyzhw7o1hrRw66e++6XEoS4w1ynYK1czomYbIUv+ikdcdRLo3d6FNthHeTgM3HJNNSty4C9UV1WRThABxqy2wyTtI7z8C67ww6dnEHLzrpuOSriHeyiO1VdQh6zl4GuGI4apJlWNpTazO5kyCUsmwoU7BMBoZkzlqFbNT1bpWwVbnvIunsE23WJWD1cC6yzM+VjwqkIyH8yq82dAGYsyep9N8AfRs0BK1BB0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(366004)(396003)(39860400002)(136003)(376002)(451199024)(186009)(1800799009)(5660300002)(6916009)(41300700001)(6486002)(6506007)(6666004)(6512007)(316002)(44832011)(2906002)(8676002)(8936002)(66556008)(66476007)(66946007)(478600001)(86362001)(83380400001)(26005)(82960400001)(38100700002)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?I+9harr7iQy7YqRv7bfSKMFTv1UiJVMKwemVYhvKMcNycOnL7jOV5+E3eaWS?= =?us-ascii?Q?hJ9zLjYKdaElTl50bUaSMR18W0Yd6T4B8f+dgze0E5HzUS+iWrUYAx5h+lS4?= =?us-ascii?Q?my1fcal8res/TPUYlQbE4/wAUmP+p7QA6zDExhx3G+VgI0eBiZ09Blb2d189?= =?us-ascii?Q?KKf/K82513uTYMhTbj+GRnPaxVP/ZeELq4OoDfdnsy1aA+/eyZ+HTtmQgIHZ?= =?us-ascii?Q?QifWwlLzjkuVtPlS900ZO97Valo1k0fGpV/u/RtGHOyw68BHe/77O7wRIy7A?= =?us-ascii?Q?YfCoK0iXbqsFuFKF2+qivQQabAG2zAb/ZAQU8ZEIZXeNQomvGAoGW8KbPVaP?= =?us-ascii?Q?mXC1+Nb2Fh4xbRIeE7ul24SKQY7iPCVV1bnVCFMr0AlxWp1RmbkcHhE+beCh?= =?us-ascii?Q?6MBz/XsGRjtkihZZ34HWfdAjEhuFD7Z6rZNyCbl9UIv7GrXTqMzWJfzY9SRL?= =?us-ascii?Q?bSgiiQp91M5ml2/7AKJ/pw5B0YUakSPzUkH+wcSo2XGLsjSzC8Gi5Fur3wk4?= =?us-ascii?Q?8WoI6fCmN0O5mMQ9f29Gi5YCmfMxYYa2cdt8POmaW/2l/Oo1YE0M3a353yAV?= =?us-ascii?Q?9kHgiOFKtBhekX+w5PffdZHdyiHZVncxzZB3h5btsjWd0Py6K4TCG/g2VO7E?= =?us-ascii?Q?95qqFLReOVUz/RYPxplMwRtfRo22ChuHdqoNZrwb1+KO2pbserqxn1AV+TzK?= =?us-ascii?Q?rORBZ40CiGbDnwyA2K724nLD801b1/lLQRfyrawEklv9BVpPh2XWU5CavaAm?= =?us-ascii?Q?QxsEcGP98zuLYo9tQU7Ww+HM2kOkrwSPlT7I+HSFoltGw6tCDkcp2v4pWsf7?= =?us-ascii?Q?xIhXV7kgWHR3PoMR5j1Mu06hOMEmcYDVk7DKLEf88IIzyo0XLEjeXTHa8rJI?= =?us-ascii?Q?WOtYEMfxo0MHmF4TfBfArNakBrQ1WtW8c0KCkq81R6tBWMmT2/yU9FzXL41q?= =?us-ascii?Q?iS6gspZfOOFUPdr+qDCZHowuxJCVKngJBk4fAHfWjBca9PZjbTwGJG12hIm0?= =?us-ascii?Q?P3UuKZisypud3OLbwqH03O6Pe94cLdGmT2hqVqaFpBwzi1sYzOX6TvUVGv2c?= =?us-ascii?Q?ju6pqrGzdTrSU5TF28rlVeLRrpvoANVKCghECD63G4VLyJwo6ZvlqODg5nSW?= =?us-ascii?Q?3ULK3LYm0F438OZugWzG8oWJEEbMRiuEAkk0i14a5js6xgDWuM/376HAvWFD?= =?us-ascii?Q?admLwzufYghUFUnSzL0pklsL8up0jn9eFHjdQnhOmnCpVmQBp6YlC9QHTaGM?= =?us-ascii?Q?TugRrvcyg/j+zZ2cUP5zbzOF21jjCeekk7xpgAJd7f4MGpMrW1WMNdT1sqWh?= =?us-ascii?Q?N9vggJt7nTHWOCt3R9hYKPxzdkFqIDHSwt9YB1q//BlfFVYKHaYLeD4gwpck?= =?us-ascii?Q?BcaPkkUka4Gm1CUGWWo1lJTxebVuzvePNo23ERLjYIgCbPjvHnuAIOXKmnTs?= =?us-ascii?Q?V2Q6Ba8zcnIXwVijq0uJbD9he1wdjveGlviVqMgtyW6Dc+MfmNgtijX05n+s?= =?us-ascii?Q?Nibix6vo29Po0e3+RXAqf3mQRspCFTTNGlh/jFf4++A+lCMjMyG2TtU0hlF+?= =?us-ascii?Q?ElAhvZS02TLEVV+pAiPY4LDXXBzGcILKp9IiAlK0wyy2vvcVdy6grYSN0lkG?= =?us-ascii?Q?Ig=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0934e2bd-e3d7-47de-2044-08dbb92916f2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2023 15:57:13.4414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7oy4wtBCfrns/uZFE0A30tvLhsYVp2OxTv9gje3vUwPpTdxlLBtLo6CQdDd6DLItqkQ8kkgBopbNvkOW7KqSFXYw90oYU82VBC/5gH6C7Oo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4784 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Recheck-request: iol-unit-arm64-testing, iol-intel-Performance I'm informed now that there were infra issues which should now have been fixed, so requesting a second re-check. /Bruce On Fri, Sep 01, 2023 at 03:23:31PM +0100, Bruce Richardson wrote: > When the user passes a list of desired libraries to build via the > "enable_libs" option, the expectation is that those libraries should be > part of the build. However, if those libs have either external or > internal dependencies, they still may be silently disabled, for example: > running "meson setup -Denable_libs=security build" will successfully > run, but the security lib will not be configured as "cryptodev" is > missing. > > We can fix this by setting a flag to indicate when the libraries are > specified via an enable_libs flag. If so, then we error out when a > library is unbuildable, giving a suitable error message. For the above > example case, the "meson setup" run fails with: > > Message: Disabling security [lib/security]: missing internal dependency "cryptodev" > > lib/meson.build:218:16: ERROR: Problem encountered: Cannot build explicitly requested lib "security". > Please add missing dependency "cryptodev" to "enable_libs" option > > Signed-off-by: Bruce Richardson > --- > lib/meson.build | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/lib/meson.build b/lib/meson.build > index 099b0ed18a..cf4aa63630 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -131,7 +131,9 @@ endforeach > disable_libs = run_command(list_dir_globs, get_option('disable_libs'), check: true).stdout().split() > > enable_libs = run_command(list_dir_globs, get_option('enable_libs'), check: true).stdout().split() > +require_libs = true > if enable_libs.length() == 0 > + require_libs = false > enable_libs += optional_libs > endif > enable_libs += always_enable > @@ -189,6 +191,10 @@ foreach l:libraries > > if build > subdir(l) > + if not build and require_libs > + error('Cannot build explicitly requested lib "@0@".\n'.format(name) > + +'\tReason: ' + reason) > + endif > endif > if name != l > warning('Library name, "@0@", and directory name, "@1@", do not match'.format(name, l)) > @@ -208,6 +214,10 @@ foreach l:libraries > endif > message('Disabling @1@ [@2@]: missing internal dependency "@0@"' > .format(d, name, 'lib/' + l)) > + if require_libs > + error('Cannot build explicitly requested lib "@0@".\n'.format(name) > + + '\tPlease add missing dependency "@0@" to "enable_libs" option'.format(d)) > + endif > else > shared_deps += [get_variable('shared_rte_' + d)] > static_deps += [get_variable('static_rte_' + d)] > -- > 2.39.2 >