From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EF13425E9; Wed, 20 Sep 2023 10:15:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1051F40A6D; Wed, 20 Sep 2023 10:15:04 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 29DAD4027B for ; Wed, 20 Sep 2023 10:15:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695197702; x=1726733702; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Q4tC4nM2kVE6ldgHM3Vgm+YFRpNjs/ict9knkPmbC4k=; b=kb/VKRDKOh/I0V7+mAHe3TO/fcoR+QawOLoIN+wl4OoUDSgyeIHpfmsi Zn7G0rbbfN1oP4eVqIptnzZlKj+xtC2J7PXHekkfEJ4FrDnSw6hhPNegx dtzIpE6l1TpL7TMqZQ3rMxiKrik8aMfziCdk84v1EhZeHX4S0uHbRAMV/ C6ku/zm4kK9b4TYUNAJio5DKglDUnTXGVKuS4DiMDnMH/j9Em9ftQ4V4j z2m0F6+NU3P24QIod/0ptWlag9tzxqC3r5AqgMfqDotobVVKlWSCe9mho Zq/qO9uX+m2rGBwxMgkZdbwRpon819mWjjMeerSNakBhKNCaseG/f6tTj A==; X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="384005229" X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="scan'208";a="384005229" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2023 01:15:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="1077333638" X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="scan'208";a="1077333638" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Sep 2023 01:15:01 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 20 Sep 2023 01:15:00 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 20 Sep 2023 01:15:00 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 20 Sep 2023 01:14:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YPmK16neS9ViU2ZbriIZrZQ1NmowN1a7gce50mM4zY3M7FEUZsybXVttAzpRstnIJGiAMt1XdxzF7/4Yj2Nafms2kCzM6o42NXfyQL3YgVGUcUvJ2lYxQf8XpFhLmDLcUX6nAxIVH8IlM8of9kDiTDrqJQ9BvHK23ZK9N8PgC86zWSQ5XIBYkr+JxOhzDUkjGhs03kNlFOh/hm2UkBskTjgsGg7tjLkyY59eonviCUch92DuWr9PmK/aUXkBD2SVgsJfpwybOFddzXwI4uuUJwziTDQ2swa5GiuKOhI/GtzpZ5KVYfszDeEAg5jTSfWWgH/MR+B/0uSwTJzEblPZ7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QVp7mHYp/9Bv/kWvF1M/MAHCsiH53/UfMkY3wEGdkPI=; b=EES64LK/o50jex21I1ppBYRrfKG0jhLtBG41L83+ccjl5pnz1BdwFh0MHVcRR0U1N41hNb+/1J+7OXa3841Lz2qmuMaa2IWth2n0sAOZKn/snc+ZD/AgmvjE8sqx8KFgp4akvewn4tLBrI8ssS9ZD6Ib5yHENnqAmijHn4wm4L7tGdd98VIzFz/3HdioBT2NZmKZAD2YieWcsvC8RlgoJrbwsyS3aO7dp+5tQBu+oGWKVVaKICwzeGWUXG5eq8Um4LJfGgwEcA33bc2Au2kmR2yT+a2dJn2ZWljkhIghudvKLmtbgPcFIbe85J02U6C81iw8rTsakIxvZIbdITZO3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BN0PR11MB5711.namprd11.prod.outlook.com (2603:10b6:408:167::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.20; Wed, 20 Sep 2023 08:14:58 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6768.029; Wed, 20 Sep 2023 08:14:58 +0000 Date: Wed, 20 Sep 2023 09:14:51 +0100 From: Bruce Richardson To: Jerin Jacob CC: , Rakesh Kudurumalla , Subject: Re: [PATCH v4 02/14] app/graph: add telnet connectivity framework Message-ID: References: <20230908104907.4060511-1-skori@marvell.com> <20230919160455.1678716-1-skori@marvell.com> <20230919160455.1678716-2-skori@marvell.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0079.eurprd01.prod.exchangelabs.com (2603:10a6:10:46a::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BN0PR11MB5711:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a8ff40d-a7d5-4f6f-84a7-08dbb9b1ad7f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q/dXBHwDvLZ1wKpPepJOGadgd3X3djdMB7f9xP7E2iD8y7Pmf3Q+bt2o4x5GAJOInMy3PSyTjB0SrwusOp82UDi4pAc3GJsjTsOfExsorO8jY5oWw+3rM22TVYV6DNCEKAPzodrRvl72zjk7dLqCNXRi1TCc20qwQqW4RL8Prbe+7wJucFSNv5iGB9d1OYkoPr1AfHcz5sywIm3Vlg+6awyb0v6a4kItaf07wXKgjBcbzt8cSwDNnnIMwa9x7pfI9tKoEtlGIR2LQb4j5KsStHABsO94uLOQiTS2zoitAGH+Knffw9lO3juzVIV4af73SnSetojWjIA+fOcZW7/Yfld8N78vOKj0vsqCB5+fNvKq92OinyOO1WQAuqthVeVdoC/pQT8l5AYinI49qo2mVdjEsweylT+j8dzL4nSYRZS1vmDzdCOodsm9qL/iCVPiIdXPWTyBuK+SuQEncugF6ttO5gkwJ0PbUN/tP7+ObyD752MSk/KGuJDuWfJlUukClfMnV6ipn0cWrpNK5OoTYWGoYluYBA0UnzHv1CI9m2TJ3Wnyj4Eib4x47fFed3teNprorL2uSE9bj30qPaJU4m7IbxPtMVpvyKFq8bXrfzUzIj4Oh+aLPzlPLPEZjEirQf24DQEI2u+YLUuEdAkw0lCqWa0n2w4LvgbPDqldGaM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(136003)(396003)(366004)(39860400002)(186009)(451199024)(1800799009)(5660300002)(66899024)(41300700001)(26005)(2906002)(82960400001)(86362001)(38100700002)(4326008)(8676002)(8936002)(44832011)(6486002)(6506007)(6512007)(6666004)(478600001)(53546011)(316002)(6916009)(66946007)(66556008)(66476007)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXI2VnJIb1FWQkowL3RtUi8rZjg0VTl5YVk5NE03aTVCT2ZrTDdaRllySGN1?= =?utf-8?B?cHloZ1VQSkJtYVZNdmJyU1BhTUgybHJiQTdlWGVDY2YwanFzNDQyOENKYjhv?= =?utf-8?B?Y1N4WWliL2luTWo0RlUzdUk3MXp2T2ljQjlWU0QwTXdJeFpMVzJMaXhJTEpX?= =?utf-8?B?T3c0V1hueWgrbitxUDNndXczUTVPeVgvUXVna0tMWTlUOHFFKys4YXpYazRD?= =?utf-8?B?M2xCaEErZi9uRk5WQkE5cGJoVjhvVzJzbXZhaXhLeFRESk1OREpHZUZZRHN0?= =?utf-8?B?NmYwR0YzK0hPTTBQYjdtRzlFZkNJaFlpUWJESEZCdkp1TW5LdzAvZ0pQVUli?= =?utf-8?B?T1dVc3BrVmJYZDFMWVRCSzZMSERPaTZQUGpONkV2K2NaWFhEOXFOOExyeFJr?= =?utf-8?B?K01OMzNJSkFpSnY1SGdWSkRGN2ZUT0VaVTdQVTE1M21ZanR4UHc3ZWVFVkNt?= =?utf-8?B?bFhaTTUvQkwrTEFpNjBhYmJWZWRDZk5ESEY0dy92SHIzYVdwTUFRZGpxbkNT?= =?utf-8?B?dDcrZW1DMXpvK0pncTFQL09ramJFeVJCTUU1TFZ1aUkvTmhrN29PVUdaOUtB?= =?utf-8?B?ckJxSFFZWWNWUlBOWklvMmNMMWc0dDRBRVRDaS9wQ281QzYxeGY2TzljdnJM?= =?utf-8?B?amI5ek0vWER5UVZQdXd2Y3JvY0VOKy9ubHFYNVY1cmNJcnBDVEp2dElnTUw3?= =?utf-8?B?RDZDNVFaTkc0dzY1TEc5MzVjMlBjL2tmVURNbHNzTzNCMjl0S1lIUzZtMVhn?= =?utf-8?B?Z0RIalAxeXczR3lrY3ZFcExRNjVGVlp6RU04NW5naUF5TTNudWdBNDdEWFFY?= =?utf-8?B?NkErUlFCSGVXWG0ycmN6SEVLTUozN21Jdm1WQ0l4QldUeFJtaUhmQWVHT2lU?= =?utf-8?B?OU1EREJxRzc4dVZyUjhYdTZBZjkyTXR2ZHRxamtJUmdKZzVJWU1lMVQxRytS?= =?utf-8?B?YWd3dno0eURjNGhRTVgwd2FtdHBuWTkrdlgvOXZJZU5DUkFIL1BXdzdHY2lY?= =?utf-8?B?S2lBbFc4ci9Sak55NGp2aDk4UVRoNlJjbndic2dhZU1udnlob3k0bXlXS3Qv?= =?utf-8?B?WXlWUVh5bytHemVtSHlVMWZNWnVsd0lXVXl2ZDBBditJRGhRazkzSGY5Q2ZV?= =?utf-8?B?RlhjdVlqYzF1YlN6eUYwQjhxL2VyN3Jib1RoVkw5Q25DSFZJWTVoOEpFY3lS?= =?utf-8?B?bEg1WGJ6T2R1WjZFalBVNXVjU244OTRlaU9vQkdUdUVqb3pic2tOTlNhOUs3?= =?utf-8?B?aUdJRytxZkhoSWpxWXo2MFZQaUpLelpBMDYyWTJsd3pZSERaYVdIRThDeGh2?= =?utf-8?B?SHByNTN3dzYyNVkzaWtTWHpVMU5wcm5ncU1zbUdja1ZBNEdYbUdUR2RmRVl5?= =?utf-8?B?MXprbm4yQUFKemZYeGhJbWlSQkcvcmNqOVF4S2FoQ001Rm9ja2FDdFJtbE5p?= =?utf-8?B?MzdXcG5Hb2RGMmY4R2RuOW4rQW1UN1ZEVjdLcjJXWURWaVpOM3BXMFg3amQ3?= =?utf-8?B?Z1VSVm1VSEpla0E1ejVvTU1vU1JCOUUvdFlpbDVCNTYweTErbnZYci9xTktI?= =?utf-8?B?WmJPc0FEcEIzRU9MUXdYWDF4UzZvTmVNQUpnQUJpWlRudVZPWDkrS2xkSGtJ?= =?utf-8?B?RnFzVjg0eVB2aXVyWVZyZUNHTnhWcXJMZ0tSaG9LRXJ4K09FUTBzSndpVFFN?= =?utf-8?B?UENOUzJtSiszeXdJS0pTdzc4aUFPOCtMMEx4Tnd1KzQyejQ0cUIwdDFWdmgx?= =?utf-8?B?M0hBN2tZcUYvLzc5czlrYWdBZUlqU3BEbWpHUlRUZnhqdllHT09PR2M2OUgz?= =?utf-8?B?amtzcTJYTGdvcWxoWlE3T05iRzdTMFdPa0VkWWo2VHZkK05ERlMrdUhaZCtx?= =?utf-8?B?T3N2c05ZbHF4YkdZQ1B0VnBoSDJ3aEI3TWRnWWRhTVlYaGkxZVlxTXRLTXFV?= =?utf-8?B?THpmWnBLVmxiSGVEUEtUNXo5bXpCZW1aUTJCZTI4Z1hkSEk1UDBJbzZ0OGE0?= =?utf-8?B?dUNqc3BNUzZMdFJzc2dqeHpmZ2NwYVdiczhPVjdEM2pCazNPK2FFRTJRU2pa?= =?utf-8?B?ek94eGRHWGNmNG5nVjRjQkd0QkFQRDY1TG9Tek5zMno0a0ZzY2hWci9mOXQz?= =?utf-8?B?bUFvUFZYdFJoMkZMME52YU93WXI2c1lGZ1NiREcrazV2VTFiTTNncHorZTN5?= =?utf-8?B?S3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3a8ff40d-a7d5-4f6f-84a7-08dbb9b1ad7f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 08:14:57.6414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FeSfdj3/WwxNgCs65J9bu4do/14crwP+ywZ9UAQuYMe4tDf9Co1yrdj2CI4F4aLBXk9ibNis7Q+zh9BW8p5I/koC+mM0mObQZIQSbD9bhmM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5711 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Sep 20, 2023 at 10:04:55AM +0530, Jerin Jacob wrote: > On Tue, Sep 19, 2023 at 9:35 PM wrote: > > > > From: Sunil Kumar Kori > > > > It adds framework to initate a telnet session with application. > > > > Some configurations and debug commands are exposed as runtime APIs. > > Those commands can be invoked using telnet session. > > > > Application initiates a telnet server with host address 0.0.0.0 > > and port number 8086 by default. > > > > To make it configurable, "-h" and "-p" options are provided. > > Using them user can pass host address and port number on which > > application will start telnet server. > > > > Using same host address and port number, telnet client can connect > > to application. > > > > Syntax to connect with application: > > # telnet > > > > Once session is connected, "graph> " prompt will be available. > > Example: > > # telnet 10.28.35.207 50000 > > Trying 10.28.35.207... > > Connected to 10.28.35.207. > > Escape character is '^]'. > > > > Welcome! > > > > graph> > > Some improvements > 1) Please squash 14/14 patch to 1/14. > 2) Ctrl - C doesn't work which is a serious issue. We have to kill it > via kill -9 from a separate window. This is probably because of > command line library. > 3). In case app launch fails due to error, it will leave terminal into > a bad state until "reset" command is executed. This might also be > because of command line library. > 4). Just a wishlist: If on terminal console I could do a tab and get > commands help, just like testpmd console. I think that the tab completion is only available if you use cmdline_stdin_new vs regular cmdline creation function. In the case of the telnet connection, it may work to set the telnet fd as stdin/stdout for the connection and then use cmdline_stdin_new to create the cmdline. /Bruce