From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83046425DE; Wed, 20 Sep 2023 12:09:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1BA864067B; Wed, 20 Sep 2023 12:09:13 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 6DE404027B for ; Wed, 20 Sep 2023 12:09:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695204551; x=1726740551; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=IsG9j70DDk9t/xP9oJ9LaUAvQhnYGVdBVR789ow+I3U=; b=QYY/OuFBIvPXBUmGpuuEC/vPQIyPR2dKDPUt/lpU8YbZ856kQXq93zgl Aiwl4vo5jr6tiyKukkCUL2KuZaljZ3lRMTM8xUQpsymmSbVpjfwqahxjK RfnBJ3DaMdZatbbpXBcrchhY1swqVa4VdeP5bK/xRnErsFMKD6Uw/ad5t GiGEKqXmvbGBa6Ec8xRUNwbepOmc3C+WhEulxUP5Wc/TszCuYFQV/CukD xlKMW1w2c7S170/Q21gGRENSK+qT0qfgbk4NnnIqT8S7JgcpMU0cA71ib MuAHHXNePlN4Hj9fqDC+IoSoPvRtZqB1G7lYv6dxz2M/r60sQdywBy5Ko g==; X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="359569875" X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="scan'208";a="359569875" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2023 03:09:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="746587385" X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="scan'208";a="746587385" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Sep 2023 03:09:10 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 20 Sep 2023 03:09:09 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 20 Sep 2023 03:09:09 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 20 Sep 2023 03:09:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c2OBuVuSSnUjXhnXlTdtI2dPxRAKQ2TTHaS9xpcmtlN2tGwFAR8kMs2N3cojmukKKH6Jd8X05D72p2XhVPff0zeGcgc7IK+CFWuOPMACTjgH1gjqA9aE9Z8Fx0dkciho5XKgTMltvKrhhtQdr1Khcp9SRcaRL8IqZl1bmlXA1lNOk7qKz513kDnIXXBFjRW/BNqKiEBPDWKG1QfQfPc8FiY7fG+CVU4rUhhsLPUaXgQG7Jag6PGVDNxzGTXZGQIvxu2ltUkvk4H5W2rHsQn+PdO8WVWEtFB3AnK+zaR3kjvCBOUD1aKchYS0ZJPq7oUoxqywurV9S0YAGWmXfHHUrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sCik0VbZpqb+iuoj4/gexgcAf9ZU+xrNWGx3Z3hw8W0=; b=nL6/6hA1oy3NYPWethnpPLvHdQXGa9+7FmYmBQswriEW6+gzXNoZ5Rj1GVtmEteTlVA8/FTDgZ7QQcUum7GpXEGdPMkS9hH90D2/9D7f3aXgboxHAlSBsaePjkdWihynoRgJhpUtoDCwGueFkWzYlCX2ie5aKU0bTQlmwYr30JMcZ1NnM43lFn/yiXrCycIiFVE0Qz4VkkbXQv7sKNuk0m2B2HvqVO4srg5mdndvJosCjuku3OpJVq/Yx9/y/4LEpdPSgCwvXeCl2p4NinwBY+7kQJun1Nmp1ntjxW1OXZa2qOL6NfLpvD/6gOeL40eYxjEbNzjSrerOa1QzO49DXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA1PR11MB6468.namprd11.prod.outlook.com (2603:10b6:208:3a4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.27; Wed, 20 Sep 2023 10:09:07 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6768.029; Wed, 20 Sep 2023 10:09:06 +0000 Date: Wed, 20 Sep 2023 11:09:00 +0100 From: Bruce Richardson To: David Marchand CC: , Aaron Conole , Ferruh Yigit , Thomas Monjalon Subject: Re: [PATCH 0/1] make file prefix unit test more resilient Message-ID: References: <20230914104215.71408-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU2P251CA0010.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::25) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA1PR11MB6468:EE_ X-MS-Office365-Filtering-Correlation-Id: bebcd5be-c1c5-4028-36a7-08dbb9c19fde X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7qt5kbgmQ2Jxg9k5799/+nNRPWgM1HpnodJw4cJBYmWIIkiAoLP0smuwBgTi5U/C94tRRSJoyHX9c+ryxE4RfjLfJIcOqGKHXEk2+oukCmrWvFYgAgTJPAeygVe3ogRdQZv3ycwvSt6q4R4F9VKFjjn9fJmFhTLtghLNUu+k1GdqaWeAn9QbQ+vPtJiCa5/TvY9QafCtQmZqoeeGsGoVOK7gXwxHek7S6gxiCaRy9E1pdEA+a7+PqxQO8yUmj2wJb3or6074kxR934tbNkoXjQCBiXS1HT7snOumFmBLme3su7Dr1+k9X/ipoj6m9iw9kpspN7pnw6Lq2UvNvCKkxPCy2WPaT2Akza1H4Lotx9/oUN9zk8iI4NRWIGB3gcvnkWXOiQN+OMEIgaigqtsmetwKCRmEvGsvWCrgLyQEZclfrl1tTf+GIvlj2f2u6M2dPMVGYwb+uaS69Qm2g5Vw2eVPbI7FBXeqRFywjN2V+bkQqNlLd5ZKqzoeRuJY5IIWbsIbEwX/E2eCzXrbykqLJJJ8ZGIJ+EKUHzKO4pR8tZcf+i+QbkUSoXkQhHuTlpdxnDAjHYJ+fzjYsCn5THtiKg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(136003)(396003)(366004)(346002)(376002)(451199024)(186009)(1800799009)(82960400001)(38100700002)(86362001)(478600001)(966005)(66476007)(54906003)(66556008)(6916009)(66946007)(2906002)(6512007)(6666004)(53546011)(6506007)(6486002)(8676002)(8936002)(44832011)(5660300002)(4326008)(41300700001)(316002)(26005)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3ZYdURmWUJLWXg2c1NhRXBEd1VWV1JIeHhzMnNiMkpkT2k3am5JR090ejlq?= =?utf-8?B?LzBrRC9VaGo1ZGtzOHFuUmo3UTNIeHZxcVc2U204VlRDS2FJQVN4dHdUcHpC?= =?utf-8?B?d2J0THpicVlpY2NKNFFSWjltd2YwY0ZDVVdhRUs1dng4QXdxZVVTbU9jKzNo?= =?utf-8?B?dzFhc012YnREMU5SNVNNTFZMOXdnZW9GRFEyNHVleHk1ZHg5SlhoMjlHeFRS?= =?utf-8?B?NEVXc3cxbHo1SXlidllkaDF4azVtWFRPNG4xbmpIS1BtQ0YvMnYxQUx5WkJE?= =?utf-8?B?N0VkaURYZTVRd091TEVab092Y2liaXVHa3QrYXE2Vk4yVHJoczB4eFpDRHgr?= =?utf-8?B?d1k1bXNNRGh3cjZKSHVCUTRGQTNKR2FJUXM5ejNQdmkyM0FkVWIrSTB6bklx?= =?utf-8?B?YW1nQlVkTXc0dElKY2JTRWdFZ2VSOURsSk1tQVBWcUVOL3BKL3NGb0QreElm?= =?utf-8?B?ME9HZVV2ZDJVVlBKUy81YnFPU3JwbG1UU3g4YzRrbUgyYkJIc0RyMkpQbE9h?= =?utf-8?B?d3U0aE1haWlOK3lIYmVZWElDSWNrMjRxQ0tkNmlGZmVieitZb1VZS3RMWVlV?= =?utf-8?B?K1kyL2QveWtGdjdUMy9uM3kvbitySFN5MzI3THlrdGtpRzYzK0I4aHdRbzJx?= =?utf-8?B?dVVRcFFuYldxMml1Z25QNjN5bnVhbzg5bzJaRUlWSnN6emZYVldSYXBudk1v?= =?utf-8?B?LzlQRVJFTUpKZzJwWWFWQTZlb1Q5MVB3TklBRUZ4Sy9FL3NIc0QwM2Q0d1BJ?= =?utf-8?B?ZGhLeDdJc1FMTkUzakI3OXBjQmx6MTdMNFJBSTlvd3RFZTBTQ2pPc1BSUmZH?= =?utf-8?B?ZzJvdmRiWERJaVpoSXdiTjRmOXZqUWhkRStEZHJjOTdNeU1BWnNzcm51dERw?= =?utf-8?B?SWJjMG5pbU1pSHpKb1NCT1YrTkpNUE01R2t1WERIczR0RmJIM3I5MFVZSnkr?= =?utf-8?B?MEpxa25wTzN3SEhLQ0VFRFpOSVhmZkRmb0NrMXpxa1RFL05PMHJjZ1BvR0dk?= =?utf-8?B?NnJzVGltK25kT3gzVS9YL1NQNjdteXNHbXZlMUNGSFkzdTdtQ2ltRnhTS0FI?= =?utf-8?B?dUlqdjdieHhBR1M2Q2VKSU0xVUc5MUZxb0hRNHdJbkJmKzZ1eEU3UWtRK05k?= =?utf-8?B?bmRxOGI2L3V1Ky9vbkVCMVdKTW5VenFTdTZOamxYck9HTG1QVTEwb2RWL09R?= =?utf-8?B?YUtEb0lkMkRhV0wxdGpwdTJjZWU3eVc4OE1FS1RIRUJsNzBxa3hFSTBBOFpS?= =?utf-8?B?Wlh3SC94dFM4RDJiSUZ1QXQvYUxGWm9yYTBhb2t3Q3dJV1NEWHRQM0MweFh2?= =?utf-8?B?d3NtSHVBVFo4YkkxSUpoNU9vZTZSNU1obUVqaW5FS2w2MWZnSWVaa2ZjRTcv?= =?utf-8?B?K3pHcFdPeVNUNDVjL09JdEUvWURKWW9GYjBJcUw2dlE3cFBRbTB3WGhjMzQ2?= =?utf-8?B?cnpIUHRLQTJZTlZtYmFXczFGUmpSMkRQdDI0SitQZGNHTjArRnFySk55elJK?= =?utf-8?B?Z1Fnakp1ZEJBZTRDeVZlQTRzR01RQzJneVFaQm9FWWJHSHF6Z2puNGUyMTZS?= =?utf-8?B?NU80OFBUc29TbFJTMWpSVUIvVnlsMHNiV2ZFNTlvUjUxT1kweXZLNEo4QzF6?= =?utf-8?B?U1ZWWk4vaFI0azZ0YkVMVlJoM0JpKzNrNUZoMXkyRFU5MWsvRTdscWNCbytx?= =?utf-8?B?elp5UVNCTCtsKytFK25ZVnNmK2hqaDA2bzl5clJnUmxWYVhWazRxS3dnSzdM?= =?utf-8?B?eHhPVmRseG80MFYrZE14UWdvRE9TeHhWZUFWcFhEakJRUmw4aUxJOU4veHVl?= =?utf-8?B?SnhrNHB3MGRRTzA3OHA2YVJDOTBrNWlsOTYrbS82MWo2VGc3Z3c3Q2FSaXlW?= =?utf-8?B?a1lwMm9mREVFNlltU05BOEh0RlVUbWdxNUp4NzRNZXA2MmRMVU5PUHMrZ2hG?= =?utf-8?B?Ujk4b2dFQ01zMUROT1NBcC82ZWdTd2pwRmM5RGpSTFlyMmx3TFBEYjBWWWR1?= =?utf-8?B?S0ovY1VNYTBZVmI4N0VmeXpZL0ZZSExIRE1OaVVISXp6dTZSbDRUQ2VLd2Vj?= =?utf-8?B?VlNxWHlERGp6dGZCeEJkNGVpUHhTYzd6ZlpnYitRL2p6dkd1bjNyRmdCaldT?= =?utf-8?B?eXdsSEVNdGFyODMzV042c0hpbjV3WDRkZlNTZEE0NDdhSVhRVWVya2puRFpI?= =?utf-8?B?SEE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: bebcd5be-c1c5-4028-36a7-08dbb9c19fde X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 10:09:06.6865 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 44oBcaAUYMLdV+KwSAu33HkVKOysKPNCsXIZ/kVjj9Nz5dy4N3Rx2IkYk4OsAffZV3dOtWkA0S8ZbdAEc61Yntz5zAEQgAClSg6vu/uetr8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6468 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Sep 20, 2023 at 12:00:08PM +0200, David Marchand wrote: > On Thu, Sep 14, 2023 at 12:42 PM Bruce Richardson > wrote: > > > > When examining the IOL testing failures for patch series [1], I observed > > that the failures reported were in the eal_flags_file_prefix unit test. > > I was able to reproduce this on my system by passing an additional > > "--on-pci" flag to the test run, since the log to the test has errors > > about device availability. Adding the "no-pci" flag to the individual > > Something is not clear to me. > > While I understand that passing "no-pci" helps avoiding the issue (as > described below), I have some trouble understanding this passage > (above) with "--on-pci". That's a typo for no-pci. When I ran the test on my system with the main process using no-pci, I was able to reproduce the issue seen in the IOL lab. Otherwise I couldn't reproduce it. > How did you reproduce the issue? > > > > test commands used by the unit tests fixed the issue thereafter, > > allowing the test to pass in all cases for me. Therefore, I am > > submitting this patch in the hopes of making the test more robust, since > > the observed failures seem unrelated to the original patchset [1] I > > submitted. > > > > [1] http://patches.dpdk.org/project/dpdk/list/?series=29406 > > > > Bruce Richardson (1): > > app/test: skip PCI bus scan when testing prefix flags > > > > app/test/test_eal_flags.c | 20 ++++++++++---------- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > Iiuc, the problem is that the file_prefix unit test can fail if any > DPDK subsystem forgets to release some memory and some hugepages are > left behind at the cleanup step. > Passing --no-pci as you suggest hides issues coming from PCI drivers. > > This is something I tried to fix too, with > https://patchwork.dpdk.org/project/dpdk/list/?series=29288 though my > fix only handles a part of the issue (here, the ethdev drivers). > > Another way to make the file prefix more robust would be to remove the > check on released memory, or move it to another test. > I actually think the test is a good one to have. Also, taking in your patch to help with the issue is a good idea also. I'd still suggest that this patch be considered anyway, as there is no need to do PCI bus scanning as part of this test. Therefore I'd view it as a harmless addition that may help things. /Bruce