From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01E6A425FF; Thu, 21 Sep 2023 12:47:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF70D402C7; Thu, 21 Sep 2023 12:47:25 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 00E77402B5 for ; Thu, 21 Sep 2023 12:47:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695293244; x=1726829244; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=sommWhotpxLctho8GPcJWIfDhBYmrgYRgAvuHtDe1gw=; b=P76N78yNv/8JGz/I2eRkqerWlEXopX0LgGn2bKSc6niaEBmNaUi3tJWi EZ7STsMfabTXP810xCzKIxIWrqQvE/ioJ0xIRGnws5eA/awTffwILq7BS e6UtM52QJ6YeCKHaMiarai1zYgSynNKLJbALBymcf/ygOEgrTcj5KqUjU pCwkcTyRboGaURqtRJJ1xzuPDWyaLApbXH5EnnssUkZj7+4te90svr9BC kYQ3wKZzcm2u3vgJ0jGIqB2Be3WqWK2++sDiK8rkDRngfFzoGi/CJvWYL s5KA7CzWoOUZngN0EoY10o7THcNngs1Zz8BclJIFW996P/ArdtnpUbFrL w==; X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="359867591" X-IronPort-AV: E=Sophos;i="6.03,165,1694761200"; d="scan'208";a="359867591" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2023 03:47:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="870761519" X-IronPort-AV: E=Sophos;i="6.03,165,1694761200"; d="scan'208";a="870761519" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Sep 2023 03:47:22 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 21 Sep 2023 03:47:22 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Thu, 21 Sep 2023 03:47:22 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Thu, 21 Sep 2023 03:47:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nW2m7oaS28K6WZSEuvbz477ppBisS+sV6zSa8q3nWBF5NjmKNWGhrlEVYUPEV5pIi7V8DbMnOMVJJBoOE3FVgvKcjcDvb8KyUVBX1tGKwk8lqgAK2uZuMDtKlCHwuJTyfnx7CmBNSgmCs1jxrQqAxjQeVhwdPGh7gyhFvzLUAp2Zc2wm2MEVzQ4YDKiBiZBBNYj0Y9yvde5k9mllE46dp8FbpRiifAk0ud0nn56W3xGTvjLZI9IFPWj4bUGA8GUjTeNm+ZfjvTvKFsel375nmIQ2Kf+g/LDq/mEpNj+GcqbDsm9ZFG/mXNdONNyc2PT0u3G83crFbtjpWSC/W5seAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IMTruVgiFDhkBuQchESa5WpAvvlgXKFT0C3qptNCJmA=; b=T2tHJWlWZKt5zqTOvJyW6IR9fwULQYFp7OcJ7PzXBe/eSweFuICPfUsdCKTLKoxQT4ubl64wzpxhz8ykJptA2tqzWFYuchiaFksqnvzWSw/2zahgXdLTY6E1FuMcyJUnkVN/Pevk/YaKQ8lSG9ZY/7rlawN6vaJo0EbfGIhWrLUYBrtQHjlhDICkSBbb4TEwT+qaUeKrQo98YEEkoXz6DJFzHQB6YhSD+dz2+UgAyDQCrxwFopIWnXJgMZuT3ctKYCPMxsWSNs+87m/szAoFHMrwZy87rLQWih/HRPUfGyYbxiXZprq4f6BkjQw1Kktsz+KDhFHedjpXeRS62/HTXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA1PR11MB7319.namprd11.prod.outlook.com (2603:10b6:208:425::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.33; Thu, 21 Sep 2023 10:47:20 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6768.029; Thu, 21 Sep 2023 10:47:20 +0000 Date: Thu, 21 Sep 2023 11:47:13 +0100 From: Bruce Richardson To: Shibin Koikkara Reeny CC: , , , Subject: Re: [PATCH] net/af_xdp: pass cflags to appropriate build components Message-ID: References: <20230921102923.65738-1-shibin.koikkara.reeny@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230921102923.65738-1-shibin.koikkara.reeny@intel.com> X-ClientProxiedBy: DUZP191CA0009.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f9::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA1PR11MB7319:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ad19414-bcf6-4af4-77fe-08dbba902136 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6U5Er+Jru6cY3AnQKly/Z3z3J4Y+SiN3gW2xcqhYb2wG6FQs4swztjoZVrMVkhWcYx8CHFzqT6UmgFDsKdCtDYz0+nqB+mnJ05yTO9SoBYZqoi/eu1HJB3tohsk5MnrSOBlxbUVAPby575KYwDYBHpGHh5N5USpdp7VRZHTEc9NDW35ewXdW6o06Yayh2lYaazCKo33FQILmJ4tVVSjp1gR8PbCx0qdPWAeTWLbnqZmyGak00GUWGsw9dVuGke3YM1cOcpJUcTqWJgqcOHTCU4NzDfTVyflkZntHXK+gbSLaG3HhYOpZXVux/2a6Dx91Rfj9Owhy1KRyWHu+/vw6fvMT85aw+JYO5r5AkdP01166pjoYGFTfOtFI92rQ/KXMJIxO6LoyxoEfnQZrjoOCzc/n1VyN7M5KUQbX5bqcVSo4nx+23S+oUYmTz2J9UMm/wxjE1BeEBpI+YnLrq9UCTK4QDkv2KdnV+2Ok+WAvoLbwKYz0JEssD/IG0LFrrkXn4tE+t1GDoqDMuYt1Ok7jfw9nNGkVALRlUIQbZ74IQj00NNvBPQvm62yhTdu82vpo X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(136003)(396003)(346002)(376002)(39860400002)(451199024)(186009)(1800799009)(66476007)(6636002)(83380400001)(107886003)(66556008)(66899024)(6486002)(6506007)(6666004)(38100700002)(86362001)(82960400001)(8676002)(478600001)(6512007)(44832011)(41300700001)(5660300002)(66946007)(316002)(8936002)(26005)(2906002)(6862004)(4326008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qg6KANaV1aFjsVZG7MRPKsikvn9eVYn7eVYSzzsSwcbUxm4glLWOCCoaeJH7?= =?us-ascii?Q?3MC8o1p/s0G8YbQJc2Mlr6vhrA1nygFRwwk2vdjsIuIvRy/6Exg4Ub9ZCIah?= =?us-ascii?Q?4YCC86tqpKxMMoWELE5RRqArQK1HvRu+lXMRTA3JUvdkpPDuCE79w9Hinhkv?= =?us-ascii?Q?D63Ai7Ori1yZUXOGmsIFTBJ9l3XUjV1pnp3ssg0TbSpuEspMDO2qOsCU+EkH?= =?us-ascii?Q?oKCba9t8r1w3UuKn7aJrXRYNEjRBs8BiehqkwXsnsyhS+yM/1wCamju88drA?= =?us-ascii?Q?YiNBhG3utBfuXMwOyuIKZQa5XrtwzZX+WQ5EMAh/dvvBBHds6xtTUIdXL0IO?= =?us-ascii?Q?6VPdhAAmlRt8CmNgz9vSiPAWDiBLSI9m27VP8+uuLArbAzWngj+rrJhW75gy?= =?us-ascii?Q?+/bE1ne8+CO6GoQyPCSh22jtdqsMsn1/6NLvocQolLwUDKxdQu0ahh/sTfen?= =?us-ascii?Q?SbyGGAdX5gEE4moLhk93IPM0QQVj2sU6MMyEVJZ2cEcQApOcovxeVg2JWaQz?= =?us-ascii?Q?g4MqFNCbfKX8vinVCkdxD7Upu7vwJMApVEyCLSMIKUyKIb1sI8tlrbPZgZ5v?= =?us-ascii?Q?XsyyP0WtUF8ccQPqQC4hspBE8NFrVrL+gqJ9+MKAlTFosh8Wl0TU+B+QlZcw?= =?us-ascii?Q?gnu575qAj5rPTRGb0pytPYFPhuj0/niF/yBrgSE+yUQS32f2rFj3nt0J/gW8?= =?us-ascii?Q?v6AL6t+wx9BPnBowxZXGpk+fOtnO/rDXGTypVkf3zHJzZF8teWcgbBNtj0xi?= =?us-ascii?Q?p0k/hgkrsFoXrWQe2WBh/KHZIwpwjXoalqdWBfRmfprVq2g/xvGSwidBpf4S?= =?us-ascii?Q?+p/s2nbQtK5yCSnNCe+57MLeLQagSIJshRTZ+Le1mdjPLy7MX6ND3krLmRWC?= =?us-ascii?Q?634EGENhTiCW5Exfp5ilj47VN2zVUop39F7I9Z3caUktEFv+8U9+0hYo1bQf?= =?us-ascii?Q?DVYwYsh6alXu0l0SLmLCsFRYTGVe4+IAODLTMctb44KINa5Ukq/ZcEWe1ekR?= =?us-ascii?Q?L5C0k75qEzwvsRNj0OOJ+EbZ21c9u6kV9svjJPUbaKPwoYbaKuFTeYvM2h/6?= =?us-ascii?Q?07RUfV/aO8fnNLHyHufmLoQO4KOU9PKYUFayEEv6ciuoSGtmABdArHNCuKY1?= =?us-ascii?Q?Rzs88rrq6KYQGohhGQxnHiM22Wzi+Dc+Akzo2z2Fsqz5eia4Kpwto0WmpsJv?= =?us-ascii?Q?PaiI/WRh+gUfqWZW2PF6kmP5VbuCYAuGOzB/IAV74w4LJbhKpXOXFoTv4azA?= =?us-ascii?Q?WpfdH6KE0kig9Pp8wuQseeVtPTckzhJOic1/yekHHZcw9WENQ/YrCCS1mmzY?= =?us-ascii?Q?pPh8P/eJkHzVsuaYgYNcb3nklcPqMx7CSmSet73DXRvZTAZv1ntr0CIskHzG?= =?us-ascii?Q?C8C4yQbAq+Fzckvg50gmdJ1pcFa/VMW0Mm3F6EaFXbX1JFOHUq0eXnyvAf+A?= =?us-ascii?Q?+hyn1nvsdQ292Nxkx2T3MEQB7gic9I2PLcRa3DVNiXNnYdPCHuUzfVs6gcke?= =?us-ascii?Q?dzAGNNIF149xHU4QENz8mJMs8/BV3QBMgSMDms12q6ZHDZvVdhS4s18mS/ba?= =?us-ascii?Q?YmnbeSgN2L49QEmaTQma7P7/cRkEliVOwTgiiZNEg1V9fhU9hHIQW1YhpJGU?= =?us-ascii?Q?Uw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2ad19414-bcf6-4af4-77fe-08dbba902136 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 10:47:20.0321 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1beafFm2S0w2bR+x3Va2l/98/FiniPltCCGqjg2Ivqld4P1Vl0siW3OATcalPuzIeuEG28S4goGIePjfeMte6yxlrN/yg0s4rIKerqX60t4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7319 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 21, 2023 at 10:29:23AM +0000, Shibin Koikkara Reeny wrote: > Commit 33d66940e9ba ("build: use C11 standard") enforces > the C11 standard so some changes need to be made to the > af_xdp driver meson build to ensure that the appropriate > cflags are passed when checking if certain functions are > available in the libbpf/libxdp libraries. > By way of additional follow-up. Can you please describe the actual issue encountered in the commit log, and how the code change fixes it. Ideally, the commit title should also start with "fix" and a short description of the issue. For example "fix build with libxdp version..." or "fix compiler error when ...". Focus more on the problem rather than the solution, since anyone looking at the commit in future is more likely to be interested in what is solves rather than what it does. You can include my ack in a V2 with updated description. /Bruce > Fixes: 33d66940e9ba ("build: use C11 standard") > > Signed-off-by: Shibin Koikkara Reeny > --- > drivers/net/af_xdp/meson.build | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build > index 9a8dbb4d49..3319acca65 100644 > --- a/drivers/net/af_xdp/meson.build > +++ b/drivers/net/af_xdp/meson.build > @@ -56,17 +56,17 @@ if build > ''' > > if cc.has_function('xsk_socket__create_shared', prefix : xsk_check_prefix, > - dependencies : ext_deps) > + dependencies : ext_deps, args: cflags) > cflags += ['-DRTE_NET_AF_XDP_SHARED_UMEM'] > endif > if cc.has_function('bpf_object__next_program', > prefix : '#include ', > - dependencies : bpf_dep) > + dependencies : bpf_dep, args: cflags) > cflags += ['-DRTE_NET_AF_XDP_LIBBPF_OBJ_OPEN'] > endif > if cc.has_function('bpf_xdp_attach', > prefix : '#include ', > - dependencies : bpf_dep) > + dependencies : bpf_dep, args: cflags) > cflags += ['-DRTE_NET_AF_XDP_LIBBPF_XDP_ATTACH'] > endif > endif > -- > 2.25.1 >