From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C208426C2; Thu, 5 Oct 2023 14:06:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F946402B2; Thu, 5 Oct 2023 14:06:50 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id D7B5D402A9 for ; Thu, 5 Oct 2023 14:06:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696507608; x=1728043608; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=WwWf2++LW/JX5UYgpQFqg0836mBK3dETQjnxvO/WmwM=; b=ZDk9vo8LzLkdK/CqH/sR8efGEQVdsjCtrcYuNpOVgfuLkuIh4Ki2Hwt7 STv8i3/5CyeDGcgjRx+s65eaPnVYOuhl2nvQmRYfNJHkfRNFbiYrPTbH2 xVZ/tOHwaB3O3Q4t9hjeFyh4zIMKpgprnTxZ4ORTVm5sZf+InEicHoL4a xu4Io2qRLZGRsGUfRfFeJNCWNVGtxVaMjEjxX1zNLwpNuz4TUoBSw/ynn 0xTUC/ytESDEIK7PuyOwLPtKwEwiwXp5+eaj9KgHr7hwAV1fpIVrQUaK+ dhaLOUful2TMdv78SJM1ayBeKn5xFWpjfavXvAIekNVjBFlh9f9CMjy64 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10853"; a="382343362" X-IronPort-AV: E=Sophos;i="6.03,203,1694761200"; d="scan'208";a="382343362" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2023 05:06:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10853"; a="745427546" X-IronPort-AV: E=Sophos;i="6.03,203,1694761200"; d="scan'208";a="745427546" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Oct 2023 05:06:46 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 5 Oct 2023 05:06:45 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 5 Oct 2023 05:06:45 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Thu, 5 Oct 2023 05:06:45 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Thu, 5 Oct 2023 05:06:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lMTmNX1pHuUaXMUjSQ2NaQcz0pLeNFGEZYHBHUPk/9+99btXHxlbTtV6Ut8HpXnjuEwJ/dUSZOLuslrbCmU1XQ6W3Ljese56vkykswxf59SpgfKqXMedW1mk5unhTRsDTLnyulNWjKX1tS0o+hpUjmxFZrIi7h03f3H8Tfe1uCrEB61f9ltaXvmikITT3tgn3o/F3kwv+Szv5LxXP6ZvXS+nJjw6M/9r/jXUjJoHiNJANA0eOTW6n95zkNp/TDHwih2mH/rQEIGEyGKFasQde+np3uM3lyd0zA0LtRLEVAqXmteMoMxVxtEBuWxIEok4DrDKZRu8r5Q9RO9vK4qbDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sMgxBrF+lAnpRuzgbOXJvkpor27Fy9fPZ61/9DUGqwo=; b=WPplR08Q0ZWJAkMYzmPoucBY+hbEIUA4t9sqCwt1bIkRdI8qeBdDEG2yru4f3mOcx4FFl9VqgSPxWXkazzBuQcetXVN5V6ijRB+9vcZ4fBLf7iomVJbxB3CXT13gU5y0uLOsUcQwgRe5vtngjKNukkGYEUS8rii7izfZ2NpHh+FqYoR212lDUM4PVZlvTdvWEg0QGvdyL+NloIOyHU4xamtVOw0TrAKnu+Y2VQo+59VlvKjDuG+ScNgSgu+Wl+yqLrYW5iG3r51KmWrDcWYeVUE9SvhsTk5JV8A5bfRaLYCSP+yb2ses5NgVjKnm0RSbP/ev6PhG1tfriQBfA8Fo1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7411.namprd11.prod.outlook.com (2603:10b6:8:150::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.37; Thu, 5 Oct 2023 12:06:43 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aa85:ead1:baa8:c652]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aa85:ead1:baa8:c652%2]) with mapi id 15.20.6838.024; Thu, 5 Oct 2023 12:06:43 +0000 Date: Thu, 5 Oct 2023 13:06:37 +0100 From: Bruce Richardson To: CC: Jerin Jacob Subject: Re: [RFC PATCH] eventdev: ensure 16-byte alignment for events Message-ID: References: <20231005115101.12276-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231005115101.12276-1-bruce.richardson@intel.com> X-ClientProxiedBy: DU2P250CA0014.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7411:EE_ X-MS-Office365-Filtering-Correlation-Id: bd501ac6-b327-4dc5-6d6f-08dbc59b89e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SZtrpadV8HUP22Zg5biG3woqcTpDKEA+6y8FgyNwh3FxViGUbbTiBXdMIhEqiK5OLqvkYiiLttvJb0f46goiGpgsEpSMoV8xcL7RseQ4viZbBWR9wR8Vl6ujNk+OBMh4u6te4mHC9F3YqopHZHIYMCasEXFPOkALfPXziQMKK2ajB5JbkKpOctmey1pitDi09rDGrpe2Sqi6a0cuc5a8bz35ghFoDM4FQ58namMSgIqe7IsOcSl6LMbs/5N/ZyKw/jZXrBo1omnuBvxLxsBFFk7nQ/NDyLfTRjyMuPBO1MFyRsSlyAGSf1rA88brSCIZ4pGTUQ/T/ou4AisbunSAW4x61nrCjgh23pkcS0jMumc+F51FnOLe+FLzVK4cZVzk3KKqHn05OVAqxIJMuZlK0mF1fV7w01JOUNSBsj6/b6nqKo6GWoRfkOGTDisXql+Vv2brFhW5t2+gh0JDTKaEc8MdWdZgZ4kG5xlHo9Fiyd3CIjCHyt70tMmOEbbxQtZFkHGGK4CtdjDnRBEcEcbGY3cJSLXCygOoyOiq0istqJXNcYAKfp//w+PmN4SkKYZI X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(376002)(136003)(39860400002)(366004)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(6506007)(6512007)(86362001)(38100700002)(82960400001)(26005)(2906002)(6486002)(6666004)(478600001)(83380400001)(8936002)(8676002)(4326008)(41300700001)(316002)(5660300002)(44832011)(66946007)(6916009)(66556008)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nab4PufFx4m47keVWwHtsTLrnknPR+jzmUl5BwJmPtWRmc+X8F+dtJ8QCvnb?= =?us-ascii?Q?A7SDBUFRoyJE7yY06TnaZCFceZzGth8x0CfsQm4RwkXBo5EJYMkENwDXN0Bf?= =?us-ascii?Q?QjCcOtyM3VVnXrIbdWtDMY2xvdGNuVDmB34BaHq6Yl5fleL/u0flJ4493oG/?= =?us-ascii?Q?df+tsUgHVWShwOyNzoAslTwEfZjS+QMJhLGMePjnlw4Xb3aQsE/iRxJPg6Y7?= =?us-ascii?Q?84gmQ0mkT0q7wwpBHkSL+ywpb1MqCvYB6qFxXuqLLbcFnPtZxX3SUesqnzkh?= =?us-ascii?Q?uKBqG+eKCQ8qL27iuj2KzhLzXNv2HbEPX79aGzwnXZEChVezySUtJgiaszdw?= =?us-ascii?Q?CXEmBfQoM/fbK5/jENGEImC8/asvd9LcNzTaKdtPjY9gFXc4uGj6YyZ7MzVV?= =?us-ascii?Q?ht2/aN5aEm1TUPKopk/5W2LhF6mtDmBYgs6hcmdNKioyUG2c72NXB64DcktP?= =?us-ascii?Q?DiJF4vdMIGGy2AC1zkWgh72bXvKvyouDXeF73ZujiHO1njXS/y4wru/2gbcN?= =?us-ascii?Q?OPwDSBZWhN2LiIDvPLHzWxWWVXzt8N04ie25Zb87RGJM2OSTiJ9vRyOQc8YO?= =?us-ascii?Q?d8y1FmbPsWUcmly6GPOF5EPIT/7n8jH5pUjy66jvW5BpkBZKc9g7s2DvO0mJ?= =?us-ascii?Q?IXnl0g/WwA7QlpN+btk3+OtJprhkf6KfO9DtD7R507yFuQT/ar4x7g1XqJ8o?= =?us-ascii?Q?IoQEvzrZQHrv4czXGCkSCcp3qQN9Ud8gwK3hu89ONIk3i1vwg8dpY1a13rho?= =?us-ascii?Q?QJw8gNwu7nKZYMPy2n8DCoMqk4OE0qr5szkgVfUBnxJgvm8pq9HsS9P6RDp1?= =?us-ascii?Q?a1VhkYYz5U13UiO0xd6XBMTHEU3AiHvxVTQQCfW3izTJmXWTkLC3D/Z+Tr+t?= =?us-ascii?Q?dloB+yk5/VpVT7jZBg9nHtZCvDaHsbDxrF1JWY7vFHZKX4JWX7A58ZxLTdEQ?= =?us-ascii?Q?xiw1yQkTexFZkusFQ6/DgWaUnUau7HcQQk5tNPgXrbcS6w+7PT4sVhM7zDVm?= =?us-ascii?Q?z4XOqW87nT2rDbO8tzsqG7xnj6Dl/myvyp7BQh8UM9TJGXUrRj5d3diuGIYU?= =?us-ascii?Q?uI9ujcrkrXBxBguUi9HLxfBnsbQyhae6S0xPmt8pMwN9WOmNy5YufhLlg+CW?= =?us-ascii?Q?TPa+1Ttp8aPBm5KXyQWaLH97ukLuhkhJtL2kQQm0FxdwmhqBRqGW2QUZjsT4?= =?us-ascii?Q?0Qiv3MFPSro3icz7GPevgNkeXXhl/9eo/gCYXz519pYDjALjG9mTXEv14t/D?= =?us-ascii?Q?nfCO4F+TZmnTzbybdsT58MiS9tNfl6RAS8VcxJz+OBbFEuEsyo/cQD3H/ab0?= =?us-ascii?Q?f9pkVxzJFNrlGjTGVC0H6J4OMViTdRonnUgmo8lrUQZsZM4sBFtVNUZpNV4z?= =?us-ascii?Q?+jCccSvPpYWSOga6KfA2p8uENeh/x5k0dFDRghSAgmvwpi1QjE7+9eUqisXE?= =?us-ascii?Q?9IlcYbS7Q06UF5RB5BvlXVFjutP8tJoNxMovcNzssiVj3Nia4C1ua5yMVPLF?= =?us-ascii?Q?nHCdAsje1B0VSdqgYodMJSj5lCyYu1DscV2vwG35wJQMdQp5d/geFNA5EZfg?= =?us-ascii?Q?avtvb3HkARpDAwchYd5NnjUAgjVdDuTKtn5QLQIaGeo7iRTZdLoQQV8Rg7c4?= =?us-ascii?Q?uA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bd501ac6-b327-4dc5-6d6f-08dbc59b89e0 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2023 12:06:43.1678 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BzwiRuXjXIjCOwTF8ZbGHfHbZtSG/rJmWyjJxLZrgH8cdb77kqEjFVY2hvTesUA6QdBsEJr4fvCclTBV/EL4FhtbnfUS5+F2v1GiM8Pkigo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7411 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 05, 2023 at 12:51:00PM +0100, Bruce Richardson wrote: > The event structure in DPDK is 16-bytes in size, and events are > regularly passed as parameters directly rather than being passed as > pointers. To help compiler optimize correctly, we can explicitly request > 16-byte alignment for events, which means that we should be able > to do aligned vector loads/stores (e.g. with SSE or Neon) when working > with those events. > > Signed-off-by: Bruce Richardson > --- > lib/eventdev/rte_eventdev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > index 2ba8a7b090..bb0d59b059 100644 > --- a/lib/eventdev/rte_eventdev.h > +++ b/lib/eventdev/rte_eventdev.h > @@ -1344,7 +1344,7 @@ struct rte_event { > struct rte_event_vector *vec; > /**< Event vector pointer. */ > }; > -}; > +} __rte_aligned(16); > Looking for feedback on this idea - hence the fact this is going as an RFC. It seems to me something that should be done for performance reasons, but I'm not sure if there are any negative consequences of doing this. Since this is an ABI-affecting change, a decision on this needs to be made for 23.11, or else it will be locked in for at least another year. Hence me sending it now as an RFC late in the release cycle, rather than deferring to next release. /Bruce