From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23CA84263F; Tue, 26 Sep 2023 09:49:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09BEB40277; Tue, 26 Sep 2023 09:49:00 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id EF50D40271 for ; Tue, 26 Sep 2023 09:48:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695714538; x=1727250538; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=KPlLaiTqql75WdgAynXSWjwfVEH6QB2MuV0Y/1rXqaA=; b=GRB/F6SUKVw+F3511cbOKdZfOxnlk+ZqpWJ3tmRMY6KgLORlt9OkByCY pDalY/OF4NAU9gnmQ2CeCH5L0QcMcAkSUEkbveSLc9Fp+ZYnrfFHkpRe8 nWWwAHBh/H6B+ScG8Spi/ETryyL8nfm+JjNLZ9hB25WgxJG9659Mj1vVV lsrq5zXojbTXJIvtUFCQoJQtNjCmSZa6UrFncSvhA3/a+/ZcwAAS0joeW 2CS8vlgGQSA3FhGbILEw+hOWORllHTqBGnoo1r3qxEJDfW55Zn5sw8B8X HmjDuADrRobVe72+BShMukyDRZ5ns0XhjSbd+vGkMc3uKW+JADMIjy81q g==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="371845005" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="371845005" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 00:48:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="748730285" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="748730285" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Sep 2023 00:48:48 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 26 Sep 2023 00:48:46 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 26 Sep 2023 00:48:45 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 26 Sep 2023 00:48:45 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 26 Sep 2023 00:48:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NPkkX50z8kJ9u+3yEjuUxoyfVUuWtOx5mzlDA54J3TwrbuVxOBg4WUvMPVQVNJ/FLop+1K36Im6NXHGxMKp8jt28dDwFHn0XvOADSqg5GClTYJMmVClzRffSSVB9hiq70c+ETc0wKodoT+9Vu7exK7Vtx1NcEMicj4xtUYnshQtpaMF1XHY8ReeDYVlrf0JzSzg7K8XrX/N39jmG0RTuHiNUkqYjz+nzufMvWNI4GnqRsNFepxltMC7pLP+YccG4jgCZEnJhR5iDk5Emo+SoTFGzC0L3h1MDIoFPkBSyXEWVrRDeJ57UYtEdw/ubekjOWDAfxXV6QiM+NcS5PAWiUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Z04h4PaZY2R8FHu781IvXFkMrDGwXBW0zdhEt9SUDw=; b=Okku4urgpt+3bmopU5OKMPvRXo88VBgLByVroT8f1fmXf58gkKlCcJ6Z+x++CwME2LV5xsQ9TxUdsH2W5WL3IdL5IVWWEDjOcJhzq8eHfgKFSnNlYqKq9k4XUy3k/Ooz8TrJaJdU+p4JhvLEUJ6JYhg9RieYEorlK7p4B7gbTEs1WlE59aMFuK1dA+vz9nV0qkszyBEPqKxft507yKtTtqxxwypKchjnPCvTVwkaWMhXrD5rBKp4V4SStTv7CAjpCSRXgZ+pqQyUQr5yXOemoL96rtWm9hhcNj4DMGecbiQ8HcEYaXadbZiRtU4v82Ijn/V2apM4LdlzJErNSANWuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB8163.namprd11.prod.outlook.com (2603:10b6:8:165::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.23; Tue, 26 Sep 2023 07:48:43 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6768.029; Tue, 26 Sep 2023 07:48:43 +0000 Date: Tue, 26 Sep 2023 08:48:36 +0100 From: Bruce Richardson To: Shiyang He CC: , , Liang-Min Larry Wang , Simei Su , Wenjun Wu , Yuying Zhang , Beilei Xing , Qiming Yang , Jingjing Wu Subject: Re: [PATCH v3] net/iavf: add devargs to enable vf auto-reset Message-ID: References: <20230811094043.200995-1-shiyangx.he@intel.com> <20230915130249.425790-1-shiyangx.he@intel.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230915130249.425790-1-shiyangx.he@intel.com> X-ClientProxiedBy: DU7PR01CA0029.eurprd01.prod.exchangelabs.com (2603:10a6:10:50e::7) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB8163:EE_ X-MS-Office365-Filtering-Correlation-Id: 729e6320-9ca9-46b3-7e4e-08dbbe65017c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kk85acTxDkGfJ5KSrHmiHkFudMhjs4OvCeg5WfRdqO9JAABIa1Os7s1sXf24bZn8AmhZ6KgKaUctaJQr8oWBmRy9jRjLCqUKc70CRu4WWmZDBVx+dn/YrnM8n4fnXLTmb2hikYY4BgMOGZAiMQx2AsGAyqnSeuy1WZRXVCx3nH8zYBrq0ZAOvgR8JyqoQgHjJKWsNJMJozKaCNU2ha6SlWCjFDbMDQHg++dfNZ30iKyEUGYDkU0WwVdmZBAf2vZPOj/aicw2YKPWCpF9gQ25tiBmSJU+bbARSmtiKK882/Dyg/xPY//notOlSng0YKZ/q3IhBX2m/uPZ+l5WsWye1OxhnTM/lXhdt9GQv65HdDi6A6cffv9jCXSlmnYI3dKFMmayF+fHszj7heffRRn39LOCJWxGZpYCzGgHqzcXW1LgoTxTIqRgN6P3vDm7I+czr9VgbSsBynH1CWzG/hykmFu6tEOuFHF4KkNXIPIpRDwynIBVXUQDPqtpv1x7VUtjgC0WBi63O0eR1tcHmew/EZfqLh0ZMWkBByznLIcBeNSSjcpGhQ/bfNyvk9PGcOkK X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(396003)(366004)(376002)(39860400002)(230922051799003)(451199024)(1800799009)(186009)(38100700002)(6486002)(6506007)(83380400001)(82960400001)(86362001)(107886003)(2906002)(478600001)(8676002)(6512007)(8936002)(6666004)(41300700001)(4326008)(5660300002)(6862004)(66946007)(66556008)(6636002)(44832011)(316002)(26005)(54906003)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?VuPrK17wCXRKdoGaTDDrnS3NOp7eAA0tuQX/AY/2KjthxfReQ9xLgoZT/h?= =?iso-8859-1?Q?b+0GvP5J6Ns+XiT0C70mD6q07EG1mTIcpnxdFpGsp34w3opB44/vTJKlEM?= =?iso-8859-1?Q?V7yB6+VzarJbCx5vWJd56m9Q0W9tACNZ2ONBH4cuMUFNgW73aPg9JCHAo1?= =?iso-8859-1?Q?C8kFpdmSvaIKHfs9bjUBTl9GWrHipKq3IbRm2aXWExKgWCD1wgxcTPHREE?= =?iso-8859-1?Q?1NDA58o4nSbdH+L9h/hF3fDuO97OcXDQoOwubuTR1W5x8iHa2h3Nh5VpK4?= =?iso-8859-1?Q?EV6w4xHUn/5jh6iGZ/cUvmisnyTo1ZdPU7tT7MnzskAtToRrC7D93SNOQ2?= =?iso-8859-1?Q?WIR+kQXowmd8sr+xw2NoTXENOSS8l7aYsIypER3qPyrKsApIS6Gjms9WMR?= =?iso-8859-1?Q?CLFUO/MR3QcLAHtPmwggmUgaHlLmSy+tv3StwLJKUOYQghkuc2Br/yLfYy?= =?iso-8859-1?Q?DRNJyO9P/MlvZQNiDrcdck4APYXEwXeBGjV6PEOgSmeZkO8Gj7YKFwa8Nj?= =?iso-8859-1?Q?l/TN9h+X0UZHNSLItDESkwIv1ky6A9roqh2iPflg6gV4n2JG7JbQMcZLOS?= =?iso-8859-1?Q?ykzh883lfKKf/E07BrDfFC8DDMGXsULnURSzFg3XRwZ6IycUrUcZje4BbZ?= =?iso-8859-1?Q?jfxm50ggcb5RczuoHEatSj1mpCZgyhVVJgOVi4PRjJuEpCJ5ACy2yRAZHT?= =?iso-8859-1?Q?yvj+Hs1Lv9+4ejRmGwklG1ON92GTJKSHzUvmKsivYla8Hb1H7s+0EQ5IqR?= =?iso-8859-1?Q?5Lti74/iou0crEKIZJ6FQNcS/3eYuywHP5BllE4MYLnkVW199sXmYUSRd5?= =?iso-8859-1?Q?xuUIaBnKc9HhGy3LZSIt/sMFKuGV0pjFqDrv+GBVkvpD8T/QwqTMFV9t+f?= =?iso-8859-1?Q?gnYf1vjAurj8jb4b7/k+R+DcAu+nTboa4JWWM4ZOQCsKyTxvRnozfDOEkK?= =?iso-8859-1?Q?qYV/ukxQWzGSZx98vLKB2FZjMbeQBe3AKvaiepb3fdnPeqSLCoRV5M1WoR?= =?iso-8859-1?Q?iASDdGgEzyAYrjJArbcUG5kw/Q/kBEg32sEPohxokKQOaTutxgRzkz5mDT?= =?iso-8859-1?Q?rvMlBZfJgem41YqWNKUdFLcIRnsRko1Q+HfnkPgvjdgOKrkFmKwc2XR5Py?= =?iso-8859-1?Q?pXVGwwvYXafxbtz/q0OZlpGwmowsDyDUikf4l3FFZNS2b7OLjToBkRuaOC?= =?iso-8859-1?Q?pd6IOOiaHTU0ZBdxzS2pV7sfNI8gra2ogl4dzubom7qj09Y27R7T8xxGOn?= =?iso-8859-1?Q?/ero9aGcKgE+ikMN/3nb/ZVGXJk3M2G8y7u7wEjwgASiXIngB7QEIBYTHG?= =?iso-8859-1?Q?A6o2N4+ZbMuyGxV7Onjhr5yJVRiyCqWeUAI3BbdCNOW1gVs+VdG7Q1zjLN?= =?iso-8859-1?Q?HJkvJyKrXHvjKIKcju1QSOlyjizcznPKU53mweFU/eH+9freS6NgA0vfDy?= =?iso-8859-1?Q?nmW6TcGR8v4tff9qtZYyMtvCnsGU7HHjRUy2NTAFjblzj/XWQV+tp7PU9V?= =?iso-8859-1?Q?nV7eitnxiX3bRDTWjp7Oq7hBItpt5AV/67H3KB+PPYFNOJ2H55jCm/POSA?= =?iso-8859-1?Q?RNem59KD/bMyjqeDnz+fnVepg/wgOlMxPa/Q4sa94zHJvdXYYgGkpvHWnD?= =?iso-8859-1?Q?++ZFjMCd79Jyi4d4AEU1qfnj+C9sAODwlcys9m0ongudiH4Hl3+vcK9Q?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 729e6320-9ca9-46b3-7e4e-08dbbe65017c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 07:48:43.1959 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +nP/bPg1xJ6gYEXkCGJz3QBm/6HUmHtZdjwT4FcSPF2VFhuXr3Wz4XzSrw48k8oIhmNhsxx+w6q7u5NMfcaI76vWniBC3Ah1r9XPBw6stxc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8163 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 15, 2023 at 01:02:49PM +0000, Shiyang He wrote: > Originally, the iavf PMD does not perform special actions when it > receives a PF-to-VF reset event, resulting in vf being offline and > unavailable. > > This patch enables vf auto-reset by setting 'watchdog_period' devargs > to true. The iavf PMD will perform an automatic reset to bring the vf > back online when it receives a PF-to-VF event. > > v2: handling reset by event handler > v3: change reset process > > Signed-off-by: Shiyang He > Signed-off-by: Liang-Min Larry Wang > --- > doc/guides/nics/intel_vf.rst | 3 + > doc/guides/rel_notes/release_23_11.rst | 3 + > drivers/net/iavf/iavf.h | 7 +++ > drivers/net/iavf/iavf_ethdev.c | 86 +++++++++++++++++++++++--- > drivers/net/iavf/iavf_rxtx.c | 52 ++++++++++------ > drivers/net/iavf/iavf_vchnl.c | 11 +++- > 6 files changed, 135 insertions(+), 27 deletions(-) > > diff --git a/doc/guides/nics/intel_vf.rst b/doc/guides/nics/intel_vf.rst > index d365dbc185..c0acd2a7f5 100644 > --- a/doc/guides/nics/intel_vf.rst > +++ b/doc/guides/nics/intel_vf.rst > @@ -101,6 +101,9 @@ For more detail on SR-IOV, please refer to the following documents: > Set ``devargs`` parameter ``watchdog_period`` to adjust the watchdog period in microseconds, or set it to 0 to disable the watchdog, > for example, ``-a 18:01.0,watchdog_period=5000`` or ``-a 18:01.0,watchdog_period=0``. > > + Enable vf auto-reset by setting the ``devargs`` parameter like ``-a 18:01.0,enable_auto_reset=1`` when IAVF is backed > + by an Intel® E810 device or an Intel® 700 Series Ethernet device. > + Why do we need a devargs for this? If the VF is unavailable - as you mention in the commit log above - should this behaviour not always be the case without the user having to ask? /Bruce