From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EF844265E; Thu, 28 Sep 2023 10:42:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AAC340273; Thu, 28 Sep 2023 10:42:50 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id EE5D840150 for ; Thu, 28 Sep 2023 10:42:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695890568; x=1727426568; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Aia2u8unpNIu1Ncl/7FiswypUcDSLAMxloCrloEpCMA=; b=Ne1VIiToRXuBCviFff1HmTLGH4y1K4Tlc7r0v3fOoDe/Utn/1an5Wadj 5JK5dpzn4hg16wBgJ0Pn/6hNAqB0hKKyh4yiToCkWsPwDd96xwfNwPW/Y SW1ZyYYJNxrLSG1tn9JBgd/GC4hqq7y7vibLhzl8o58xjF5XqALZPi7jP W2yLWC4nIEW+NuYuqAFMH9wj0JoWrUhMks+YLaQqhDzIYyEOmIWkDkC/Q 9uONak8q2GxBbzyK7X4Zcg0gF7axbmvp4/ikKqQ4srdhmIsdGo9Pm3x1P ibz14RU/gPxkE1NaMKJOL1xmFvM+Fo969wO6DPPbKMgyLkMT3N55TSNMB w==; X-IronPort-AV: E=McAfee;i="6600,9927,10846"; a="362255887" X-IronPort-AV: E=Sophos;i="6.03,183,1694761200"; d="scan'208";a="362255887" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2023 01:42:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10846"; a="873223482" X-IronPort-AV: E=Sophos;i="6.03,183,1694761200"; d="scan'208";a="873223482" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Sep 2023 01:42:45 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 28 Sep 2023 01:42:45 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Thu, 28 Sep 2023 01:42:45 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Thu, 28 Sep 2023 01:42:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W5NjOLK33z3eHIq4E+B0EPpswVSGSasya8oQKl5kUOL6sCuv+DI4PfSHgejy7zjJeIR7F+69gRtc1P5rKrfLTYbXuOrIPfnvPTui4D0hZhrOMX1zSxwY0nqrAZWFmU51EUFlh0tnrZwWlPnvtEQJkGH4PbH+8d0ozCNai6C1IYFS86Z8UhizysnNp4HYxVpMFpwD8ImkcjnElMvJjIIkTy8uw4Ga2wu0p3W6z2/ohzXOIrfBQKzQM/Va1+DkmyI38XfouEF2fqf8lNrAcdvdNqzeqRteLmpI/UOp7BmKFgdh9IKc2CWlv3+9fx9DCm6dIr8hbm7Q3xPYRqQkpJ76LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9P0/Hr+YxhnjY8kF/CbVrYEKfv5MzPef4xgtj1vWsJY=; b=bQOwYm61n0VthnmG9wVFCvdhRhBTXXDzAYxgf+W2tpxLftPgc5hO8Zqv75vqDmMTJA0VhvVtz8SqzD2vMJi1lDjMkaQLqvh8QBqv33gOWHvUWl52SYRB4KV19zSK5mdl/+j5kstqsr8aNw54Qz2J7h+yuDvKZcNRefm4b80d4ui0bhKQkoikerP5FW85zbUNU4Wsi/9X8q79cbVCEqR57xocGXguV3bM9LKDrnuk8l0WP9oAJDBepMXY7zHLzUHaXnPaAUfrv5NUTrslc34uvynFwog+St21JKkGgBPMYOffxCHbP1NC5Q44Xnl+Bco59BBumNdAlIaw9q4ExQuPig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) by SJ2PR11MB7669.namprd11.prod.outlook.com (2603:10b6:a03:4c3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.31; Thu, 28 Sep 2023 08:42:43 +0000 Received: from CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::1049:683e:132f:e690]) by CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::1049:683e:132f:e690%7]) with mapi id 15.20.6792.021; Thu, 28 Sep 2023 08:42:43 +0000 Date: Thu, 28 Sep 2023 09:42:36 +0100 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= CC: , , , , , Subject: Re: [PATCH v2 2/2] dts: reformat to 100 line length Message-ID: References: <20221103132926.445627-3-juraj.linkes@pantheon.tech> <20230926121013.23351-1-juraj.linkes@pantheon.tech> <20230926121013.23351-2-juraj.linkes@pantheon.tech> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU2P251CA0014.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::15) To CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR11MB7290:EE_|SJ2PR11MB7669:EE_ X-MS-Office365-Filtering-Correlation-Id: f7040587-b5b3-45f3-6f4a-08dbbffee1a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uNDMZuwsf36ldPaDF05uP5QSaUgkDhhU1fcZF+b3+mKRrbI1QElXefyk5+6/iK5JFOztRcgjHP5dfDSAtd31TeVjS5VTLrdQpKm8Fbe+s0xi8vAzA2/eOmyfYjPQ9nyur7EEMpYwVkKFz1EyBmuHLbrUL9mod3H6GzANwzEDKf6RVtEHHGgv2CyLh6nxbk6RFQEs3TtSSgYKLWxpM5rTp6n6ryvRnWHgmrQohOAILwNC4NaoFUQjnAYSLgHC68kQzI6T7wkusnKzlutkzaK76cZ1pL7zdTd8gvUCVjXKHmzvj8e5jdubLhr5WqmupVo0762RMlhayy8hvj11evpGJzV4wNGFwFCZi7+x5ZGA8GI95+zf8xGggcvLopPecmXb9wVz/j7nxw+0lMsO1GYh+2ddH3V95gJU6dpzZ0zcyMvHQ1j0lI+3SjV9ZESKOqMsaMXturKIDccfHQqqgoGpnZQFiwEFNWoZnelBec5urIK+Z+8pBGCDpLrZGPt41Y/knODLgJJXXopIVnDnsPStSv7lMyyij+e8BvCafiEKtikI41wB0dcst3/BaG768I7C X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7290.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(366004)(346002)(136003)(39860400002)(230922051799003)(1800799009)(186009)(64100799003)(451199024)(6486002)(6666004)(53546011)(6506007)(478600001)(6512007)(26005)(4744005)(41300700001)(5660300002)(8936002)(6916009)(66556008)(66476007)(8676002)(44832011)(4326008)(66946007)(2906002)(316002)(86362001)(38100700002)(82960400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFlzeElsQTRtRVZUMmxyMmFiekVaZDhZN2t3bzZkN2NSU0hXK1B4WXRRcnRk?= =?utf-8?B?NXZkbG8vWXBKUXVaWTRDWTNWR1h4ZVNBVlhjcXB3RVVHMzlJZ1EweEhMamYw?= =?utf-8?B?dnpIT1lHK1pWQnRWUlBLYnZXbXNJMG9Ma0s3OFoxNWVQR0ZnVGN1a3k3NGR4?= =?utf-8?B?RDk0TVdCZTBFalhUSzVHb3J2TzBRWVJLUTBVYS9JaEVLcTA4RjlHcDBkcko2?= =?utf-8?B?bzVqZ2JtSkQrTUtSUjJZVTliQ083VzNUM0FaZzRHOENFeG9HRDZYemM5cUh0?= =?utf-8?B?bGFCOFhNV3lqRnNpOTJ4cThXdXBVQjJuUkN1TlcweTBsWHgxck5XZEZXVUNZ?= =?utf-8?B?RjBXLysveUx5aW9SRExEdm5NaG9UTE5WVWxPdzVvcHNBSGFOMFVOcUg3eWFs?= =?utf-8?B?L3VZMlFWeFNqOC94eUhMdTE3U1o4NWtwUkxoUzUwUE1sZTFKYlVNdG5xVDBL?= =?utf-8?B?UnJkWlhQVFMyQytNVHhPSEVQaWtXdGhwOUlZaEJuM09nZlc3RFNPVVdNbkNl?= =?utf-8?B?Y0Z6ajZCVWdMTTdJL3BkcjlIZmZjSlVxWjliWnZuT3hwRnhxdTlTdGZybVNU?= =?utf-8?B?YzB4amVCc29POTkwTEtuRStaWVBkTlNSd053TDEyaEs1d0RGbWpBWk9mMzdS?= =?utf-8?B?ZlpRNktxRy9HbFhMMFJCMTNwaVBWMUNXV1VRNUpQekJFbGRGS2tBVnBMZXhK?= =?utf-8?B?UlR1cVNKS3pRYW9DdmR6c0pMQkN0OVg2R1c0T1A1MUhUL2Z5VUxNTUVuSEs0?= =?utf-8?B?UUFyUWYxb2daQ0pWYjMxSkVyMHQ1Z1pJRHRHcm1tUnZaaG0zTGtZeU9WM1VU?= =?utf-8?B?QWxtUUVYSjNZSkVvZlpCSzdRMDdWMldGbEJkMFVaWjc5NDRSdmFPdXZ5Y0Fy?= =?utf-8?B?VHNKNUxaK2M2cVJCV3IzK1BobUxFdXQ0QkEwd2VqZ2dRZkxER0ZGVm4xOUc2?= =?utf-8?B?SEp4L1dxeUpBdFJ1cWpOWCtJelNpNzNsNHZKV29KMHNPVWxYMGl1UFhVcjVv?= =?utf-8?B?RW1QdW1JZmk2Z0lpNHkwa3ZnRHNmVFMrQnd5Q2JvZmhXVHY2UUp2NkVYL3pU?= =?utf-8?B?OHFGR29TVnBkYzlUd2I5WmpPSDh2M0MzeFJ0Vko1RmlnSWtrRjZEeHEwR1R4?= =?utf-8?B?eDFZczUwRmFUNng2RGk3SktZOGtDTVVDYndoT1N6TFNrUEd5blM1dXVHSHJV?= =?utf-8?B?V01oM242NFQ5YTNRWUJ6VVVoR2RkazQ4bEF5RFRtQ1ZNM1I2cktWdXFwRlR6?= =?utf-8?B?RlNIWGV4dnRNR1J0MnMrR1JtTUJWenFid1FrWkwxTFc4SWRTWUNBY0xYdU8x?= =?utf-8?B?R2NrYWs2Wm94Rzc4Smk1WHI5RWw3MitjSmt2MGlaNEZQc010UWlwdWh1TU51?= =?utf-8?B?VUp4SEdXcklGVllOK2w3dlh4cGZtYzVJUnZLQlNvZEV5SXNqRGkvdkFneGJP?= =?utf-8?B?K2YxQlViYytpNUltb3pwSEh2WUNSVStVVFFWMmhKYXl1MTJLZEZFMURmWVhC?= =?utf-8?B?RlVScS9renI5cXNzVFBiTE96Ly9qSk42UmhLWHpsaXd0OWZpTUh5OVdJaEdB?= =?utf-8?B?NVRFL0hlNWg5K2MwQmRBaEdBUDc5dFRBZTU1SHJ6YTRiMXVBVXh1VUswL2M2?= =?utf-8?B?MlZ3RE9uR2c2cVhORFRlVCtxcHF3VkhvT29iNTdpSWQzcFJwOExpTnJUNHZn?= =?utf-8?B?K0hWZ1l0MUxMWE1KTjVzclBsMm5scWU4bzhqbUh2ZEhVYUhVdXJhZlAyREFn?= =?utf-8?B?Vmd0MGJSRHg4eUlJckN1djNIVWJ5ODVoTk1paHlYTWUvRWRKRXlVaWF3K0NP?= =?utf-8?B?V1E0MUVqOEZBR0JhNjZsYk9FYUU2RGRzSHJnNHdidUtkTTRKcEhIbVdlREpr?= =?utf-8?B?N1pXZ0g3MWFkSHdveDhEdkpVYVovaTJmVE1CQTFtdUFHZmloMFluV0FTYm9F?= =?utf-8?B?VUxwL3lHMGJwckZBY1RUVFBhVUZqN0x3VUFESk8xck82bzdhdDZhTjlaRlFQ?= =?utf-8?B?c0RrbnpReGExNm4wN2VoQnFpSHd4OW5iUTJabGVXOWQ1QWFxVzRDMEpBcnNW?= =?utf-8?B?cVAvMDVRN3F5QXNUekJzZStxWGF6MW9BaGJzZ0NQc1hzdUpITWpxME5xQ3dC?= =?utf-8?B?M2w5UmFtaEZwN3VlTS82SVg1TFNIc3FlUEpleWhNQ2pkOVJaTFVjU2lmMnB2?= =?utf-8?B?Rmc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: f7040587-b5b3-45f3-6f4a-08dbbffee1a4 X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7290.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 08:42:43.2135 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uHyUO5AcSuzrivlviZBDvGUyHJonVSlmqkGfDQmeg5Sehxw1/XWIHS+DNUIANwXS7HoDucWQxwjurbxPIKtvqhylzPXDQMd2snIcPaVnEcI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7669 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 28, 2023 at 09:33:55AM +0200, Juraj Linkeš wrote: > On Wed, Sep 27, 2023 at 10:08 AM Bruce Richardson > wrote: > > > > On Tue, Sep 26, 2023 at 02:10:13PM +0200, Juraj Linkeš wrote: > > > Reformat to 100 from the previous 88 to unify with C recommendations. > > > > > > Signed-off-by: Juraj Linkeš > > > > Generally for something like this we wouldn't reformat the existing code, > > because it confuses the git history e.g. for those looking for "fixlines" > > for bug fixes. However, given that DTS is so new in the repo, it's probably > > ok and worthwhile doing. > > > > Acked-by: Bruce Richardson > > Thanks for pointing this out, Bruce, I'll keep it in mind for the > future. For now, it's kinda necessary we do this because our reformat > tool, Black, reformats the whole codebase so I think the pros outweigh > the cons. > Agreed