From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C05A54265E; Thu, 28 Sep 2023 11:55:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABBF640A75; Thu, 28 Sep 2023 11:55:59 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 7E6E5402E2 for ; Thu, 28 Sep 2023 11:55:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695894958; x=1727430958; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=cC/Mwe3SG3aydHJDKgIm/JNNUWlaSadhmRId7Ub2FW4=; b=VwvQnP7VWM99N7S0AYWUePTTgzYI8sl84rhi53tWlDYIoDFhbCv/cFrF FqomQWXeuagqW5M2z7CL86DUJIJqK1EIoldfY7MMMAUs88ESFIpECs4Jx 3hLYW2kLE6u6f8rzQxMehtQIhNB7lzjEVsOFA5lGtCL5OzX2UrM2BMCX5 ab2gVyvNAvdHwmesGuHpOE4rN34ndXPO7B66ftbX8cnW4PfuElH11kldL aN7uI16sYdt1JPa8wmv0IZ/PYtcyp0YQDt06u4bQ77pjby8vohFWn2R8J hO1Ed3bgAIoAiiLrqSxq8RtijXXUe07MMxQEoW7RVMwqkIkmcRZ2QmlA7 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10846"; a="380899596" X-IronPort-AV: E=Sophos;i="6.03,183,1694761200"; d="scan'208";a="380899596" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2023 02:55:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10846"; a="699207426" X-IronPort-AV: E=Sophos;i="6.03,183,1694761200"; d="scan'208";a="699207426" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Sep 2023 02:55:57 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 28 Sep 2023 02:55:56 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Thu, 28 Sep 2023 02:55:56 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Thu, 28 Sep 2023 02:55:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EFZEjIOn3u0UTL8ngAG1UDMPeK8M8pUEvVjpVvfQejt0htEZrmOB9nGMFLMFakRTh6NHT5mnCKO/OkF4IryYLMrEG8lqfZeshDXfr0/VGrwDTQrec7YHgu8y84/xyrlMroS/21E3dmCy6tRaRnbOO1KQ03MH2XsZUqAofmKimNMW3lj3HVIEU2rNAf7N45wG0ItB2U/4uUo7VkfNL1UCJNnQMBBjXyoqu+VN2LiwH7ndYgfJcVU0rTOxvD3IvBMPUTTfTdMaGT6Epp/CUxg8eDeQuGv9bDyGT5lsJx9J5N2cMM8bknSi2Slb9s0OW7Ust2HMDeMrZDXNEjClSdGGSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RNpxFspJ4VA5v9OBPQapArd2BZ2V6lCU8k+sa7166ak=; b=IH2WW8GmdwR5YqQLUWLBQNDzvPmLtmbO6DMRyhiDvX5qKLceQcNAnBCjLOwsa8RQi/bvYf36+81lZitsUepoW5wHD9+2oSnUt4urY62Ah7I3SICNfTAOnAyZB+44/qOvToAKMet80rMTejNVZVLRTra5iYLXDgcbb9ov0GZXSSLjw5QCAKoGC3YhX2ENQQizTJhu6i8ByPEB5g1uNPDk7Vwv3YMw+/AYWuad5Z5+kWSk4iE727D0fUhnU5VqMldSn8xC8qYK4YOoUuZ/VCs5H95y81H+Hc7NzHegrBvnJSPJWyGQW2K+Uz9DYtWOBxJ+yzrdNjLkr7h7gmfN6lDZJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ2PR11MB7548.namprd11.prod.outlook.com (2603:10b6:a03:4cb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Thu, 28 Sep 2023 09:55:54 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aa85:ead1:baa8:c652]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aa85:ead1:baa8:c652%2]) with mapi id 15.20.6838.024; Thu, 28 Sep 2023 09:55:54 +0000 Date: Thu, 28 Sep 2023 10:55:47 +0100 From: Bruce Richardson To: David Marchand CC: Akhil Goyal , "dev@dpdk.org" Subject: Re: [EXT] [PATCH] app/test: drop dependency on crypto scheduler driver Message-ID: References: <20230928092639.162449-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0050.eurprd01.prod.exchangelabs.com (2603:10a6:10:469::20) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ2PR11MB7548:EE_ X-MS-Office365-Filtering-Correlation-Id: 72fd5dbf-ef10-4401-ae29-08dbc0091a89 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0fge6KqWzgrbqyMVF+FXTTFZW/iBpGbIiLNjVtfQYFXtm8rq3X8PvJuF3T60dVbeCRNJHA8DwyIy7QAn0D2GkMvPWA3vxBacsGhxtsctuY0wLRmHpqH7rYbOpLEWqj3tDZeCSCSB4LnBSkMa5DKz4xMxiXTsf78lc8fQ1snIh+0JL3cKHLbqtFkIVfQ5uQ399yoMI9uBVuQXGJv5epLV8kUZD2D+i31eceHPcvBPPSATFBk3cEW/gf29nl1F6OFzcFysblt5Rr2xedZy05AwwVrCSgpdMjBCQY5Fz/vWgSArIM+riZ9r9ZQviMSa3hTycZVBpkNChJbzs+yejx/9z50sqJaV/DydkPf3CvSNgY7KQfnKChWsrJ/ROx7e0XStH7RDhVxuj0ceaUxzXJKKRHkeO64sy0L1SADxfpF3o4nmGCdB7+mQ8CVHWbfZhoe6//kQO99WTVRZf7wJT8SZcnlbOPJvPIadhqJ55Zgf4IdhPMHC3/bG6mCM0w7CfiltLsX///w0KqPbGnqeIs54cB+s7lT/GYO16cCHvoAUtwd445aVzgE+WDztc9W2aAlB X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(136003)(346002)(366004)(376002)(230922051799003)(64100799003)(1800799009)(186009)(451199024)(6512007)(6666004)(53546011)(6486002)(6506007)(38100700002)(82960400001)(86362001)(83380400001)(26005)(2906002)(41300700001)(316002)(6916009)(54906003)(4326008)(44832011)(66476007)(66556008)(478600001)(8936002)(8676002)(5660300002)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3RDekRENDNucllsaERqdHZna2UyK3F2OGlkOVlCR3F3N0IwYkZlZXZ0ajRx?= =?utf-8?B?bHQ3UDJIbU5makV4OWpndHZtY1dDUDZRVXBuSTJKamgwT1RWYmdMZzZZZ1Vk?= =?utf-8?B?L3ZwZGwrSEoyRHB6ZWhiUHVwV3M5Vm0veHRZUUFib2svQnZnR0Z1Wjh0ZUJV?= =?utf-8?B?QjZXTnI5VlJUNktGWEtleEpRNnU2K0M5Wnd0Slk1M09KT3FwdThLZnJ6MUJh?= =?utf-8?B?SVhWZkJKN1VlRlJYTzN0ZTRoNGFIdXpyaFFKb1IxQjMvdUFHcGlQeU1EQWxO?= =?utf-8?B?dlV4czY5V3hveFNpbGlDVFdCSk5HbUNkcWVkY2hCZXU4Rnl4cThvb2pJc3V6?= =?utf-8?B?QzB4dXU0RGdPTERlMllqd0FuWTM5R28xNFczVFJ1S3pEZDl1cFJpWit6Rk0z?= =?utf-8?B?aVZqVmJEOHRvWjU2WDRucDZVNUNXY2wwVGxDMFd3Y2ZxT3hsbVNFamNldUFX?= =?utf-8?B?RjlvMkpBYWpJYUtHdWwrUnltWDNJd2Fwc2RwTzY5SG5Yd3hISjE2c0xGVmZo?= =?utf-8?B?aXlUbDkvbkJwckRGajZWN2xVNTFhWDU0S2JkUmNFRzZlemNqa1Q1aVE5MWhW?= =?utf-8?B?QUp6cXVMVWhiejB4a0I5eVh5ZDdWd01LL0ZLeVVnNk9DQXEwTTl1TnlRanNk?= =?utf-8?B?Y2dvYXgrYzBJYjlWdWl6MG9ZTDBoYncyMUJsczdRYnFiazhYcE1pTDNjRFJa?= =?utf-8?B?RGdzTC9VQk1pd0xBWCtOM2hZVUdhY1ZjUkZVRmx5SE1McG5NdkZvNkZvL1hw?= =?utf-8?B?clhkSU1oQ0dMM25wVXZkSTcxcVN1U0RCTHdsMTNqU3BEd1BwMWRPbUVWRzJh?= =?utf-8?B?Y3RKSGc4UFpDcHJFMTloc2RCcHBHSUJsNEwzWjExRjVPMVdQSGV2SGlIQVdp?= =?utf-8?B?T1FxRi9tbVNtWVhsYjBmZjcweWllUFJDazJxRjYveTNlVzNNUFhYMnk0K1J2?= =?utf-8?B?UEVPNElnR2I1WHcyTjk1UDVHeFB5TmpqRFFIcWxCYjBKNmRmNERmOXo4YWFT?= =?utf-8?B?VUZSd0gwNWgxK2x4TEZYNFdEd2VFdUhiblI3M3BDK3VCbysxM0E5TWVmZ3ll?= =?utf-8?B?NHUxMkd4NEpDaTF6VGhLV2hiMUlzZHhtQ2hkdXh1a1RDdzFMQlBmcWNRSWRY?= =?utf-8?B?aHdWVUp5UEcxNGh2blFmQ1pKUFkrMEFma3F2emNERks3bHF0Z1NwMGtWc3Qy?= =?utf-8?B?QkJDQ05KZkF3MU5PRnBYaDBobkg4YTQ1SWU0VzZMZ3JBS1FCa1JGa2xibXkz?= =?utf-8?B?N1VtZVF2dEcxZUhDMUg3dFRFR056aU8va3IweTdvUngxYVVaUmJxT2dmNGhY?= =?utf-8?B?eC91dUwwdG1kWEhGNDJpWmtWYXVmSnZCTWhuYnJraytwK25OcTdLVVp1NkJO?= =?utf-8?B?dCt1dmR5Y2U5QjBUM05GVUJjblplK29BaGJGQ1RLd3BSZVBXZEEvZ1M3V3FK?= =?utf-8?B?aDMweGFpMUN5UVNGd2MxWlVkVkovK09SNnlDY08xMW1sNlJPRVdQY1hwNzhY?= =?utf-8?B?ZjV6WTJsR1lVTGNhdi9OZ0FmcXhIVlMyNEsvbitVRi9UeEVVYXMvWXd2Nmo4?= =?utf-8?B?YW56ZGV3c29obVFPL3ZKVFRVa2VVYkFuakZaaktiNDY2Q0pzOUwzYzFJekRu?= =?utf-8?B?ZWowNmdtYlpvYWF4REo0eFN1OHNtZDI1RFF5RG56SkszMDdwWUR4MUFTVkFK?= =?utf-8?B?WkNTd0R4MlRNRjRFa1ZiV1I3bmFFSHQ1SzdoaDdXRzRVOHFqTHRoWk93RnI3?= =?utf-8?B?Mm5JbWFNRUFnL0hZU0UwYTE0V01MaDVodk8vSWlUMCs0bWd4UnR6WjN3Njhj?= =?utf-8?B?T0JCUTVQRmcrNjF4MlFNNndweUh0L3RnWkZKb1NzZTE1MVZhTFVGb1BVV1p6?= =?utf-8?B?aG1WMkxJVjVUSFJobno4REhLaDR5SUxWaUJUUktyU0RnU3NPd0JHbXhYYkhy?= =?utf-8?B?ZTViVHExN3ZoTys1UXphR2JhN0ZEVldXaHRHQ3V2L2NCNVpGN0dYeFkvZ3Z0?= =?utf-8?B?RG5yMWJBUUpJYzNHMVlaOGdZeHVEVjhnVXVGbmVlREY3dktDWFEzekhZaTlU?= =?utf-8?B?ZnpCVTZXd0Evakp2YjBNc1llVkJUR0VzeDJ6R2NqUEtHUnhkbVlpVWIwSXNr?= =?utf-8?B?WlZ0dXNjbXlQQ0JSeXBFK0haQVNVWmo5L2ZVWXBGYjNubzJ4ZDdkeGJvd01h?= =?utf-8?B?Unc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 72fd5dbf-ef10-4401-ae29-08dbc0091a89 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 09:55:53.7234 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ecWkXK7mSRdXkB/QGMNJiHznPXV/0+Rp50B+LoeF8E1sXANPCDuryRmm90CLYe8ag5lPZEH2wb6WrxdP3kKRoRgEhlXqbo1jdVEUppm5AuA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7548 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 28, 2023 at 11:45:37AM +0200, David Marchand wrote: > On Thu, Sep 28, 2023 at 11:37 AM Akhil Goyal wrote: > > > > > The cryptodev autotests make use of the crypto scheduler driver when it > > > is available, but build fine without. We can therefore remove the hard > > > dependency on that driver when building the crypto test files. > > loongarch CI does not seem to agree, can you have a look? > Yes, although I find the error reported a little strange as it should not be including the header if the component is not available. However, first I'm looking into some other issues I caught post-post of the patch. The dependency tracking is also not correct after this change, so I need to do a little more digging to fix this. I probably need a precursor patch to fix the dependency assignment for the binary, as having optional dependencies means we can no longer use the dependency list for determining what objects we need to link against (and what header paths to search). Instead for the unit tests, we should just link against everything we have built. Please ignore this patch for now. V2 set coming soon... /Bruce