From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E6EB426A2; Mon, 2 Oct 2023 15:02:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 34A2D40294; Mon, 2 Oct 2023 15:02:17 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id 41B6D4003C for ; Mon, 2 Oct 2023 15:02:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696251736; x=1727787736; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Z6W+hoeQmyAulgxdTQvxQiSJ8YXHciM8EYh8MgKD3DU=; b=FOZQMYOQxZKU1U82rB1c3/peDwRGYy1BXyCRK4lJpqwfxAe4Wyo9kkqx w1r4zth1Dokw0NY5t3m7g+QnafUVjjozTx7dyL8ryrwG1H0l+2yt8cqvT ptvXBl4FDgS+x8UuO1qF8arLzsqdDYez7oI6K7CKB8Uyb/e5pasVnNt9S tSPUJtGT5fKROfTOmRUZMDut3PA3McI40XFY6cXP3akubn+w0Pc0QjWGC 4AUzzKhxKOq3j5I6ne59auxMH8YsXhyD2h/sBdmKjlremy0ZZsliefMKU Is9ndfBlq1J/iuRW3sig4ioVOY/HG88x0mQ/plqS04j16/WGpJCZqzF1N A==; X-IronPort-AV: E=McAfee;i="6600,9927,10851"; a="1218210" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="1218210" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 06:01:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10851"; a="700340075" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="700340075" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Oct 2023 06:01:47 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 2 Oct 2023 06:01:47 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 2 Oct 2023 06:01:47 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.47) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 2 Oct 2023 06:01:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iE3pLuhI3VhihNU8uwOozgbNPWORBIgEQZaTwO+nHfSeABttOnD7SZdtkh0a2xzbaEyiHu0LWE+HshQGnw11xQJBrbT0Mi95tQigTuZ7Wp6bZPCEZRXBLX6j/Yh9fNyWTM8sWqU7g/Rn/bfGarUHU3qvx/QdotAclTGiZnYrrpyBDhmmuPMdSVSC69xKfpA+QpaZPXyt7NvNFEQQzoby+abF4NH2o0QMxrsR6TcBA8XEFWdqeRZtbR9NLUBpROio39Z8d+DxVyWO36Bs54KT5pwrPcTAv3o+CsEXAYCykdvCSe+BnImT6bejQiqipbsZThT2kjREPEVJFNM2g25PlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1xmEFZLaciehb6LKUap2cCnRQheXegumGgUHYplP9IY=; b=eqzRzQOCtZv1LL1lZeTDr683KQsBHALhMUDyEbUaQ92ivEob8sAupUspg1qyGREfFBleLGvbctdLn05cCOgr3btaAzm9F98RRmIPIIZHQUPxhFNynjRQxE+c60fBnIbUxwfDx10vSRKnkHLvFx1hMuY4VvbN8d3yzkIG1jrBn35MHjxHZCy5yE4iPSEMBJ75juRQX3xdHuIIrdnx+KOCAVHfx2L2V2N9t4UgqJOzODnYbUzCWMQhilJMeBZJUPG4hGcF4ZXhUUjMUpMwdHSn8F2KETe0KzXcgrBv0N0FdqU7jfj6ONNSG+u5CezyYwaGyxc7gfD1BvRD3zgigedZtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) by PH8PR11MB7968.namprd11.prod.outlook.com (2603:10b6:510:25f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.31; Mon, 2 Oct 2023 13:01:42 +0000 Received: from CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::1049:683e:132f:e690]) by CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::1049:683e:132f:e690%7]) with mapi id 15.20.6838.028; Mon, 2 Oct 2023 13:01:41 +0000 Date: Mon, 2 Oct 2023 14:01:35 +0100 From: Bruce Richardson To: Shibin Koikkara Reeny CC: , , , Subject: Re: [PATCH v4] net/af_xdp: fix missing UMEM feature Message-ID: References: <20230928092553.339452-1-shibin.koikkara.reeny@intel.com> <20231002124852.76374-1-shibin.koikkara.reeny@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231002124852.76374-1-shibin.koikkara.reeny@intel.com> X-ClientProxiedBy: DUZPR01CA0083.eurprd01.prod.exchangelabs.com (2603:10a6:10:46a::19) To CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR11MB7290:EE_|PH8PR11MB7968:EE_ X-MS-Office365-Filtering-Correlation-Id: 9eb6e631-8d9c-446a-5a11-08dbc347b8ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YF3FwF32ICEk3TdluEK7q8j4LvPcFX3Sbnkq1bXP6wudEQ0vZIjjL70OZk6v53hP9XUwhzDL5x5vG6oaP9i2ZwUhCP/sYh5q2CzCZLARMQOI5HDHSb/DED3I8LxmCGdjf9BtmBajQpq3uPrv/ip6Gl391tduM/mpkWNPW+u+kwV1dVtHbV5W7O8OwKpPtU0YlrutSrq9+Ksej3e+zFuXdohPoxEzcy98+rwPpH7gpV8KTl/g0yN329w0lZz3UM+RbJsFwhc1wwTopYNay3Nu3r0bj6BrMBQEOPGGitUnxZFGNBKFM65Ze1o6jZPBAOCoZzyia5iTr9Z4Gf1o+9d8bhGDGBXUazTfyT2bHCaUnUS82Ovw73Xu6J+0ZwD4DUvBJ+4+10hKcf0eiwTP4Uo7lvEX+QNa6cceg25QkShURFSloGAZpo32Mul7uCpioQbkLz+tziuIj9rjg2TaQpdmxh7bZwoe5q+lzr+ZRiU0qNtNGhTEe3yU+r+OaFvNYaYxv6+XNlMLJsPUeH3Ohx8+kkIUWR7dcb+J5dHEgiNAM20= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7290.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(39860400002)(346002)(136003)(366004)(230922051799003)(64100799003)(1800799009)(186009)(451199024)(86362001)(6506007)(6666004)(66476007)(44832011)(4326008)(6862004)(966005)(6512007)(478600001)(6486002)(66556008)(66946007)(316002)(6636002)(5660300002)(41300700001)(8936002)(8676002)(26005)(107886003)(2906002)(38100700002)(82960400001)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NAADs3XW0x8Yxsp0ChYy6M90SfKKwiE45C3AC9a/L44eFkK/1ifyDzVsM6yO?= =?us-ascii?Q?m87FBIYrSlLpv87k1oGm5KrlrO5cui9ie7lfFiz/AeYrLZ69zUatgFsd8UjU?= =?us-ascii?Q?EhyoxANmd2AX3Eo9kksp1rFMTYcSo7wj6rTR5xqPaFRXtrBvneXqpXnyuSPC?= =?us-ascii?Q?CSGhpWCsQ4zcQluMZ4O9jwazQqDqdKo+BZHsK3gCAF8uls43eLQGLdrZhV4x?= =?us-ascii?Q?SSDdmvqrbQscvm1Ma24QdPBbfqZjHZXLKVaMnLcz49qamTK/owtOBP7UirqH?= =?us-ascii?Q?VCuGt6h1c2K3kEdYCm23qqONU6hYMrOrw7FF8jYysgfhuPN2x+e5cYjBZIc+?= =?us-ascii?Q?iXgM2OwLufdlrggY8Rn5dLhPCrspUkv+xttYFY8pa7VAcQpbYa4gWnvgz1Qb?= =?us-ascii?Q?CyEzcrYpwtnduQjDLsxsuOUJQc6UvAcJRoDcxw7gNmlwHHF1n/DA+vAmDQKC?= =?us-ascii?Q?5Ev6LILIagXIQ2SVoehUrClL51qY1cs0Ch2khmCMrZzmNp5bP0ZD3iHSgj8i?= =?us-ascii?Q?WTL9sid/Ug3gU+1+vtrLkA7UqKxmVIkOYcZlsPNxWXj0Us55y8u4w38Pc6Ur?= =?us-ascii?Q?PXidGclJVOiNF827ngLnxC4hduNY7np8183PQeF6uqU1xogqJT7DJzgNwfcS?= =?us-ascii?Q?OYv+HcTlaNjFKIkX88+Q5JDw6enCBup3RePP15GTtKR5eL/MxwoD9/wWLoz2?= =?us-ascii?Q?8Ih08UfYDytL6NfUqGD93L/A5XkLtnabMfECe+Lz1YsXSsULj8k06BHAM/Es?= =?us-ascii?Q?mh3dJfab6VzSeed1YrH4t67XFmbxYD/3qjsV4sxMoYQ9xz3Cw8FnZMNP74ww?= =?us-ascii?Q?qgkZL/RBUGWA7A2oFsc5WWWNvFzvstl3o1GBU+6Dl+yp8odseBpOAYGZum+C?= =?us-ascii?Q?t8+zD/pWnajvTv2ylaaULEYHTSMWivxXI72/kExmuxsQoktzitwzEf6DxCfx?= =?us-ascii?Q?GM0se1HYvhSgbZ55b84OivTHIGswnPViU9xnhY2CUaGgmSuZRWaK+EVXdEl3?= =?us-ascii?Q?99de8WjBEZG1Ze2bQ4eeBLOT+uLU/8gz+/E6OEZRpQZU3V9nIze7rI52hBF5?= =?us-ascii?Q?w+hp1KobiQXWvOmt1I0fZyY0avuQzCMf+7Nk3655IUo7tT9xoZIuZZJdrEKj?= =?us-ascii?Q?VJk7nNmaDdGGgDct2+PrjNMoYVYDjsFeep/jaowPgwFW1j/gFZEpjEAqwIAM?= =?us-ascii?Q?yjWVcsYLQzy1WkQfauJQxdGDZu+8TvpdMbBAOl2J9fL+seO4Qh5C5+dCB2wA?= =?us-ascii?Q?7jCRDoHOGzkH67nQciAw3KW1GLDm0gySg5a2+2kXKW8jChX/rh4fcOcc0BHW?= =?us-ascii?Q?5rXoQ9I0xGSWDUhfTTDy2zyidd/pbeM2w/CRujKb0DDqaD8LjsDyHYQ3fWJC?= =?us-ascii?Q?aE6OCUPG8d6Ypz9hS++m4U3nAdb06MwxqsDF/uKplznTvybfcmtYDFMkgv4a?= =?us-ascii?Q?IyQOyu6hVEv0dX0pugRMWsxTlGrqcapqhm02ufyidkqGSRr4Gs4VYamzucMm?= =?us-ascii?Q?SpZzy1hBfdJHi4b95YCW9JK6sk2vI5OHmorTjF5VqzmMYWeSw4EL9Tpvlcpk?= =?us-ascii?Q?dMP0wPeC4/YzSUTVcGM7puftTVGfBCJ5VAzZbpQIcRxg25tfDG9I37VGdbnR?= =?us-ascii?Q?Fw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9eb6e631-8d9c-446a-5a11-08dbc347b8ca X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7290.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 13:01:41.6473 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YaBIY6zhfRXRnRGnF1H/d7maPvavxLJ+c3j8g3+EVa2IAQ6TR7eXSCfnh80OAoYskIQfIqBOGyzg4DvwH5t0Zz8dmu2pKLL6QCPxLtLCf8s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7968 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Oct 02, 2023 at 12:48:52PM +0000, Shibin Koikkara Reeny wrote: > Shared UMEM feature is missing in the af_xdp driver build > after the commit 33d66940e9ba ("build: use C11 standard"). > > Runtime Error log while using Shared UMEM feature: > rte_pmd_af_xdp_probe(): Initializing pmd_af_xdp for net_af_xdp0 > init_internals(): Shared UMEM feature not available. Check kernel > and libbpf version > rte_pmd_af_xdp_probe(): Failed to init internals > vdev_probe(): failed to initialize net_af_xdp0 device > EAL: Bus (vdev) probe failed. > > Reason for the missing UMEM feature is because the C11 standard > doesn't include the GNU compiler extensions typeof and asm, used > by the libbpf and libxdp header files. > > Meson error log: > In file included from > dpdk/build/meson-private/tmpf74nkhqd/testfile.c:5: > /usr/local/include/bpf/xsk.h: In function 'xsk_prod_nb_free': > /usr/local/include/bpf/xsk.h:165:26: error: expected ';' before '___p1' > 165 | r->cached_cons = libbpf_smp_load_acquire(r->consumer); > | ^~~~~~~~~~~~~~~~~~~~~~~ > /usr/local/include/bpf/xsk.h:165:26: error: 'asm' undeclared (first use > in this function) > ... > /usr/local/include/bpf/xsk.h:199:9: error: unknown type name 'typeof' > 199 | libbpf_smp_store_release(prod->producer, *prod->producer > + nb); > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > Fix is to provide alternative keywords by using macros [1]. > > Fixes: 33d66940e9ba ("build: use C11 standard") > > [1] https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html > > v4: Updated the commit message. > v3: Used alternative keywords fix. > v2: Added original commit causing the issue. > > Signed-off-by: Shibin Koikkara Reeny Reviewed-by: Bruce Richardson