From: Bruce Richardson <bruce.richardson@intel.com>
To: <pbhagavatula@marvell.com>
Cc: jerinj@marvell.com,
"Abdullah Sevincer" <abdullah.sevincer@intel.com>,
"Hemant Agrawal" <hemant.agrawal@nxp.com>,
"Sachin Saxena" <sachin.saxena@nxp.com>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
"Liang Ma" <liangma@liangbit.com>,
"Peter Mccarthy" <peter.mccarthy@intel.com>,
"Harry van Haaren" <harry.van.haaren@intel.com>,
dev@dpdk.org
Subject: Re: [PATCH] eventdev: fix max link profiles info
Date: Tue, 3 Oct 2023 17:48:40 +0100 [thread overview]
Message-ID: <ZRxF6NyfCZ+tglz9@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20231003152535.10177-1-pbhagavatula@marvell.com>
On Tue, Oct 03, 2023 at 08:55:35PM +0530, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Since most of the drivers overwrite the info structure passed
> from the common layer it is not possible to set defaults in
> ``rte_event_dev_info_get`` API.
> Initialize default max_profiles_per_port in the driver layer.
>
> Fixes: 162aa4e1b479 ("eventdev: introduce link profiles")
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> Please squash to 162aa4e1b479
>
Just wondering, is another valid approach to check the return value from
the driver callback and set max_profiles to 1 if it's set to zero by the
driver? That would save modifying all drivers and probably still fix any
issues. [I'm assuming that max_profiles == 0 is invalid, and that every
device by default should report "1" as supported]
/Bruce
next prev parent reply other threads:[~2023-10-03 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 15:25 pbhagavatula
2023-10-03 16:48 ` Bruce Richardson [this message]
2023-10-03 17:03 ` [EXT] " Jerin Jacob Kollanukkaran
2023-10-03 17:14 ` Bruce Richardson
2023-10-03 17:17 ` Bruce Richardson
2023-10-04 15:38 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRxF6NyfCZ+tglz9@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=abdullah.sevincer@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=liangma@liangbit.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=pbhagavatula@marvell.com \
--cc=peter.mccarthy@intel.com \
--cc=sachin.saxena@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).