From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E984426AE; Tue, 3 Oct 2023 18:49:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F4000402A2; Tue, 3 Oct 2023 18:48:59 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id A448740262 for ; Tue, 3 Oct 2023 18:48:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696351739; x=1727887739; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=ae8Glg3OE1dAColsUWRij293tSjddRBoBOS3/kfhK/g=; b=Fe9aMxQ9c+OpJJRs60n93Dbe1L6u9SqCAyZe4GeCQhoPV5NenPHpe7tR 3F2bs44BOw3VVf7XlpQmO18TkBtEg3j3Q7e+Si1UD9ygdTP5BD8pfu2k4 HLUK2I4csxHCzl+rjD037PSFniunB23+X+n98pxdyKU6AK5MASG2nR+qD MoQ4IULqwuJbxW5hf/da6P8URoXFvfuzJWOtn2cMWo1RaZEtw1kGkbbZE Dx1SqOQIoA614JhDIEQSkJwYC2VOEw4lTqd4gGEtQ8HwgcUX3MKgAQgSJ HPm1Y2tZkODyXJ4lTOaVQE+NWUS/7maCPNo7cmjSCVZFSUHbUVWH2zinj w==; X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="413835020" X-IronPort-AV: E=Sophos;i="6.03,197,1694761200"; d="scan'208";a="413835020" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2023 09:48:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="780372906" X-IronPort-AV: E=Sophos;i="6.03,197,1694761200"; d="scan'208";a="780372906" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Oct 2023 09:48:51 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 3 Oct 2023 09:48:51 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 3 Oct 2023 09:48:51 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 3 Oct 2023 09:48:51 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 3 Oct 2023 09:48:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OVK4+GuHiJYbnNDKZJEFMCY5XD5Z3LESDJwvG4TqdRDYF/uenjrhN6MM/v9w5UveH4WY4IFMJgNYAnOFs/WbB0u3Tq22Px5NugcXZ0SroOmb75zjWlTpfwVVDlq0zxlgyhmifcaM7Am+PQeXOOtUa8XAtt7liEC5h/4S1BkfSE4uEM1NcFcLcAPHIKPmBUvT99LhrU8H3qN9EdL+wsAFSiVA050tkadYrqoJTi+YJAWiE2dClpf28p8Gl1Bm83XCvUFCIi+8BD/hl6kgZtyCLpdrxMyYzVZEyJWWc0vyWa1VqZPWzyrnVpxmjvt8y8GTltVKP+qvVvptQ+QR5No49Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DhAIrPGcHL4iZs2ETs+bXsm2r7EePeILFllNlUbSeDY=; b=ScIOMzv427wE5x0Tc6ZKo7KI/WDK5vKyKOQbUfA5wgZRsQoGdfkX3W61P0lY8phwjQQuxwqKokeUUqCkCeAS5J7r0GDrHHwPTqMCz0S58AuZ80SMtnlRbN6f8kQDLplfWbsbnhHgPGVWFtGt+QLjcT/5XqUi9Ib8yTSIE7PsZ5SW2V1YGvyeZ2pionHW4PZJvHVHO7mXfaUx6WhfQcQ9pV6zUaiLDGuzHBzJS2PXdulFFdaPoxfsttj/eqpuPTlR/CNkdjo87I1hpQdMjMuo9ORpgChQjYD91FUUTH6VP+QjUh6CjnW2obFBayRC1w6CEP8/MwPljrRoRmJlWE7YPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB8095.namprd11.prod.outlook.com (2603:10b6:610:154::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.28; Tue, 3 Oct 2023 16:48:48 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aa85:ead1:baa8:c652]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aa85:ead1:baa8:c652%2]) with mapi id 15.20.6838.024; Tue, 3 Oct 2023 16:48:47 +0000 Date: Tue, 3 Oct 2023 17:48:40 +0100 From: Bruce Richardson To: CC: , Abdullah Sevincer , Hemant Agrawal , Sachin Saxena , Mattias =?iso-8859-1?Q?R=F6nnblom?= , Liang Ma , "Peter Mccarthy" , Harry van Haaren , Subject: Re: [PATCH] eventdev: fix max link profiles info Message-ID: References: <20231003152535.10177-1-pbhagavatula@marvell.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231003152535.10177-1-pbhagavatula@marvell.com> X-ClientProxiedBy: DB7PR05CA0068.eurprd05.prod.outlook.com (2603:10a6:10:2e::45) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB8095:EE_ X-MS-Office365-Filtering-Correlation-Id: e95f1ddf-9fe7-4a81-baa6-08dbc4309ca7 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: upSwEO1LUO4t1SIfrDrfkuMrWnQKXF3KuQkJ4dYJymEk2ajhhALKwJxivWtN8lWCuPJeCCjC65D0i2/JVDp/ZyHyhLwUxhk6hTRsFVfWNwM7563PnMbw3z/GlyVlk35yZpHrOLJXFP9aRDxEiidIJZ9FcxcWVWk6yk5RUo04Oea5vRefoqyU/lbLLql3MWznWks7CDet2vubNiq1Z7+aanIZ//TzmdnhwpKWKMsAKZLhwJzO/ASKkyAlBnDKqNdWIIfDHhsqfbkmQzxy+dohmXqlzx9Gkv0hLZ0GOxP9+2/8pZJ1e6Jb7yrjrCbIYYQSU9ryiQ8NfFPIx9Nd/xMxSVHKFex0mYR5y+F+TMyUn4EtvLXkx8b7kR7ru+uxGLum+khc0CsHRsC0hQsF8KkGqvZIhd4l+vFQO/jfOMsJPUIBhF5EnMHYHq/I2Hr7LkHGPBNDeOFShD2O4aJ0CwocuatbtEFxGTY4VbgjxhSnCd5nUCjTt0jvn22wmAJKurjgiBHhx+50pv8hs1YdTS3u+0yAEtOueYVcmNzi6qEN0oX2s0J0sBxtmHDlewy9OXFPVNEsV5twpwNUkNCk2a7bZILom1voAR5bAFW4SR254ic= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(396003)(366004)(39860400002)(376002)(346002)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(82960400001)(38100700002)(86362001)(316002)(54906003)(5660300002)(6916009)(8676002)(4326008)(44832011)(41300700001)(66476007)(4744005)(66556008)(8936002)(66946007)(2906002)(26005)(6512007)(6666004)(6506007)(478600001)(6486002)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?V6U/EEWT0L00bW3Aniny182bXF0zZYn5n0w8EDdY+it4oVMQpdtO4r2q4HhY?= =?us-ascii?Q?TZB+oTttx7SMNIAeBxtF1EQhx4XfrvOekh7Y21qFu0/+ot7HQSmmx8Xicy0D?= =?us-ascii?Q?MBG9s2UTD5BJKByFHIOeErfpMsTfzme/6Qo4BJgzeYotCraaioY1OZvpYmy+?= =?us-ascii?Q?NedY7WzxdQiOt1FUK0qr9p5CSUKB1yU0ULsBXZx/Vx91Axiyog2/m/B/mxEv?= =?us-ascii?Q?U24HhYJfhLs2GjAMsRuxBvu+4KRiM0EDHHmfm+a73DRljZ4MJBfnkw30GWD+?= =?us-ascii?Q?6F4o28m0JA+IZrznkJXbGydwmOxnYfuawnYR1iowAMhLIVOBS+v7CntzdD0/?= =?us-ascii?Q?y/I4ZadQgHHqkB984U5XUdcBYrcHovZjAKFEeogmYJI8AyQozDtK6UQgPgMj?= =?us-ascii?Q?7HIk41FGJoBUPZqdSrJWd3gNYDK+99dykwiMgDZRH4NOtWVjYisXrQZCg8MC?= =?us-ascii?Q?6ft8JkW+/RYE0ucphyMELYdVQ9/idxS/m/b8S5ftPSK+/e2f8CgfsCuQVcMA?= =?us-ascii?Q?4pm7Y8zr9r5NPqgKdboA2Slkmjpte7kHi5CecfarFERiZBQ0VGzfkf0t30MZ?= =?us-ascii?Q?umYs7R/sUqtqcgRDW8F707BIoRfvV5dDuiiiXag6zpYgxZTXTxXQPHknwJv5?= =?us-ascii?Q?cR9At9yXDzkT7eE+8OQDRiXS0PHyH8Wt61MgI/rm2nExaeFDBgyZ1KbJsiFN?= =?us-ascii?Q?iOvxkEUeYGCcaeFK/568pQQ8yEuNkFAMX0yDYc3GmT6UGDX4c90zpIZW/SuT?= =?us-ascii?Q?//G+xbjtMWf9H5CBjdmmpwMgWZdt3r0WB662+uYbzPKvbLFvwIjV/PINBJC2?= =?us-ascii?Q?bLECJ04BqZUIXRlIwA/6KbJbM82sIdCPs6n5akty/N9AZTHPgkSXOx2+gIry?= =?us-ascii?Q?feXBzwvVTtd+anD+Rh0RcK/k0YGiMeK4wc4Z/oDMupSTurTcHOdAtEE9lhfx?= =?us-ascii?Q?67JgwkqSYW2NZrwj9kPDz7/mN0VXQcE+TwEzdIHvTdz/QVtOw3Vst79TPx5K?= =?us-ascii?Q?6baNXvfWIr5MvaayFpoCGRT8mS5LKOQmcYXSSyZrZ6YDgyS6i2d5ySYbzfqj?= =?us-ascii?Q?yO6EHrAlWiuzwVsOeRzUxzFNgZ6jOToJO3PwN3DGonQI5fx2oi3YSCHIg2ce?= =?us-ascii?Q?KALV0LWWl3hcL8LQppr9k9m7dZZLZ/OLJ90bJFkRhB08OXu2gGvNcs2BvpO8?= =?us-ascii?Q?7Ix7vxSAW4DhytmMBCSPFj4m43A0az+qXyxpqDBLxm67x5XQjF6netScXnDq?= =?us-ascii?Q?4Bxzts4ZZqW9wBvWe776FZQ+YvqbX7aFS8nHZXx7YRx2LnVOYzHhejp1DhIs?= =?us-ascii?Q?cALkQk2HoXTW5LIrSkLVjFxD6CelCoJxgLw7R8jLHeT/ZVv9c/o4WvLHRzqc?= =?us-ascii?Q?jggWEQ1x9xwAWMdj6dUx/unPVsHHtybNlq1FdRxfBksLhuQXuxbeUI8HrF5x?= =?us-ascii?Q?/wwurJWR4xeNL/pFTEF7YHreZUH2IUvLHmiTwUDeywv3LrMWlnaTihu7S4aT?= =?us-ascii?Q?oPTzP019tZbl7u1v8w60dV1Kg7a0aR+vQDjoisOMwzsMyrdkwilSIkmVW89K?= =?us-ascii?Q?DHogfCGKsX4MCvFwYt7yMe3E6fyumz2KCu/oAKREnonuAD/68v4ke17hsXJw?= =?us-ascii?Q?tg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e95f1ddf-9fe7-4a81-baa6-08dbc4309ca7 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 16:48:47.0866 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5TTQIQ3Voj7+3NEjXW15uT/YbH/Bu6G1jq0kBvYs9lbAaIaGtfVkcCQVA/qAsz/hI0LIxMV9c/nbbNbPMYa/Kdfl9v1pQ9FkYQQru952Yis= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8095 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 03, 2023 at 08:55:35PM +0530, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Since most of the drivers overwrite the info structure passed > from the common layer it is not possible to set defaults in > ``rte_event_dev_info_get`` API. > Initialize default max_profiles_per_port in the driver layer. > > Fixes: 162aa4e1b479 ("eventdev: introduce link profiles") > > Signed-off-by: Pavan Nikhilesh > --- > Please squash to 162aa4e1b479 > Just wondering, is another valid approach to check the return value from the driver callback and set max_profiles to 1 if it's set to zero by the driver? That would save modifying all drivers and probably still fix any issues. [I'm assuming that max_profiles == 0 is invalid, and that every device by default should report "1" as supported] /Bruce