From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16871426AE; Tue, 3 Oct 2023 19:15:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F288402A2; Tue, 3 Oct 2023 19:15:06 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 0997F40262 for ; Tue, 3 Oct 2023 19:15:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696353305; x=1727889305; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=nVpc3I40ihaPWYB1owSVhqi8d+NK60mwbpplLah9ZSc=; b=BXBxPzsz5q69oahGTl5BrQ2ze3ej2uhWJcAGOln5xsV/VeedlR/y3GCF WZDIHU7PW+wjOcuxhLarQwsHczI7/9JoPuwN2myCEo5fPvlOfcZIVrLiq d0+EGfCYmF2vXQXKNZTpTg7a1RSu8auI+lbwN7PrGYWaQNW0vXjaUZau5 XaFcSjiK3Xj2yPVpSHsdzpUIFXZHRA4O363era9JsKou0eqqwBZbMkmwI 2tOCGLHcL6n29Dabc5sQl5K7fuRFi32sa7ZlV+GvLTyzkWb6o4/FErDZ/ gaX+1dY1//V50fcahLXSvZq0m23SdLJ7SP2qUAPz9VKE6anNjm5G7M0Xj w==; X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="469211645" X-IronPort-AV: E=Sophos;i="6.03,197,1694761200"; d="scan'208";a="469211645" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2023 10:15:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="821336742" X-IronPort-AV: E=Sophos;i="6.03,197,1694761200"; d="scan'208";a="821336742" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Oct 2023 10:15:02 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 3 Oct 2023 10:15:03 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 3 Oct 2023 10:15:03 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 3 Oct 2023 10:15:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zcg7hfAj9ZPLU37YWsbHBiqTQ8H94wJcfrpjWRCnzkuqg/wxfzGZ1olPh5V8dHkt7+2P3Ixv600sk4jZStzHYIGmOm0cNbesgVG74ynd7NyKIE3tbPCFgcFrM9WiQTpZySMe2qZip3WersBUUefiV4cyecjLa0FiEKA0yjGFGxha0djHEVigY58K/q+sOjLz7lx7vMxjRaGQF1nbEhpUl9wJrtPpLgT25tO6bRenthfzbubeIg215xKC1RmWC3WCOX1l49CUurHZf6BAbs4hyveVCkWqZXz4fTjILJDpLr+rFg/PNKne7HBfalpMlbPCgAbhQXiOuXXTNXQKfAqKHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vYIdMvnszJVjPyaU/wLwEY3v0xwyY+laqOEVX46sNwo=; b=FkbIMKAVsp4fZGiKqAM48EOHeuizwrUcHDU0Z8TePru1fxtXq7Hh2PzX94QbTc/mxNXPqKAlPLkHRNptOFby6PrlH3N2lHKNNV3JTRpeRR8TfSIrQSQGk32+W50hVqZpLXb5BS5xBrJvrfNLodJvrPCksGIpLpjkrJpU1abfpbKrbce4ZN95r3KeWWQKV6DeUptY3mASDX7FKEka4mgV5M1Z6ZjkoQsmQg7KVUE/fPbGwYc7OpSqiNz7Km3hEYhCxCMJ2BuMhRIwS3JxeXumnMdvkHM2lNqqUdHSw5xaWtJzv/jdvYP8zvSnH3bJzJDsZ8NGKIh6H/WYnSTNArmHyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB4827.namprd11.prod.outlook.com (2603:10b6:806:11f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.23; Tue, 3 Oct 2023 17:15:00 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aa85:ead1:baa8:c652]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aa85:ead1:baa8:c652%2]) with mapi id 15.20.6838.024; Tue, 3 Oct 2023 17:15:00 +0000 Date: Tue, 3 Oct 2023 18:14:53 +0100 From: Bruce Richardson To: Jerin Jacob Kollanukkaran CC: Pavan Nikhilesh Bhagavatula , Abdullah Sevincer , Hemant Agrawal , Sachin Saxena , Mattias =?iso-8859-1?Q?R=F6nnblom?= , Liang Ma , "Peter Mccarthy" , Harry van Haaren , "dev@dpdk.org" Subject: Re: [EXT] Re: [PATCH] eventdev: fix max link profiles info Message-ID: References: <20231003152535.10177-1-pbhagavatula@marvell.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU2P250CA0007.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::12) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB4827:EE_ X-MS-Office365-Filtering-Correlation-Id: a4d75d8b-3402-4ab4-9f36-08dbc4344606 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5bKoi/dO62jBBmV2JKwfTs3Rt6R5CwWhQGD+qOMpIgWqcE+iLx8Oot7xRg7Zdb6fNBSyeHrcS1Fy37sscwi7TjSuz0b8sQvNnGTkSdrYx1Xi0D2GEiDGnMBNb7U9GI1XkwY1c2AQVfJw5wEvUuyARZInKte+Oq4sTOauWizIYBmGzsfkxZTG0lsBJ1ArCHXnsQm/H1lDK4uFLPUcsLI1LPLQ2cg2+Q5pJC2v6Sh4/IDqdlLINshishD4AUSC0HXYGSD+4ImUUuYpj73rEdw2yRLngCr9vhXl2UjKCQD2CPLdP/5HlKnAd/mcl/KLcVFLeRoKNjFuMmGg4Hdkil2uckXiDqR3ogCLnJw6r6OQxgAdiaLHNeb0YxuNd2ySeataMYaom+6NJH4GyNbBsrYLxPQD82+sWbwQGfXpeVcxcYnjfmw8MADXbJvvJHsK1HuzSiulgWPVQx4kLNF5V1zxxponA45D8bBsURWxe95Otxr74R9s1qKWv2xnbF0ReMHMLn4HhQxOx4yP/n7pfidfLnS6NTyHXum71b0PIzxhkP8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(366004)(396003)(346002)(136003)(230922051799003)(186009)(451199024)(1800799009)(64100799003)(26005)(478600001)(53546011)(6506007)(966005)(6486002)(6666004)(38100700002)(86362001)(82960400001)(83380400001)(6512007)(2906002)(54906003)(5660300002)(66556008)(66476007)(44832011)(316002)(8676002)(6916009)(41300700001)(8936002)(66946007)(4326008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?O72f9WUiPbmPabD7FuqPQGl45+mTYfAGPDfWOsqaelR2Rz3OzgdY6VjwtN?= =?iso-8859-1?Q?H+nAxyU8KuitqM+ByglYOqXAknJVO06Eb08CwTn7kuTCp22G/LYyynDVXx?= =?iso-8859-1?Q?xyH7H2z1vZkfoL6Ui9Psa0+9zRvDDeDL+15WW8ga09wOA66oEXb61K6GHY?= =?iso-8859-1?Q?V3VfLR74pNUsMRV9ZCXZDes2uHPlTRFphOteG7LXY1b3csmodHB9zPPpgm?= =?iso-8859-1?Q?8iUltuYebtZZvKdT4XKumRAByhkXY0lDrfYZRn60Om2JsCKEhgjihPYkK1?= =?iso-8859-1?Q?YH0OXt073f7HXvrWXenTp0FlWTYCh688EMptJig5EMU0w0c4tGPTUjCxCx?= =?iso-8859-1?Q?jhGNqStGbJJ7BqQ46GJ6SB+qjT40shOrGzH/Idi3hZK3dqSns7u2ckjfVL?= =?iso-8859-1?Q?BMEiP4ZC7UhC+E9xiYOX6+oOjsdfU7i+W7vqawsZZanhpZj8Vm4zzlMmV8?= =?iso-8859-1?Q?3noMIIYgclTrqYruHJIjvj84MdFq5rpW/N7J++Nd1psR3zk/wWOJLP3wps?= =?iso-8859-1?Q?qFE+xaFocqE0oBVCqdZm/omx95+aDukSnVEynyWwRjZSoZdXMPQsqAS9j5?= =?iso-8859-1?Q?S/AIj7yQtgYCdXNU5Pm3PLbiRq6Gv11oklCbiqRsKe2ZqenZYaTAi6Xlzq?= =?iso-8859-1?Q?F7pPYvbNuuLtXTulguZa243rDceLa5yZbNqr4ojdaIVsiX88OmzFKcha9T?= =?iso-8859-1?Q?pG6V8HvGsxabVqATJQJy4qi3VP8dYea6imym0SJVb3iHMZ0HLeP2ikrgE9?= =?iso-8859-1?Q?fDleA9BhTBgcbKv6nwZ6waMZyrz3LsvkDO2s+2q/0oytVmy8wCz/9aTndK?= =?iso-8859-1?Q?dhuMvKnG4qNTJlv7uUVuVNrAK8hgR/3CMxZQKsFUIVLErESK/RoU9s3tyq?= =?iso-8859-1?Q?C6/YAeW0dGK04jVwi8cBgAxX9/gvZs42qOrUZKiaFn0BhshnmIXPsJnjRi?= =?iso-8859-1?Q?SGtgYUjHg/D8iYkgCC+Yu0Pd8XSTlP10tiBhssTkOpOh3h0ad858i8nm2E?= =?iso-8859-1?Q?xXlT5H+zYKt5yDcRykH1mNsn3QEF+vZvYPDtPYizbK38MO9yzy+mx54pIj?= =?iso-8859-1?Q?MO4WXprU0mHVr8NndVeOs0I9PADI7jS6kPuX1DlHiBZpyGOV0+UdDFNkGL?= =?iso-8859-1?Q?D3iC1FOyoA7R4kugq5bVCee9rNognTkXL0vHZnLdE2CONQYEqh9A+uuPNK?= =?iso-8859-1?Q?pUoeYYLIyuawUyDrzBFZGauTGMAmHP5cevTW54xdaIOxDCH+QaiUO+FDb6?= =?iso-8859-1?Q?od4voR7ZpJZtDkefx57Sv9/ZoyJfWQTfks/uVYYpFVIEUu1HCTjGn6pEJl?= =?iso-8859-1?Q?4M62sPWL4Lv/Gwg3ujSuajdcC64VhuNcLHy50JKBQ82T71MA22+TzWuZTC?= =?iso-8859-1?Q?k2oilvIihUuJSTOplJI5Xm/5rUZ3ZPyg/X/JbpmE+AqsGEuaYk3lo9UJPl?= =?iso-8859-1?Q?uop/yinx31Qw9g34Q0W5/QOusnICyQbxsr9ArYVi9q/7+2TS5Ft2WiQog+?= =?iso-8859-1?Q?hh+mpoEK3tvbSgi9blLpjjdVdtl9gqQePV+7g1L+lzfI1XZoDwZiM/+EpN?= =?iso-8859-1?Q?yTWEn7JX80wOsHtiJfPePOIrx8JSh/w+TC9R/M/hwrbZaRCiU+Y/tNeASp?= =?iso-8859-1?Q?DnTbPdRCOkZTU4ubIZ8ds+UD0P46Siz8WmHtU5rv5xUR0fK804oZ7K8w?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a4d75d8b-3402-4ab4-9f36-08dbc4344606 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 17:14:59.7821 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cAm0qN5QWf6kJHwl5HRDmnOU73Gg1jC3sKZ6vU3uJ49wXamKJpJVT3s7FWvzZoPAx+e05Dvya6Rby2LaxsfYekZupjdfS4Ny0H+oT5ib91k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4827 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 03, 2023 at 05:03:28PM +0000, Jerin Jacob Kollanukkaran wrote: > > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Tuesday, October 3, 2023 10:19 PM > > To: Pavan Nikhilesh Bhagavatula > > Cc: Jerin Jacob Kollanukkaran ; Abdullah Sevincer > > ; Hemant Agrawal > > ; Sachin Saxena ; > > Mattias Rönnblom ; Liang Ma > > ; Peter Mccarthy ; Harry > > van Haaren ; dev@dpdk.org > > Subject: [EXT] Re: [PATCH] eventdev: fix max link profiles info > > > > External Email > > > > ---------------------------------------------------------------------- > > On Tue, Oct 03, 2023 at 08:55:35PM +0530, pbhagavatula@marvell.com > > wrote: > > > From: Pavan Nikhilesh > > > > > > Since most of the drivers overwrite the info structure passed from the > > > common layer it is not possible to set defaults in > > > ``rte_event_dev_info_get`` API. > > > Initialize default max_profiles_per_port in the driver layer. > > > > > > Fixes: 162aa4e1b479 ("eventdev: introduce link profiles") > > > > > > Signed-off-by: Pavan Nikhilesh > > > --- > > > Please squash to 162aa4e1b479 > > > > > Just wondering, is another valid approach to check the return value from the > > driver callback and set max_profiles to 1 if it's set to zero by the driver? That > > would save modifying all drivers and probably still fix any issues. [I'm assuming > > that max_profiles == 0 is invalid, and that every device by default should report > > "1" as supported] > > I can think of three options > > 1)Change max_profile to max_profiles_minus_one as name Or call it "additional_profiles"? > 2)In generic info_get, fix up max_profile as one if max_profile is zero after PMD callback + https://patches.dpdk.org/project/dpdk/patch/20231003150829.8257-1-pbhagavatula@marvell.com/ > 3) Or Keep as this patch. > > Looks like (1) and (2) not very clean. I think, we can keep as (3) if you don't have strong opinion. > No, no strong opinions. /Bruce