From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AB724319A; Wed, 18 Oct 2023 14:13:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BD5F402CD; Wed, 18 Oct 2023 14:13:27 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id DBF9F40261 for ; Wed, 18 Oct 2023 14:13:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697631205; x=1729167205; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=YVlZod2wySlz+Dm0tae/nW5kGN3DsfMFZmsTqyLBq4Y=; b=FwsNDNJWCFOElkTvtx5e/Jc635y7njmyzXwnTCilm19VIpP2ajWKNqAB CPwvHpzag5dFqJhLbgHgwj27d4FMakKpRmT9FJhCz124Qgkm/fqPk8+qI XQUcJQi8H//koRUf84+3pbCumDgX3EoNaGuSZ3ItS5kcf9K9ELLl8XjCg StT8c2HR05+xnn6+FIC0oQYQTACmDuSWgbiI3/gdKuNWoNtjPs2w2h/Kd IdDgEVRmdp/3DoH97t0fab+uZnwhzVvOPHVbSlAHqbsXTkSu3KsrbS12h aGLSRrNBT+nNI+YA4YMHPzJ/7DuNg+ybPjAGntJ1W62kSzYamlSkQaLBu A==; X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="384881784" X-IronPort-AV: E=Sophos;i="6.03,235,1694761200"; d="scan'208";a="384881784" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2023 05:13:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="880220993" X-IronPort-AV: E=Sophos;i="6.03,235,1694761200"; d="scan'208";a="880220993" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Oct 2023 05:13:23 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 18 Oct 2023 05:13:22 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 18 Oct 2023 05:13:22 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 18 Oct 2023 05:13:22 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 18 Oct 2023 05:13:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CpXzt1WhzF8xpkXQ2zgeBlppKzN/XYF3AOBlrFhU/gpEO+xwiAgfQxpP3o23NCLclFoawgVrWDNHXvqpl/RQHEAoJhwfJXc2Vv/YYt3BJDoRdTAy0w53UBXfCpMvwFwW5sQjQwDeZZpFfojMQSreL27poodnC7REA4vDYsuw0Uj2b6SdE1O6AGBQy3uIAn1ZBkEgQBHdMA+6imEo3oq5k1W1cvegpAaM0cL7OHlfjee0PgXra8zKrWcxqI7d2GTCjYgwa/1x5vYIrcFuwEM0qt0+Bp3NilZiUwP5hi+ApXUU/RmYc2CGWvqLSTyVeyDNxw7xpAJ2GQFtyXNBpnCp6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2G6QxTCAC4MOMcFMXG8KAPIxSxOG5pUE4CHAof062O0=; b=lgN0c5FZouUEUcSIbmiULxYhC0ZqPqsrvhswmAlpA4cP6oJQMR7jxjs1g62lI1/+XoSLUXsNLXi+hGPpwYPHu33Xpx/owsXKfDOF+MnPBzMcH7GB1EkJT9tD+gNHP8YEK9D85Yy2awaRytj/9NPvLWaOoAcLrwSaYzxv6WXGKN9OulE+3AIHTHviBj4fkUnyqY4ddaUEgaAyi+f96mwMJPddJ3jS95tZHKmSbOMewV5PlnBAi59qgb072lAvLFdyOg65avmP/SzMYjmF+KoBFhy8YdXScLZpzrbolYWNHyuQdNRubhRyQcMVe6y/tZghZOmeN7ds7jp83n2gJp8gRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH0PR11MB5490.namprd11.prod.outlook.com (2603:10b6:610:d5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.23; Wed, 18 Oct 2023 12:13:20 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5%4]) with mapi id 15.20.6886.034; Wed, 18 Oct 2023 12:13:20 +0000 Date: Wed, 18 Oct 2023 13:13:14 +0100 From: Bruce Richardson To: Jerin Jacob CC: David Marchand , , Subject: Re: [PATCH] event/dsw: fix missing device pointer Message-ID: References: <20231017154532.152741-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0323.eurprd01.prod.exchangelabs.com (2603:10a6:10:4ba::24) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH0PR11MB5490:EE_ X-MS-Office365-Filtering-Correlation-Id: 643700b3-4bf1-4ff0-2bdf-08dbcfd39dc5 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 197+ychka1Qx5/mGMocNEfxvVXhdGI3BMTPKwbV72Egr7zhJ4pS/TNkfr9ez4hc7gDKJ7z+h1Wj3QoDtrwf1bZA1KZznYfrDFRZ5SBTbDxceSqiJFnAA+uKvT2AP4EOag8oqzaXpGckJNScdHtlNZg8VR1FyVxbF9Cfqvem4geDp0eiWL5kuCpx6qvJdTXaxWb20jGYnW/HlC8poYdm/+3lLseBegcOFMqxWuWCBEQxcbyG4P5rsh+r/5IEdVcOg4ZfZb+JpOxCUp55eJqDNIwN2dSMK9DVL2qcPJF4GdDQTzAFGDiccL5kFT3SlbOor3H447V6L0ibcvJgajJ4huk/F/C1eePeIsgSQfZEgHnzbdoOpc5wwZv4MTGcj6cU5K53DfffRgSJkSzcCPZNBvXY4IMlRjwGu2f4DYgq9t8tjz3mYvYbEi/6n6JDtGIuCAnxT6pjWMYKxS0i2KtoIngkm7m0uABlqmQX6bqH1gXpoIXyhiOQLArJMUa1rV+zo6s2H8xTfXILlehgfJmiQl/u4jZdfk/uQOjSvioaiA1lBFOPEpYqyyGtoJPFIp9yf X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(366004)(346002)(376002)(396003)(39860400002)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(6506007)(41300700001)(66556008)(66476007)(66946007)(6916009)(316002)(6666004)(6512007)(6486002)(478600001)(8936002)(8676002)(4326008)(5660300002)(44832011)(2906002)(86362001)(38100700002)(82960400001)(26005)(53546011)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cllmQU5STlVSWGZSU085bHJ2TlVTODFwR3RjZ0g2WWEyeHdFaGJkcFZrU09w?= =?utf-8?B?bG4rZmtIUDlrR0hrOGdKMWQ5V016byszdjNMYjRHa1Z6YVVERWhKOWxzQytC?= =?utf-8?B?Y0JneDFCOTZjc1ovSDlUd0trQnAvT0twRjNDSUNaNTV3YmV0L0VDMCs0eGow?= =?utf-8?B?dXBlRmRDYlNSeWdDV1V4dGpjWjRaS3VPNmhWTExYUGUrNHM0bG9VckUwTlpK?= =?utf-8?B?U1dOc3NWVTFmNzBPUTFTVERzSkJ3dnVuTXNPZXlDa3dyV0psVStiSzdNcXd4?= =?utf-8?B?bUpib1pQdnIxZU0wRyt2ZWhJd2Z2Z2VrVWdZZ05xUndiNWVrUDRBMlo2Zy9s?= =?utf-8?B?MlBXd3NReDFEY1dpeEVvdTRLVWtPSGJZUU9zbEdUbDBwbkc3SkRpczlMSEwr?= =?utf-8?B?QWFwYWJSalViMFZoKy9CbnlXWjF5bGJWeTVHRFBQNGNDdE5RalZjcjk2REF2?= =?utf-8?B?dit4OG9Dek5mYU5Zb3BBcTB1Mlp2bStXdzNqVmJueC9TcjhDMVNJc2c0VXJr?= =?utf-8?B?QzVmQlVDTm5hTFNWSDc4Nm5tR2d2NjF3UjF1Nm9vOTJ5bEdNYzhCTTQvM0Iw?= =?utf-8?B?NUlUN2EvQ2ZTdUlBTGRxOWNMak1sWTJZVmlMV1Qrb29tMzJBckMzc0xJaEpp?= =?utf-8?B?ckFtYk5OYTlaZU9lYkNXdmR6U0hMSWNuVDhRMDltdXZMZVlORHh4cnBNZDlZ?= =?utf-8?B?Ynh5YnNpTEZ5eDJuSnFtcTFyMjZTUnZQbWtsUVFOKzlwOWxzRGdYUHdkQXRx?= =?utf-8?B?d29WN3JyVXhZM0JRdkpoRENaRVB5VW82c25LanFEV0g3QmNNRldYSzQxeTlV?= =?utf-8?B?OUhaVEtSSVo3QmJRODF6TjZqT2t1b3B5NGY0SUprOUhCYTVFZWZBZUMzK0NN?= =?utf-8?B?M1UybHVLdGlqQ0hVS2tKSmUyRWFKUFpseDFnc25MbkhuYzJRWmtIMDhsMHZC?= =?utf-8?B?dTBxemNuRlJTakNYYldoQ1VoM3l2K3hpR2dUY3h4KyswOXNEd2VmQmdRd3VM?= =?utf-8?B?eVhNc1oyRC9vOWU1TTdqc0g1cGgxUkwxbFZlMlR6aW96L1VyUmF1SEtlYkp5?= =?utf-8?B?TGpRRFRWZzltNG1UbHVYbVd5eTZDOUU5eVNMYVhDVm00UllEZWRKL3BncEhY?= =?utf-8?B?dmU1RFlIdmxBUzA1N2NlM2ttL2FLdG5aalpNbzA3VTJIam1hL2tuWWtqY1VQ?= =?utf-8?B?akVxVG9LVytrM3RkbDhiVzdDNloxTmM3bHZLNEFncnJBR0hkdlBMN2pZZkZN?= =?utf-8?B?Rnd0ZVZRU1BlSHFZbmVzUUJYQldKcXZraTZsTmFqUG9IVTVoZW5icThUSTdq?= =?utf-8?B?ejgzWTMzTE1PeG5rWGl3WldTb1QyR3plQ3lIOUtMVmp3L2c3Yk1CVWFwNmxt?= =?utf-8?B?dXNlUHpsL1lMckFNUjI1eWFTa2lGNnhKT0NOcnZaQ1M4SVJEWkZCNnVvd3lP?= =?utf-8?B?T1dSSlE2dlpXSitFSlI5ajlObER1ZndNWmhOTnZTZURoMWV0aFUwa21QQkxJ?= =?utf-8?B?ak9aczN2SElmeWNoYUsxcW15MzVoMHhUVUFnZ3ZaUENSUnJ5cU01bTdyZ0pD?= =?utf-8?B?c2V3dCt4dEFFQmpWZGpHc3l2MUYxK3VkVnJxK0l4VzNldEhHVUt5eGVCUEkx?= =?utf-8?B?ZDJGcG5iNUR1M2lpOFJ2b0hZcUF2Zzd5TjdBb1dRdi9LbmJKd1Y4UzNyNXBa?= =?utf-8?B?Y3B2Tkc4TitWR0xkRTdBRXJoaW4yRjVQb1gxRytCWVB6RFJYNjVYVHdXUy9k?= =?utf-8?B?MnNPbnQ1OUowUUxvNHJpQkdiNFljQTViUjBuTzNpem1EQVNHNHBoUTljYkRS?= =?utf-8?B?b2FDbXBoMVZ4Und1TmlLeVorNVg5eXc5b3UyQWtuN3BkKzVySjFrei9BWVBE?= =?utf-8?B?ZGlNWmNrMUNiTGhhWE16c0ZZNXFNazdJYWZrZGxHdnIwU3l2Zk1jNVR2blda?= =?utf-8?B?c1E0aTdFS0UzK1pySzZYWkhZd053Nmh6ck1KeEhJQ2ZkbFc2K1NHeGI1S0Ry?= =?utf-8?B?SXhiL2VMNFZBelhLclpuanVvTHdmT3ZFZm0wcVJ5eVZQaUtaa2NTUEJQQzVG?= =?utf-8?B?Tmw4NE91bll4WmtnaXV3L1VCNzJwL0E2azJlVjVpNjlWNVdrVnpUT2hYRS8x?= =?utf-8?B?S3U2a0ZIQ1VWd2VVUE9ON29FQ1lQb0FOUmhOUkRIUUN5NFc3Mm8rQWs5alov?= =?utf-8?B?bGc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 643700b3-4bf1-4ff0-2bdf-08dbcfd39dc5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 12:13:19.9726 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ebJIwcdTGtDTjSdZ7EUhQeZKkt29IzaDjaTO+z6BILB+Gm00gSTmChlzyEsrj/V380gHBAqOqQL7qf2Khq2NP0j+JuggxA9Ag4IGRJpK/QM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5490 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 18, 2023 at 10:48:14AM +0530, Jerin Jacob wrote: > On Tue, Oct 17, 2023 at 10:21 PM Jerin Jacob wrote: > > > > On Tue, Oct 17, 2023 at 9:45 PM Bruce Richardson > > wrote: > > > > > > On Tue, Oct 17, 2023 at 09:34:04PM +0530, Jerin Jacob wrote: > > > > On Tue, Oct 17, 2023 at 9:32 PM Bruce Richardson > > > > wrote: > > > > > > > > > > After calling rte_event_dev_info_get() the ".dev" field of the info > > > > > structure should have a pointer to the underlying device, allowing the > > > > > user to e.g. get the device name using using rte_dev_name(info.dev). > > > > > > > > > > The distributed software eventdev info structure did not return a > > > > > correct device pointer, though, instead returning NULL, which caused > > > > > crashes getting "rte_dev_name". Initializing the dev pointer inside the > > > > > "eventdev" struct in the device probe function fixes this by ensuring we > > > > > have a valid pointer to return in info_get calls. > > > > > > > > > > Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system") > > > > > Cc: mattias.ronnblom@ericsson.com > > > > > > > > > > Signed-off-by: Bruce Richardson > > > > > > > > Is this issue for all "vdev" devices? if so, Please check for > > > > drivers/event/skeleton too. > > > > > > > Yes, good point, looks like event/skeleton also returns NULL for the device > > > pointer. > > > > > > I'll do up a v3 with the extra patch in it. > > > > Looks there are more vdev devuces. Can we have common PMD function or > > extend rte_event_pmd_vdev_init or so. > > > @Richardson, Bruce I will be on vacation from Friday, So would like to > give PR for rc2 before that. > > Adding helper function in rc2 may be risky, Could you fix all vdev > mentioned below. > Helper work, I think, we can take in next release. > Having looked at it more, and considering I cannot test a number of the drivers (dpaa*, octeon), I actually think the safest approach is to modify the vdev_init function. It's a small change, so I think it's pretty low risk. Patch will follow shortly. /Bruce