From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAD004319A; Wed, 18 Oct 2023 14:52:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE59C402CD; Wed, 18 Oct 2023 14:52:32 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id EE63F40261; Wed, 18 Oct 2023 14:52:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697633550; x=1729169550; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Ibqaa+7ZW1P5PKQb56LEQ9p0J/UqN5ob4rTSetgN6DE=; b=f/yCu9gWjMPcXn4QEP0ecJokGmzlfb+ccdKCMaohhf2eYJXzWvilgIQd 6RvPTO2ey0Uvy85Jb1J0kOP8QfBzwV6E1uhQmsOZQNwJJXMJJ3UjubcQl w48tN+CN9CRUt0aqOlC/3yALo6qJ/4GXdGRQHzixlxN5kC6sFc0XgN50F uI3Syr4LXkZ6fVgDsxhNwLB+jg1hzz7TIMrMBrhcyOJbaAz5YpUIaHMOY X6zYXBXjWNOeVQ/Sn1goIsI2Wogb2gMIkxx+bkLPQ3kv0nmYV8LREE6yS M5cW9uiwp1Vv25T5GoqsA0F/dUQ5OjMMVwQHzdn6kGVajPtPvVyiDcN9F A==; X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="7556229" X-IronPort-AV: E=Sophos;i="6.03,235,1694761200"; d="scan'208";a="7556229" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2023 05:52:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="847262287" X-IronPort-AV: E=Sophos;i="6.03,235,1694761200"; d="scan'208";a="847262287" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Oct 2023 05:52:24 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 18 Oct 2023 05:52:23 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 18 Oct 2023 05:52:23 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 18 Oct 2023 05:52:23 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 18 Oct 2023 05:52:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MEo4QjkmwGJU2SfjyGlNUFhCRG2S3WWYfy0vnCmYaNSuxs7oKbEr37EJy6TFKNLTnAGy7wzU448sHXZpjO3MmevzEEppmucH1j9OoIYi35cOl2B7sHWnuxwEFWRCCr/tDu9vxqf+Oe6+9zihaguBsQXOUbqRThMUaBgnrFzd15Sq3PW0VjXzA53gGpNfLCm/Zez9zdx5ANLmTsLnpkrv6xRgerHJkZbAS+Fpv646qUXcP3S07cNGNRMy3Hk4tS/jS9JmoW4QSugCkIwIrnDQZCivqISxkuM/cyC+hY+G3+b5HYrwInDm6NCKNTyV3m6ee829sSbgJSngIHjB9Rw9Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SRG8X3PMVaZz36arU2coHKR7d8AVGNXygKRTS4j6eRc=; b=RcFK/Q3dxxEv6NCr/HWlTftfe5N3K4dqUC9TPouQoPq3arHDlly4En6vtHtCsKePItdW4X75p8wyOt00xIyAKx5yGqgIGolQ37jXPbySZRBDQ1UkT25polVnw6BmIesQANv0Uu4aL9v3Lhga52QiOZ57ZjaifLwaYZi0z0HKekMn/WUWA+S271VWIu79ymBZaIZ6GTVEWcyNSyzHJU1BxfF3jSY1DJ78KsJC1hQPnCNHmUTyEOlPWMpaOPT+ksqR0UahAZvX/WrxQTpJ0rMbgmIawuj3frHMuCAz9AtGJn80MiEgY3dQlOFOSOUueIVtNn2khfez6iQnH4jm8qvSTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by LV2PR11MB5997.namprd11.prod.outlook.com (2603:10b6:408:17f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Wed, 18 Oct 2023 12:52:14 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5%4]) with mapi id 15.20.6886.034; Wed, 18 Oct 2023 12:52:14 +0000 Date: Wed, 18 Oct 2023 13:52:08 +0100 From: Bruce Richardson To: David Marchand CC: Jerin Jacob , , Subject: Re: [PATCH v4 2/2] event/skeleton: set driver name string Message-ID: References: <20231016151713.711965-1-bruce.richardson@intel.com> <20231018122558.126686-1-bruce.richardson@intel.com> <20231018122558.126686-2-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0353.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b8::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|LV2PR11MB5997:EE_ X-MS-Office365-Filtering-Correlation-Id: ed49a673-944a-44c4-e94a-08dbcfd90d39 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TIHLe9lR7p+pirCNnpJNFF3bgwfkDDI01FKPpg1NWqd/fD1O3UDfVWeD/aJ6AN/CEygle1Ets0WNHMInR2/AGid5t5FNQbmrbenRGleJWnDIW9I0sSO+0/AsnGXr5PLPiGlGda5O2oGfdi3CdwjdBLagmdLpD23UVuzTcNA+6EeH8X691avmIYwZIJMG4qdOn3Uks40xxFhQKpt1ksPOhkr/7knU6CoqYyBeug96xADIADuyZY76GDQJ3AcM3+89M7s/IY4UJAB9nKyTELkhdhjdccKbOxuK8r/dWSoAwX27klm9jfw72Uqlz1AitHjMD526+9cd0qoR5JAYKz1cgtMC2q3tls4Hvbl/CI3hVkeMy1NT1iE9uF2dJPV2ZG2b8D3cJSyStpGr0FR6UWPEwqiXncxw90LAf62d9LHdX3Mp8kFr9Ocx4egy25hTX4dXeiYAHo9dhwIuHBZIR27nrsrK0WfLMiviIJI4bb7MNgvVhSkuK8E4tOJkT0FmaBOUtcjYxRd4zYtC8oL3E4Q6n9YkKagBtFioqBGpl2j7xswGOMSt/QCQXlXgCmomKMYV X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(346002)(376002)(366004)(39860400002)(136003)(230922051799003)(1800799009)(186009)(451199024)(64100799003)(6512007)(26005)(66476007)(6916009)(66556008)(38100700002)(86362001)(316002)(82960400001)(53546011)(41300700001)(83380400001)(8936002)(6506007)(6666004)(8676002)(6486002)(478600001)(44832011)(66946007)(4326008)(2906002)(5660300002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWVUaWhBVlJNeDRUMys2US9mVHA3cFRpSDRuOHBta3pVYmFQazQzaUdSMUJ3?= =?utf-8?B?NmdkeTVoL1JjSGNabWpjNU1nMVo3R0syMWZIV1d3OFB3VnFVOVlhSUJGVnZk?= =?utf-8?B?TFRsNW41djhkSlNTVlRFYkhlNExUMWtWdFRkeEI5U1IrenFFQWQ3ejlPdXl5?= =?utf-8?B?TFZtYVdIYU4vZXBLNHhma2FITHZpWUZwc3dlaWVTTThBdHRhRnBkOTR4N1Va?= =?utf-8?B?QWdBajhlbUVIcWM3VElieDQzRk5QTGh4b2hqZGJ0SThoaWNZR09zRUVhNWFy?= =?utf-8?B?YmhQanRCdXhsVys0K3U0cXo3SXZ2N0RMTXUzWnIwdzFsWkNCd01pVVFiWHIx?= =?utf-8?B?Kzk1bUR6MmxlR3BDdEdPWnQxWHVQR01Kd1RvU0FEYi9WSkw0STFrWm8rT3hy?= =?utf-8?B?U2ZwNWZqeC9kajZFWHlCc2k2ZkptcExNZ1gydk1BcXloMGlLMWdmTGV5enRV?= =?utf-8?B?SmhaZHppWFRxcjhmOUwxd1BPUlI2VkxJZWdlSnloTkl3VndiMEsrRFAwS3hL?= =?utf-8?B?ek9WbTBjUTFvQ2NyV29QUVJpTzMxcXNPeXJUeFhYZ0VYQm13eGR3QlhuWHRa?= =?utf-8?B?SnVERFFBck9janVkRDlOcHJHdWRmNEQwVWJzNExjRndJS1JydTBaRVpiRUNJ?= =?utf-8?B?TTVjSis4Z2NIaXN3eXczbXV2SnVlZ1BpdVZNU0JuRi9TdzZJZTJ1STFkcVIy?= =?utf-8?B?cU1NN2k0c0FYM0VyTW1GUzdJRnFsREpsbnAxdTBnU1FreWZjaEVFM0RldU9v?= =?utf-8?B?NG55VngybXBQZzVud1o5K2JwZnJ1RGNCTkFFQ2xIZzZUdlZ0VmJ6VWhBNUlD?= =?utf-8?B?dEYrS3IyRmRmdHR3NVUxUTNvZDd1UEFSV3ZDb05aNVJ0UGgvdVU5WDF6RFND?= =?utf-8?B?cFI1dlMrYU9VTHBFOGlJSkZaNUdWYlFRcmZqL0JOTGk1T092M3ZuWE5Bcmxk?= =?utf-8?B?VUczaXlWZ211VUVWZitKaUNIKzZDeU5GbXFkVjVLL0NnWmhIaFVUUEQ4VFhk?= =?utf-8?B?cE1HOS9xdlBZWUxSNHNJbUdHb1prVU8rTjRNZkhQblpJM1VZOW1JUVJwYi9D?= =?utf-8?B?RHpFU2sxRkF5QU14L2dVbURDekFiTm56aVE1WUYvd1U4czNyL0RFR1cxb21B?= =?utf-8?B?TXJRVmRLSS9pMjR3ZUYyK2JheVYxMFFYVExYcEg1dHNlcVh3SW5RVGY0b0Zh?= =?utf-8?B?akd4YmJuY0hnZ1NBYlRlcDBtcnJmcjZiczIrNU9Vbm1sUnU0NFgxTmVBNGZH?= =?utf-8?B?UzZkeHRtNjBUdndvUnQ5NlpyWWFCLzhJTm1MM0VCNzc2M0VkZ0hZOFdiNita?= =?utf-8?B?UGJ0V3I2K1hiVHVKNmd6TWdiMWRFOVc4eTdPS2Vzd1hxTDRLc2RwQmRCL0Nm?= =?utf-8?B?eWVlMXlkUWlVa3JDTGwzN21KZGorN3hWb29TRDRFeDF2aEFiOU5raEZCdE1n?= =?utf-8?B?c0x4dVRUWTlISFk3MjVoVGJvbmdRQ3JUMmpHbjZia29YMlhXSHY5dmllOU1h?= =?utf-8?B?VkpsR0p6ZGpSck5sYk1hSjlwVHJjOTljWXZmcnlYQjU3V2FtQWQvUitZd09T?= =?utf-8?B?K1ZNMSt0dlJVc3AwZUwvRWJ4KzVTdEZYZGp2UjFpNURHS2E3RWJWdFQxTkxC?= =?utf-8?B?Y0dMek1HN1kvYnJtR0ZKSWlvV1lMQzdVWHJyektYZkRYRnZiUGExL09MalhL?= =?utf-8?B?ZXFqOGY2eWNPQzBleWpHcDY3Z1FvTjR3SlYvanNjNnpVM0pLRi9PT3kvUHpD?= =?utf-8?B?WHNZUVdBZkFSMkt0NVY0ZGlBKzdiQkZZWmRVL3NVZk5rSzBDV09rVzJ6eE1j?= =?utf-8?B?ak91S2pKQlJQalpKTXR0RVBBdlBJdWJiZzVieDJ6Q2RsVFdvSzAzMXhZN2NV?= =?utf-8?B?N0lDaVh3ekhkeXN3dmR3SUE5NTd4SnRzWHJXMmZrcDB1aExyY1VWUGovVHhI?= =?utf-8?B?UkNnWStQVEtaRlQ5U1U5aWZjUzR3dm5xQ0ZuUFJPY05KWHlwaHlNZzhVV0li?= =?utf-8?B?M0ZhaElXcW9nZ2hldFhrQVpscG5mNkROWldqdVZpSjJYZUpuTFllaFpCdFBj?= =?utf-8?B?UXhKTjcxNmdWbENOTmx4S0UyZThNbit4dHVqVFdPSDlHSjRFRGVwZEVhemlu?= =?utf-8?B?dkpFNnVkWU4vTEc5dEJvOEFweU5hMHlEQ0kvVm4vSTlTSHBLQ3dSRTU1KzE5?= =?utf-8?B?S0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: ed49a673-944a-44c4-e94a-08dbcfd90d39 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 12:52:14.2834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o1U2cumWwibXZQ+2Og5aBCZAKpYasygu8x+BVbgufMI5xSXzUoVtzTQFLvqxC/dWEm1rsdRA9hQhw4ifpAZ1PvbLA99rqxUloEoicWONuwo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB5997 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 18, 2023 at 02:44:11PM +0200, David Marchand wrote: > On Wed, Oct 18, 2023 at 2:26 PM Bruce Richardson > wrote: > > > > When calling rte_eventdev_info_get() the driver name string field should > > be populated. > > > > Fixes: bbbb929da5e6 ("event/skeleton: add skeleton eventdev driver") > > Cc: stable@dpdk.org > > > > Signed-off-by: Bruce Richardson > > event/dpaa2 seems affected too. > Ok, hadn't noticed that. I tested all the SW drivers I could and didn't find any of them affected. > Can rte_eventdev_info_get() fill this based on the driver attached to > the device, like ethdev does? > > Something like untested: > > diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c > index 95373bbaad..37ccc0dc77 100644 > --- a/lib/eventdev/rte_eventdev.c > +++ b/lib/eventdev/rte_eventdev.c > @@ -104,6 +104,7 @@ rte_event_dev_info_get(uint8_t dev_id, struct > rte_event_dev_info *dev_info) > dev_info->dequeue_timeout_ns = dev->data->dev_conf.dequeue_timeout_ns; > > dev_info->dev = dev->dev; > + dev_info->driver_name = dev->dev->driver->name; > > rte_eventdev_trace_info_get(dev_id, dev_info, dev_info->dev); > Ok, let me do up and test a patch. /Bruce