From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF15D4319A; Wed, 18 Oct 2023 15:42:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D82C2402CD; Wed, 18 Oct 2023 15:42:57 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 2D17B40261; Wed, 18 Oct 2023 15:42:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697636576; x=1729172576; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=ZcbAvyHTC0+eicjRDaFDkaBKmyvbErWwM5oPjplwBLg=; b=bCAFGtRxMW5HLC1LN7DFa7Fi7hsuidDS5ezxTzTbU8nmu12e1bBB+26B ttITVIN+4XiJTst1nloeA0Adpl24xjUs3kqOVzuI/PT9O61rAq2IaDWNV VQst+YA6sxLUYM5HAGRaccxZloUeOGiBiIso3dQmn6efEqG0AhFnyZARB B6wkjqaXSmqfyejew6WBErLvssDdKrC727WFoS9XpCBpcCTD8/cxOEayo WBluGs0ny40/1zNqQFOEc/a7/9NsTqMh3uM5H+RQ1r8eQT4Sq6THoUE4w npR/J4f+71HeaHCE2zssxZ0kYbMgPyOJCXIRE08EhXwleQXTYvjKtQb0F Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10867"; a="376384710" X-IronPort-AV: E=Sophos;i="6.03,235,1694761200"; d="scan'208";a="376384710" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2023 06:42:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,235,1694761200"; d="scan'208";a="4378507" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Oct 2023 06:41:45 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 18 Oct 2023 06:42:52 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 18 Oct 2023 06:42:52 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 18 Oct 2023 06:42:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fYFYrFdiOYvMhkuzCTaJ4Cc3ybTR8hiX/5I4jNjUyQKTgHe4vWNLJhTbU+J58f5/ejHg6L67rytw42cvi1Yise3/cmhKWf0052WaLgQt9y1tZeu3MQbrEPlfq3Lej7imxdL6PQUTa6hmeCCTggtn3q/sBtfaYzG3WkX7lcAEVvulXqWKdoMVIU5nF9HahbC6LHc6bcxTQ6Cguxc/eqeRR+eJueNW+je54s68HhjSX6goZ/MyZF7FebdePQOBzMQDG0kH1Ii+oQhRWEZkOx3b5AlHiYZd0wL14oN8A6jmXQKAWGPEuCsxjQND3r/FVIMMWo8K7xhSbKGqagEl78Tzcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=26qVbWqI0Y+cTVrnH+ko1UBXrHwvCKlCmwuaYrARHuk=; b=dGKPuJxmKnJ1a7LUzFXD2gkF/AimYKPDhGwwknPW58MILFDS6JMspHbD0WAWM6CfnYHT012V5USEkrYubVlumLi4azUAoBu+oR1j5E7FCiCi9Zy/Qbom0rxwzUPoFFyErdrXQnVQWQLPSGalu2jMIRuv2nlBxidKzVvx9Rvt01YlvsWL0PT5IzRvYSS6JFq4sBPcJfReWAkbpduw5jsfqfyrkdiK/Au9hnJFy2PnVgecn8IUmeojtxyHTrhwfI860p7+pAkG7qmGYY0trrMyisUHz9Y3uXeEu2RUfZQeQDxOOe2j6XY5Yj8sMQ8jKBziCyt3XCiziZqgesQo6mdt7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7359.namprd11.prod.outlook.com (2603:10b6:8:134::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Wed, 18 Oct 2023 13:42:49 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5%4]) with mapi id 15.20.6886.034; Wed, 18 Oct 2023 13:42:49 +0000 Date: Wed, 18 Oct 2023 14:42:44 +0100 From: Bruce Richardson To: David Marchand CC: Jerin Jacob , , Subject: Re: [PATCH v4 2/2] event/skeleton: set driver name string Message-ID: References: <20231016151713.711965-1-bruce.richardson@intel.com> <20231018122558.126686-1-bruce.richardson@intel.com> <20231018122558.126686-2-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU2PR04CA0318.eurprd04.prod.outlook.com (2603:10a6:10:2b5::23) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7359:EE_ X-MS-Office365-Filtering-Correlation-Id: 5305556e-5978-44ba-99c6-08dbcfe01e8d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EaS5YTzO77b2/0XlxdcbrpMxleeOOZP2TWcRm+PVeiIwpspTlFE50k51eFHXXvo3G7hFeFsgLEyEaNUwjDlslkiJ+vPTeuPb3QPu0LKx1yRnql5NanXYhSBjxs9941Tw6auaZyzHdcX1YGONOQtjlr9l9MuNOlbpYSxEgl+RlDlhBTcv6w2IBJzMlPY4q+6wccVB4MpmaXdK8qxziwhkAOYyn02FsUJEyj6GIKHQYPcplkJM/RXKipZfr8bKSrXwi5m9SyVIDP3kGP0KRVBUcZVe3Z5lkyIGK1OiQm7afoR2IkCStCemlHuCCFGKCoZe6GRcDo6xSrq92xcDPkMp1WB6RHt8EyUkVRZtorlySLPPLnXV8a8asJNoqyPA3h5RlPRJnoSKggTbno1jokPl8nWeo7gWSIdncovefNTAJZUP+STONCzczNGtyROr4NQGqjfPalTnPrjmDco0SVWAq1zsjrXyoTkjAgSfj6YfIyGH/eYaAde41iC+qHx9EJGNJttMNQxIIbJIkFREkZPfOA45V3s5ddxaclxRbRpziMrpElKd7Q67Qry9FshJjaL4 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(366004)(396003)(39860400002)(376002)(230922051799003)(1800799009)(451199024)(64100799003)(186009)(6512007)(26005)(83380400001)(6506007)(53546011)(6666004)(6486002)(478600001)(2906002)(41300700001)(44832011)(86362001)(4326008)(38100700002)(82960400001)(8676002)(5660300002)(8936002)(66556008)(316002)(66946007)(66476007)(6916009); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0t6NDBHS3BFZ1REZ2tSeGJ4ZHBuN0o1SUpNR1pkMmVTU2ZjSEwySUxrendY?= =?utf-8?B?a2JFZ1poWmw2WUJPckVrNjlVaS9OS0dGQ3I5dkhvck1GeVRsbDlhT2daMXVv?= =?utf-8?B?ZXVDVWwvT3REK0U4VkFXRzBQU0tXTnlxT0tRK3pVZExHNTB1RUR6Sm00dEJN?= =?utf-8?B?N01VdTVQeit0QWo4a1VUMkNEcXFJV0Nuc3Rmd1dyLzB3VW9iNGNWR1ZxSGVp?= =?utf-8?B?SlF6MDYwelVRdURyYXZhWUxncTBOYkdBenlUWUpZL2tBZmZrd1Z3VURUNEFB?= =?utf-8?B?cWxCcVJIZ2Frc3dUM24wKzJUbWZGTVhNYkdRYVdWWUZMd1hRTStlQkR6SEFy?= =?utf-8?B?Zks2QmltWnhNQmQ4S0hLWDROb1FldnMydDZSUzJKVEo0aEd2M3JSWlFGbjdM?= =?utf-8?B?OTZBUmtvQVJoUHI3elkxQ1RUTEo3OXdJL3VKcHJaYUxXc05lMXNtaDF2Y3BZ?= =?utf-8?B?S3RiQW9DcjdQNTd4L280N050Z2ZXMkhYVTZEZGNhZTVLRS9kbHhoRTFKQmhm?= =?utf-8?B?bnVmWWorVWp1MHNpV3BuVjFRSXBLVW1lVmtTMkhQdkk4MlNxRzlBTTZnY0s0?= =?utf-8?B?TXMrK3VyMkV2NWc5Y054aEVsbXF0YWxERFpvdjNiNE5VZUVrbFJoVWhIaStJ?= =?utf-8?B?cWtvOVg0TUQreVVucnpML21RZDBHelZVTGN3djUydy93MFhJMkdaaUVWRW1j?= =?utf-8?B?Z2JwMnRLd3BBb3JkcC83WlhYVmVwbUZ5UUF6L0dVeFlGdk5ud2VtMHBoL3pm?= =?utf-8?B?UGcwUkdkdCtTNUtaaUZTYTFQSERJWC90MDNVZk13N1hvellBTXhrbDRVdWtK?= =?utf-8?B?dXJ2OWNqM09PWk1Wa2plNXAzcHJBRUgwS1Jlb1JOZFUrN3g0OFovamRObFQ3?= =?utf-8?B?WmNQWnk3SndSK3U2SFZTSDZKVlZLSm5mZDdNcmlnUEVqNDdpVWtkYlkrbm5F?= =?utf-8?B?UlZWWVNTQk4yVHpKY3hPZ2pEOHFnTzNWTmdBNzEyREx5SHo1RzJZVjZMQmZJ?= =?utf-8?B?WVVEa0FDV3ZvRlhnenZHdzdiV1VvSlRqRk4yYkQ2T0NxcXdzclBBZHBEaU9p?= =?utf-8?B?UFl6MElMTlBkK1VVVEVvM2pDNlNYTUx0OFhxSU14WDZYUGpFMGVjcUdhQlNS?= =?utf-8?B?UTdSZUdlVHIyUVZUN2kvbU5wc3Roc25xMVBTRHZzS1diRldYQ3g3K295c2ta?= =?utf-8?B?M0NTNGFvNmJrdU4vMDdZTVVJSGhkNEpvVFRFQ0J6Zmh0N3BMVnlYTkdvVUpV?= =?utf-8?B?b1g5V0hGUzBrOXJRUzBYVFZCSEE5K1Zma1hWV2x4dTZBaFFoS2VKTk9NWkkv?= =?utf-8?B?MmNFNnlkT0h0ek53Uk80UW5NNzdScWwwZGtqRGFhazlpTXJjWGtLYms4NE5M?= =?utf-8?B?Y0JSV0g0cm1nRFNRanlRdVE4RXkzTG9uZ0tIR1NkYWQxQmFCdXlDcGl6OFpp?= =?utf-8?B?WWIzcElZMFd3aVRyeTlUU3dkM2FvaUhBOFBQUmk4RUc3TS96UUdScll2aGVD?= =?utf-8?B?dGZma2VIa0J1MFRWY3IwZ0FpaENMMkFFNStJb01xemwycmxiZW9CVElneHl3?= =?utf-8?B?czFmczhYNkZuc29yd2FndzdGS3VFMU9nbHRJM0pFMGNhc0lMRkNYTTB5T2NV?= =?utf-8?B?YllJelJkVGZnK2lIalhJWVVFajdJQytUZmtqSTZURWRYRklLdHp5V0g5bGlP?= =?utf-8?B?UlVGM2dsZFJmcjNXRTNKNWZnNURrR2pKTUpWcVh4Z09MaDVTSjdPOGg1Q3pV?= =?utf-8?B?L3A3RW43d2pYenl5S01tR1ZpR2NDZmh6cnNCRmFoSGUxQVhvK2ZBTUxBOVlY?= =?utf-8?B?RVNaamIrWlFNcUNuUWFKQXFHY1dHc3RiRE5GVnlpWGR1VGp5ZWZjdytMRUNF?= =?utf-8?B?amo1a2NvcHpkd2RhSDNsTHZNV0hFcnFoU1h2UkZHTGlkOXluZCswY3MzOG80?= =?utf-8?B?Z3czWjZXNjNOOWFjc2hpRGx0WEhLKzh1bDMzeTFYWDJsSHkzUlMvU1NocDZR?= =?utf-8?B?VFp0a3RKQXFoUE91aGo5OEJ4TDd2VGFPb2xFd2FSODUxTllTVE9yTXFCT0pG?= =?utf-8?B?RGVJOWVSSHpBSzBjSXUzUGMxRy9MOUpuanJURy9DUUZNNDZRNU5NU0xJdHBT?= =?utf-8?B?WFJ6eUJSYVZ1aG5MT1l3SEpVbjhwZVUrcnBnQVdaSFB0NWZwR1MrV1FDWUZM?= =?utf-8?B?NXc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5305556e-5978-44ba-99c6-08dbcfe01e8d X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 13:42:49.7436 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 781GTz7+Fy7debQzlGm/qDmh3I69nHNYMNx0yRDkja0qweCOkuaNcwRHkfHq4XPYUhi1e7Pm7hlVb+b1liLRvMLAcu7hV9quwI5Z4mN+yOg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7359 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 18, 2023 at 01:52:08PM +0100, Bruce Richardson wrote: > On Wed, Oct 18, 2023 at 02:44:11PM +0200, David Marchand wrote: > > On Wed, Oct 18, 2023 at 2:26 PM Bruce Richardson > > wrote: > > > > > > When calling rte_eventdev_info_get() the driver name string field should > > > be populated. > > > > > > Fixes: bbbb929da5e6 ("event/skeleton: add skeleton eventdev driver") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Bruce Richardson > > > > event/dpaa2 seems affected too. > > > > Ok, hadn't noticed that. I tested all the SW drivers I could and didn't > find any of them affected. > > > Can rte_eventdev_info_get() fill this based on the driver attached to > > the device, like ethdev does? > > > > Something like untested: > > > > diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c > > index 95373bbaad..37ccc0dc77 100644 > > --- a/lib/eventdev/rte_eventdev.c > > +++ b/lib/eventdev/rte_eventdev.c > > @@ -104,6 +104,7 @@ rte_event_dev_info_get(uint8_t dev_id, struct > > rte_event_dev_info *dev_info) > > dev_info->dequeue_timeout_ns = dev->data->dev_conf.dequeue_timeout_ns; > > > > dev_info->dev = dev->dev; > > + dev_info->driver_name = dev->dev->driver->name; > > > > rte_eventdev_trace_info_get(dev_id, dev_info, dev_info->dev); > > > Ok, let me do up and test a patch. > V5 sent with this fix instead. I just added some additional conditionals around it, just in case we end up with some Null pointers in that chain (hopefully not after the previous patch, but better to check). Testing with skeleton, sw, dsw and opdl drivers showed no issues with reporting the driver name. /Bruce