From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AF3B43198; Wed, 18 Oct 2023 11:45:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21CBE40297; Wed, 18 Oct 2023 11:45:46 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id CF44140151 for ; Wed, 18 Oct 2023 11:45:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697622345; x=1729158345; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=c74dSpsR/XXEQ04lNtMTgHmXxUcQIrH3aTs5TGBJQzg=; b=S3wG01CjryBNIb4sYR0FhLV2ugu/l+wbp0TyXIeBq0b4JUd/YHw3KCEv Yy3dfao9cTDEzNsoCeUuhbFrpIUh7Z6r4gr8pjNCk1QCFvRAkzz+t0SjC 4wMAgjERXmDoMFDB2cidRjmrnZVczW53X5pGccg+n4jNWc0E8xczWG2vs 29Yea/NYVmeMJ/wSWnwqJUvIFN9a9+FBNs5Vbe7j/AlYW0k6OA09NnxfM b25LYMoV9Vk+qdwOm054f+AuimGiEi066H7RhZq2yPG4HQ4nWzhAfWeJf WtvxDc6Nl2uzZE8PIXlK1wdsvudh1YXKDIzHE+dbG83ol6Rc+Y3udseat A==; X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="376349560" X-IronPort-AV: E=Sophos;i="6.03,234,1694761200"; d="scan'208";a="376349560" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2023 02:45:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="847198467" X-IronPort-AV: E=Sophos;i="6.03,234,1694761200"; d="scan'208";a="847198467" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Oct 2023 02:45:43 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 18 Oct 2023 02:45:42 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 18 Oct 2023 02:45:42 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 18 Oct 2023 02:45:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uc1f06MiG1mst74fSGQm9xS921ebeDxmZnJW7RCM7jqraO9LKvju23uXP6wtawdA3hJKnpFk/cXMxyJzHeTYBoaVdaWGSsEKO1aAk+kwwaCzUbRFiv5VJs8Dk4tfIRB8DrU8fvF8MBr+g/NV4CFn6P1yfrIwD1l5oL5KfrKh362JzzvRI3mPI53hY4FDo4z84dh+/DlCePm6Tg6alJiMgXR+CjWc+zUw4B6uPDqovFGwZ7T69dRkn+48YjXRiL59NK+pYTAOjYBOXyNf0jzd1WrdZI5iR9jXvNi1h9CnnYFrJo8cXdz221mGsvcU8jaETCE3s3jCHl5S/mubBcYrsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8n7uQrIbpmaKi/UNmQ6R7yxDJdebzFpOWBB3Rk+oE54=; b=AxQanM4qhqcJaCxnDYnDs0awoUznP0BkmQYXyzhsX5QmM0myxeoQPqtg+DNfkIZzUH7x9zRSPOde0f30Wf2fDXqzK9S8q8Wfj+E+YMeNzB3qCOSEqWMo/pk/z9ep6ejATHFHpeqjj980a1lvqTenS//ipmRaAkfuNFxnm1+1zmyZot/cD2VTN36LO+wiR+TPA/el1NuKT/lhs1ymgvRTPDdVT9YQ4KsHI1J55ToaO0/lUjOXANW63l0iga3rr3q9ECH5WVgolBNb7vZArIWhW/OYsCPNrM6ChKgzJNw/tGkfwUdPtCKJ067/S/J0S8plJS8us/2tKHxpykvpLniZtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB5211.namprd11.prod.outlook.com (2603:10b6:806:fb::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.34; Wed, 18 Oct 2023 09:45:40 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5%4]) with mapi id 15.20.6886.034; Wed, 18 Oct 2023 09:45:39 +0000 Date: Wed, 18 Oct 2023 10:45:34 +0100 From: Bruce Richardson To: Jerin Jacob CC: David Marchand , , Subject: Re: [PATCH] event/dsw: fix missing device pointer Message-ID: References: <20231017154532.152741-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB7PR02CA0009.eurprd02.prod.outlook.com (2603:10a6:10:52::22) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB5211:EE_ X-MS-Office365-Filtering-Correlation-Id: e9c0d468-969c-4e11-6842-08dbcfbefcd5 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: amtLUUyWJAMSAxrOxlTf3OowXTSjEoRQEzQdVfRmk/yWI72gdC5/qIxcz0gVORH19ZhtpV7Htv6899eRXVsINGdvAJwj/8f4VpK4ux9ErqWNmlQ4pu9IwzHv5IaXMGNP0gue7f1CkdVUemKsZ7CAu99+e81glIOmrjdwfKooxgk00YK3b1nzgqpq6qbcUgNhwAMhDCZ52Gq0+xwo465xgob1zvSKkekCkvr6IkLjw03kWT2FPTzS/abNRxT7Bc/zGJWM/j0lWL/5yJ+ZteaRJIO0DokG2Ueg/OPTznxnXJ1zhyyR5+DBbPAh57R3FHJHsxVhVOl6SQope05ijX1AFit6DG/gkMtED8EBFr5YwR2EtxdLVEA0KR5sPpQdBO505rRFvRzE2toF70Smzyn5zP4yiiiGyDi287vqtbSrqx83GZAsa3CwMx1Zytz96CAVniPXb2dQaMx8I3NTvq3rOMwVL/4NRCJcg114/kmHD7yERN0KN1RmGXpCGE8tCwitkBafiOVgdIuhKuK62s6RtySAQZQ5VZ9GNLl9Q4bvHJwTPXrGxMb++Fy19qhvD4V5l6c18U6Dql6Fh+6PjzV8ysAktBFdbhlYL+lTKNyEojc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(39860400002)(136003)(396003)(346002)(376002)(230922051799003)(64100799003)(1800799009)(186009)(451199024)(4326008)(6512007)(6666004)(53546011)(6506007)(8676002)(8936002)(5660300002)(6486002)(478600001)(83380400001)(26005)(66946007)(66556008)(316002)(41300700001)(66476007)(82960400001)(86362001)(38100700002)(6916009)(44832011)(2906002)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnZyWm9pM00vK21sMFZidkF4eFBwMXpQNWFJV3RoMnBkcm1wZ09Yc09ZZ1Ra?= =?utf-8?B?LzVZdjAvSnhxT3dVdHFNcWhjWjd2bWVzQ3VjQzhQNm1IZ2FlRlYxdTc2dmxQ?= =?utf-8?B?bmMwNWNKZDh2c1RIcnlScmNvYnFzU0RKN0t2OG5MRHpDbHVuLzlnRCtMQmhr?= =?utf-8?B?N2N3S2J0Zms1ZUZoK3dHUmNpTGdnM3h1UldlNjR2WHEwei9IeTJOL2crZG50?= =?utf-8?B?ZUQ5WVoxNmtXZzRSOU9rN3ZuankvQ1U4ZTV3ZDVZR3hxNEp5MEYvNHBWQjJR?= =?utf-8?B?S2dYeDZxR1Fpd1Q4TGVXa2tOdlZ5b0dCU2NaemxIWlZJSUhEYno5TkxDSitz?= =?utf-8?B?d0FWczFJU0d0SVJxNVJjd1g5bVNHTlhLbFRnU0RuL0kyczhTSS9jdE95Vmtl?= =?utf-8?B?aWRkcHFkSGRRb2hYYmhzU0tldndnZHE3Vi9XWnJKd1pBYVZxMk5rR05oZDln?= =?utf-8?B?Rnc2M1owM2I2eExQZjZKVHdJR1NwdTUxQ1Btdmk0Nkg1eDNDUHBrYWRsVDJB?= =?utf-8?B?R3ZSSFJmRlFMdm1rNEJpUXNHTml1NjlxQ0hQd0RXanE5MlhFWk9TNGNpdmNE?= =?utf-8?B?VnZoc29RYXc5KzVaSVNvRTFrVGFjL05lOUVPcUhwUC8yZitTdVdJaVg0YVVp?= =?utf-8?B?T0phcDluVjFqUE1VcHRseFVOQVRRTjBkNCtZU0xURU0xN2tJYUF2M0xZakFJ?= =?utf-8?B?VUsxRGpUdmFOWHF5bVRJbUNkVGZpeGFvRVZJajd3RUJoMnkxSzFSSEIvMTRw?= =?utf-8?B?MUV3RTVqc21VVTlaOWRsWFNjM2trOUFaOFpLcE9ROEJHN1EwMVFVT0l4VWV0?= =?utf-8?B?Ky80bWFWRHR3QWdEWkc3SS8yV0hBYTc1OEh6Z2RkR1psMkhkWDhwblZhRWdV?= =?utf-8?B?WTlkRDh1Q25vU3RnRlovQUI5bDFHU3Vac3d5U1BFV1RmQTllbzdmNzA4RVZL?= =?utf-8?B?OEZWTVN1Y2Z1QWZTVWpCWjd2OWJSc1ZIOUVrWkRuYktZczIySjY5SjgzRmp6?= =?utf-8?B?QURIbHpHV00rb1ZQVk4zMHd1RDk1OHpORUNNMFhCOGdmRUZPVkNrU0FEM3ZB?= =?utf-8?B?SDhGMjNMem9hU2hTNjdjcU1HODhuU3JWZ3VrNFRFZUlqMDlkM2xsYnB2UXpk?= =?utf-8?B?M3hFZTI0Rm9NVHNFWlVoRDhudmgybk5yUTQ5TUR5UXNIUlRWenh5Ym11VHh1?= =?utf-8?B?Vmp6RXlzeUJhejZFVldhdGt4VFlTNlh3cVMyWHAvMmlFTlhjNXE3ck5JMkZq?= =?utf-8?B?N0J5TitEMWl2M1F4QitqSXZ6NjVrT1EwaHZ0SnNGSXZIOXB5TjRvNVp3ZDhS?= =?utf-8?B?aC9aZFBTOVNuVTJta2ZmblBxWjFhTlpMcDRuYjV3RFR4dlkybmd3Um8zbnc0?= =?utf-8?B?czZGK0pSN0RlOXR6UWNjbG56blY2VGZ1anhkbFFiVUg1d3dxTVUyYXBqU295?= =?utf-8?B?Qkx6bnc1dkZGNTFXUGptR0luekRpc1dLTWFrYTRNQ09maWlSK3M3cUJMOWY0?= =?utf-8?B?K1l3bVZyM1hpNzFJSHJJWnpsQnlDK0VDZVk0aTM1UzhvbXVTcUtvbU9jdVQ2?= =?utf-8?B?Z0MzUXdYUjV0NkFQNTIvRUdNNnVCSHFCQUQvK0xYdG53VWVzTy80KzgxZE5Z?= =?utf-8?B?bThyN3JLUVFSVmZDdy9reEdLRGVZQjZUWVVHVXA3MG55V3p2WGJwRzc4WVhh?= =?utf-8?B?MFlteS84ZFpaeGhmZnVqTk9NenVKbFdRRGNjd2N1cTVYVmJWOWV1a0x3QUg3?= =?utf-8?B?TDRwd2hQNlBINER4alkrVUZvcjlQZjJUNmV3b2RBUHlZN3d3N2RRNUt1OXNI?= =?utf-8?B?bjNPdmRKRFFMWVMzUHJLUUJaQ1IxVEdNZkFPU1BSMkFNYjNtWWR5VFgzQlJ1?= =?utf-8?B?ZHhqeGNpZXYvcXhQeTJKVGNuNEdPbml4bXN6QmVNNlowOHdnZTZ5T0grZ05v?= =?utf-8?B?RGkxeWZUMmJienoxeVBUUWdTY0gwSWF1MGo5SWJ6dmpxZmZkdlVpdTNkcmlV?= =?utf-8?B?eWhFcVhmcHAxejBXUDVlQ1hVMml3b2I3ZzF6UnByVmpZUFh5eGlGNitqcEY1?= =?utf-8?B?TlBxMzRTUEY3MXBoNkZZbmdHQ3JESVhaeXpkZDYydkNGWmdLNld0SzZKTmhE?= =?utf-8?B?Ri9nQVNzMUgwdDI1cjhSejYzZ09sOFdwT0dQdk13WmM4Z1hvR0NzRXF1dVJp?= =?utf-8?B?bGc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: e9c0d468-969c-4e11-6842-08dbcfbefcd5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 09:45:39.7987 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rZnKuM9WqHxf/F+wzKo5AxguhNoJyR9zjn5z4UABVoBMiMkNGxyEOI1t2/k8hOyMX2PIHTqaLFpT7y3ZNEGMTcgOLxCmiCjtRdOL48d0cJE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5211 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 18, 2023 at 10:48:14AM +0530, Jerin Jacob wrote: > On Tue, Oct 17, 2023 at 10:21 PM Jerin Jacob wrote: > > > > On Tue, Oct 17, 2023 at 9:45 PM Bruce Richardson > > wrote: > > > > > > On Tue, Oct 17, 2023 at 09:34:04PM +0530, Jerin Jacob wrote: > > > > On Tue, Oct 17, 2023 at 9:32 PM Bruce Richardson > > > > wrote: > > > > > > > > > > After calling rte_event_dev_info_get() the ".dev" field of the info > > > > > structure should have a pointer to the underlying device, allowing the > > > > > user to e.g. get the device name using using rte_dev_name(info.dev). > > > > > > > > > > The distributed software eventdev info structure did not return a > > > > > correct device pointer, though, instead returning NULL, which caused > > > > > crashes getting "rte_dev_name". Initializing the dev pointer inside the > > > > > "eventdev" struct in the device probe function fixes this by ensuring we > > > > > have a valid pointer to return in info_get calls. > > > > > > > > > > Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system") > > > > > Cc: mattias.ronnblom@ericsson.com > > > > > > > > > > Signed-off-by: Bruce Richardson > > > > > > > > Is this issue for all "vdev" devices? if so, Please check for > > > > drivers/event/skeleton too. > > > > > > > Yes, good point, looks like event/skeleton also returns NULL for the device > > > pointer. > > > > > > I'll do up a v3 with the extra patch in it. > > > > Looks there are more vdev devuces. Can we have common PMD function or > > extend rte_event_pmd_vdev_init or so. > > > @Richardson, Bruce I will be on vacation from Friday, So would like to > give PR for rc2 before that. > > Adding helper function in rc2 may be risky, Could you fix all vdev > mentioned below. > Helper work, I think, we can take in next release. > Yes, I was going to reply with some similar sentiment. I think it would be risky to try and do a proper solution in a hurry. I will attempt to fix all vdevs for rc2. /Bruce