From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 494604317F; Mon, 16 Oct 2023 16:12:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB2DB402CB; Mon, 16 Oct 2023 16:12:02 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 4630C40269 for ; Mon, 16 Oct 2023 16:12:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697465521; x=1729001521; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Z3hJrKE+BD4HyjNoCsnTkAfUQ5zQphlcyIuTsHvmFYg=; b=lmLmY6ECJcIIP1QN287UI+ThlB1kCfwz5bY4KWxPPi1nFN0EbB2d9j7+ woMe06Js+6FKMPMghdUtJdLjH4xjkf7NSq4HXIsYHLu5UDrhuOf7tK6Ft MEyB0dqXVXZdG+Y5gncEycgfkhPczGS0DXjPRtoKlUTX+++ICZl2ticNo PjmkLa2bx9YUmBB8hgxNVgxpQL+rbCtuyAJOgSbVJZT1SDwW4SEgiWUN+ Xv+j0O3nHSAV/hGFqHTHvI7zMIhymld6xq4skSWYVWbItnYCsYrouyp20 oVdzWMadmqEqlyog5RvAGESjXPlGvvkHY3WFkvAdLJ4irrYC3/mmYADXs A==; X-IronPort-AV: E=McAfee;i="6600,9927,10863"; a="7104102" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="7104102" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 07:12:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10863"; a="1002954618" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="1002954618" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 16 Oct 2023 07:10:47 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 16 Oct 2023 07:10:47 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 16 Oct 2023 07:10:46 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 16 Oct 2023 07:10:46 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 16 Oct 2023 07:10:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LekWNcX7j+YJTDSJnGTpu+i28CzURekGydZwfEV4HYk4KiA+SYSXEzRd/YsGN1ZE4BAE61+F6SBd7XsKDOszBidKxhVRp1JIkrYrQbRSYXmYrzuBUz5BU843LbymmJGQEX65QhA7NDHLIxM4tYfrwOi8HNNiIbWsh+muDe2WQuGoyDq+EgfnXnItJbQI6YrVWHO2mIxBMsgAWgGuJTsSlBY/oV/BX1W9/PJFW3m6zclv7wghXIxcEiqHC61kRHo/GdYePz37dQibkRHj74WLHZvss2yfuH+Tmjx3ixbhaQm7WDsb9piL1N92tpjq7jY4KCxgKro/Jia+wSBsgDcTpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4BqQpTtVEclb9JuPVe7LKAiZ4ytyYtky6qiHNSdPBFU=; b=iuXOXoEGX/5eqrikrYgMKEucjID/j+q11ye7y8cyqQ6U+vl0mkgA8sMrg8WgB1PN7rY55mSGod9xHcSYQ1e5eHk3v9WdcSXTyjQnp7vly+l9Db5C0uyRtC5pGsXxi6FBqz9p4onjyBnvKYLahOsME8EDkSO+4IhLpvu4LwAHPDvy69YtGjwVB40E9AAcyykAV9z4KKk06oe5L+z8fVk2auPTtVf0pHxlGF0TRfIjKeIDQlm5roeew5QgtSJvxrqHJWVinIyPgi2PrP3h5BVlVVF4VlsfQU+CDezYeYBA2c5c7linnbVk2AIvcK4tdYIIcxEwVbUsPR4ePNeyWL5Ecg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM6PR11MB4642.namprd11.prod.outlook.com (2603:10b6:5:2a2::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.44; Mon, 16 Oct 2023 14:10:45 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5%4]) with mapi id 15.20.6886.034; Mon, 16 Oct 2023 14:10:44 +0000 Date: Mon, 16 Oct 2023 15:10:37 +0100 From: Bruce Richardson To: Jerin Jacob CC: , Rakesh Kudurumalla , Subject: Re: [PATCH v8 05/12] app/graph: add ethdev command line interfaces Message-ID: References: <20230927115412.55018-13-skori@marvell.com> <20230929095814.692890-1-skori@marvell.com> <20230929095814.692890-6-skori@marvell.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZP191CA0022.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f9::26) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM6PR11MB4642:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e81168b-f849-4237-1309-08dbce51afd4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TGAAvnfrvbV3jNGtYTb7BmUTMFdQNXoPfa7uH8FTJwrtEG/T6VFmlh/4tNQTfhK0el7vYZW6u5Sxy1SQa43yENIA1h2yMrNdSf4v8Ktk0nDX9mf60ZLmczz0OiOPAjj1af3O8Lkbpp8bCpoFGgCXL+D0w65mzg0DZgEhKgYAdbV6DQev/1zhF8yOTaFWZilgwVH17uzJ/dYWgwTOa0wZizDlMKkLGP+XA5ljnlA+2lXzmMittcAbsMv4hql++Uu1UqCFqDT26Ud941he9NVq8f+fh2QOakplPwcR9hC1SnJMKCuuwBbwzWx6d5WAPL+Y0s+zBzxDx7WosTq1ct2ovDCJ0gVf7Cc1wMcONyFVaC/PGiCA29H3mGDbNaMl2bfN0c2jtZssh5EbPz9vcYnqHM5zHasWNx3+2KSA3r4oSdIxLluYaij4SOgeJbOlL677KagE4d8GxIdSHxI/JGNl2g2HoZBOYZSBpgg+yBkWpHRDbZZQ1C0jwYlpG0DCAEseEsv7Ayn71Gv4ptxqLDoddYKSlOJJ7leGaU52aTItLPE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(376002)(366004)(396003)(39860400002)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(6512007)(6666004)(6506007)(26005)(6486002)(53546011)(478600001)(966005)(66946007)(316002)(66556008)(66476007)(38100700002)(6916009)(4326008)(8676002)(8936002)(44832011)(41300700001)(5660300002)(2906002)(86362001)(82960400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0lRNjB0RDRVSU1lSlpVZndvdlMyK2RtblhGSFZTMmlVUGt3bGlrbG85WVpR?= =?utf-8?B?eU1xQzg3NVUvUkVwYjBIb2RkMHhUclVseDBpNy8wQXZ5dGdrVW50NHhZeHpo?= =?utf-8?B?b240aTd6ZHRNRTNLQ2kzR0VaK1ZTakJiKzB3ZEJ1RFl4Rjk1eHk0bjMwT3Rr?= =?utf-8?B?eCtBVWdodGpWTSs3R0xmU0hZQ3Z0RGxMa2czZk9hZHZSb05xUUdzRncyVVlX?= =?utf-8?B?QlNyVEduc1ZTUnNRbENNWkoxSzFsUEh6cE04N0tsZzVpUWhvSXpJZmJWVkFE?= =?utf-8?B?Q3p2eHllb0xTUlBqNjV6OGJVdHdhcSt0cDFQMnZITVZCU3hDRTdFQ0NldEhP?= =?utf-8?B?TWVudHRWMGJBLzRTWjVMcjhQWUpPVHJMcVM1RUpqYWxvTzc0NGNOdXo4dTFv?= =?utf-8?B?MDVidm1tT1NWcU9Yc1cyMUlIYlBEcHB1UWlvMmtDRU1UaHBSVXNSS3lqeThj?= =?utf-8?B?S0R1WS9lS2FlVElkaUd1dnZUTmQwSG9yNndhYlE0QWdYMVZhdG91b0dtbElW?= =?utf-8?B?cDhzNXo4ZnlLRWk5ekhkdnA1U1ZBMEtFekwybmRwejFSZzJpdVlnd1EwdlNC?= =?utf-8?B?TUZ1elJ5Nlo5aWhSMWJOSjFIWnRReGsrZjVQZTl2N0J2RjZPSmppM2FZLy9W?= =?utf-8?B?QVFWTEVmR0I0YzdzbDBrMWhGTXhuNThZN0lLeDA5dzZEcEx0QzAyZDEyTVVs?= =?utf-8?B?TVVEOFNCMW1acCtzdUI3TGU3NTRmbW4yS05ZSWIyb2hYUDBrNWIrbWFjdzZt?= =?utf-8?B?WjJUZDlKSzV4MG1aVFFaNjRqb3ZMME1nUk1DMmxRRzl3MW81ZUdSWW1yZHJX?= =?utf-8?B?SFJLOU9rVlp0WWJpdVNxcUhYSnVUdWdVbnZNbXovbkFFWGF6MUtGVXdxbDEx?= =?utf-8?B?SGxPNnFmdkljaENjZVZZY3IvSnNuMlRiOHdUb2k5Tmh0czdHcVhVOU9ESGJB?= =?utf-8?B?NFRXT0cvT3c0Ym1IKzNRV2t6ckpITFVUVGljY0tHQkRwaHhPVjMzYTIyOFNo?= =?utf-8?B?eUdKU29ITk9hajBNemNBUkJaWTVPMG5EYlZld3hjaXZ6aDdEdmx4d1ZOSk4w?= =?utf-8?B?eGk5T3V6ZXluMHZwc1FldytldTRTakh1ZVhjalhkOTZrZ1lNa3A3Q052UFh3?= =?utf-8?B?L1RHSktXU0lhUkpBaG4wT01xMzBUUmJvdjBpRm4yMTlSUEQ1VTN4d2ZFOFB1?= =?utf-8?B?bG1icFhWVnBPMUdQaVJERmZxeEtoZjJoMUt4R2laNGc3K2tWbTMwVHhPRjYz?= =?utf-8?B?R0tFZnlqeVNVaTRBRWJPQnZtRURuZGZaN0tkMm5uTVBKQXRXbStlZmxuWmps?= =?utf-8?B?WHdVciszVVpFQ2U2cnZvUXRmU1BaTkNUOVl0MXJRVlF0RXYvNzJ2dm5MZXdo?= =?utf-8?B?WmRnOHZPT09sRTJsZmZKZjhMVjVOYjFEb2lEdThaYS9mN3BDNWNxbjR1ZmFn?= =?utf-8?B?RlI2TlJnR1BoZDQydXE2K1hMb1J1em9mYzdkZDNpOTF6OWh5bTRwUXNhZDJ3?= =?utf-8?B?UVNOeS9XRlMxenAwRWY4WjlPQ2hBYTN5OEV0Zm9oWG82MUJNYURBU1R5LzJx?= =?utf-8?B?TXh4WjFQYTJOdUxEbTRkVFVtdGZJcTlJWCthQ08wYmlLUGRhNTU0T1lFV1hq?= =?utf-8?B?ZUVTSEd1aXF6bmh1bEdCYlQyYlFMMXBib010L1ZhNHc2aGJZamVPV1RBWHVM?= =?utf-8?B?d3p0YWZHQVhwYy94Qi91VFEyeXViOHdCRUlzTFRuWGpXYmRidnRXZksrQjJJ?= =?utf-8?B?M0RJbHJGRm4xdE8rMnRYTUpESGxyQWY5Z3ZhUG0zc1BKY2FZSmkwOEZwVzZr?= =?utf-8?B?bGppRElJdDM5cHF2ZGt5SlYxcFlVZ0VodjVXMTJoZUtQMUxyRjVzWEFhYmpi?= =?utf-8?B?ajBzUUhwOE9Scmc0cmRERUtqdDE3R0cvTTFXU2VzUGorNEoxb3FTam80T1NM?= =?utf-8?B?ZzFUT1c3TVNnb2o0U3FTZSt0amZVU1F0WU9WNDZPOTRnZFc1VTNRY0FxWXZK?= =?utf-8?B?SzdFbG5SV1ZORnptSGE1bDdlckx5WkVGTllpeDJOSHNLd2FXUzA5RFNnUnJo?= =?utf-8?B?Q1czc1I2RmZ3Q09yS0ttcENEbndUOStNd0ZxVWlCYzZGSTdxSmVGVXFOYkZU?= =?utf-8?B?eGRUSXZYNllJQWJNNEQ3TWZSUS81N2JXb0ZNeStlSWp0NytJNzU1VjJyUDRI?= =?utf-8?B?SHc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0e81168b-f849-4237-1309-08dbce51afd4 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 14:10:44.2901 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eYSj/qGNbRau4CzfCyX8KYpZL78BzgN9nO1ci6bcYqE18qlOSMKmKvVXjrBqTMhutd8DcTxvR21fK0MTycmmJUBbBLidyQZFBsNzr688lMo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4642 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Oct 16, 2023 at 06:50:47PM +0530, Jerin Jacob wrote: > On Fri, Sep 29, 2023 at 3:29 PM wrote: > > > > From: Sunil Kumar Kori > > > > It adds ethdev module to configure ethernet devices. > > > > Following commands are exposed: > > - ethdev rxq txq > > - ethdev mtu > > - ethdev promiscuous > > - ethdev show > > - ethdev stats > > - ethdev ip4 addr add netmask > > - ethdev ip6 addr add netmask > > - help ethdev > > > > Signed-off-by: Sunil Kumar Kori > > Signed-off-by: Rakesh Kudurumalla > > --- > > Acked-by: Jerin Jacob Just FYI - if patchset [1] is merged, you could potentially save a lot of code additions in this library by autogenerating the boilerplate for the commandline. Maybe you could take a look and see if it could work for your usecase here with commandline. If any cmdline features are missing with it, it could be good to add them. /Bruce [1] http://patches.dpdk.org/project/dpdk/list/?series=29852