[PATCH 1/1] app/test: resolve mbuf_test application failure

[PATCH 1/1] app/test: resolve mbuf_test application failure

[Rakesh Kudurumalla]

when RTE_ENABLE_ASSERT is defined test_mbuf application is
failing because we are trying to attach extbuf to a cloned
buffer to which external mbuf is already attached.This patch
fixes the same.

Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
Change-Id: Ia5a0f8a81036e12a1cfec82e61bfd6f1d0c6f89e
---
 app/test/test_mbuf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 8d8d3b9386..e2b81db308 100644
--- a/app/test/test_mbuf.c
+++ b/app/test/test_mbuf.c
@@ -2375,6 +2375,7 @@ test_pktmbuf_ext_shinfo_init_helper(struct rte_mempool *pktmbuf_pool)
 		GOTO_FAIL("%s: Bad packet length\n", __func__);
 
 	/* attach the same external buffer to the cloned mbuf */
+	clone->ol_flags = 0;
 	rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova, buf_len,
 			ret_shinfo);
 	if (clone->ol_flags != RTE_MBUF_F_EXTERNAL)
-- 
2.25.1

[PATCH 1/1] app/test: resolve mbuf_test application failure

[Rakesh Kudurumalla]

when RTE_ENABLE_ASSERT is defined test_mbuf application is
failing because we are trying to attach extbuf to a cloned
buffer to which external mbuf is already attached.This patch
fixes the same.

Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
---
v2: removed gerrit id

 app/test/test_mbuf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 8d8d3b9386..e2b81db308 100644
--- a/app/test/test_mbuf.c
+++ b/app/test/test_mbuf.c
@@ -2375,6 +2375,7 @@ test_pktmbuf_ext_shinfo_init_helper(struct rte_mempool *pktmbuf_pool)
 		GOTO_FAIL("%s: Bad packet length\n", __func__);
 
 	/* attach the same external buffer to the cloned mbuf */
+	clone->ol_flags = 0;
 	rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova, buf_len,
 			ret_shinfo);
 	if (clone->ol_flags != RTE_MBUF_F_EXTERNAL)
-- 
2.25.1

RE: [PATCH 1/1] app/test: resolve mbuf_test application failure

[Rakesh Kudurumalla]

Ping

Regards,
Rakesh

> -----Original Message-----
> From: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> Sent: Wednesday, April 26, 2023 2:58 PM
> To: Olivier Matz <olivier.matz@6wind.com>
> Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin
> Kumar Dabilpuram <ndabilpuram@marvell.com>; Rakesh Kudurumalla
> <rkudurumalla@marvell.com>
> Subject: [PATCH 1/1] app/test: resolve mbuf_test application failure
> 
> when RTE_ENABLE_ASSERT is defined test_mbuf application is failing
> because we are trying to attach extbuf to a cloned buffer to which external
> mbuf is already attached.This patch fixes the same.
> 
> Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> ---
> v2: removed gerrit id
> 
>  app/test/test_mbuf.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index
> 8d8d3b9386..e2b81db308 100644
> --- a/app/test/test_mbuf.c
> +++ b/app/test/test_mbuf.c
> @@ -2375,6 +2375,7 @@ test_pktmbuf_ext_shinfo_init_helper(struct
> rte_mempool *pktmbuf_pool)
>  		GOTO_FAIL("%s: Bad packet length\n", __func__);
> 
>  	/* attach the same external buffer to the cloned mbuf */
> +	clone->ol_flags = 0;
>  	rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova, buf_len,
>  			ret_shinfo);
>  	if (clone->ol_flags != RTE_MBUF_F_EXTERNAL)
> --
> 2.25.1

RE: [EXT] [PATCH 1/1] app/test: resolve mbuf_test application failure

[Ashwin Sekhar T K]

Acked-by: Ashwin Sekhar T K <asekhar@marvell.com>

Ashwin Sekhar T K 

> -----Original Message-----
> From: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> Sent: Wednesday, April 26, 2023 2:58 PM
> To: Olivier Matz <olivier.matz@6wind.com>
> Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin
> Kumar Dabilpuram <ndabilpuram@marvell.com>; Rakesh Kudurumalla
> <rkudurumalla@marvell.com>
> Subject: [EXT] [PATCH 1/1] app/test: resolve mbuf_test application failure
> 
> External Email
> 
> ----------------------------------------------------------------------
> when RTE_ENABLE_ASSERT is defined test_mbuf application is failing
> because we are trying to attach extbuf to a cloned buffer to which external
> mbuf is already attached.This patch fixes the same.
> 
> Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> ---
> v2: removed gerrit id
> 
>  app/test/test_mbuf.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index
> 8d8d3b9386..e2b81db308 100644
> --- a/app/test/test_mbuf.c
> +++ b/app/test/test_mbuf.c
> @@ -2375,6 +2375,7 @@ test_pktmbuf_ext_shinfo_init_helper(struct
> rte_mempool *pktmbuf_pool)
>  		GOTO_FAIL("%s: Bad packet length\n", __func__);
> 
>  	/* attach the same external buffer to the cloned mbuf */
> +	clone->ol_flags = 0;
>  	rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova,
> buf_len,
>  			ret_shinfo);
>  	if (clone->ol_flags != RTE_MBUF_F_EXTERNAL)
> --
> 2.25.1

Re: [PATCH 1/1] app/test: resolve mbuf_test application failure

[Olivier Matz]

Hi Rakesh,

On Tue, May 23, 2023 at 03:39:53PM +0000, Rakesh Kudurumalla wrote:
> Ping
> 
> Regards,
> Rakesh
> 
> > -----Original Message-----
> > From: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> > Sent: Wednesday, April 26, 2023 2:58 PM
> > To: Olivier Matz <olivier.matz@6wind.com>
> > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin
> > Kumar Dabilpuram <ndabilpuram@marvell.com>; Rakesh Kudurumalla
> > <rkudurumalla@marvell.com>
> > Subject: [PATCH 1/1] app/test: resolve mbuf_test application failure
> > 
> > when RTE_ENABLE_ASSERT is defined test_mbuf application is failing
> > because we are trying to attach extbuf to a cloned buffer to which external
> > mbuf is already attached.This patch fixes the same.
> > 
> > Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> > ---
> > v2: removed gerrit id
> > 
> >  app/test/test_mbuf.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index
> > 8d8d3b9386..e2b81db308 100644
> > --- a/app/test/test_mbuf.c
> > +++ b/app/test/test_mbuf.c
> > @@ -2375,6 +2375,7 @@ test_pktmbuf_ext_shinfo_init_helper(struct
> > rte_mempool *pktmbuf_pool)
> >  		GOTO_FAIL("%s: Bad packet length\n", __func__);
> > 
> >  	/* attach the same external buffer to the cloned mbuf */
> > +	clone->ol_flags = 0;
> >  	rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova, buf_len,
> >  			ret_shinfo);

I think we can simply remove the call to rte_pktmbuf_attach_extbuf() because
after the call to rte_pktmbuf_clone(), the mbuf is already attached.

I mean something like this:

  --- a/app/test/test_mbuf.c
  +++ b/app/test/test_mbuf.c
  @@ -2345,16 +2345,12 @@ test_pktmbuf_ext_shinfo_init_helper(struct rte_mempool *pktmbuf_pool)
                  GOTO_FAIL("%s: External buffer is not attached to mbuf\n",
                                  __func__);
   
  -       /* allocate one more mbuf */
  +       /* allocate one more mbuf, it is attached to the same external buffer */
          clone = rte_pktmbuf_clone(m, pktmbuf_pool);
          if (clone == NULL)
                  GOTO_FAIL("%s: mbuf clone allocation failed!\n", __func__);
          if (rte_pktmbuf_pkt_len(clone) != 0)
                  GOTO_FAIL("%s: Bad packet length\n", __func__);
  -
  -       /* attach the same external buffer to the cloned mbuf */
  -       rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova, buf_len,
  -                       ret_shinfo);
          if (clone->ol_flags != RTE_MBUF_F_EXTERNAL)
                  GOTO_FAIL("%s: External buffer is not attached to mbuf\n",
                                  __func__);


Regards,
Olivier

RE: [EXT] Re: [PATCH 1/1] app/test: resolve mbuf_test application failure

[Rakesh Kudurumalla]

> -----Original Message-----
> From: Olivier Matz <olivier.matz@6wind.com>
> Sent: Wednesday, July 5, 2023 9:42 PM
> To: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin
> Kumar Dabilpuram <ndabilpuram@marvell.com>
> Subject: [EXT] Re: [PATCH 1/1] app/test: resolve mbuf_test application failure
> 
> External Email
> 
> ----------------------------------------------------------------------
> Hi Rakesh,
> 
> On Tue, May 23, 2023 at 03:39:53PM +0000, Rakesh Kudurumalla wrote:
> > Ping
> >
> > Regards,
> > Rakesh
> >
> > > -----Original Message-----
> > > From: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> > > Sent: Wednesday, April 26, 2023 2:58 PM
> > > To: Olivier Matz <olivier.matz@6wind.com>
> > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> > > Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Rakesh
> > > Kudurumalla <rkudurumalla@marvell.com>
> > > Subject: [PATCH 1/1] app/test: resolve mbuf_test application failure
> > >
> > > when RTE_ENABLE_ASSERT is defined test_mbuf application is failing
> > > because we are trying to attach extbuf to a cloned buffer to which
> > > external mbuf is already attached.This patch fixes the same.
> > >
> > > Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> > > ---
> > > v2: removed gerrit id
> > >
> > >  app/test/test_mbuf.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index
> > > 8d8d3b9386..e2b81db308 100644
> > > --- a/app/test/test_mbuf.c
> > > +++ b/app/test/test_mbuf.c
> > > @@ -2375,6 +2375,7 @@ test_pktmbuf_ext_shinfo_init_helper(struct
> > > rte_mempool *pktmbuf_pool)
> > >  		GOTO_FAIL("%s: Bad packet length\n", __func__);
> > >
> > >  	/* attach the same external buffer to the cloned mbuf */
> > > +	clone->ol_flags = 0;
> > >  	rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova, buf_len,
> > >  			ret_shinfo);
> 
> I think we can simply remove the call to rte_pktmbuf_attach_extbuf()
> because after the call to rte_pktmbuf_clone(), the mbuf is already attached.
> 
Yes we can remove call to rte_pktmbuf_attach_extbuf()

> I mean something like this:
> 
>   --- a/app/test/test_mbuf.c
>   +++ b/app/test/test_mbuf.c
>   @@ -2345,16 +2345,12 @@ test_pktmbuf_ext_shinfo_init_helper(struct
> rte_mempool *pktmbuf_pool)
>                   GOTO_FAIL("%s: External buffer is not attached to mbuf\n",
>                                   __func__);
> 
>   -       /* allocate one more mbuf */
>   +       /* allocate one more mbuf, it is attached to the same external buffer
> */
>           clone = rte_pktmbuf_clone(m, pktmbuf_pool);
>           if (clone == NULL)
>                   GOTO_FAIL("%s: mbuf clone allocation failed!\n", __func__);
>           if (rte_pktmbuf_pkt_len(clone) != 0)
>                   GOTO_FAIL("%s: Bad packet length\n", __func__);
>   -
>   -       /* attach the same external buffer to the cloned mbuf */
>   -       rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova, buf_len,
>   -                       ret_shinfo);
>           if (clone->ol_flags != RTE_MBUF_F_EXTERNAL)
>                   GOTO_FAIL("%s: External buffer is not attached to mbuf\n",
>                                   __func__);
> 
> 
> Regards,
> Olivier

[PATCH v2 1/1] app/test: resolve mbuf_test application failure

[Rakesh Kudurumalla]

when RTE_ENABLE_ASSERT is defined test_mbuf application is
failing because we are trying to attach extbuf to a cloned
buffer to which external mbuf is already attached.To make
test_mbuf pass CI we have updated ol_flags. This patch fixes
the same.

Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
---
v2 : Addressed comments by removing extbuf call
     as mbuf is already attached

 app/test/test_mbuf.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index efac01806b..722e1ef624 100644
--- a/app/test/test_mbuf.c
+++ b/app/test/test_mbuf.c
@@ -2345,16 +2345,13 @@ test_pktmbuf_ext_shinfo_init_helper(struct rte_mempool *pktmbuf_pool)
 		GOTO_FAIL("%s: External buffer is not attached to mbuf\n",
 				__func__);
 
-	/* allocate one more mbuf */
+	/* allocate one more mbuf, it is attached to the same external buffer */
 	clone = rte_pktmbuf_clone(m, pktmbuf_pool);
 	if (clone == NULL)
 		GOTO_FAIL("%s: mbuf clone allocation failed!\n", __func__);
 	if (rte_pktmbuf_pkt_len(clone) != 0)
 		GOTO_FAIL("%s: Bad packet length\n", __func__);
 
-	/* attach the same external buffer to the cloned mbuf */
-	rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova, buf_len,
-			ret_shinfo);
 	if (clone->ol_flags != RTE_MBUF_F_EXTERNAL)
 		GOTO_FAIL("%s: External buffer is not attached to mbuf\n",
 				__func__);
-- 
2.25.1

RE: [PATCH v2 1/1] app/test: resolve mbuf_test application failure

[Rakesh Kudurumalla]

Hi Olivier,

Let me know if you have any comments on this patch.

Regards,
Rakesh

> -----Original Message-----
> From: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> Sent: Wednesday, July 26, 2023 11:25 AM
> To: Olivier Matz <olivier.matz@6wind.com>
> Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin
> Kumar Dabilpuram <ndabilpuram@marvell.com>; Rakesh Kudurumalla
> <rkudurumalla@marvell.com>
> Subject: [PATCH v2 1/1] app/test: resolve mbuf_test application failure
> 
> when RTE_ENABLE_ASSERT is defined test_mbuf application is failing
> because we are trying to attach extbuf to a cloned buffer to which external
> mbuf is already attached.To make test_mbuf pass CI we have updated
> ol_flags. This patch fixes the same.
> 
> Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> ---
> v2 : Addressed comments by removing extbuf call
>      as mbuf is already attached
> 
>  app/test/test_mbuf.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index
> efac01806b..722e1ef624 100644
> --- a/app/test/test_mbuf.c
> +++ b/app/test/test_mbuf.c
> @@ -2345,16 +2345,13 @@ test_pktmbuf_ext_shinfo_init_helper(struct
> rte_mempool *pktmbuf_pool)
>  		GOTO_FAIL("%s: External buffer is not attached to mbuf\n",
>  				__func__);
> 
> -	/* allocate one more mbuf */
> +	/* allocate one more mbuf, it is attached to the same external buffer
> +*/
>  	clone = rte_pktmbuf_clone(m, pktmbuf_pool);
>  	if (clone == NULL)
>  		GOTO_FAIL("%s: mbuf clone allocation failed!\n", __func__);
>  	if (rte_pktmbuf_pkt_len(clone) != 0)
>  		GOTO_FAIL("%s: Bad packet length\n", __func__);
> 
> -	/* attach the same external buffer to the cloned mbuf */
> -	rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova,
> buf_len,
> -			ret_shinfo);
>  	if (clone->ol_flags != RTE_MBUF_F_EXTERNAL)
>  		GOTO_FAIL("%s: External buffer is not attached to mbuf\n",
>  				__func__);
> --
> 2.25.1

Re: [PATCH v2 1/1] app/test: resolve mbuf_test application failure

[Olivier Matz]

Hi Rakesh,

Sorry for the delay.

On Tue, Oct 03, 2023 at 04:20:57AM +0000, Rakesh Kudurumalla wrote:
> Hi Olivier,
> 
> Let me know if you have any comments on this patch.
> 
> Regards,
> Rakesh
> 
> > -----Original Message-----
> > From: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> > Sent: Wednesday, July 26, 2023 11:25 AM
> > To: Olivier Matz <olivier.matz@6wind.com>
> > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin
> > Kumar Dabilpuram <ndabilpuram@marvell.com>; Rakesh Kudurumalla
> > <rkudurumalla@marvell.com>
> > Subject: [PATCH v2 1/1] app/test: resolve mbuf_test application failure

app/test: fix external mbuf test when assertions enabled

> > 
> > when RTE_ENABLE_ASSERT is defined test_mbuf application is failing
> > because we are trying to attach extbuf to a cloned buffer to which external
> > mbuf is already attached.To make test_mbuf pass CI we have updated
> > ol_flags. This patch fixes the same.
> > 

Fixes: 7b295dceea07 ("test/mbuf: add unit test cases")

> > Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

> > ---
> > v2 : Addressed comments by removing extbuf call
> >      as mbuf is already attached
> > 
> >  app/test/test_mbuf.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index
> > efac01806b..722e1ef624 100644
> > --- a/app/test/test_mbuf.c
> > +++ b/app/test/test_mbuf.c
> > @@ -2345,16 +2345,13 @@ test_pktmbuf_ext_shinfo_init_helper(struct
> > rte_mempool *pktmbuf_pool)
> >  		GOTO_FAIL("%s: External buffer is not attached to mbuf\n",
> >  				__func__);
> > 
> > -	/* allocate one more mbuf */
> > +	/* allocate one more mbuf, it is attached to the same external buffer
> > +*/
> >  	clone = rte_pktmbuf_clone(m, pktmbuf_pool);
> >  	if (clone == NULL)
> >  		GOTO_FAIL("%s: mbuf clone allocation failed!\n", __func__);
> >  	if (rte_pktmbuf_pkt_len(clone) != 0)
> >  		GOTO_FAIL("%s: Bad packet length\n", __func__);
> > 
> > -	/* attach the same external buffer to the cloned mbuf */
> > -	rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova,
> > buf_len,
> > -			ret_shinfo);
> >  	if (clone->ol_flags != RTE_MBUF_F_EXTERNAL)
> >  		GOTO_FAIL("%s: External buffer is not attached to mbuf\n",
> >  				__func__);
> > --
> > 2.25.1
> 

[PATCH v3 1/1] app/test: fix external mbuf test when assertions enabled

[Rakesh Kudurumalla]

when RTE_ENABLE_ASSERT is defined test_mbuf application is
failing because we are trying to attach extbuf to a cloned
buffer to which external mbuf is already attached.To make
test_mbuf pass CI we have updated ol_flags. This patch fixes
the same.

Fixes: 7b295dceea07 ("test/mbuf: add unit test cases")

Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
---
v3: Updated commit message and added Fixes
 app/test/test_mbuf.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index d7393df7eb..a39288a5f8 100644
--- a/app/test/test_mbuf.c
+++ b/app/test/test_mbuf.c
@@ -2345,16 +2345,13 @@ test_pktmbuf_ext_shinfo_init_helper(struct rte_mempool *pktmbuf_pool)
 		GOTO_FAIL("%s: External buffer is not attached to mbuf\n",
 				__func__);
 
-	/* allocate one more mbuf */
+	/* allocate one more mbuf, it is attached to the same external buffer */
 	clone = rte_pktmbuf_clone(m, pktmbuf_pool);
 	if (clone == NULL)
 		GOTO_FAIL("%s: mbuf clone allocation failed!\n", __func__);
 	if (rte_pktmbuf_pkt_len(clone) != 0)
 		GOTO_FAIL("%s: Bad packet length\n", __func__);
 
-	/* attach the same external buffer to the cloned mbuf */
-	rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova, buf_len,
-			ret_shinfo);
 	if (clone->ol_flags != RTE_MBUF_F_EXTERNAL)
 		GOTO_FAIL("%s: External buffer is not attached to mbuf\n",
 				__func__);
-- 
2.25.1

Re: [PATCH v3 1/1] app/test: fix external mbuf test when assertions enabled

[Thomas Monjalon]

23/11/2023 07:42, Rakesh Kudurumalla:
> when RTE_ENABLE_ASSERT is defined test_mbuf application is
> failing because we are trying to attach extbuf to a cloned
> buffer to which external mbuf is already attached.To make
> test_mbuf pass CI we have updated ol_flags. This patch fixes
> the same.
> 
> Fixes: 7b295dceea07 ("test/mbuf: add unit test cases")
> 
> Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks.