From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E8D74318A; Tue, 17 Oct 2023 15:18:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0E3742DC5; Tue, 17 Oct 2023 15:18:26 +0200 (CEST) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id F1E8742DAC for ; Tue, 17 Oct 2023 15:18:25 +0200 (CEST) Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-32d569e73acso5061292f8f.1 for ; Tue, 17 Oct 2023 06:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1697548705; x=1698153505; darn=dpdk.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=i2gRyNIEaeMsYNinUK4Er9mBF7OEeL4UiX3TD+HGjf0=; b=jAJY9UAhKZloGLSe+26wFRsuI3vS4B/ISaFu37uTThtIiOrN+rgL8QZla70t3RNX0A IWrlTyRYT1KlmKe4S/a7ZJQQTUb5L2CG936ZThSmN1R8azZjFdGlwXAL+vFzPP33i3Ie OrlR8MSzZZshe8LfjkjKgntd9YiusR76pTMHQWiqWnd0bx4MjH/RPK4lGVpAi78nL3He ooAAE98sQpQWixwZ5j+/1ldOncXrYFGab3jQNQkY2/acDZOcR+jE/zGmCS4asAcQsfcP ykty1w0e222GP/XNrrYJYgTQqJAnaxvuRQ1uScNRp2IAkp9JttqtBi9KK5fSB/6pwziD ivJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697548705; x=1698153505; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i2gRyNIEaeMsYNinUK4Er9mBF7OEeL4UiX3TD+HGjf0=; b=XmIAHSBG4Ayi2+mUHp100gZccBieYslH0hB7tN5aBXGCqV2ZpqSgrAqsohhOovCOVI OBeFBu8Vzz18wHoFYaJGH3KtOElcmUB/eaaN3//xGlz9vWOussgAHuD0He2SzLdFicGS tnoKi+k16Q0Ae8yfUIK7dPxBCmLD1LbMqfLHkj5wJTAr4rKhPhepjrGdMNhOAWiuKhUc tezCL+hFJ4nXlziJxLdlrnMz91fJ1KSZq4bEg/TTiH0/pmTtTfufQh/WMNhirn+Iabrz YNP9JDvg2KOt0MUZkXiaB0XoAIgFFDFWTtWkMt6PI95rUKXzp7ItF9h0ptwGOSiDw5w8 CkLg== X-Gm-Message-State: AOJu0YzkuCTaBmDCOgRBITPnZbbtFTlet5IwFQYyOoUl25HA6K6b9Di7 wKeiHLqqnhucmqkzE0W3DPGGqQ== X-Google-Smtp-Source: AGHT+IGyqhCk+Ie2oSxu+TRdd5YlMLSwMH7d3bAJzEtF2sAX8iG4TRI5QM6uGP1sQYhyvAmQ7xjclg== X-Received: by 2002:a05:6000:137b:b0:321:67d8:c3e7 with SMTP id q27-20020a056000137b00b0032167d8c3e7mr1945228wrz.12.1697548705504; Tue, 17 Oct 2023 06:18:25 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id k7-20020a5d5187000000b003253523d767sm1668464wrv.109.2023.10.17.06.18.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 06:18:24 -0700 (PDT) Date: Tue, 17 Oct 2023 15:18:23 +0200 From: Olivier Matz To: Rakesh Kudurumalla Cc: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram Subject: Re: [PATCH v2 1/1] app/test: resolve mbuf_test application failure Message-ID: References: <20230426092750.2423850-1-rkudurumalla@marvell.com> <20230726055507.1183617-1-rkudurumalla@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Rakesh, Sorry for the delay. On Tue, Oct 03, 2023 at 04:20:57AM +0000, Rakesh Kudurumalla wrote: > Hi Olivier, > > Let me know if you have any comments on this patch. > > Regards, > Rakesh > > > -----Original Message----- > > From: Rakesh Kudurumalla > > Sent: Wednesday, July 26, 2023 11:25 AM > > To: Olivier Matz > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Nithin > > Kumar Dabilpuram ; Rakesh Kudurumalla > > > > Subject: [PATCH v2 1/1] app/test: resolve mbuf_test application failure app/test: fix external mbuf test when assertions enabled > > > > when RTE_ENABLE_ASSERT is defined test_mbuf application is failing > > because we are trying to attach extbuf to a cloned buffer to which external > > mbuf is already attached.To make test_mbuf pass CI we have updated > > ol_flags. This patch fixes the same. > > Fixes: 7b295dceea07 ("test/mbuf: add unit test cases") > > Signed-off-by: Rakesh Kudurumalla Acked-by: Olivier Matz > > --- > > v2 : Addressed comments by removing extbuf call > > as mbuf is already attached > > > > app/test/test_mbuf.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index > > efac01806b..722e1ef624 100644 > > --- a/app/test/test_mbuf.c > > +++ b/app/test/test_mbuf.c > > @@ -2345,16 +2345,13 @@ test_pktmbuf_ext_shinfo_init_helper(struct > > rte_mempool *pktmbuf_pool) > > GOTO_FAIL("%s: External buffer is not attached to mbuf\n", > > __func__); > > > > - /* allocate one more mbuf */ > > + /* allocate one more mbuf, it is attached to the same external buffer > > +*/ > > clone = rte_pktmbuf_clone(m, pktmbuf_pool); > > if (clone == NULL) > > GOTO_FAIL("%s: mbuf clone allocation failed!\n", __func__); > > if (rte_pktmbuf_pkt_len(clone) != 0) > > GOTO_FAIL("%s: Bad packet length\n", __func__); > > > > - /* attach the same external buffer to the cloned mbuf */ > > - rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova, > > buf_len, > > - ret_shinfo); > > if (clone->ol_flags != RTE_MBUF_F_EXTERNAL) > > GOTO_FAIL("%s: External buffer is not attached to mbuf\n", > > __func__); > > -- > > 2.25.1 >