DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: <dev@dpdk.org>, <david.marchand@redhat.com>
Subject: Re: [PATCH 1/2] build: temporarily disable MSVC warnings
Date: Tue, 17 Oct 2023 14:31:24 +0100	[thread overview]
Message-ID: <ZS6MrGHI52o9fF6g@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1697548427-10153-2-git-send-email-roretzla@linux.microsoft.com>

On Tue, Oct 17, 2023 at 06:13:46AM -0700, Tyler Retzlaff wrote:
> Temporarily disable integer truncation and conversion warnings for MSVC
> to allow CI pipeline to be established.
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
>  config/meson.build | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/config/meson.build b/config/meson.build
> index d56b0f9..6e8320e 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -36,6 +36,9 @@ if is_ms_compiler
>      # the MSVC compiler regards as unsafe but are used by DPDK
>      dpdk_conf.set('_CRT_SECURE_NO_WARNINGS', 1)
>  
> +    # temporarily disable msvc specific warnings
> +    add_project_arguments('/wd4244', '/wd4267', language: 'c')
> +

Please add a comment line above indicating what the warning is being
disabled, e.g. unsigned compare warning etc.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

  reply	other threads:[~2023-10-17 13:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17 13:13 [PATCH 0/2] make dpdk buildable with latest msvc Tyler Retzlaff
2023-10-17 13:13 ` [PATCH 1/2] build: temporarily disable MSVC warnings Tyler Retzlaff
2023-10-17 13:31   ` Bruce Richardson [this message]
2023-10-17 13:13 ` [PATCH 2/2] eal: temporarily disable standard c atomics support for MSVC Tyler Retzlaff
2023-10-17 13:49 ` [PATCH v2 0/2] make dpdk buildable with latest msvc Tyler Retzlaff
2023-10-17 13:49   ` [PATCH v2 1/2] build: temporarily disable MSVC warnings Tyler Retzlaff
2023-10-17 13:49   ` [PATCH v2 2/2] eal: disable standard c atomics support check for MSVC Tyler Retzlaff
2023-10-31 18:39   ` [PATCH v2 0/2] make dpdk buildable with latest msvc David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZS6MrGHI52o9fF6g@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=roretzla@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).