From: Bruce Richardson <bruce.richardson@intel.com>
To: <dev@dpdk.org>
Cc: <mattias.ronnblom@ericsson.com>
Subject: Re: [PATCH] event/dsw: fix missing device pointer
Date: Tue, 17 Oct 2023 16:55:28 +0100 [thread overview]
Message-ID: <ZS6ucJJTgbC7pb6y@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20231017154532.152741-1-bruce.richardson@intel.com>
On Tue, Oct 17, 2023 at 04:45:32PM +0100, Bruce Richardson wrote:
> After calling rte_event_dev_info_get() the ".dev" field of the info
> structure should have a pointer to the underlying device, allowing the
> user to e.g. get the device name using using rte_dev_name(info.dev).
>
> The distributed software eventdev info structure did not return a correct
> device pointer, though, instead returning NULL, which caused crashes
> getting "rte_dev_name". Initializing the dev pointer inside the
> "eventdev" struct in the device probe function fixes this by ensuring we
> have a valid pointer to return in info_get calls.
>
> Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build
> system") Cc: mattias.ronnblom@ericsson.com
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> ---
Since checkpatch has flagged a duplicated word in my commit log above,
copy-pasted from the equivalent event/sw patch fix, I'm sending a v2 of the
two together in a patchset. See thread [1] for that v2.
/Bruce
[1] https://inbox.dpdk.org/dev/20231017155148.153095-1-bruce.richardson@intel.com/
next prev parent reply other threads:[~2023-10-17 15:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 15:45 Bruce Richardson
2023-10-17 15:55 ` Bruce Richardson [this message]
2023-10-17 16:04 ` Jerin Jacob
2023-10-17 16:11 ` David Marchand
2023-10-17 16:15 ` Bruce Richardson
2023-10-17 16:51 ` Jerin Jacob
2023-10-18 5:18 ` Jerin Jacob
2023-10-18 6:29 ` Mattias Rönnblom
2023-10-18 9:45 ` Bruce Richardson
2023-10-18 12:13 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS6ucJJTgbC7pb6y@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).