From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AF044318D; Tue, 17 Oct 2023 17:55:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E884A40273; Tue, 17 Oct 2023 17:55:51 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 6C9FE40270 for ; Tue, 17 Oct 2023 17:55:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697558150; x=1729094150; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=xifr0ATmrSmreJ1ygcjt7of+wAMS2BdlaVklKjQ2EIg=; b=IQOZoQGrvaqzZ5qjO0gVkJujSOSv5CHKiS5zMky2ux4ZOj3BaDfRgqAR Mz24QX1ralEhMc+3b7YYE0ufcc9+qvtAIqly5/szm5UBxdrkoaodPwvVC uKGH880Yd6LGpsbPIGdsTo7a6wQ7viu50OBJ8xWzKX4qJ+J3ASFU2RlEP 9J0B2ghLLXk8kHbImB8zhdumulPzynRMu+Cm35/OGRes412SiTVgTwkDG Y7/5RXoYoZxUE8NgjRZ6/J6lyuyotWr5tMGK+vWUqM4f/EA+5FkXlU7iz sHwWxwV537uCU9VkIHicggNbzXK9I345YPktGW48Mryu93dAZdVj3RAfZ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="472037534" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="472037534" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2023 08:55:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="732762526" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="732762526" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Oct 2023 08:55:46 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 17 Oct 2023 08:55:40 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 17 Oct 2023 08:55:40 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 17 Oct 2023 08:55:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VsaH/95RFqz+kd8TFgLw9blzQGyulsCfZMYIt2P3gQRHPb8goBE4H6wV2CIod297Vo3SRuH9BIDsUoJu0yYJt8fIT0f+Peu2pXZOGICL1ck/qnjud4kv32bDkeFBz+BkyVaagjrs/REHTi13GdH3oexTK/TfHi4NBIaG8zGbTqi17TrtV67KmQOCE5stu3eZC1iq2HvWCAm+5iZrPbCRRi2WNNvqmiBhlUhiQMXC8c9JVawHnvNwJKKmp1ERyG6M4eO4fgrW3DECy9Q1B84capQ6q+q5uvR3EYP2ZG0NwcfvhkAwLlI35zso+B7l70b3cCYS7oMh4xm+cnShimHtCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FweLe2yIC+5pt4MY4ntxykN8qQUrLYf2LU+FpxrBZOE=; b=RvioexXXfa4kludbO5qXGa26YysJ0aHQJ5C0bzPVFklAdksYA8rKLOkKiShNqg3M/C/UKRY/aCnznZrpJqXFtrI4Q6FCippVmd7BdyFUFF+5Omh8HmJ7Y0MUGIgw6OjlDgny7u00uYOjGzBWZKCYzQfmFoJzwZT0Cc1tvNX08IhgqM/gX1a32RU9yAmChwaiKHt2xDBUT/i/RfDWPQPBjrlSyYEs+GALyGysyVqVKOlGtvatDdjiO46E3W1dYSyK+HjgF1WnVTvNsviJwjVm5fppydDmT8e0YpFaoRsMfUHsahGmId7qzKw8KU1umFLv2FZX0WN8teGCnmQRzJoUQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SN7PR11MB8263.namprd11.prod.outlook.com (2603:10b6:806:26d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.35; Tue, 17 Oct 2023 15:55:37 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5%4]) with mapi id 15.20.6886.034; Tue, 17 Oct 2023 15:55:36 +0000 Date: Tue, 17 Oct 2023 16:55:28 +0100 From: Bruce Richardson To: CC: Subject: Re: [PATCH] event/dsw: fix missing device pointer Message-ID: References: <20231017154532.152741-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231017154532.152741-1-bruce.richardson@intel.com> X-ClientProxiedBy: DB9PR02CA0019.eurprd02.prod.outlook.com (2603:10a6:10:1d9::24) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SN7PR11MB8263:EE_ X-MS-Office365-Filtering-Correlation-Id: c83cb8a4-3611-4f8b-2482-08dbcf2980ff X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JG8YMRoTvRpeMVqv5uFSZm6qipOASULTHitg9/zsHMF6ipnM5N5CdRlQ++adQ148HRD/SRU413Eo1AoZfq8TtDg6DZzfN7uhkZuYeqaiNfdnQt4N0qKwLIZqZMREetjDhFubqEHGLDXiwz9nOUylluSWDziKLJbkV5Hx2bn/R390sOjcMJuiMlwUD7ynv1pVwSDNfnHIwJLTCOheVJ+dcCFX+gH57BLsqgJIcTyF9fPEAaHGfzRKlOF4J3+Rur6akkECqlj2RORMnPlLldjifxHDvxRrtNqrAU8WJ1knawOtQcKXha7VLbpqCSYK4kFM0ZQgm0vE3qGGegR1dYNiboDaWoYFLiXlH8fRpTFX+/llcxXAttxcKTwjV1B2Z0kU2efChzmazQckW4UdR1fQG1dYv7tEo12Rhwtso9ma98OB0UNpKKeOGM8njxPwivZ5r5+K3hL7/mKUcJifgFdfAuEtkYunGmd/ztsiHQYBY8l5MrhmMmlcn4Xt3D3ZOqYKkoL0+xwMv+W6CNQwo/ZxKjQw1kyJqlwSAMU9jFH25ao= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(39860400002)(366004)(136003)(396003)(230922051799003)(451199024)(186009)(64100799003)(1800799009)(6486002)(966005)(82960400001)(38100700002)(83380400001)(6666004)(26005)(6506007)(2906002)(66556008)(66476007)(6916009)(316002)(478600001)(66946007)(44832011)(86362001)(41300700001)(6512007)(8936002)(8676002)(4326008)(5660300002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2vT3XIMynGh24KZris8PaB0fW9r1QVzsWKS60LvZsVsxWUzwJfvVoXplavt6?= =?us-ascii?Q?KfsQdEwNo+4nynphge4sn7mME5rOqLnM3e3tadJhNc3/I+6EBid0Qsutq13I?= =?us-ascii?Q?dkwEMuH4qp+n46r/ajftTS3n7SOeMpH4cmgTR16y+QGkWz0SgYYrlE3+0QLk?= =?us-ascii?Q?r+R4U85qPvSzWvGGQosGjVcEny3n7TusaF3JrZmC0yZ+Z/uRfQFUM+saOA2X?= =?us-ascii?Q?ZCtdjAVjTl+ivXX1AmdoG1hq4+e0zocdJ/WhfHF/tpKbkARcF2Xxm9tSmtbk?= =?us-ascii?Q?LU8eU203pLS/OvF1CIFbjZch/7fHgi/pUkxvRouwX4FF8W+6/sR3rqlYX+6B?= =?us-ascii?Q?awSdzC25uhks4Mx3pZLAy6mxOx4ZZc6FN6kQg7iZ7T14RTid27oO/DhNagRl?= =?us-ascii?Q?MDLA1bP+YhHdk3ftNXlvpF1C2eDB1oN2ZR0mWrMX2dF2qj/fW27sUC4GAm3y?= =?us-ascii?Q?NEt2K00XW7mY12k1Bo6zl7prWbaeGDS3ZkUqjypcRPYiQxNo4MULxmayM+0+?= =?us-ascii?Q?QZN01zKcEAfGgiP1vuwrmHtkOFFvBnp0/tL9DyeKenTV05E1gtAVoYrTuug2?= =?us-ascii?Q?uHt+izVfUbtkoiJnORtqgEFKfjDcVQTUaD708+n5OwcxCd3+9Ov0mHlJXew6?= =?us-ascii?Q?BHYR1XXu/o00aQRdobqkxn6/U5Bs1AWkWLH6VWYefbSt/mjToQSPJnH/wBYF?= =?us-ascii?Q?bk+ep0vSo5YG8EIGJPEgzoKYiZDhsb1cp55NIauKjRyPt+QYYExMeJUCH08V?= =?us-ascii?Q?DYLvDd56fyDiflV7BVQPxHw00ryYJodunGvfi+++x9SB5jBmKv7IroIRKnWo?= =?us-ascii?Q?lVokH7JiWBNlb1Wk47p2kBhWiOtks8PjT8YLncaa3xazR44WdeTRgdIpvBFc?= =?us-ascii?Q?QH8Krk3jAhEvHlwcdYGqhnv3arKkfy8COn+n9ReIpIv+drzaxY6JZdgsr9NG?= =?us-ascii?Q?znZgoOTTTWEY2kSvTfH3e3IZa5fPNChgwMzM8w3rJ6vvAbticZlcHnHz9RBz?= =?us-ascii?Q?/MlS13z3Xo5WDkaxIuV+C+hIw+Fu92Hd+JCunnM/ChEXbbQznWJuPW7UtEcp?= =?us-ascii?Q?bpkBYU3gsQQMFq592jkaqjWiVF29fN8NuIF+OI9giTbyUpAYlVhHkQHeAHXU?= =?us-ascii?Q?f4XqrzZ4qrIMG2c/2+pl+oOmgxmdhWO+MJyMBGSsckS/+r/Zpbam/cveB++F?= =?us-ascii?Q?ImzW2m9mWtbTR4U4sRZF/eeEtotXMltrqRSVi594Bp0WbRYrQRqaMKu+61Kz?= =?us-ascii?Q?MHsV4Oujewc6YNw+882jv0Wd4QrLFR0Zcbn5k+JYa5JiakD7Fk7v5ynneqqM?= =?us-ascii?Q?1vh5pzsKqQIn1xHoZ1XWqBhXh3Et4SITgpMGsfnsBHxQhmoK9wNn5VZk9rp1?= =?us-ascii?Q?JQ67Us/XnduySXynqYYZ6z8WZOc2Y2DMhBKpTdOYRRPjXNBUqIizNZM6psqw?= =?us-ascii?Q?w4OE48XJaJWZjkReA5FCEeUDLxfIY/7xjH1/IF+8eb7fmE3FjiUhrOvwFfLm?= =?us-ascii?Q?brrqMCVM+h13wrSSLrlUldbrmcyQgPunQOovPG4NRhffqbhzzmoPmgvcCMu0?= =?us-ascii?Q?KIFCzvpmdP+49LrYWv4tnt+Q8tJFIy/1mJ+pI0uXtNmhsNPRdZwBI5AhJYRY?= =?us-ascii?Q?lw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c83cb8a4-3611-4f8b-2482-08dbcf2980ff X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 15:55:36.9193 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dUIxJBHzZEPnOcMqHMhoHpo8IKw9TSXrXvaZClNs1cwahIUmRPL3DcfPDNZPPDSICFGuqkZbevDaYxwYgUN15n3naX74h5hNcyoCzMPPEDo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8263 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 17, 2023 at 04:45:32PM +0100, Bruce Richardson wrote: > After calling rte_event_dev_info_get() the ".dev" field of the info > structure should have a pointer to the underlying device, allowing the > user to e.g. get the device name using using rte_dev_name(info.dev). > > The distributed software eventdev info structure did not return a correct > device pointer, though, instead returning NULL, which caused crashes > getting "rte_dev_name". Initializing the dev pointer inside the > "eventdev" struct in the device probe function fixes this by ensuring we > have a valid pointer to return in info_get calls. > > Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build > system") Cc: mattias.ronnblom@ericsson.com > > Signed-off-by: Bruce Richardson --- Since checkpatch has flagged a duplicated word in my commit log above, copy-pasted from the equivalent event/sw patch fix, I'm sending a v2 of the two together in a patchset. See thread [1] for that v2. /Bruce [1] https://inbox.dpdk.org/dev/20231017155148.153095-1-bruce.richardson@intel.com/