From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCF9B4318E; Tue, 17 Oct 2023 18:15:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 68B1C40273; Tue, 17 Oct 2023 18:15:30 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id A6AEF40270 for ; Tue, 17 Oct 2023 18:15:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697559330; x=1729095330; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=v7FaNLPkOmwqfBpapqxWnC+IUsfwqb9kTGDyssmcNYs=; b=Ek3UBhfSAKcUwBiee5zZzlbNlpRo+OsrVNhmeESIsBFYriLE9QyPInPC TKBBUrk8dwPE28WTEJR3YVClLXy6zyIMTBzYF5tCG+Rme11l89kuwCrp2 pdRpn+NPkpTAhfEsPs8/tbG6dWNZDaov+MmQPxNNIUvtWTsjp2EdiPhKE Tvtz1EiFizPevFtIAVxn4FIfi8T6Nx5V4a5xA39VAIff8IGiE7zyKZ8Xc 63eYTMC1j3KTfr0p8r3yYD+uleyffJnKGwZXjOKGCob0MKSTmAN6AttNX z/kVWlSCn9fSzNCAK6c6nvjSVBvb/nsgKsHTHWDDNgwOWOayuU0sfpqAH Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="4415150" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="4415150" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2023 09:15:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="3975550" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Oct 2023 09:14:21 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 17 Oct 2023 09:15:26 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 17 Oct 2023 09:15:26 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 17 Oct 2023 09:15:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PznHbKqQbdtulL84XtB22JEM0oKCA7Dlu53E5NmMAJMm2aH1KakYpMXAorvBgtRYnuhEkZa/RzeiwcSkEPllfbewfO6KGL23XJ0iuKQwCinKnS8SzBIcHwujjgyRazBOn+O0NVdd7HXP+aYW3nleAhymbxhvGCyLljMfYi9uEDrJIBAlp0rx7KE2iGip0fjZTRPnYy747r2KdAC15mhaZmBYfXlsQM3vhcneeV4M+ljBvNTzH6nDrXM4LJEygefZJR/JIRxZGdD7rx+DIp4bxGbKahn4HjBqHutsaHBaYmPTph65XolQhth2y0t+cRnKnhSP7ohRxWmIPNs/qW/mDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M+xfgU9/6ZEVdhQ4bU4M49WpQ54moiWbCqJQbO8zp/w=; b=IXDAWHiS3yhae28B6lr+txRZJGRWM7kLEulTV0hEfK6E3DLC+s3Rzir4IO//qUXhHTNKiYHIl6gyR+cLpGoApw6S133kdWdMooQObWlxIC0z1YhhFNIBlShKfdwLoKI6WceMOpJNojT4ZWYj9sjT0a/MsYVUA/bjN6GLWz6mRvVEOqyEYS2weNpFKdQ9YKnDfCZ67qPSgZTlXwK+9IJ28QwNdeRmEi9qKdaA9xdpvSq4XzycuiGvvbRij0JXFDDYiuojr3R+bBo2urqBMHp84pttuzTtI5M9qTsXKXdWIPI1YQfYW/cug3pf0R8u8YES0gHDB/FSb19olxZm/QEO1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BL1PR11MB6002.namprd11.prod.outlook.com (2603:10b6:208:386::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Tue, 17 Oct 2023 16:15:21 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5%4]) with mapi id 15.20.6886.034; Tue, 17 Oct 2023 16:15:21 +0000 Date: Tue, 17 Oct 2023 17:15:16 +0100 From: Bruce Richardson To: Jerin Jacob CC: , Subject: Re: [PATCH] event/dsw: fix missing device pointer Message-ID: References: <20231017154532.152741-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU2PR04CA0334.eurprd04.prod.outlook.com (2603:10a6:10:2b4::24) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BL1PR11MB6002:EE_ X-MS-Office365-Filtering-Correlation-Id: 94f7fa4e-7cc9-4e5a-c15a-08dbcf2c432f X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mMuiULoV+I/tDd/IroRVEgMmo4yUPPoeaEVceIzkuCvGEsIhlA6UHxbQE56KQVabLrCCQiy0pQZ53t50mgSoR7xPfulxZfnV0J72FR+vg+vtJLUZdIbEY8sWWccxFblT/LMTuHpeNP7IUfq7VyXzwgRH05xRytDvAGwNYrg+oRgvRt8YWW4RHMpSOvgPiOnm2nRcaUFxl+2e8h/q0drU9xF6vIQRbk39uniQFwVhs4DCiULbpOQCnZvLOInsNrlVb6QrrSSh9y9LlkpEvd/TxeFFr2LkWq+Y732boHlSw8EVx1RlC8aVr3RdPKHCPHdcL5C1I2ciBtXxq9mcwipQUJU2J07YkpWjWIPaNYmPoycRkFjsdfjpVPg60HzEV9ejn4RbHyXvy48+VNX4SwAURkHwz846tXVOxNMErJxHhyE1UFDaBCUtz9LW3hbOO/2Uy0aKFbq8JuRcWQN4vYcq93GEy1E20BVsVplavYc5Qpvbr4f6QcMRAEXDMkDxW4W8GAdosFEgGuVK/rrQOEgsaU5D19lSKrYEDwA/vE0OnAIvFiohgkUdoNTyvJ1Ve67lviFm0iKtbHls5ZMLq38r66wWul3xqZv7Y7cDUdfc7UY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(39860400002)(366004)(346002)(136003)(230922051799003)(451199024)(186009)(1800799009)(64100799003)(44832011)(82960400001)(26005)(8676002)(8936002)(4326008)(38100700002)(5660300002)(41300700001)(478600001)(86362001)(6486002)(2906002)(316002)(6512007)(6666004)(6506007)(53546011)(66946007)(66476007)(66556008)(6916009)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHd5aTM2UVhXZG1lKzZsM0E0NjZSbUNUYjVQSmJ6RnpvZ1BVS2Zwd0kwNW5z?= =?utf-8?B?WXErLzhQVHRxWndKcFV6UHZ6YVFZT01kUW9HWCs2QzErekQ2ZG5vVVFHNDA0?= =?utf-8?B?SitVV3hBT2ZWMG9NdTYyWVUzaHhVeWY2RHdydDRyVFhFMXdqTHRQbFVmR25O?= =?utf-8?B?M0hVbXRad3FIRGo0aUVYZzQxOFdWQVFTY2o5MFg5RGJkam85UE5yamZvNzdu?= =?utf-8?B?a2lBWmY4eEc5OFpBQytrRHdZd0JmejlQN0pCeFNvSVA2ZHJTNEdWbm9oU2p1?= =?utf-8?B?dVp1UUhJQ3A4V1llbEZkQy9XRldxNlFIdHFQenplSDkwa2dVdDlxYmxtUkV0?= =?utf-8?B?MnNZcm1EckhVVmNPTzloa3lqSVFyb2dOWS91UWR6UHMxMDRsUjh4cHprNU5Z?= =?utf-8?B?K3hIeWhyejRXaTdhRWdUTXFCbDZCV0VlUmc3Sm1pcXk3UklmMkJwZnNIdzF3?= =?utf-8?B?NUtGdmszd1plcmlScm5zL2gvdlEvTzdkazc5aUxQZ2hmd1ExR0g3WHUrVlZJ?= =?utf-8?B?cmlBb2FLN3FSb084dWMxU25zR2ROOGVBTE0rQ1BGQjZtUTEzWEtIY2svWTFn?= =?utf-8?B?SXdpT1NIYlQ4a2x2ellCbVVPaTZIcy9BRndwMEpGUlVNekFNZHdQWnpyL29G?= =?utf-8?B?dnJtWmFMY0o5ZUJ0bFVYZVBwT3ZPb2tsLy8xaE5TNGZIQmJuZXQ3U1E3bm0x?= =?utf-8?B?amN6SDE1UVhJanMxKzk4bUp6SHA3RmoxZDJKbkhMZTYwWTM4ZjI0OUlBME9m?= =?utf-8?B?UG8wL2Z1clV3eFpZMjMrYmJkSEcxRVVqYnM4MDZzSFg1UDJabW1sRXVaRUFn?= =?utf-8?B?NWFaSXVyYmJkV0tRcnRVNTVPQzFobk9idVZsZWY1UjROWEUzRzZINk1iSTRV?= =?utf-8?B?L1lSWmE3SDg1NEM3alpIYnRnVFJSZ2FGK3NnVTRPczljNnZVcE9TT0x5UlRt?= =?utf-8?B?VkZ3MEh4RlNrdGVLYVcxcXZaVHI1MlFGQzNRdFovZXVkTjBHZVhKemhsOFpI?= =?utf-8?B?ZEFOdnVXY3d5QzFlYklEQmlmMUF2TFArOXl4clUzYXBKV3hQM3YzalRqVG9i?= =?utf-8?B?ak1vREVuc0FsZS9ET0ttY1FyRkVJdnVSLzU5VFNvb2syMVpVTEdFZzJOZ3BI?= =?utf-8?B?dXNoVUloZkpQT2tGUy9xZXdlZlFGcTNOY1lUQ1RPZ2tTNTFMRFNDWjNmdmtT?= =?utf-8?B?Q2s1d3B1Y3g3b2lLZG5YQlhNakJoSkZEN292TXpwL1ZVWS84bUpkWmJCUkJB?= =?utf-8?B?a3dMbnpvUjNqbk1Ya3lpaTNTbkQyNGo0R2NhMVNpUFpHQUJEdUUxMUphZmNi?= =?utf-8?B?ZFYvWmxIaEhLS2k5OGJEZnJyRWRBWE5kNWpsRUNsdVBBcFR4OFFjYkE3ZHgx?= =?utf-8?B?SU11MEJXbE9HMmp2M1VMejFxTU1VM0VQMk1Rb2thbHBSZm5sdVlHZWRjZHAz?= =?utf-8?B?VTFnLzE0d0NodmZVUUNWV1dFMWlxZFRuTWpoejY5d0gzM0Z3TG5uaDAydEIz?= =?utf-8?B?RTRBTUpJbUpUT3BMZ29VVHEwMUZYd1lMR0czMzNPeTROVlVxQy95SExEMmUz?= =?utf-8?B?UW90ZXN5WnlYMWJIQ2NNZ1NEcG02VExVSC9hQ0hxMEl1YkZTOW9YL0pPMzFM?= =?utf-8?B?OUJOUTdwOUpsbU0rTjhYc0hMcnN2NE4vbUhYQ0NHOGhZd092VmZpQW5ZYkpR?= =?utf-8?B?aDlVTEZRc1lEK2xnaDY2bnlSQlg0SU1SY09USndnd3hDVmU3VWxqdXJETG02?= =?utf-8?B?MHVFemVhWFo4aDg1UXhXaHR5dnVDd3lPUTlmSVN4SzJUa05ncXhYcFVONzVn?= =?utf-8?B?UVVJZWtNdDUwbVFBTW8zM0xYQ1lKWGlsOUE5RjNkeHpZRXc3bUIxSXZHNWZ5?= =?utf-8?B?bEkxbGdaUEZ4TXA4Qi9VeldoZi8rb0V0KzA1MWt0aFhYYTB6NkxQWVdyVmJn?= =?utf-8?B?Q3l5L21Hdm44WVE3c0hwMHU2akp4aFRKbUM3aWVPWXp3czJpQWhJWCtwUk9i?= =?utf-8?B?MWVnVXQvWFNuMWhzcTkvamVobHc0S1FHdjZ2TEJHbGp5RWVVbS8reWhxRUN0?= =?utf-8?B?aTk5bnJ3OE95RzBRL2dETWNXdnM0cTJaaEtPeHZ0ZE1IMVBIQ1F6YVEzQlFQ?= =?utf-8?B?VzlhZ2xpc2hTdndaeUNnMlhDK2pNalZnVHNZOStaQnJOZ0krQ2o2bjR5QWVS?= =?utf-8?B?OVE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 94f7fa4e-7cc9-4e5a-c15a-08dbcf2c432f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 16:15:21.7656 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZPleyLoJtztA1Ea3LlmhRnk78pMd6mEZyjWs2E8GwlR1h+WuhB1I6ZX0hbnWshvpWAM7f11S5V7maP0Y/uZvbAacL4Gej93kVxQEHkmaaPA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB6002 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 17, 2023 at 09:34:04PM +0530, Jerin Jacob wrote: > On Tue, Oct 17, 2023 at 9:32 PM Bruce Richardson > wrote: > > > > After calling rte_event_dev_info_get() the ".dev" field of the info > > structure should have a pointer to the underlying device, allowing the > > user to e.g. get the device name using using rte_dev_name(info.dev). > > > > The distributed software eventdev info structure did not return a > > correct device pointer, though, instead returning NULL, which caused > > crashes getting "rte_dev_name". Initializing the dev pointer inside the > > "eventdev" struct in the device probe function fixes this by ensuring we > > have a valid pointer to return in info_get calls. > > > > Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system") > > Cc: mattias.ronnblom@ericsson.com > > > > Signed-off-by: Bruce Richardson > > Is this issue for all "vdev" devices? if so, Please check for > drivers/event/skeleton too. > Yes, good point, looks like event/skeleton also returns NULL for the device pointer. I'll do up a v3 with the extra patch in it. /Bruce