From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D74542352; Wed, 11 Oct 2023 17:34:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D995040279; Wed, 11 Oct 2023 17:34:30 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id F0BA5400D7 for ; Wed, 11 Oct 2023 17:34:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697038469; x=1728574469; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=N4NPrnHUX1KEVuAV33wcNv0XEwza65mBYn0et2o6VME=; b=IQHkdYwfJiiAwIZOcW/p9bGuPO+xjgyjqJ85cR/iAQaVCcKa5NBBRqNk dh2dtHKc9M+z62G9lKHuc8i6oxrnGa/sBaZOh6ofQueWiaLDMRTSH31nq IxD01xpvd8IZDuCWuSvTXRAiLSBtp6RZaQlIfTn7iAoC00ZzXTOV5f7vJ 9szrU7tCIZyQ3zbD7s4Kh/Q9cNzXpC7/YZhKLbOj88UReOQsGRhqQfcQx TCgBmvYZnIx+7Ra9lfrihTctoDZq9CvbiwwHILORwRnVKoyfw7sxe/IJV 7Q/9upMrj1ct96tbBbNLiAI/WleQ8SRyZ+lo2AWtRnAu8D5EOe9jaeIz8 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="451187064" X-IronPort-AV: E=Sophos;i="6.03,216,1694761200"; d="scan'208";a="451187064" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 08:34:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="730541572" X-IronPort-AV: E=Sophos;i="6.03,216,1694761200"; d="scan'208";a="730541572" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Oct 2023 08:34:27 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 11 Oct 2023 08:34:27 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 11 Oct 2023 08:34:27 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 11 Oct 2023 08:34:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TW4FSnl41Xj7KXzoFt99Jc+7wVDHk+8Cj4vao6IMzc7UvBMYJ0A/AaW6JAtMFMheiks4Ag75hDmWLynUGENnRTZgSRjrg9+hWRTNeUqFpw0uWMteabUT9vZzWrBKUC0YotV5G88DBwHCHGCaXroAu60tRJR6QWqme8ns1c6Rb2aI2LlnxtZ2DDe+vFuT7zTY7JOBU1eD/3A14jexAvay4fJoeylvRpv8na3onmjH2sg10llnVIAmDiH/XLQULFD7D+jjJ+PYKgOK/4ll4v7yvGzgn03Hfg3PauA+AbYvUkC25o6Qz9vY8ddJDG8C7qNjmAm5DO7/I2bggGWe/JMD8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DUhi0MyYElyvqQ4+yyvx9+l+oV26okeoe/uqRBIlecU=; b=L3O8sza3/GjidscGKTI3EzZY78exvcRpqcKsLba+50eiU9G/lfvyJorbQBg0o8Q2VupchKL+bOvlplhDVqVLWOYdpJVk4NEKsQqVTPgp6Ljwt0EhypuVXTyeRwvgEwr/6vSb78JLhqR1NFiyznjXTbWHVbRjqCTB82VE3nH2tXL/9LUPFezhUt2Sfr8rQpLxGCOaORuG09z+5BZig5swOcy4iKu8gi/Ij4FlufCK+ip3DHq6ISmDa6klgsiqEpsWOJgEmJSCxnipC2+8m351DdP7iMpAKLJu7qbPIHpD8zdHW9Dj/wmnm/UZukogUm/xYhYYYfO8PVsO1xXxpneF7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) by DS7PR11MB6126.namprd11.prod.outlook.com (2603:10b6:8:9e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.44; Wed, 11 Oct 2023 15:34:25 +0000 Received: from CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::1049:683e:132f:e690]) by CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::1049:683e:132f:e690%7]) with mapi id 15.20.6863.032; Wed, 11 Oct 2023 15:34:24 +0000 Date: Wed, 11 Oct 2023 16:34:17 +0100 From: Bruce Richardson To: Thomas Monjalon CC: Ric Li , , Subject: Re: [PATCH v2 1/2] build: fix list_dir_globs failure in MSYS2 Message-ID: References: <2188661.NgBsaNRSFp@thomas> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2188661.NgBsaNRSFp@thomas> X-ClientProxiedBy: DB3PR08CA0031.eurprd08.prod.outlook.com (2603:10a6:8::44) To CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR11MB7290:EE_|DS7PR11MB6126:EE_ X-MS-Office365-Filtering-Correlation-Id: f4d4963a-2d36-4072-e3ae-08dbca6f8c35 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 64NUsGMjanoCwEw7K/P3hTZ1H/0ZM2zdX5meuxQePq2/ohtJaiaqlZxhohjBUfM2Wvl9jdGpfRS4YgxrBAKJWBmTnK6dmRTOKJw0nhZhpLMfO9h5fnzDO8ryeTsuS/K71z0yda2y1igX9ew3PqY9PGM17t0z5b82vNolvZT4FgM0ehBSRX6NltZDO1jPhC92nkWQNzQMrKF0b70His/ANLhOuQPqfCxLaXG6nnh5VaYaSb3ePPuEm555KHBvI4vYE8wsbMw7P9f7hQWkNyEk1vLQ8sbICBjBMIMDZ9mQYtNK/qoKyom436hZCupTQNOOxHgOLsuuJrgYSUfQFbGrOxWA8xuh6HIMqlnQ9XP1kxWN7j4xLRSRlguBQr0SSuNKMFaQvHL3ZgUtB9VKBqFnMsaFojrClivpUi5MIiDBsxdvS6poHOTjjmqVtIBY7RPH+U6mWkiCFA3q8nKqeU2kkMvrzCPycxxaWJkHyTfcW81jUq9Q/1i/NFT5Kp0iRPly6kHMKf165/gwN8TapNbFaqYtmnoloMfoaa8a5QVOGb8e5Tel1ykIcMzT/ClfAINN X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7290.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(136003)(396003)(346002)(39860400002)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(66556008)(66946007)(66476007)(316002)(6916009)(4326008)(8936002)(8676002)(41300700001)(38100700002)(82960400001)(5660300002)(44832011)(6512007)(2906002)(6486002)(26005)(478600001)(6666004)(86362001)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?a1IzYdzGOJii0AwTwUjxZ1EAy6Of069Ikw463Fs5DMsJvaVn8TcKl/n0/pRT?= =?us-ascii?Q?BDCbOXHnl1ZjEXhcCRhWZo2bNiy+C/BvwlStMd/hJKNXZ13ekXRLWLeFJdHQ?= =?us-ascii?Q?Ly32fVigM9j30Z1SV86AQhl03F62DP2GF34YMaapEwbLEUurSOIWteZz+h+V?= =?us-ascii?Q?CznPkK79X3+4JymXNDpxelTmuPoGxJfTOgCTHeTwwY6LkKU9i+9pfgbK5rG9?= =?us-ascii?Q?07JtvU2gQudVMBO3AylFff6RQHX78jUhtnbcCQ5O5sYIh5pYSGh9JJjVDzIF?= =?us-ascii?Q?lqJ5c9gNuAADp60F9nOMIRo/zRlSkP5u2q2zes4F19lpxl5PEOjZhj8N6c17?= =?us-ascii?Q?SrJqZEOejxEdPtbCTxW0jdyfT9jgzFN+X5T2uYQ+mC+BH+wVMaiYFsgh8Q/s?= =?us-ascii?Q?yQdaMo6pKPEi8UPS29lPnzTKHRw54hx+j+17wM2Gu6Kwu4ih+p/5LmBylQit?= =?us-ascii?Q?X3jYESiMWOMRquApiNRpyFx8bAaCFE+SEMrKEFPprLnWsATtKdoi2vowMVfC?= =?us-ascii?Q?gfkUkscRhdoSUtkf/p6tySukfwHw5fkHA5Q0DtvRtJ55vpVWQ/v5wB9LjKwG?= =?us-ascii?Q?JqHVH/XMhsqW2WN9UJbep98LDoa8/AMDHVoI9pIHwMf0XKQkuXXKK/LUWKv8?= =?us-ascii?Q?8tZRxHlpI4bMIhOhC6C/SrVBquzQ1Q+BaY6eM7qsKxCa/9Rk95z2wTXtxvE+?= =?us-ascii?Q?8SZ17vWlUI9Z7gdIhnIj7y+V00s9oZKDYRX545tqWEp2DAivDv5RbE/sfAol?= =?us-ascii?Q?j+gnldc6cPm5wrRDqxMFjt26uqhGRCuAz+TQ7YhLsA4HpN+CukchT9OD5JFZ?= =?us-ascii?Q?EFXCO5zZEo3KoyjQLXwS7cEE/GmLXAUDqQDO2RUSwTvT/0LTXXNXzZ7EOFXC?= =?us-ascii?Q?a3d5GLVHAJzc8g1qiK3CvccVhZxSKWWdDgwFU3Gl1qqn5jsSLCMm9VSfWGJs?= =?us-ascii?Q?0JX5rKEwvdzj3Cv2mu19wgr0fA0Cz8Pb2mgWsPLPNMczM4QEtW/HFB4xkLPd?= =?us-ascii?Q?FdeLnYYw69NwLLmAAJ7R9NiPgT4M4kRMEPSXKP58wREg4L8/ypfm/ur8xey8?= =?us-ascii?Q?fR5gr1ri36eu+e6tSrWuUqjb71dypL2R0EhRBY8yOAdrd3bdx7Q4oOAFYERI?= =?us-ascii?Q?OPADE08eMaZazBxVTWgAwefM5IAY4Oe6A32pOvpcSK1SaphlbLgBa87UZWor?= =?us-ascii?Q?93B8AtqPgodmFrh2sUqP2r39oA5TJ84B4U6ToS6e8AeFHu4+2E43XkygpsKe?= =?us-ascii?Q?q7pJkWG0ntVVK/cikyUyWooSohjuoFqnjcbLw/5t1VtBBkSoevdgiX0dIb8O?= =?us-ascii?Q?jc3x2CNe35LnWYOXUsoimVJTpvF1Z/68c9HDX30ze7Mqe1q1LHeIoZ1l94SU?= =?us-ascii?Q?n6ZP33e1SROlQemJ86Evm09m2Vhh3shJVXJxncsir5B3MUB0PEBupHCbUFx7?= =?us-ascii?Q?ZQq+GMI8mKLIDfSZPiclTkEUPEkCcT0/njNUrlUm2yAPKaP9kmd+l5jxTW36?= =?us-ascii?Q?jOEPEc655bSGtI6Ua0u1xwYYwjfJnzj7GNBuF+YOlyQ9V1mJ+MthYG+wNFm0?= =?us-ascii?Q?T9B0cqLNEfwx/AREo26Mh6UpGOV/6ITW5tsltB/nbwSxFA259vpSQz1obIkC?= =?us-ascii?Q?Ww=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f4d4963a-2d36-4072-e3ae-08dbca6f8c35 X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7290.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 15:34:24.8402 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bMcVIrUoULAdsjLVaDDH1mhchHw8qm+Sv7LMVvyVInsPvASR9bqZFL2LhQFDjlU1XnpJsCty7o4UF+GtQNb5Cou73cClXg//vuVPCDHTlO0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6126 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 11, 2023 at 05:27:22PM +0200, Thomas Monjalon wrote: > 20/09/2023 16:18, Ric Li: > > When running 'meson setup' on Windows with MSYS2, > > "list-dir-globs.py * failed with status 1". > > We don't know why it is failing? > What about other usages of list_dir_globs in drivers and lib? > > > Avoid using globbing to get components for app build > > since they are already listed in the meson file. > > I don't understand the logic. > > > +disable_apps = ',' + get_option('disable_apps') > > +disable_apps = run_command(list_dir_globs, disable_apps, check: true).stdout().split() > > This could fail. > > > + > > +enable_apps = ',' + get_option('enable_apps') > > +enable_apps = run_command(list_dir_globs, enable_apps, check: true).stdout().split() > > +if enable_apps.length() == 0 > > + enable_apps = apps > > +endif > > If nothing is enabled, we enable all? > Yes, if the enable_apps list is empty we should enable everything. However, on reviewing the v2, I missed the fact that this patch is removing the expansion of the disable_apps value. Given your comment, this check can probably also be improved by checking the get_option('enable_apps') length, rather than the expanded version. /Bruce