From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07CF6432EA; Thu, 9 Nov 2023 21:01:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 93B7E402EA; Thu, 9 Nov 2023 21:01:58 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id DBD3E402E7 for ; Thu, 9 Nov 2023 21:01:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699560117; x=1731096117; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=s4cywm6+1jc6A9oiDXuL/BfBa68Veqny90EVbT8O6vs=; b=Wgd0jjRYV6cCcTc6vWjyLHlN4c126S2eiuOj3MkUIHfZi378Y1e5Vfla jDLOrFDPJcMw6e3YQIjP3rAbO35M/7QGNv2bl3+iBCs2RvFu/En4l7vp7 okISMst6K4iaUpNq1cImGEOMVvbADhvAFE6DZWBrm2XvWO7dmKdlSFX1T VuBvF6avwkFrU4gI0eyzCvOdjpIYXwYPWGJiFkogUVtNjszPM07OuDsp/ WVETj4N0cLioyA+sryxkJXrXIqUQJgevf6AaWweHb1XCU2+7k+uWZxTYy ADgyGfIc82j/JzPMqBf3mxUbpUBgafn7z9XLZFxkOp6yEz674QU9BGzun A==; X-IronPort-AV: E=McAfee;i="6600,9927,10889"; a="476295619" X-IronPort-AV: E=Sophos;i="6.03,290,1694761200"; d="scan'208";a="476295619" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2023 12:01:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,290,1694761200"; d="scan'208";a="11651989" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Nov 2023 12:01:56 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 9 Nov 2023 12:01:55 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 9 Nov 2023 12:01:55 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 9 Nov 2023 12:01:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MBrpNeMWKW9AzyXRQuAqOWy2ST6pMuQx3+nNa0FDTnpx5Rnswa0zIiFUdtU4PyeM/lHA9tEhtDGs09BS/U2FsK43e8A2Ha/JYkyJQp6jXxLjuaO5DwA3jErXyUq33GstUR1jNzFhlhK6rCTjRN8V8ajyWyrPJ9VmMc5WoECX+I/1jAIda2GjsYAgY6etzhDqBcHk4qBVHMmUrM5UJzL9A75kHpg2lVtdkNrrQ15y/ZXlcfo7TtM+kK/Og93wruipgnKsX7cpfCodA+5gOy2r6qZywlCVlQwJv8kJhFR+9h3AW1EniKMnr8CUzFtH72xorrcGygPr0ewyFTGEHpvdAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nyxWw+fWDCgPqJdBn86Otf0u+du7QMgKVgC425DQIbU=; b=XlQo1h1ahBF0AdOweaJ/sTcygFvK5aRux+e/ks6GzkccN1Tc8PY/76aVaRKcIhJypPka++7O9I4guvv7lI3V7PACxgurMJVhA/9lF0Wt49/4G7b/ABb/PFC1+CbcJoO96NKWZzEFJTapgq8IBXy5WTi4LmInXcR+w8vidui5DhCSA/cTSp63Qqlzw2m9QaCH8OqusRI4FbQglQilLJ+8/PVsFNPEToHh3UKGgDZvCtQjA7T1yFT/MhXEODfnsBXDc9kyJm1VzwfmX1aqePd5jzy8ciC6HjcloEVAPRW7Hmkf0N44pZQsY1WOmFQrX9M59OD+y/O1VlJU7WgcE0Jt7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB5778.namprd11.prod.outlook.com (2603:10b6:806:23f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.28; Thu, 9 Nov 2023 20:01:45 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::8645:d921:ce8a:12ba]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::8645:d921:ce8a:12ba%5]) with mapi id 15.20.6954.028; Thu, 9 Nov 2023 20:01:45 +0000 Date: Thu, 9 Nov 2023 20:01:40 +0000 From: Bruce Richardson To: Stephen Hemminger CC: Gregory Etelson , , , , Ori Kam , Aman Singh , Yuying Zhang Subject: Re: [PATCH v2] app/testpmd: fix indirect action list parameters parsing Message-ID: References: <20231108163445.422772-1-getelson@nvidia.com> <20231109183637.498742-1-getelson@nvidia.com> <20231109114137.7cf4292c@hermes.local> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231109114137.7cf4292c@hermes.local> X-ClientProxiedBy: DU2PR04CA0199.eurprd04.prod.outlook.com (2603:10a6:10:28d::24) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB5778:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f23f9de-2319-4f5f-ee85-08dbe15eb341 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zelyhWuYxZiSgJ0kEuvUVwuRJfQg0gDkx///a1Vkf1b4F/SG68+3ybg0C12leGyU/ojaWekkcaXSLETOIN7WQvlkcZGoDfPuAMQt98JfgCZuiN/ScnoWJ0rKI85u+X2j12RndGk9XdHTpiEUoSNMTVmdQvVjirJw2RrSZsWCSvc1x14ebo5VFxg2Fat70pMAQEVXqbwzQr9spjNFXJ6gQJMdJd1I7/JwofHTCpFviEqZie76WP4Rlv3vQ4E7eLplDdJjrgqiD5JXbKx4YlYSC2mnNJ1KELVJszSUs2uV01PykW1QC0I2eikKZOLH0bm4bDdfRzJwHUDwlNvpjr3tBoMr2YfK/f+YIGWl/zlCcufXKYr5dTN12nRjJm/na53IUdNVeYSbqdxSzpD2PwtnC5q83m0m/QS0rpfL/x//roJzCqKeS3cbob6jzNwUlYk1ysVdObLWjNK1Y5VXcSDN0JacOFPE+n7blAkBgv0XZk+6p3WgH5GlzlJ+N92ijJ6ZXOJelSuwjZ+ykDEt+0ul7QtmFhx6z4P5OylFyxBrfQOhN5tzy7zn5c2KlyDFlPkV X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(39860400002)(346002)(376002)(136003)(230922051799003)(451199024)(186009)(1800799009)(64100799003)(4326008)(8936002)(8676002)(41300700001)(2906002)(38100700002)(5660300002)(66556008)(6512007)(86362001)(6916009)(316002)(66476007)(6486002)(44832011)(54906003)(66946007)(26005)(82960400001)(107886003)(478600001)(6666004)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8Kaypkrf1vCpQqO1NkZS1E3ekJM5qqWJu+IGxnWD/bk/nhZ5D/azLh9TZdUk?= =?us-ascii?Q?f4ci4PEGDj7ugI141dzNVk6Z7RLQRQ8O0fNMvtvjZWQXlkGvjHRf9N6Dwryx?= =?us-ascii?Q?a+hJJ8/COaQxR+uJJS+FWmVYdZx6pr+m9FDO1oQFF4Rxz/Y+fAvMrC2Egfb+?= =?us-ascii?Q?ssROW+rlrUBdifu8TBuQYDm54Y5tI+r/DZKVp3rgvywER5F+ZSfnUUa/rlb5?= =?us-ascii?Q?ySZZHmDwuuSZyuZfsXYrIVgFLHvkUOqefqJY/nP9D0eqRUoinA2otf3ESHNo?= =?us-ascii?Q?U1aw7AmPI+2N2kINU/OO6XJKuwJhLSEo2+ERv/r7pD1XiY42myNuALMtTrxi?= =?us-ascii?Q?MA5nHnFBTdnToCf36CzNdoPb49SeS47X7kwtF1Qbf+OET/z4ttFGTDhTdxyY?= =?us-ascii?Q?ikoZq/ixvlkp1TBQbTBWfskKRUHs0sB9Z4YJGkH4EbpQxYT00rNqtzP5ZBYQ?= =?us-ascii?Q?DNdDxVQTj6y+e3rrx0mDVbObwdNKGsoPJGwq11wvaqUN2wPnAJybjjYW2DUL?= =?us-ascii?Q?O0N3ldwe2EzAKpswZwL2pInPpcsDa9MH+e6SAK7Xd5hkFmrb+oMD9PlN2Ah9?= =?us-ascii?Q?7iCeY3QVHSJwIL4FsI+xUikP+H/SWgk92tmhB+6JfiJDQHKAhc7lJIG6S+np?= =?us-ascii?Q?mODwv4nUMrK7WEe0Bex9pzcHZzSPzxgvyz2/WQeMZDW7ZW5aAxSkHsVaFcjt?= =?us-ascii?Q?KUJdBvPlGDZheXf8uAl3gKLCXVGqw3x7sdyX6t6Monl77yM7xYJcGp6te108?= =?us-ascii?Q?VK2Xm0Hq9syvyZfaLOCZkriBX9tjoY+lc3MJyvTG+7vlkamc2BuZVjBwoVdK?= =?us-ascii?Q?qVzMWiZpIulQy3UEzV1MTNB+PyDiyGSkdFTSR003i2H34rl4nwhkNdZnntfD?= =?us-ascii?Q?ArkOP7f7g1pK0P+XVqJLlDxG+DpPtEZnok1uvm7KHwdRyGQALnFM7ATa9JxR?= =?us-ascii?Q?iABaApJLU9tLA4h4+Zs0z1Luj9hc73ewmu/qgwo6sjVLVed87Uyh/Cjc0YxX?= =?us-ascii?Q?oZN3JCcVpZBgCizTQ2yy4MWYOemWSd5kAhOFc57/vKSdyvb9Dylx+/vLIVuj?= =?us-ascii?Q?jwvh2+rogYgjWi+Q1CGyhuDin7Qj0MpHRZAYzCUPXVgyxsMa0O0QmCoj7TVa?= =?us-ascii?Q?8298TCh8uAtfRyFWXhL93Xmw36GB2wFc8Blhe63HAk6kkmriWil0Vt1zJry6?= =?us-ascii?Q?hJbCuwaD/4RA7svbAbFnP4lB84GXJ12tIry+fNmFkhJACGPFVqE+Q2Dgb3oH?= =?us-ascii?Q?GHo0RpDAJwbvS88e/vREyaMy/gzaSBQOvh1iVOAbjYHbOb4b17GTIONTS0S4?= =?us-ascii?Q?9rCmPLZw5exNMqvM9zzukKXB85V2TZf4xkLCLu5z+B/zl9zL6YVsdniwJRI6?= =?us-ascii?Q?W/1ljMGVSFSFReq+N/OASk3ogYMrtiWHPFz/iP5sRJT07ZClVGK4o1eLxmoi?= =?us-ascii?Q?d/vbW8/NmFlMFr5kiUZX+ByrlIKN63cRKxpspxdoJfSJ7zZSjm8vNjTstrel?= =?us-ascii?Q?JvNKBISDgjBQpgnvF+rkHUbvPJMVSUanp8xi8CsP9XuzvfOh29cZ9LpYhnuu?= =?us-ascii?Q?Y5NH5PRmFJVGe2K9QvjTwxKD345jgy1Y//gfMH9nmCUmFa+5+7QQYrB1q0pA?= =?us-ascii?Q?YA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8f23f9de-2319-4f5f-ee85-08dbe15eb341 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2023 20:01:45.6215 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o7g90UEZeLplWT0dPkLsCftVGMv+VwDrsiEnOVIFBrbMbG4rTcg6BF+nfkgbRfY4NL82LygKVHS1mMZSZfS63SqYTF4+cdSmAw+5w5mF70E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5778 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 09, 2023 at 11:41:37AM -0800, Stephen Hemminger wrote: > On Thu, 9 Nov 2023 20:36:37 +0200 > Gregory Etelson wrote: > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > index 0d521159e9..397f9bc3eb 100644 > > --- a/app/test-pmd/cmdline_flow.c > > +++ b/app/test-pmd/cmdline_flow.c > > @@ -11331,7 +11331,7 @@ parse_indlst_id2ptr(struct context *ctx, const struct token *token, > > struct rte_flow_action *action = ctx->object; > > struct rte_flow_action_indirect_list *action_conf; > > const struct indlst_conf *indlst_conf; > > - uint32_t id; > > + uintptr_t id; > > int ret; > > > > if (!action) > > @@ -11350,7 +11350,8 @@ parse_indlst_id2ptr(struct context *ctx, const struct token *token, > > action_conf->handle = (typeof(action_conf->handle)) > > port_action_handle_get_by_id(ctx->port, id); > > if (!action_conf->handle) { > > - printf("no indirect list handle for id %u\n", id); > > + printf("no indirect list handle for id %"PRIu64"\n", > > + id); > > On 32 bit platforms uintptr_t is 32 bits. > Uintptr_t is always a typedef for unsigned long so use %lu here instead. PRIuPTR(and PRIxPTR) is the corresponding define from inttypes.h. /Bruce