From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87D0443270; Thu, 2 Nov 2023 18:15:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49559427E2; Thu, 2 Nov 2023 18:15:44 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 55E6840144; Thu, 2 Nov 2023 18:15:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698945342; x=1730481342; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Qu3RNxsRm+7MrzoXXtacJtVbdXaekU3lirpZxjqhQQ0=; b=bVFpkohi1H3fZSErer9fl3Id3WWkj5rS/OefJ5PP6JkPcb+QXwnn0UmH eYfDFjkeH41LvwRxDd/BUhZQbtPvvCmeFkFNZRuyRby5JhHBSuNNzn8/Q 6xmDcwT9JgaMpmNkVicaAiDy4yeIwKY86cdkSPoI/wqTJJKudxvIo8ksh g8yHzu9PQXg1LigkV6rR3liAxKqbo3LpkuOwOaPDDNtLpaOYyKjpQdO6L G8Daeyd0IkMQ3+P1LZIQ3S0CaLE+ofaWuE4W9ozuH3+U0hn5uxaDNd1Cw eJdPGjEZwozuoeAQ1F9kREtUJ5haFBI8CimHXMpG3tDI7u2t3zj+U+9ZV g==; X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="453070248" X-IronPort-AV: E=Sophos;i="6.03,272,1694761200"; d="scan'208";a="453070248" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2023 10:15:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="764993219" X-IronPort-AV: E=Sophos;i="6.03,272,1694761200"; d="scan'208";a="764993219" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Nov 2023 10:15:40 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 2 Nov 2023 10:15:39 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 2 Nov 2023 10:15:39 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 2 Nov 2023 10:15:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=grpecQfL3jKc5iLWhK1sXAKGCoMyobGV/NSJcnHqlLF6B+8QEV5Ukn3S/hMDLr/HsJh+0v+E9dZzN2Sk5tMabubDAqcm763JzZSr3Rgjv1AdT5ZuNvy1Ibw37zxot1E79Y6tIpDtAMKEzlGOBBLiQPm17dOR2q0JxNkms0X3GEJSZfQuGBpslyDdsWri9AR1uUZVsYcC9zAUcpJ+F9FOSsY+kWnZbp/WkTghDqzN4C0/2x+CH6j3RcwQsormdfgY8dYZiiK7n5Lah4t7JATG1bGNHJgzaVmoyVUsyIO2elBPESBE+bsLPHecOiCjuIpGfrf0pJxvAY+mQsjiwTC4jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gKPBRNgHGdpfE4wZiuzRY6KjC0ogW0a+MDplSgsCjyE=; b=kRTY0pwIV5LjdgyRgUvFYRGQ+kGWnu3WHmGhgyefvFsbRPs9RUp56lcG4k5PmI8Artpg5gekkS6PSwcLgvalx+DvfZLeunOaN5BxF6li1tZ8RlfE/Ps0wRgnlmvvR6JIq0KwNAR/JhDl9lGBrC2KxJfMsHNrWhVywEK352W3wOTL0HzjGDnRNzMjymgbjTFa36pFesspi5aW4c8KppamG0g+wluW0zhzVcaboYxjy3HEgOti6esaOjbdFX4fpVeyla54tpvOcvO4s8HJIHX1lqsLoXQGNc970FrR5kjr8IP8LUxLQB0dZOAXs520Rs0lGkYXsYZHmxyQuj4r9h6lPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ1PR11MB6201.namprd11.prod.outlook.com (2603:10b6:a03:45c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19; Thu, 2 Nov 2023 17:15:31 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d70b:11a0:d28f:ec44]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d70b:11a0:d28f:ec44%6]) with mapi id 15.20.6954.019; Thu, 2 Nov 2023 17:15:30 +0000 Date: Thu, 2 Nov 2023 17:15:25 +0000 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: , , Euan Bourke Subject: Re: Updating examples which use coremask parameters Message-ID: References: <98CBD80474FA8B44BF855DF32C47DC35E9EFCC@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9EFCC@smartserver.smartshare.dk> X-ClientProxiedBy: DU2PR04CA0062.eurprd04.prod.outlook.com (2603:10a6:10:232::7) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ1PR11MB6201:EE_ X-MS-Office365-Filtering-Correlation-Id: 4eda9dc2-2032-4d72-c155-08dbdbc750c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8GtK2XiY/LRUfNIBZnbWKjrE43+uNTrzDH+IRDl/TX4Crxznm2xj+KovysjXW5Cj27VdCpGIMbPcJV4P+ynCdOp4lYAA+MPkRvsQZYl3jq8F/CyWTlZ9uMdBu90l9F4zmt8TxDmJkhubumYyCKj8dce9Ct9bEdfBCEw79JvWitpz4vVHuTMXbxoNWmf3CFS+iiUz3VvcttDv/27P6LoYeYWe/5mj9WHA/U0otstQNY+dhsntulBrodB4aZ+zZIFMIdWXhtWug+ZJIQPmndPfcJK+qx/yNgCEAm4mq7oLqLvr9QDE/dV2c1fDptWEt4QDWDmX27TifRmFv8mslHVEHWrbvbU50D9k/BBZXSuyyP0fFcTAMXcJKzQbmyhjY8UWIYDixg2o0yH+hOe5YleqwlXBvNJYny88+4wv+Zz2IGP8Dpfmt9F/rWka6z7a28jt8unDWIkXQJ9VEm8FafL/Ek9kgX1ukSkSRnHDAFb+BC0ye1z5sIh9dnCOwB0BS2riysUa/34367Tx9zva2LJesutucElXbf+km2VfNg9X1VMkLHrSgaOExzJ8+97eA6zQ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(39860400002)(136003)(346002)(376002)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(26005)(6512007)(107886003)(478600001)(6666004)(66574015)(6506007)(83380400001)(5660300002)(2906002)(44832011)(6486002)(6916009)(8936002)(66476007)(8676002)(41300700001)(4326008)(66556008)(316002)(66946007)(38100700002)(82960400001)(86362001)(66899024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?C016/R09afoGUS1p0kN4krC1JjuKGp7qzj6HKlSeNnBIjlWKXTNnb4J4WV?= =?iso-8859-1?Q?cslo9vCTWvX1QFzCQmMNxYB4RcxwSNoH8z4DaLYbQoxKSl+9OZRYFIpyRx?= =?iso-8859-1?Q?hgG/eW87k2WBnm1g3Mr9kWUxhWfzHKK4ZcmtP15sKqFQQ8nocsz+lFdw6o?= =?iso-8859-1?Q?zhS4Od1E1tHfHvRTtMKelQIZMxzFOHHYNUr5flFYdDJQ4X8CnvZDUDZNOF?= =?iso-8859-1?Q?mjWz5CUQXsQ0iIx0cp76aj+m8zd9uHC/NDBRm/ZaT3v5hqS8DhfY0BPqSs?= =?iso-8859-1?Q?jQMdIFTaD1fcQ9wTM5bAe/mgC3L54pmpKImsHjSZZppmMUno6Pgo0OME1s?= =?iso-8859-1?Q?807P5NnuUVhMe7pFoqB2Zrzkp32unyZM+bX8ZEP3b6EPIrw28auSLEwe13?= =?iso-8859-1?Q?qAOZQ1ATLf4O3vlsPPDaEv79/NPJQX4H3YBqHbfJPe/cODu07mITDoMBlO?= =?iso-8859-1?Q?RhS0qsAWQhHNis9liUP7jomVBHz8eSJMcJOH99U9eOv4lkNwiUJFqMPJgX?= =?iso-8859-1?Q?3fwIRmNfLHQAhnsDSFrZfXsHS9ozdnq3doZXOGJTt4BZ8e7m671fIbf3Vc?= =?iso-8859-1?Q?0Loank8inEAhPy1T9eGmBXM9tFy9cOJCQudhvBxnzy75Y8cAm6Tl1SBFj0?= =?iso-8859-1?Q?AuwqIdGUvGOqHDP2D8FOVe+K1Sy3ZrXGDgtR3KfP7qAq7IFOHk7wfMmTIN?= =?iso-8859-1?Q?sF9RWFXjqoBXgY+8+YKR+qNx7syWxVrMbO++BCXeqSHyUKDArhTO36+COA?= =?iso-8859-1?Q?jKWFhQbjuDa0Fd217dBrtuCVQgHXjyHaupAP4HDV2kfBF/cDfAXSbK0nC8?= =?iso-8859-1?Q?sakILVQ/E0VyjfZoCXBjU68i1dFhrQZkwY3+aBrb5ojnI2NZTaea6z2b/h?= =?iso-8859-1?Q?pZtR2dwFOamcWj6R/SSMwu6/RjebCKTFpRrwjEGcLBwinZWnYlZrBlvnia?= =?iso-8859-1?Q?JyvEvrRbzGnNhhaOvyw4Fk6qXYoLWs8fb8Ke9J9gGQ+ijT8aS/ZxBHYoJH?= =?iso-8859-1?Q?wZB2Pi2nRpqo/5GCfkQ6t1DVrlkfDSCzcw81FHZ8ExjKCz84x/B4HIIaE8?= =?iso-8859-1?Q?lq+NvUIFrQ9zCKjF02OB9DgrSWWYBqSOaGHosg0KeN/s2P8bG8eOdPbcKQ?= =?iso-8859-1?Q?LfAwoP/UY/f94+v1WYvbAJAUCw5VtLIdFpLNvKWYYdFyg/T8n3UGbt/EuS?= =?iso-8859-1?Q?Tkb8lihXAEysk7Y+ic56GLb5pKTPm/AnAV8q+sDET6DqB6hDmfkEK/HuRP?= =?iso-8859-1?Q?N9hp6pfJOE6Oj7RFFWpeiQQo4LBGrJHdJEDddxL1Qeq4nlNGFYTlr3HPVT?= =?iso-8859-1?Q?sxh6T7QxI6nhSnZhwDvCa47E+92eUmVPy9anl9euMT/W+nZKJ2BYrfaY/C?= =?iso-8859-1?Q?Mvxcge+PtvEveD5ENVor2BIrwAQN1k9X4hG/fq+y8oq5WF1al8bZdF56G2?= =?iso-8859-1?Q?oE6vhVYWjcFE/aNTrH/WBCVApfia7Wo5C5wAbVqr2OWE7K3kNFE56EJxAd?= =?iso-8859-1?Q?UWntEICKGFI6M8OCqql+ve0/7CRAYfilb8OSb3z0wPFXvIG5mh3TcHWN9e?= =?iso-8859-1?Q?6fLIPxpQhzDJ0xYzrw8gVNdeym6aBaCP3xJeZIRqPhtCNlhkE6IG+duaVz?= =?iso-8859-1?Q?B8vnaF5PhQvlU6xDCW8T9WegcM4w3Ygbu54WhNlCDh/7BVg/cvN3p82A?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4eda9dc2-2032-4d72-c155-08dbdbc750c5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 17:15:30.5199 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1vGxXlHjq96+ihmyYFVPq2J9DfyW4OWG+U3TpPpyg3W5L/Ex/5qt5OYzgf36GOw+2Eh5DSpiJcaJ3sSHkqu6eU+7Kh/1yIA4dXemcu529yw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6201 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 02, 2023 at 06:05:59PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > Sent: Thursday, 2 November 2023 15.57 > > > > Hi all, > > > > looking to start a discussion and get some input here. > > > > There are a number of our examples in DPDK which still track core usage > > via > > a 64-bit bitmask, and, as such, cannot run on cores between 64 and > > RTE_MAX_LCORE. Two examples I have recently come across with this issue > > are > > "eventdev_pipeline" and "qos_sched", but I am sure there are others. > > The > > former is a good example (or bad example depending on your viewpoint) > > of > > this as it takes multiple coremask parameters - for RX cores, for TX > > cores, > > for worker cores and optionally for scheduler cores. > > > > Now, the simple solution to this is to just expand the 64-bit bitmask > > to > > 128 bit or more, but I think that is just making things harder for the > > user, since dealing with long bitmasks is very awkward and unwieldy. > > Better > > instead to convert all examples using coremasks to using core lists > > instead. > > > > First step should be to take our EAL corelist processing code and > > refactor > > it into a function that can be made public, so that it can be used by > > all > > apps for parsing core lists. Simple enough! > > If not already there, consider adding support for open-ended lists, e.g. "2-" means from 2 to the rest of the available cores. > Interesting proposal. It's not there yet, we'll have to look into it. > > > > The next part I'm looking for input on is - how do we switch the apps > > from > > coremasks to core lists? Some options: > > > > 1. Add in new commandline parameters for each app to work with core > > lists. > > This is what we did in the past with EAL, by adding -l as a > > replacement > > for -c. The advantage is that we maintain backward compatibility, but > > the > > downside is that it becomes hard to find new suitable letter options > > for > > the core lists. Taking eventdev_pipeline again, we would need "new" > > options for "-r", "-t", "-w" and "-s" parameters. Using the > > capitalized > > versions of these would be a simple alternative, but "-W" is already > > used > > as an app parameter so we can't do that. > > > > 2. Just break backward compatibility and switch the apps to taking > > core lists instead of masks. Advantage is that it gives us the > > cleanest > > solution, but the downside is that and testing done using these > > examples, > > or any users who may have run them in the past, get different > > behaviour. > > I'm in favor of 2. > > Coremasks are obsolete. Examples should not use them as parameters or internally. > > We could emit an informational log message if a given corelist parameter could be a coremask (i.e. if it also conforms to coremask formatting). > When enough time has passed since introducing this change, this check (and associated log message) could be removed. > Thanks for the feedback. /Bruce