From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A330743279; Fri, 3 Nov 2023 11:18:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E2AB40284; Fri, 3 Nov 2023 11:18:00 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 198D440273 for ; Fri, 3 Nov 2023 11:17:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699006679; x=1730542679; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=53uFzrHFm1PmGh+6X5ijRWTaxGqAXOW7N8U/cXR0jlo=; b=mi4COAgi/PKOudAJh5oktXBU4PXmqpP5nhXxFwN+0DXOpxud4d6KVxjE PavP7vwWfP5EKqh3qSbAM8O+wWx2UuzwTd+ECubT2fY+wDyQOZ1bTaDSF GuIQq0ug7T34z4fRty2Uj0hPvLUVY0V3/1/YK5YRClKM+D3T6rcp97o7o U8hzw5w+hg3UruoWSAchg/A8U1AiE0IRzWnJv9kxZZcKCTXGfN+3s3D3f KJQTAq0wmRqkeMlGD4JlxpMe8ZKQu8GvrE/amKp5bDDhb6BIaGfCuXLRC eJdi9bzqMAymQgUjQV2wN4xO6WOpqkXHLSOEF4mRkTLwy/IpwYUH0OyZA g==; X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="420029533" X-IronPort-AV: E=Sophos;i="6.03,273,1694761200"; d="scan'208";a="420029533" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2023 03:17:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="878605836" X-IronPort-AV: E=Sophos;i="6.03,273,1694761200"; d="scan'208";a="878605836" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Nov 2023 03:17:58 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 3 Nov 2023 03:17:57 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 3 Nov 2023 03:17:57 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 3 Nov 2023 03:17:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LwqKfHkrwhvqxmyonknEQpT1V0MALuN8/h2+4tLzmlPCgGBYztRGkVoz9fzUUIOBam1ndX8XGZg3335xm3n98OMXKzsPIIetcSBtR4Sf9HmJX9EjWG0oCLgIRhQbIWfSJEivwxLsuIJy4WXgrY2VWQGutMe2NZ3ykmLwlymhKjoyh7zXEyc7HTQx+HM+EIJsePCNu9U1zsdKQLvRFguGsH+1yhOoLIw0KyUYUWhKOuRkawMgNZp4EXCDwW9S51iiZMe8WdVOwb+5o2QrR6P8qLxnXmzoMKU5DQ1uZASWeiogR4KShGTECNjugKP+wuxTW2d7Cz0YVjrjhc9yBGMYNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IuBpfyqja+1jeTXRXUR/4SaYk+sABHkEmIyWeY5MP64=; b=ZN9b+bIQeaMjXK07F7AcxeC7XCG0uh4S3ByjVR9r+Ez0JeC4RjP79UcfRae4PSI6FJnABs+WwFPbH4ikkcW5XZI3M22SlaOwIhJlxHP3pAHCbv3UphXYoNYnoP0NujViFaBWYsTRI5c1qnvSEiaCLRCZZDPxxmv8085qlt+0rmGQDCHA2ArWFnomi9AwQxmJVXxuAPMH8nqcwyjH4mose+wYg9M3zxHicnDNJ3pl69HOsk3GFFiw21qKkAGBxGoNYfnk5EYb761eDjxhs9IAc4BPIrcEkIx5muBU1TENCgSIZl7KxLmC9ciXdCrSxLXOo8M2+NfNc4xnj5Wn7T+APg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ2PR11MB8497.namprd11.prod.outlook.com (2603:10b6:a03:57b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19; Fri, 3 Nov 2023 10:17:55 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d70b:11a0:d28f:ec44]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d70b:11a0:d28f:ec44%6]) with mapi id 15.20.6954.021; Fri, 3 Nov 2023 10:17:55 +0000 Date: Fri, 3 Nov 2023 10:17:49 +0000 From: Bruce Richardson To: Stephen Hemminger CC: Subject: Re: [PATCH] eal: add const to init function parameter Message-ID: References: <20231102181148.56930-1-bruce.richardson@intel.com> <20231102115541.4dea4945@fedora> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231102115541.4dea4945@fedora> X-ClientProxiedBy: DBBPR09CA0004.eurprd09.prod.outlook.com (2603:10a6:10:c0::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ2PR11MB8497:EE_ X-MS-Office365-Filtering-Correlation-Id: 1836cae3-7324-4161-a6f3-08dbdc56253b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QtGj+DmButZMH+RABAaDq7TE0rtsG1X5WQzEdA18Yoo+OWusVhQzt7ryvJ0EKcRrZyszh1DhkL2ta0K9Sla8D8tyLTKsMytu/MsEgSr1ZRhOqBkU0Fn0S1tGpq94xJ50r9L6DdTyG5VywqYCiDCmGAiFaQBpTKwQ5QTsDbgdiFs+Joisn5Nt4cUDj56jsuRgP5BVC2djZxdN35rWBV8j6B9bLxO3ERH0dsnMahmNPZBPS41Gh2SD8pHpyBbcwFFfdvOi51ITxudeGpt4pAdgKzy4H1OUFlg4NP86iyTrNIPpqjvpRpzIfFLdmIb7D7SrjqHjMHqSWR+EHX4jUFOlqaN8ucrbSrHwdBZRPsk1T+qN4SrbkWbgeqLkxiFe+befbvM3JUZ9aqxi5Zyv8AmgxLob/I2edy05YbwX4HnZvsYql3ovFAMeuvWA7zKH5n6Xm0wEyA53REyQrCbRN6dGf4jXgH7iBDaG9HKwxWKyV96ejg7MGR1mKyHOGkFDCwDDmieNiDF+aUPwNqSsJAY1j7vz73OEfBEkWGDjo+0GG98rnIc0oik7EAK53YP7kDrm X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(39860400002)(396003)(136003)(376002)(346002)(230922051799003)(451199024)(186009)(64100799003)(1800799009)(44832011)(5660300002)(4744005)(82960400001)(38100700002)(41300700001)(2906002)(66556008)(6916009)(66476007)(66946007)(316002)(26005)(478600001)(6506007)(6486002)(8676002)(86362001)(6512007)(4326008)(8936002)(6666004); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JJRTw6lA5ziHFUxcdINAb6MpiCNLU8U0C6q/2XGY8AsAPh5yjKCcaaKU9AiK?= =?us-ascii?Q?eiy0rNu+Brc6WEStzy1XrDUDPMiDwd6lySQfeKyLnPCeiGhACgWBWwuUrr/c?= =?us-ascii?Q?kAzUfxaUJ+/x6E4UnZUhZxr8fgtCS9qdV+zHqzSdpnUGvW3O0irsc25R7P5y?= =?us-ascii?Q?dgh6cqstsT8vLu1UPMfPAz5ygufOiy8olfH2jgSslIyRi3r/CQSQ5qDh5l2S?= =?us-ascii?Q?QKl51lvkD6BoE/FRgc0AtaQCclBMS/OG5Wqszf8W1WA94WA76QvulHTq1bJB?= =?us-ascii?Q?/xP9vjBHC654YA/+hnLaM1QQTo/qbj4whRZWVYEME6VPMGhJqvxSplRUuJRY?= =?us-ascii?Q?C8mceohIQO5FfDaBy7RdyZGp1ocgjk14SHsMfDAuseODakpqZZpMAd1xpw/G?= =?us-ascii?Q?m82ztZABnyE4kdWgybvKUdhaDsr+qF4eKcGtCDoN2IFFnTHB2UcydBCBSz3N?= =?us-ascii?Q?ce6VtfBHD5HwNRHveLbTXXxBipe93OC7rrrYPbQye1R8HC5Y4EQhuRVVa+re?= =?us-ascii?Q?FXPn3ngmKZO73vXvKkF0lSoOh+ekxIzFOvBM3eY72UQ02N6G5HQFSuv+nmo7?= =?us-ascii?Q?LUIb+7Ycj4TwlUfAWyYi99ktAlNLWt8ytsqzDi9D1J4nBPMALJ3/Wo5B135n?= =?us-ascii?Q?Megvoyxq28vt+CY9mz2tfNG+/UjKCdWdMl8BA7wmrxENi7KhiOwfhVPO9nZE?= =?us-ascii?Q?7iXPJgCgzfSmodh/xHAOp78Xkqb5I7ndNgk9QE8lTubAt4PpCaaDrXX2DjdN?= =?us-ascii?Q?i9WRleSvwahZP4InQnLigr+Sxrt7ALgfEl/M7+VY02i3ornFvn3EmI0yJbCz?= =?us-ascii?Q?x1qWQsSutmjj0wtA7JD/KaewfKVEGOjkGYBYVZ2c/K2UlraSboU7Hs1YV+F/?= =?us-ascii?Q?vH+7EkAgdlqZus5HecvegsGSIEkSsQXlx3xExMtFoO/zC7gSzuTXUm6ftVlY?= =?us-ascii?Q?MvAFHwoG3Lm66qFDNuZ1BCddvY5gZnY53glKnQlWga9ok7XKn8IfS2uFsfyY?= =?us-ascii?Q?lVwdil+TKZ5XcZzDf9HaeKOhR6aGPSvBTARAiPAH0IgUGz73F2FXdKcz/SQz?= =?us-ascii?Q?nyfSU0JlJo36AMnl2jA048g1aQ7dno4HbEM4FuZPmTnUqoSWKhvhx1ptX69P?= =?us-ascii?Q?CuTRwfN36IfYqIPUYTpWvmdvi6HSBG7/3O2EA32uaw1fEAPW3WY2VDwCvC+Z?= =?us-ascii?Q?RTGSDV4q4Lrc9abWIw1s+b6tM7uGYpE/Q+RG3ijEf+dqMSgTj3/GPoILeMwH?= =?us-ascii?Q?Z3ecGRoDGRv9JktDBM9GsO/sCUCKcKFZxnxu+X6ggGnodEV+A7qkNTIDZ9Cm?= =?us-ascii?Q?q4KgFRc91u/KGbbnp01HP3uXowa48Dk1w7UMJ4/v0OksthycZuJttdT3g82o?= =?us-ascii?Q?lUMmdDnQxJnrpHicucH+oQchB9YrOr/L3RzwB5sXQX+lWP17cr6CI8pmWxJp?= =?us-ascii?Q?hGQJ28YEcAkl3uZibD3L77bhRiIevtdR/L2ZxYQaoXq3f7zjzqYbjVy18PyA?= =?us-ascii?Q?0bPpEF5EOabP8FyFCK7J3gXDDgUJy1o9LpWv26/wtqcn4dPDWTs7oly2OMRK?= =?us-ascii?Q?AlVdvTORFyLA6Yjpos5/OKy0O+z7WDrsyeuEaT+4r3Dx7OyaGbnSDkPcyCoh?= =?us-ascii?Q?vA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1836cae3-7324-4161-a6f3-08dbdc56253b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2023 10:17:55.3869 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7Ek0XircrVoiLgUd2RMTxEQM65AS3VABhayxazL3rH785SfqKgG3CoOUV1ZWEx/xF1TlGZzs3s4a14RbPj9/jZ6Uocr+9GVvy0zzQ6e7xz8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8497 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 02, 2023 at 11:55:41AM -0700, Stephen Hemminger wrote: > On Thu, 2 Nov 2023 18:11:48 +0000 > Bruce Richardson wrote: > > > From: Bruce Richardson > > To: dev@dpdk.org > > Cc: stephen@networkplumber.org, Bruce Richardson > > Subject: [PATCH] eal: add const to init function parameter > > Date: Thu, 2 Nov 2023 18:11:48 +0000 > > X-Mailer: git-send-email 2.39.2 > > > > Change the parameter type of argv parameter to rte_eal_init from > > "char **" to "char * const *", since we don't modify the argv pointers > > passed in. > > > > Signed-off-by: Bruce Richardson > > Looks good but probably needs to cascade down a few more levels Yep. I only did a quick compile test, which passed, but I see the CI has thrown up a bunch more issues. I'll do a v2 later. /Bruce