From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01FAE4327C; Fri, 3 Nov 2023 18:18:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E859142DDC; Fri, 3 Nov 2023 18:18:48 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id E15C34014F; Fri, 3 Nov 2023 18:18:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699031927; x=1730567927; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=AoQ5SDG97EpHyN5jT0cnOAto1wQMJE83f7oz/lI8wBY=; b=G1FdR7XInCMuQOTHT+ZKWnTZ/CoZVM8qZqrI92skrk9EnY2sbw7LR6HI 5MeEYgludxzZy6Hd0KA9uwmGaP2h6eWEFAY7MFw5nmh7E+svJQUHsoATN dkFYGk7mtzKHW5kQis6V/QpWWJBifRFTrjpwi3V1HKucxBxMirnDODkTK C5McBKOGWVhafs2ynSWeSvO83dTPZHhcMeFZKQ5tImqWfjQcyTUmV65eN 93PSK4379ocm72YWxWwnvDQtETVUr7jJWAfwu1AqfXFGxdYpIcDJp+w7X 0A8dV0L6e8OOz1UZDAlH6Hur3DxqXG7pbvYgm+9WV7YKT9seTMPTcPtSI w==; X-IronPort-AV: E=McAfee;i="6600,9927,10883"; a="379382356" X-IronPort-AV: E=Sophos;i="6.03,273,1694761200"; d="scan'208";a="379382356" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2023 10:18:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10883"; a="761684256" X-IronPort-AV: E=Sophos;i="6.03,273,1694761200"; d="scan'208";a="761684256" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Nov 2023 10:18:45 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 3 Nov 2023 10:18:44 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 3 Nov 2023 10:18:44 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 3 Nov 2023 10:18:44 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 3 Nov 2023 10:18:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nuquGmlRJNyD/xu1i4dyybXL1udeNaVF1uLqBwIRt5LREJcmnVakR2xjsk5g3nONGJMVpbRL8PiRAMpkBdURE4XqVUn1XUgIOAOVrjg1XmG/spd7JQnxHLOwdZjAfgQ3x+MdkKjFRMrSX1737pwW7SR5Hc6TTYTNILwTacgvcweJ7WYChEYbRvHnExy3jjGbo7QePfL3EuE/GkeY++F+6mwrlu2PU/GqKxvCvXPU9SdXBHwqMf8RFdiJA/gspzNIV4FU3EdpCE7EUZGVldRZ7B6ghV9MfuQqTCG7AsPodwm0UjSgIRK/XOUhBQUzJiNVAZYg+bkHEMI9JaNmnVW0Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hAwB/bIABX/gUi/e0jlpF9UxAcGQOyXziIWJrctxRRk=; b=BV8xHaEcFmvDgqnptHv0Vv2+LzOwc/DutvBfTozH6vcOYIit2NSjbsIKSVjIO/2tEEKkDinY++UYP+FRnK3TTPJz4H2i8hQm62uLPkHBn0b2KkUj+Re3DmrpC+xb6oalhNyRVqj/pMEZaJzyUAsg7LL915WMzwXXtUVdbR5DmF4g9wMWeobTHEWCtMGSy79GgAmJe4XTtx32DnayDqxKMpTF7Ogczr0Lfvd+btkN7ErlhQ8HB/PY27OHeckFs56Ek1brPLw7TjdFsgtccEzSlSsz2YIYXC+6L+2cHfCAAAQfs22WCNQ+fVpnBpD5ZskYhWQdG7+ak3KT54iW7HLMfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB7817.namprd11.prod.outlook.com (2603:10b6:610:123::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.21; Fri, 3 Nov 2023 17:18:42 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d70b:11a0:d28f:ec44]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d70b:11a0:d28f:ec44%6]) with mapi id 15.20.6954.021; Fri, 3 Nov 2023 17:18:42 +0000 Date: Fri, 3 Nov 2023 17:18:37 +0000 From: Bruce Richardson To: Abdullah Sevincer CC: , , , , Subject: Re: [PATCH v4] event/dlb2: fix disable PASID Message-ID: References: <20231103171436.2791832-1-abdullah.sevincer@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231103171436.2791832-1-abdullah.sevincer@intel.com> X-ClientProxiedBy: DU6P191CA0043.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:53f::29) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB7817:EE_ X-MS-Office365-Filtering-Correlation-Id: 0459d4f9-91a7-4bc7-11f0-08dbdc90ed64 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dvz/EQvqroAzYOANZh7H9TCQRvW3i/nulNSokDHG1sx7S9qyptZX5kp0EZVaYfDKkE85W5l6ha97qusVH/8JgDSiDNryDOO3u/4W5pM83JGAKjWxeii6wupjNllDILpr9VfEdZ+l1Rve+CKiTyEfH6Hjqf+MxSR42IFYAQ3gSNNBqq2Q9q85fsbt2znfOFVSBkXXqQgvxZpm5abTgSpMJVp2aYnFP+RFIDYVBWjLfduZRMKTd3rqYxC93OBdzZu3vi4pNRoJFHDkTw07jG8fryx16bYAU3wBSj17cX+zS0VpucItpQpqDwjoWz69zj2o/u+73kCqM265STgSH1xLWpTys/yRNryuf9IFLujCVr7JJIxegnGcHgn0IDqtBxNDcBb9k3nNI8JG50DNe2FwXNl/QCErK2lmUai25MtLE03bK+1ee84Fnrpb02zG77MFYPPP1CvE3Krx1CiEzD6saV+BPa+Vt0L5YiQMmG+zlMA5ScR2hvrKV2Az0HwOn+ChmvdsfOt3qCsJti8swj0ThwrCDtlbLdmJ38vKWPIEzbFCk7VHQA/qECWFexK/2Pq2 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(39860400002)(396003)(346002)(136003)(376002)(230922051799003)(64100799003)(1800799009)(186009)(451199024)(26005)(6512007)(38100700002)(86362001)(82960400001)(2906002)(83380400001)(478600001)(6506007)(6666004)(66476007)(6862004)(66556008)(6486002)(8676002)(4326008)(8936002)(316002)(6636002)(41300700001)(5660300002)(66946007)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7J0/17tprIpXq6zRgZkt32YxscVrkBstkbJnfembik+xRlqA1VyFP0l2EvIK?= =?us-ascii?Q?pVlQbglfGGM68pt4HTBw9ils5OKdAS3SK5xiPKI6pLFb5FjAUXWZcHPeY4r4?= =?us-ascii?Q?9nHU7RlIgKcg3eY16Vv8u5dzMJ9FoML+gdsYRgtBiWaltMfo07FLUJgQPTv0?= =?us-ascii?Q?BEYBmBNqc4Ak1U2x6ToZGrlxkSLHZih8zGxx1XeNXIGPWgrfRbISuwuTKEp+?= =?us-ascii?Q?GR8XUvXaR2VdFAApA1gCqXk0wzoXdZqhsC9zgjwsUvZLSUZ9kleJW4ZQ0+xM?= =?us-ascii?Q?9AlWzytE/ZZCdcqZAcIm46Xa9havaIbRoGkDw7Z1qghYO34kakb20c+bdxWc?= =?us-ascii?Q?8GAY/Njv0qU0rp11Bj46TVRHq2eDwjs5gl8iBx9wWQAKgnZi0F0J8cLX5c6g?= =?us-ascii?Q?uGJIYEkH9oDT4oXHQJSKKCenXKstH7qxIP1HY1gvvlpYx7LGLRFg5OcEzscL?= =?us-ascii?Q?aBQcQf+uvRRgCtmtuAiS7PlTTIqaLS8nlZmE0NvUZv5j3B7LsD9cQ2iVGpvG?= =?us-ascii?Q?brmSK9qDRgFPYFef67fv9ke8vzJM235nzLhMe2ygn5o2W4if16EPXoSub2pe?= =?us-ascii?Q?YAd/t65GOF1G9P/wOsX5eM7o4WS1Rw2zjxokOv5maqCqyJ5OmhGocYPZ9KTz?= =?us-ascii?Q?nVCiI9Zlu3UYTpNtH1KG5roCUTX6BTCcoN9Th5lmZ8ciubPfa62x/qXOTr9R?= =?us-ascii?Q?+eu9Yxu3w/whYSaDJoDJsTWOpYPteE7ntQUTUsI2/e+tXWXL4n7FTaUY5e1/?= =?us-ascii?Q?rQGr/+VBgVP2DKOqm5xqWInpXT7WEtbvViDhYpVstHrtcgerABO6VX2E9xr9?= =?us-ascii?Q?NOlMKblmc59HF7J8uTM3ansqIfQ4BYA7f/0jOJPJcJuZFaNvroDE0LWIxaxG?= =?us-ascii?Q?gLdjW5Jf7KJIccFXKTilHlaa9f+jCRTZOn5KuAbtOssajD4ieY+4br9acGMH?= =?us-ascii?Q?JGhDHA43VxtsmSy2063UJyoe7aZUzJ+NPxg5UQrJEoCdxjLuKZPe0H8EpGOO?= =?us-ascii?Q?ZlUGadLT59gE5tzrKot5qjVTeWC2caZCevoNIqklm56ZkXdUtsUXM0/hAnnd?= =?us-ascii?Q?YHt+0uzwePV41zWDPIJz3Kp/2j4fjSLqSm1WWbs99Mxxdt2un0nGVcF2dMsW?= =?us-ascii?Q?ANUnrbokoTpCWMqS+aK9ZyRIE7cAPwpmA+caL74TNcrrkema41l5YiUCEOHP?= =?us-ascii?Q?jR0ZGB9dDDwz50T3Atj/j2TXYpwTWOIya3NfOb39Go5fJDeBHJVY86Q0+1oE?= =?us-ascii?Q?SW7I/qzQdN3b9yRS5iwRMS7a30vlDRVh9CCQ5jfgC3bEckhxSeo6jZjqKRy/?= =?us-ascii?Q?HLnV2J9hJJtFwUgI+H4/v9YmjXsJBCj3YDUpfpn/yxYfO6zm0vpbc8r2yskf?= =?us-ascii?Q?LYU0A3bDZ3wNnOKolS8r9xDLcWjYNnGVrLhnSWMkRGbBNaYYKITMhCXfD9Sc?= =?us-ascii?Q?bMMZp8DUho/OlLSeZPQVqOthqEmdJXiWTGgZwAOe8tJwrO8b00KpIiQ+PXy4?= =?us-ascii?Q?mdn+qUX91abKqRVASSsOs07ATmoCk1BfFI+aJNfhedxNOrhwrDXGXSD/+71N?= =?us-ascii?Q?NobEowQiTyjRVvUMJvAabf1HodEBhn9KvCg40lFl9t7WSwLHEveYamVeoQIA?= =?us-ascii?Q?Ag=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0459d4f9-91a7-4bc7-11f0-08dbdc90ed64 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2023 17:18:42.1378 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +TTOaQdHdhYgIHXfVYJKCOR4KPPXWC9cu53byMV0UgYauAig98jNWDp5jV339BQDh6ke9lL2t0rOXzPSUBWlGipof/YOPwwE9ZBQEx6QdSQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7817 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Nov 03, 2023 at 12:14:36PM -0500, Abdullah Sevincer wrote: > In vfio-pci driver when PASID is enabled by default > DLB hardware puts DLB in SIOV mode. This breaks > DLB PF-PMD mode. For DLB PF-PMD mode to function properly > PASID needs to be disabled. > > In this commit this issue is addressed and PASID is disabled > by writing a zero to PASID control register. > > Fixes: 5433956d5185 ("event/dlb2: add eventdev probe") > Cc: stable@dpdk.org > > Signed-off-by: Abdullah Sevincer You are probably better to send this as part of a patchset with the patch to add the disable to bus_pci, since the two patches are linked. Also, if you want this to be backported - since you CC stable - you also need the pre-requisite patch to be backported too. Therefore, CC both to stable@dpdk.org. /Bruce > --- > drivers/event/dlb2/pf/dlb2_main.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/event/dlb2/pf/dlb2_main.c b/drivers/event/dlb2/pf/dlb2_main.c > index aa03e4c311..63a18df71c 100644 > --- a/drivers/event/dlb2/pf/dlb2_main.c > +++ b/drivers/event/dlb2/pf/dlb2_main.c > @@ -514,6 +514,16 @@ dlb2_pf_reset(struct dlb2_dev *dlb2_dev) > } > } > > + /* Disable PASID incase it is enabled by default, which > + * breaks the DLB if enabled. > + */ > + off = RTE_PCI_PASID_CAP_OFFSET + RTE_PCI_PASID_CTRL; > + if (rte_pci_set_pasid(pdev, off, false)) { > + DLB2_LOG_ERR("[%s()] failed to write the pcie config space at offset %d\n", > + __func__, (int)off); > + return -1; > + } > + > return 0; > } > > -- > 2.25.1 >