From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 317CB432BA; Mon, 6 Nov 2023 17:24:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB5CC402B1; Mon, 6 Nov 2023 17:24:15 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 0E7F14025D; Mon, 6 Nov 2023 17:24:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699287854; x=1730823854; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=lamWzEobYUKhZN4ir3S7wUAOWKnPVy/sndUrFDtFmJ8=; b=e8O7S+arpGAvXJsRVS1DEGCELnkw+fdg2StBagLqAyBpLJXMKTtbAONR Dp7Sv2zBM/y4ZSPGuSoEl1YqUVFkXSKEatmkabsF+N8ZT2VGw+m+scrq+ JO4+rVogyHxIvpbUjozVHXWKo//3mIORAm/xyduhecVOJDdnIlgs988L7 z35dqkxzQGWGaehqxU7B5IzWlXkj86ZvQ8AJBwtESdJn5nC/Zr3Zmx3J+ 15eI1kOd7ouPsNHG5SIru+GPEzuQuE2YtXXOYcynifV9WJFlV28rczDNg pkI/ron3n2B1iWPmxcaNP72xs7K8jwtNVy4IORo+KiPGJXaeVbL2koR6w Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10886"; a="386488137" X-IronPort-AV: E=Sophos;i="6.03,282,1694761200"; d="scan'208";a="386488137" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2023 08:24:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10886"; a="755889496" X-IronPort-AV: E=Sophos;i="6.03,282,1694761200"; d="scan'208";a="755889496" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Nov 2023 08:24:12 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 6 Nov 2023 08:24:12 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Mon, 6 Nov 2023 08:24:12 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Mon, 6 Nov 2023 08:24:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TBbn369x1OKm3pH8fbHxdRoL5DDaN+Qsng10OnOgDQwmEB6gp8dxlMehh1VBAcmLyh4hSjg+LNQQNOlXqOIJo2WmS3RDcEPkSqxYIrzKTesXoQWj+o60q975/5MVqaO64cLYP8+Ln4vdbZbevC8jkyq0W1+mC4CpmR1eWHjqY2BAkqKxFtqnmi2BRhg960uPjIgGp8AEQXcSoN1Zq/DNyYGjI3Dgf7Bh1dZ1DskNtbgQ2Eb0A9uH1HWyTboxL0qsIIcgeS3Fbn0U7kAexQy1V/uBIIp0kXSuLLSlzoPdM9JOo26H+IqimEG4mdcJNxJbcKd+q6oT6D4OLoxrl7ndHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=baZbHtTjNbzAwU5j3is7qJgSdVPqczZU1RK88xPlkLA=; b=T6BPgtaD+LMqiMdaIKVzAFe1iLF4ZanlnUjYkRvrgEZFSOvKDOfAqzRga0k1QyRAOGk3M64KeiAX0zlU66LZ5g02IHV1bcML5v6PNSLijfB/7EQs2XnMuesX61mRLvPOwBdudBzQP7RCgq4aHYtrvYpcbPlFPjmomNI5JKiEmwO7WKva3G8prW/tXbxFSsPq0B5UfrOm0NJCKlgC5iPe52Kvr8V/ICwklFf8NM04mh0GzmGFochJT8XBXgxNtSjS+LYTX84ZIhWQmzCWQ3dqrZgyeYypNBtdtptsVaaXVyDa7Ou6HY3zRe4KSOouwK0Bcbj93Bezr/8FUjH6WRlzAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM6PR11MB4625.namprd11.prod.outlook.com (2603:10b6:5:2a8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.28; Mon, 6 Nov 2023 16:24:06 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::8645:d921:ce8a:12ba]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::8645:d921:ce8a:12ba%5]) with mapi id 15.20.6954.028; Mon, 6 Nov 2023 16:24:06 +0000 Date: Mon, 6 Nov 2023 16:23:59 +0000 From: Bruce Richardson To: David Marchand CC: Srikanth Yalavarthi , Aaron Conole , Igor Russkikh , , , , , Subject: Re: [PATCH v5 1/1] build: add libarchive to external deps Message-ID: References: <20231020170135.18319-1-syalavarthi@marvell.com> <20231106041243.13621-1-syalavarthi@marvell.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB3PR06CA0031.eurprd06.prod.outlook.com (2603:10a6:8:1::44) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM6PR11MB4625:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c4eae30-e992-4cab-c682-08dbdee4cc55 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SfsyxACmSmaetvbzHg2mEVaZTyrVeK8fB6ALJERRidnqVOXj8V1oGtLX2wAJl4d7ms/wGkT9f7rLO+cX759lnRikQwSYLYSJ8MHyUy8YgER4T+R+XBWaiB7YMjuXuNRypR+tIASa4YqNlW5RnbKos18osgKd1UGoVYSVkR54ptEnpJhqSn3K31k13wzLHVe7v6TNMoQDzfLlouWxrYZx2i1nskkWgIm6YLol2NXHhC8qB3X7ktCtBY4VHeWjL41aMMqFj7HsarerYZh+cKBefDDknX+7j6hHYvpOj4oDS2+qylIvYUR46WxDgBjN/YBcDTBJv9BX4hwkt8kc/Kia5EL75dmo8XGhhZQn37eX8iN5ywDsu4AzuMg8Wfl7GherZKVPUT/mFBqROsaVf8JQERlBdjPsyq6lIvB1W+pUEJ4IX+DamWBdG46Jexvj0lrklRO7K1AO77OzihqYJi70ZQ3G7aMQFwdkXMwQR8Lp6eu4L8SxflNyEn5687eLjRWhD4Kd4AIQekS3SjREZbTiASziqZBxuqduO4+IY2AeKHHvaXkK5Ceyfuu3LbhGdcqvIs8dLqnB0zXaK1paywwDVNRTy4+svNHj+TKxdOQlYINgKCZU7zA+KjBpPC6uz+Wi X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(39860400002)(376002)(396003)(366004)(346002)(230922051799003)(230173577357003)(230273577357003)(64100799003)(186009)(451199024)(1800799009)(66899024)(83380400001)(8936002)(8676002)(316002)(6916009)(66946007)(26005)(66476007)(54906003)(66556008)(5660300002)(2906002)(44832011)(41300700001)(478600001)(6512007)(966005)(6486002)(6666004)(53546011)(6506007)(82960400001)(4326008)(86362001)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmM5RkhSczBGTUY0NG1kRjAvRU1XQW1XdnhHdG13dVJ3VjltY3hvYkZXUzN1?= =?utf-8?B?bGJyZzVHUGZLZTBWTmM2VU5DeGliT2pjUU9KcWRvV2xxVmV5Y1ExY211ZDN3?= =?utf-8?B?SDZIWUcrZDExeWt2cjhkNVFPaCtLTUluM2dFWFBxQTNxSDd1K2dFR2phVEZB?= =?utf-8?B?M3V6SHFQSkFPWVFsSGVZbDhiK1JaMGNwVWJkcG4vVXdkTTlrbG5BQ3BpT00x?= =?utf-8?B?NUhlWXRhZm1HMjZvTHZ1OFM0V3MxL0pqanUySk96alluNXhiNUEvWkNGaWNN?= =?utf-8?B?U2MxcEloenU4YlZtQlJ2QVJ2ZWlyZnJ5Q0ZNYjBReFpGOTJsQ3A0L2hLZHF6?= =?utf-8?B?RHVIeVhQVnAyWW5IM2NIckRiQ1BaMXVha3g0Slovb2x2Y1IxRHl6Y3dhenFI?= =?utf-8?B?b3dXQkQ0Ni94M0Y4cXV2eVFyTjdhMnlTQ1ZmUmpFVkxPUkMrcGI1VXpieSti?= =?utf-8?B?MTZoTzlibFIvcUgxaWdsU0pDRSt6bEFRbFlic1lpVkcxaUJOZk9YNnBtNHVJ?= =?utf-8?B?dHVKSXFiYWhXMmZXOEVZSFlGYWdzMHEyaFROdk9QNkNEblMwS1ZYOTlVMDhF?= =?utf-8?B?c2V4bFVtazR4WUpZM3BuSThFK3IxM3VtVGRvSG9hNWkyZXdVQzFuYVhvcmxH?= =?utf-8?B?MndOQ05SelVURitRcWcyTW1kS2U5YnRKOXAybDIvdE5McjRyYngvTmN5NFgz?= =?utf-8?B?aUF2UEpkT2JwYktMbUlZSko2L0M1Mnc5T3R6QUt5bFdpYTFlTUpvelNVWjJJ?= =?utf-8?B?L0pqdWNaK1Y0NDRUbmZLYU5hSms2ZEROcUVQOTdhekJ5bExLVVdMZnhuRndF?= =?utf-8?B?VmxqMDlqZlNVRnVJWWM4SXZIRGg2Sm84ekhrRXViVGhQb0R6Qk94Y3lkak9Q?= =?utf-8?B?TWtkSE5OeFpWcHcyT09nY0JFVUZDSDN5a0RZUHZ3aVBHRXlkUTJGUktkdFFD?= =?utf-8?B?eU9MaVAza09pdWdsU3dQNWJUOHg0d0pxdUlBbTY5RFNhemdaN1FiZ3Vlc2Fz?= =?utf-8?B?bXdzKzdBTmM2RDFzU1V1cGhPbDRLM21IajJKcnIrM00rbzhzUGlMMlJucEpG?= =?utf-8?B?MEFSTzdGWmg1aUpHbkxldzYwb0lnZE5kSkh5SVdtVndSK2IrbDAzQ3dQdnJI?= =?utf-8?B?WVBmc0VuOTN1cHBuYmZZN3dNbjB6UTlPc0w1Qk5LOXdQVEJDZVAzaE53cWt3?= =?utf-8?B?a1JzckZmUURrNGVCcWNkTjVxSGdvc1R2TmdQWlRvdTlkZm1VK2NyVFNiYUcy?= =?utf-8?B?MGF6WDNXeHY1WU1NL1IxN0U0dlpDWGhWUUEwRGkvQ3UwK1pyT3hMUEZWYkZQ?= =?utf-8?B?ODd5OEs4ZjY5YmJaNFdOVFp3eXNRQ0NNQTI0S1ZNSTRDZTRLU1kyd2xwTUht?= =?utf-8?B?VnNwWDN3TkVJd0ExSVMvTVZ0UTJoM2NBSXltdUZaNnduOHhRSEw2d0NkN1k3?= =?utf-8?B?VDUvYzQxZEJOaVNCamVMZ0d0V2s2SSszd09YLzNEcmtTZU40UTVWSjVBV0pN?= =?utf-8?B?YzlVMC81WDVyL0ZpZ1RFUkgxdGtQY2N3MG9ucmwwMFBaMmcxQnJDejNOZ1Yw?= =?utf-8?B?QVNPYkFlY3NjdUJtelpuT1Z1cVNiYWZnQTFEYithYmVHZWg3R2twdGptS3ZV?= =?utf-8?B?RUYveEFxbEhXUFBzNEU0YlNxNXdDNHljMlFFREEzM0JCT25FVlM3VlVrazZ1?= =?utf-8?B?aVBERUdkbE83YjcxbmNPWEljLzZMTkJvZUR1cG12clo1K0FBQU9KMERaMW52?= =?utf-8?B?N3NRdU1OT2hoRHF2dzdNV2xBamRpOFYwelk1cUFrNTg4RWMzS28zVU1qdmJ3?= =?utf-8?B?clh0cjNQcGc5T3VSUjFTQ2Rmb2ZzODZmYkR6ZzlLcjI1ZGl2S09SNTNBOTNV?= =?utf-8?B?ODF5VzY5cHZaTCtsdDQxRXE1V0F4dWpIRVUyL1QvUVVnbzVIb0JJVjlicUkv?= =?utf-8?B?YWJ3SWVYcEYzaW5BeU1KV0dkWCtlNnNNUlR2VS9ZSkpHbHNBaXBYbG9TLzNI?= =?utf-8?B?amdEalNkbVgzdlczYjY3V1UzRVhDSjVkbThIbkF4d3cwSUlUaVRZRUZXV2M5?= =?utf-8?B?Ni9SajlmRnRIN2VUY1B6djRKM3hDN0xmZTNzcVcyeFAxQTFva1NzYXUvQnk0?= =?utf-8?B?dVk1NVNPRFlKWnp0dHNHQ1hRZm8rc3E5VVAxZDgvemRhVE51UUtaa084Y3Av?= =?utf-8?B?VlE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1c4eae30-e992-4cab-c682-08dbdee4cc55 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 16:24:06.7553 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6uHBwLRGxl+c0rZ1mdZxnA1ACTWlm9DmBAWicOJymtLOS5JblvGxglV1Po0fnzcwfbYON6iOLrFXks967CKqJgkwuQPSZJULmzvUc6/20PQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4625 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 06, 2023 at 05:03:10PM +0100, David Marchand wrote: > On Mon, Nov 6, 2023 at 5:12 AM Srikanth Yalavarthi > wrote: > > > > In order to avoid linking with Libs.private, libarchive is not added to > > ext_deps during the meson setup stage. > > > > Since libarchive is not added to ext_deps, cross-compilation or native > > compilation with libarchive installed in non-standard location fails > > with errors related to "cannot find -larchive" or "archive.h: No such > > file or directory". In order to fix the build failures, user is > > required to define the 'c_args' and 'c_link_args' with '-I' > > and '-L'. > > > > This patch adds libarchive to ext_deps and further would not require > > setting c_args and c_link_args externally. > > > > Fixes: 40edb9c0d36b ("eal: handle compressed firmware") Cc: > > stable@dpdk.org > > > > Signed-off-by: Srikanth Yalavarthi > > This breaks static compilation of applications. This can be reproduced > with test-meson-builds.sh and in GHA (which was not linking examples > statically, I added a patch in my github repo): > https://github.com/david-marchand/dpdk/actions/runs/6772879600/job/18406442129#step:19:19572 > The libarchive-dev Ubuntu package does not install all its needed dependencies for static linking. The errors can be resolved by manually installing the 3 missing -dev packages. It's less than ideal, but to my mind, DPDK is behaving correctly with this fix - it is marking that it requires libarchive as a dependency. The fact that the libarchive.pc file lists static libraries that aren't installed is outside of our control. The previous implementation hacked around this by just passing -larchive in all cases, rather than using pkg-config information. This then caused other issues that the patch submitter hit. /Bruce