From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F540433A7; Thu, 23 Nov 2023 10:22:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32FF6402A6; Thu, 23 Nov 2023 10:22:30 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 35AC44026B for ; Thu, 23 Nov 2023 10:22:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700731348; x=1732267348; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=3RoX0GNuId3QtDzSuTM67kLxkggCVw1VmdPoz9FAmqk=; b=n7AFjyjJBr0+HsJ53uojadXocqRHAXGgR5oXwJ03hyQRZpkLOzIh66Fo BFLrjL9tIHizse3bLB1wbTz8SQo9rs1pel6uAq8rhsXNGKHtmnmQAE2BR uwfBA7r1BtGI38aliVegnGQLQtIzpFvNeMT/wvlofmZMYkYPWsCDm8GNJ 4Q0xKYQPJxUZt9egV+wqFa1A39lElFq74yMbcoc1vdTgSsBVt5+nIImu4 TLtoQTOR+Ywscx8tMc/b860iebjkwqZrwnchny9EMQWeVMy4JsuGVh9l2 DAHdeRKLNqoCJArgElr6KThvfLsJnt5PuxjXUL6bbUpyHAlBFADqwo2iH g==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="377255694" X-IronPort-AV: E=Sophos;i="6.04,221,1695711600"; d="scan'208";a="377255694" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2023 01:19:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,221,1695711600"; d="scan'208";a="8614205" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Nov 2023 01:19:34 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 23 Nov 2023 01:19:33 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 23 Nov 2023 01:19:33 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 23 Nov 2023 01:19:33 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 23 Nov 2023 01:19:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GBUUXFNur+21Mz8gJHDgbzTRaHTbVahK1yVbZxaYZP9GM3o5OIPCa1U8dw5W1XZf2lS4BE0J8JXcz/tz9bq0IJ4G2ZvisKzmqI4UFPIrXK+tvr+tesO7FIrUHZxiDHWZxvAk69I5Xw9C/Q3FUAkjXJQHC7aCbsdjDDzZ6/BoEMWccxi9SwGdy+iyGBMKHCVBvsg++ARTDq5tW9ASjD4dVMOVeYUGc/kw6zyfUnEkT0aWV3TQXcymStY/55jElI1yXjnvi5SQL7lDONL5EGxyMN/4a8m2SYZlf92ix6npggugudAvDGAet4ZwRhmokavQsGFT5/+VofbRj+RJPOEqVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=411n4dPrQA8wISs5/aAKv5Cwp7gRvUm1PXnBwldRYbI=; b=nzWNhBsAai0NJFIS9uvVmg7gTMs81P04A1hXb6pWBvldEy8gUs3R0A0cTKAH4ZcjfPpdqQEPNR32WcVONrNNFCznS4pK8vAa7TggUKhLjePARS9AxAeJcQT8fEEM2fuaPS62+7puqkxB7MN+FnxpcUkfO7p3QJRWsD9wqZZYqVLRhKcCDlB9RKs+zobV3t1oDjLiSlJb3D+VIqzAIoz42B0584FqYmq04g7ynd8ymVtuQvIzpU6wZTUo6p5vyOLHIKVk35ndDtQAfMnnr3mP9WVsPuaZVmSX3uTYfCwN1AC5v1E+17egwAAPHwiGg0N7d9EbMFI3ja8sq3S0yBCfTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB7937.namprd11.prod.outlook.com (2603:10b6:610:12c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.19; Thu, 23 Nov 2023 09:19:17 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7025.020; Thu, 23 Nov 2023 09:19:16 +0000 Date: Thu, 23 Nov 2023 09:19:12 +0000 From: Bruce Richardson To: Jerin Jacob CC: , Liang Ma , Peter Mccarthy Subject: Re: [PATCH 24.03 v2 8/9] event/opdl: add schedule-type capability flags Message-ID: References: <20231120172606.505579-1-bruce.richardson@intel.com> <20231121115437.96500-1-bruce.richardson@intel.com> <20231121115437.96500-9-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU2PR04CA0278.eurprd04.prod.outlook.com (2603:10a6:10:28c::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB7937:EE_ X-MS-Office365-Filtering-Correlation-Id: ee4122ee-2f0e-4fc2-8385-08dbec05440a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vmutXuR3a1geLg/pYBxmqy6Hboex26RreoJvp2c4yEUZOPWzb+gLl+CgDuwtVy89MrtpoxqqMDQfWWgPaaErYMOFvGyw90XgMN9WvLNVuq8AxgYb0h+ggseWAYy27uN1jKcJniQXJu9zIc0TWo86qwvn1qLjh5ZoVlWK/ANiE6t6LTeAJAS7iQPDFQpwlu9ZlHt1FFSPbb+ieof5V9ENaKeETik8OZax4/BICJ8mfmE1zPpXPXf23zqhHyciHclnT/2CnQdYwslxDrveeiHO+VK9xbySQ7HzQBwx9VUd04S35wcOQveAghrZJxX2yc5sxtZOcLEK06SPIzwn3755uU/+G1ycBN1OXIxAiNgaeZglad6cZhT+v7mvA7zXB5Nu52mV2t30FEqsY0fb1Yl1BEOUSyyjnZmRDVoKOgvEF2qdVEpt+EeZqInVnWFsOmRyPz/pNPtwclwlulndJiA6cC0T+kGuZ9jGG/KQOZQov3RLxA9IiauJXLbBef173yWEqXyGfMuIa8NKOrgXJ+AAbhzipAaQHx9UEdN8scOQdmOvJk6AgF87PGvL28ODHn+w X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(346002)(376002)(396003)(136003)(366004)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(26005)(6512007)(107886003)(83380400001)(82960400001)(86362001)(38100700002)(6506007)(5660300002)(44832011)(2906002)(6666004)(478600001)(54906003)(8676002)(4326008)(316002)(6916009)(53546011)(66556008)(66946007)(6486002)(8936002)(66476007)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z2kxMWd3K29PVEo1aFNRajA1RS9oTDkzMzV2bDM1VmpxdUEyRnRISG4weFlI?= =?utf-8?B?Yk5kVUJHWno1KzVEa1Rjb2srVEswRGdkenROUmw1TU9JRXlVWlBFMGowRnhW?= =?utf-8?B?UE1mL1ZEZmFLYXlZNkd0d1cyT2E1a1cra2RuTERjc1BzbTBoN3lQUEpQN0Rj?= =?utf-8?B?bWlXWHhpS0dseDFwUTVZUU5zNFhJMk52d0x5K0NMOEZaQVBleEx2NjBQZm9y?= =?utf-8?B?MW9CcUFnNkkvU2YyWmlBSlVsT2xDVmY2YVVMY0MxaE93STZSMndvRk92bEhN?= =?utf-8?B?KzV1Uy9FUzloZ0QxSERLZUp6WFZaK0hWZDJDblZYbmdMN1BrNWlvWHVMUVRY?= =?utf-8?B?Sm5qU0IxL2JSV1VXcnJudzB2ZzVIa2Erb2hGMlEySHg5VW41K2JuQTlnSU1u?= =?utf-8?B?YVVZeWRFUThpODNEMVNxYkxNSGtJZlFtc2xoV3puUzRKZjFIUk5yVkFqL2dO?= =?utf-8?B?OTE2NWtsaGtEd3ZDOTVQR1BhalZlWTRUZ2hMM0I0OVArN21CZGRUbTUyMGNh?= =?utf-8?B?dHhqT3ZLSkF1bXhSalhYeXFtVHN5NVJWVnpWNitJSFFIbWpqN05JYWk1eTBl?= =?utf-8?B?eE5sYlVab2NxaUQreTk5YkZjVGZJdWdsU1NrWHVHYjlWZUlpSjNSMTVKRU9I?= =?utf-8?B?bTZTNGFTWFNzUnMwTjZXY24zbk94U3FrY0RwVmdTbjMwcmdDWnZIZUFYRDA2?= =?utf-8?B?cnErbE5UYUVsWHlhVzhPQXdSdWJpcDI1YnJIbUFhWlBPbmtUUUNiZTg0RFB5?= =?utf-8?B?b3hlVEFGdlFqNDdlZEpIM0xIVGgydHJ0RXpIQ2tRZWNtSnp0eHRFS05FRUx4?= =?utf-8?B?NWRhMFNqKzQzRWxYWm1COFQ2cVdOdVNpNkdneWJSNDVUcjFZNTZqb3FnbGVL?= =?utf-8?B?YmhDUHZFOEdoeUpFeWFWRkthUmNjZ1JhZkhWVjFla2ZPa1BRS1dpMUdGQ2lD?= =?utf-8?B?ZDdUNFFIY0tTdTUxZUY0QTZ4Y21QWXRFWEd2VnFsaWlvbmJ2MjVSQUIwaUNH?= =?utf-8?B?eDNQYzF6Rko5VzY2THRVVXAvNzlrZnE3elI0NDlJeHZnN0YrZ0dKeHhaZ1dB?= =?utf-8?B?cWZmcjNVWnFMQ3pwQ0ZZTzBUSkNBRk1Zd3dTam9aM0NsdEMyRzFNM3hqR1ZZ?= =?utf-8?B?WWFxeHZoNExydXlRM1ByV3k2Qjl5cHZGZUF3QllDN3phWE5iUjgvTjRtUmRk?= =?utf-8?B?TjdYZjYyZS83eTM4U1diQTlqaWViUm9LL3JEUGoreC9IaW9lRmxGK2hrbElZ?= =?utf-8?B?VnBpWUxBMU9QSmxIRnc1YlNTTE1QUFNLYXBXQkMwaWtYM1JaRG9FTUNhenh1?= =?utf-8?B?ODZhdmFoaVVlcVdpam1JMDhRb0UvUExUakM0UUczUnZOZ0V4MGZrRHdrSElL?= =?utf-8?B?dXFLVkVlVFAwZ1VRMFdieGRDdTl4akNVNUJNaHdUY3lBVGhKeDhRdXBxaE9R?= =?utf-8?B?MytwVGlDaEl2Z3pLektLbTZYNS9JZ29wMTFNK0ZCOGQrNFVKeFhHQzJzbVZp?= =?utf-8?B?UEw0K2NtaSsvc1c3eFpFeURoNkhHRVRheVpzUFhrZ05rMExvWFhvUVh2d2g1?= =?utf-8?B?QS9VVDRQM3B5ZXo0ekdkZldJL3JTWG84R0k5dTV4ZmpLSm1FSU1EbStuRE8r?= =?utf-8?B?dTM2UVFpY3lJMVRYWmFycXFnQzl0REJVc2NvdlIrWGllN0JDellqb215MDR4?= =?utf-8?B?aHR6ME0yWk0vckY3NnJkb21GWUovbm9XZnFoUVlZMnVTeVQyZWVYckZPWHYw?= =?utf-8?B?RmZmVmlkTy92Znp6L3I1OHRQUklySXVEVzlZZ0p4WVdiVnVSRUJOcFhUUGFS?= =?utf-8?B?VWFxOEoxZVFnU2NKRGRUZWJSU0FVN1FjL3BXVS9CSGpuaDFKMHYrNFMraDk0?= =?utf-8?B?eGpES3ZjaFhCQ3BXbGdrWDhFWm1YUDY1L29lUXkxb05MM0x2c29ycS9pSXRP?= =?utf-8?B?aHVQclZaS1NBR0xsOXFkYnNjakM2ak1haWtxUHRUODhnNHpyM1ZybUZTaEg2?= =?utf-8?B?L1EwUDVGSWtIQmRQdmRQU2h6UEx5NVlyWlRFaFRNakcrMC9RTUlGWjZJS29o?= =?utf-8?B?MndwRkxHUnVobW5hVTVkTno5N29oc2VKSzJsaUhDcEVjWUIyN2pxR2VMT0hi?= =?utf-8?B?ekhxbDk5YTBoZ1ZXTUdvK25tWlFKTkdJM0FzUEhNWHpYQUFCTFh3UzR2Y1ow?= =?utf-8?B?d0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: ee4122ee-2f0e-4fc2-8385-08dbec05440a X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 09:19:16.5757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BBBAjdwSdZKu2vs4v7qAr/MLwFxGkTZWdTa2QoUqzDcYw6X+93u/Qz3DjDD+XztJsWv2wnyfFSjbGAip5IMusDNBkeyH6OwXEYYWMyIsAWk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7937 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 23, 2023 at 09:40:57AM +0530, Jerin Jacob wrote: > On Tue, Nov 21, 2023 at 11:47 PM Bruce Richardson > wrote: > > > > Document explicitly the scheduling types supported by this driver, both > > via info_get() function, and via table in the documentation. > > > > Signed-off-by: Bruce Richardson > > --- > > > > Maintainers, please check this patch carefully, as I'm not sure the > > correct way to document this. > > > > According to the docs for this driver, it supports parallel only via > > ordered. Therefore, I've actually made the docs inconsistent from the > > flags claimed in the API. I've documented that PARALLEL is supported in > > the info_get() flags, so code that checks for that will run, but I've > > omitted it from the table in the docs, since it is not directly > > supported. Is this a good compromise, or an accurate reflection of the > > driver? > > --- > > doc/guides/eventdevs/features/opdl.ini | 2 ++ > > drivers/event/opdl/opdl_evdev.c | 3 +++ > > 2 files changed, 5 insertions(+) > > > > diff --git a/doc/guides/eventdevs/features/opdl.ini b/doc/guides/eventdevs/features/opdl.ini > > index 5cc35d3c77..7adccc98de 100644 > > --- a/doc/guides/eventdevs/features/opdl.ini > > +++ b/doc/guides/eventdevs/features/opdl.ini > > @@ -4,6 +4,8 @@ > > ; Refer to default.ini for the full list of available PMD features. > > ; > > [Scheduling Features] > > +atomic_scheduling = Y > > +ordered_scheduling = Y > > Missed parallel > Deliberate omission for now. See note above. Basically, parallel is supported through ordered, so I added the flag below to stop apps from breaking, but I wasn't sure about advertising it in the docs. Will add it if you feel its best to keep them consistent. /Bruce