From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id F129C43351;
	Fri, 17 Nov 2023 10:52:15 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BCCD040648;
	Fri, 17 Nov 2023 10:52:15 +0100 (CET)
Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9])
 by mails.dpdk.org (Postfix) with ESMTP id C868D40273;
 Fri, 17 Nov 2023 10:52:13 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
 t=1700214734; x=1731750734;
 h=date:from:to:cc:subject:message-id:references:
 content-transfer-encoding:in-reply-to:mime-version;
 bh=M8MELiYoOQ0LwsadsaIJOOq/HhZ4J4m3fcvjO8awtRE=;
 b=lRok5h7lH6LKqxyub95/DOh6fMsCGvcvw8iiGrtyEHS82Zu1eeqnkjIL
 K53nyWrFuLTJcHWivM9GBuzaogDzuTLyx8CsScUp/WdKAz32pZJGlApzU
 z3PJeFzBdhKca36bh1Xm3MlLSgtf/WxiuOcel/BomGCrvDg+hfbR7ZiHp
 /eU8jBTO20z+owvZdxiOZVZCtostVOpwt0bY2xHrAvUlGJxnJaxf0QuG0
 3DekwZoG18IEMh7kNoJy7mQDuowH/UOL9zEbKbvi2pmo1XlOiMNwm+Jvm
 z2saaGd+9XlVJ0KXNU9j9yD1DBMIvl83xzbZkHDM56Onn91PA9H2M0+Iw g==;
X-IronPort-AV: E=McAfee;i="6600,9927,10896"; a="9930223"
X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; 
   d="scan'208";a="9930223"
Received: from orviesa001.jf.intel.com ([10.64.159.141])
 by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 17 Nov 2023 01:52:13 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="13447264"
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
 by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384;
 17 Nov 2023 01:52:12 -0800
Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by
 fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.34; Fri, 17 Nov 2023 01:52:12 -0800
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
 fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.34 via Frontend Transport; Fri, 17 Nov 2023 01:52:12 -0800
Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101)
 by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2507.34; Fri, 17 Nov 2023 01:52:12 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bLH52hyyjNxtHUtWsQng01qyeryMOG/DuD6Vit9zbf1z/+HGVJCMy6tBKRbKQGPd1yoz4NYbVQQXbrbWyihKFofRKLM8unkbXDYiwWKIWytvfq59xc2vs8WUxU1G550KM6iuk1jLJAb7A3w5tLrBhcUapMXktonsCdfDPzMfVn60MyhJq1XKyoWOGvF/PMRjmhF9RK0De103lVp8iI1VRX8rnty/OrnbdBtPRey89rhL5LFssLVNTIbocwDa5g0dqAB7NZtA+DpEPmVo0Zf2wyu6oaRndI1HcB5YyYd5oHcoFDvK803fz47DY41BRVZ/WAJVUTUjH+gZSCB+xElpgg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lnme/D3Vqd7bZ+HEGvk/OQ2qd9nrd6f/Tkynaw7ySow=;
 b=dtkA6xEhBAQ+PAnPsHzhqpfcv0PP2KVPCsMnq06raYUiiaqaafPheRbIKXaC1CuPx49RD2O19woLF2kDaLFpx0eLWz+AAL8AqTYkZZJOCyhZiKR7vGknN6VXCBgvTm4cHUIxa2QKhh0XESDM/mdc+I7o+2cgS6Hs1E1WuYl9maKsnkTEv2cmEE5jlJQWwV8U8+BCLdCbJrmHob3Snbrtnm6EV4wGmGWqzQwHRlCyCZQ2RE6LLc07eeKmsX1f/856+AGUnkbVhE0IqTiFocLO7TYj8SEc2j2dyKnnpJCxpf8qym4m1npezyfMpyuVhNVYyh+IxvI0sZ9iIboo/MCt/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17)
 by MW3PR11MB4762.namprd11.prod.outlook.com (2603:10b6:303:5d::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.23; Fri, 17 Nov
 2023 09:52:10 +0000
Received: from DS0PR11MB7309.namprd11.prod.outlook.com
 ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com
 ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7002.021; Fri, 17 Nov 2023
 09:52:10 +0000
Date: Fri, 17 Nov 2023 09:52:05 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Morten =?iso-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>
CC: Jerin Jacob <jerinjacobk@gmail.com>, <jerinj@marvell.com>, <dev@dpdk.org>, 
 <techboard@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] doc: define qualification criteria for
 external library
Message-ID: <ZVc3xeSiXza/d1/I@bricha3-MOBL.ger.corp.intel.com>
References: <20230928051648.562526-1-jerinj@marvell.com>
 <20230928054036.645183-1-jerinj@marvell.com>
 <CALBAE1OSRaSAYs4FiLgSMR430rAQU85U9ERFE5C7jq3gSSw=eg@mail.gmail.com>
 <98CBD80474FA8B44BF855DF32C47DC35E9F036@smartserver.smartshare.dk>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F036@smartserver.smartshare.dk>
X-ClientProxiedBy: DUZPR01CA0108.eurprd01.prod.exchangelabs.com
 (2603:10a6:10:4bb::23) To DS0PR11MB7309.namprd11.prod.outlook.com
 (2603:10b6:8:13e::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW3PR11MB4762:EE_
X-MS-Office365-Filtering-Correlation-Id: 2e2fd331-cefa-4258-e654-08dbe752de04
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: EKmZfZKoDdww94rf6sIPxOrVBv+oInhuNQwQXN9/WZBEJv8KhghpatNevcNdDZfJ4tpVhMo4UI/GIHWYiJgTikduOuWeYPnNH0t6PEEs5QCUJdheby4bRygd4NKVM5mm3i1xGOisVC9i0CaxtIqQZXyW/TYGirWJ6obIlBk/7qMtLtLZAJLuXUtnf/Ti19XWY2R4ZgTuJ/aN+55677pkXZuuHyxso2UhRUoVPid1AFywCTeuIqzlaMVdbfwoQ3g20bs4YspopO86gapQ3lrgLd19uxu+oLnp7Q+NEaRuWTweeZIylh32J5ztaVo7n2zE7+GywyzQ42g0ksFloBJ0UEwGV/UqcFEBAfYfVHK4HTL3u4/yqx1jbgM9kCkghRPxAN/WOkQ1htcsUue/DXaO1yseTIB9M6KlFv5ySrnhiLxy4dHJScy9S+eIbH6VWekodLScl9Flh4asuRgprLMUXTZm0oUGUBxY6KRENxym1+LC1k9XmXN9JPlyBdOssEBA/21qkTZq6lo3ZYMaTA5LTM3nnaV73YNTtlxIP2sQ+jWryfBinC+HgsxijjW5qkR+Wl6lTMmNxRkFcluJ4ZF5+gTOULgJKsxI17uxVGLZAyqzyYGQh3L6RaMY9Aw2qMRZ
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230031)(366004)(396003)(376002)(346002)(39860400002)(136003)(230922051799003)(230173577357003)(230273577357003)(186009)(451199024)(64100799003)(1800799009)(66556008)(66476007)(66946007)(316002)(6916009)(53546011)(6512007)(6666004)(6506007)(66574015)(26005)(478600001)(6486002)(966005)(38100700002)(82960400001)(83380400001)(86362001)(44832011)(2906002)(5660300002)(8676002)(8936002)(4326008)(41300700001);
 DIR:OUT; SFP:1102; 
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dk1UbCtrbjBUcXRXbURjR2dkZGU2MlRGT0lvV2loZ1BvTGZmRmY1SjBBbHhW?=
 =?utf-8?B?cEZ4ZUxUVEdEOFMwS0ZDaWxOdTZiRzNTN3JzT01CUkltbXJDN2lBR2FFYnJ0?=
 =?utf-8?B?NWFJZkZTZEZkdTRuM3pkbDVoYTZwbytGWlh3WGdCN1FKcXlWS1BkOUEwTkR2?=
 =?utf-8?B?dWRDaFFvNUhvV3NrdlcyVytwc2NOSDJTd3F2K1VrcFRrenJKZ1l0Z3RFa3VO?=
 =?utf-8?B?STdjZnFoTUx2Nk5wT0MwdEcxRWY1ZnR2NTdMSEIvY2hScmNRellScjJXQXRP?=
 =?utf-8?B?WjZnMTBkV0dZQ3FXQitiVmUxYUFwUFJXTlNzQnFSV0JTeDlWZE0wVHM5aHhD?=
 =?utf-8?B?WjJJdVhSaWV4L0lpejdiaEhNQWxMR0RmTWJ0V0NEaHloT0ZSK1ZYUjhxZXQ2?=
 =?utf-8?B?bXNjMWx3ejM1NTJtWGozbERhdTZoRU9Wa2QwNW1pS1lVZlRLVWFCT2JPODRK?=
 =?utf-8?B?RGFKMWNHZUVQRTVQZGovVHB2aWFVdTRScFlpZEZCdjFFY0pONnRXWnN2WEhi?=
 =?utf-8?B?YzRFUm1LSG42RGxabGlDeGtVbHJyZ0dIOFVodUcwQy9kNjBlUTBvSElyQXBu?=
 =?utf-8?B?RkhlOGFJbm11RExDelVzektsZTJOai9VaEpRdzdXZkhpc3l4dHhNcEhOOVNN?=
 =?utf-8?B?QnJzSVJNWi9hSlVZV0FkRjVCVUNpY2QwOHJTV2xFSVZxMDZsZXJpUXZaUnp3?=
 =?utf-8?B?Zzg4RjRJZDdWYlNkalNlMDlJUit6ZjZJaGJzdnc5YTVGWlZOUjlGR3ZLa2lE?=
 =?utf-8?B?MzhCUWJoQlVBMHl5MFdVbHBiakY1M2xLWGJxdWxyUXdqdUVPclQ2cVB4TER4?=
 =?utf-8?B?d2VuYyt5SzVCQ0IvTXloenFtWGhBQ3B1WHBMUWx2S0hJL29qam9LWUVJbERQ?=
 =?utf-8?B?Q3BBZEdzSWhWZzduOEhRbjB0VG5YYmRqZVRFeGxra3lhV0szeU1ocTlJclpx?=
 =?utf-8?B?SzZ3VXQ5aEI1Tnl1RjU3YWhjNk9WWHg2L0swWW44VzJKQk50ZkR3TVplM2dm?=
 =?utf-8?B?UFlHNVFjb2xBN3VNVVZRYzBQZ1F5ZEdueE9yL3M4VCs1OTErZnNOb2VNVGI3?=
 =?utf-8?B?RittYmhzNWg1eUprNDR2UUdoOVdnSVVvRklhRTZWbTNPTjJGaXRFbU5jaVNT?=
 =?utf-8?B?MFR6NFNSNkE1ei8rN0owelo0eUJVS1c5ZEtyVWdUa0Nia2M0SEZIWTlKTjBC?=
 =?utf-8?B?ZHBlVHZZNWlqckNVOTZTSUZkR0lUWWtJK3BzcjVUT1F5NUI5VTdTdDArQjBP?=
 =?utf-8?B?M0lXWWJHRnpUd1FFRDdMaUJyeTBVM1dVQks2UU5uOWc5cHl3OFZkMEk3aXZp?=
 =?utf-8?B?S0lYOWpiL3g0bVVwRU9wbCt5WnBGV2RnVDh5TkcwZFk0SGJSYmVXNFZEajFX?=
 =?utf-8?B?Z0RUMGxsK1JSem5xN2NZa24xaTFuZzAwTStBK2ZyK2xMdGVVazg1YWE0Y3Zv?=
 =?utf-8?B?NmZRRWZUdUpaeHRTUWVpTWFBT09HenFCci9PYm5mcllVbWlicmhSb0ZxN1gy?=
 =?utf-8?B?ZDBIeGNVaGZlNnh2U0Z3UFllbXF0RU5xRHVRKzJGcHVOajRiRmJBNmJPSDk3?=
 =?utf-8?B?R1FmcXFUc3VyUkhGaDFvVGxacjdIb2FXcUxyRFlSVVJuWkNKdnJ4SXZJMDY4?=
 =?utf-8?B?eC9IWkRNV1N3d21JaFVkUzY2b3BlN2VFKzkwdUJkWFVGU1VxdTNqalUzODFo?=
 =?utf-8?B?Ky9ST25jU2U0eHdVcElXcXdrNEs3R2VSbXp0RFQrVkRReE5HSkdFOGJmek1G?=
 =?utf-8?B?dkpnQVBYb3RZaTZkZ2VMQkNNUFExd093R3g1V3F6OHQxd2J2ZVZyemZieEtG?=
 =?utf-8?B?dmVSOXVMMWR6aEErZDY3c09MQ0RPaHcrSGs4VzY1Ky94bTZ1Y3Y2WnlMRE03?=
 =?utf-8?B?aGR6TzlhMDh2blJsL1h3d2NxY21UVDNQL29IeURQaDRldit2Ykxxajl2dDRW?=
 =?utf-8?B?RmlGM1R6emE1dm1PM0ROTXBmZXVFQlBCQ2c1WXdYK3NvVUdoWTRyTXZhNytF?=
 =?utf-8?B?cFFZN0t6OU42ZFpIeUlJKzdqWm9KeU1mYnhxd3dvcXNoUHNNQ3VPQlJiazlT?=
 =?utf-8?B?YW9Bd1dSMWdCa3BHYmNRdmkwYWEzUmg4eGxKT0xyUnRvdUVvUzB3L1dPeU52?=
 =?utf-8?B?RFIrNDFCNTczOXJLZjVxTmFyc0dwN1R1cERmTndiZUJzeUhBbk1heStab2FP?=
 =?utf-8?B?VVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e2fd331-cefa-4258-e654-08dbe752de04
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 09:52:10.3306 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xmyvLLbBWQfF5xCwfLPCM2zVl+mJKQhr9wog1j4kk5ZyIFv9PMNxlY+dtgF7S17YN7f22ugUkezLFJg7C3yIYyFyjYHhgICO8oO/0Hy96zs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4762
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, Nov 17, 2023 at 09:27:02AM +0100, Morten Brørup wrote:
> > From: Jerin Jacob [mailto:jerinjacobk@gmail.com]
> > Sent: Friday, 17 November 2023 05.34
> > 
> > On Thu, Sep 28, 2023 at 11:10 AM <jerinj@marvell.com> wrote:
> > >
> > > From: Jerin Jacob <jerinj@marvell.com>
> > >
> > > Define qualification criteria for external library
> > > based on a techboard meeting minutes [1] and past
> > > learnings from mailing list discussion.
> > >
> > > [1]
> > > http://mails.dpdk.org/archives/dev/2019-June/135847.html
> > >
> > > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > 
> > Ping for review and/or merge.
> > 
> > 
> > > ---
> > > v2:
> > > - Added "Meson build integration" and "Code readability" sections.
> > >
> > >  doc/guides/contributing/index.rst             |  1 +
> > >  .../contributing/library_dependency.rst       | 23
> > +++++++++++++++++++
> > >  2 files changed, 24 insertions(+)
> > >  create mode 100644 doc/guides/contributing/library_dependency.rst
> > >
> > > diff --git a/doc/guides/contributing/index.rst
> > b/doc/guides/contributing/index.rst
> > > index dcb9b1fbf0..e5a8c2b0a3 100644
> > > --- a/doc/guides/contributing/index.rst
> > > +++ b/doc/guides/contributing/index.rst
> > > @@ -15,6 +15,7 @@ Contributor's Guidelines
> > >      documentation
> > >      unit_test
> > >      new_library
> > > +    library_dependency
> > >      patches
> > >      vulnerability
> > >      stable
> > > diff --git a/doc/guides/contributing/library_dependency.rst
> > b/doc/guides/contributing/library_dependency.rst
> > > new file mode 100644
> > > index 0000000000..687a3b6cef
> > > --- /dev/null
> > > +++ b/doc/guides/contributing/library_dependency.rst
> > > @@ -0,0 +1,23 @@
> > > +.. SPDX-License-Identifier: BSD-3-Clause
> > > +   Copyright(c) 2023 Marvell.
> > > +
> > > +Library dependency
> > > +==================
> > > +
> > > +This document defines the qualification criteria for external
> > libraries that may be
> > > +used as dependencies in DPDK drivers or libraries.
> > > +
> > > +- **Free availability**: The library must be freely available to
> > build in either source or binary
> > > +  form, with a preference for source form.
> 
> Suggest adding:
> 
> - **Free use and distribution license**: The library must be freely available to use and distribute without any attached conditions.
> 
> We must require a BSD-like license, to ensure that DPDK as a whole (including 3rd party libraries) remains BSD licensed, and can be used in commercial (closed source) applications.
> 
I think the situation is a bit more complex. Firstly, we need to ensure
that there are no license incompatibilities. Beyond that though, the
importance of the library will depend on how strict we are going to be
about open-source licensing etc.

For example, for a particular driver - nic, crypto, whatever - we have in
the past allowed linking against non-opensource libraries in order to build
that component. That (thankfully) has not caused us any serious issues to
date, and I don't think we should change things by completely disallowing
it in future.

On the other hand, a library that becomes key for building more than just a
driver or rarely used library, e.g. one that adds key functionality to EAL,
would be held to a much higher standard. In that case we likely would look
for an open-source, appropriately licensed, version.

/Bruce