From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BE8043351; Fri, 17 Nov 2023 11:54:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9662740ED1; Fri, 17 Nov 2023 11:54:44 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id B6CEC40648; Fri, 17 Nov 2023 11:54:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700218483; x=1731754483; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=zMm8QZZb7rYXd+YsUKyuQO8aO/QcQc3kiT4UEuCQ8Jk=; b=ctx0fjgS3lWqvkHsVXVRCjGaLsfWsfr50NnJ9dbB4xyiH2nbk433PnTZ uNL7vGm58Q/d158t/aho7N4oie34zcpfSjnRcaODY9BxU9EBZIKZ/d3k0 dBNcm8H/bW8cT8dGT6/U+XWIEIGyHdXAX9cUTn45Xfs1rCmZ7pRDw+KG5 1Cyr001Bw3ER+kPxxhD/KOkvODoYXkDYPXOqaxOa3uykDazP+f+OyNuSZ M9QsKloyAmRg9Y+m6WXkD2m0eE8bt6AFP3B4dQOMz2j4/ymrFHkA4O5gt Npx98E2Nl808sl40vROxXnBGwL6q9q7N7hrmiXB00e4rUee4sAoxH4yEJ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10896"; a="12823488" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="12823488" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 02:54:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10896"; a="1012896631" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="1012896631" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Nov 2023 02:54:41 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 17 Nov 2023 02:54:41 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 17 Nov 2023 02:54:41 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 17 Nov 2023 02:54:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MknNrnT6oJHJ3IUaxJ1q6M/dCsAKdIaAJcSAUMb+HFjDaa/P0oeXa7fy7NItKnf84237BUsyOiUmuFPXm3siouAbIdl95P5+R80TPB5TcitJ4AED/lDt4UGLN27NLQylMQp+N3/BOU4CBnxAposARvuFF2CdtOIQL5vEVZS1FNs++dMJ8bdMWj3jEgmeY8mAR+qa2GFa/Fr3+RwC7MdsOJM0XHrrsGWE60oJPrJgvCNsGV7SrkD3K38LHdexo396igMC7rgW7PVUUyN+xuIWGbPZcFgd/yxolcME67BK9jttGeT5TkKP7Sb1K5xU0kAbtoUfapI3FQB4PtENZH7FHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B3ouG8WknrmMugK3YAgLGAYNaOoMeN5v3kKMiRDlltU=; b=eJZe/E1Cp8fKLOg8LDU5H0SItTN3Qi5v4rsHEepwnHX/URRfh5snUGOk0NgbwHwu/NHoHIxYETuzXgU5VNl0crq9nEp0HjAiyDFmLLUIPbS0G6pqVgZkF1y9hPSDKqKn5E025yRTXTqmUvJgNKZUB5VxJHgBgBWTumqdPjD4IqBF1OVKaib7msC1WfeCyFNC+ZtYpkQkxpHoZHMf4bQmquIdPaWcgrGR+cdAeNP8Gxn2rrydWK9HPqZIOZbZbyhdB1Zi8ZRFUx2WLUHhpKEn/APGe8EF0KuHopC/EtzhO567nbleq87wKku1RuzdF0+OtXUEOK+9RQiZehBDE3Y0ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS7PR11MB6296.namprd11.prod.outlook.com (2603:10b6:8:94::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.23; Fri, 17 Nov 2023 10:54:37 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7002.021; Fri, 17 Nov 2023 10:54:37 +0000 Date: Fri, 17 Nov 2023 10:54:33 +0000 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: =?utf-8?Q?Stanis=C5=82aw?= Kardach , Tyler Retzlaff , , Michal Mazurek , Subject: Re: [PATCH] eal: fix alignment of RISCV xmm vector type Message-ID: References: <1700083003-6641-1-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35E9F032@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35E9F033@smartserver.smartshare.dk> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F033@smartserver.smartshare.dk> X-ClientProxiedBy: DUZPR01CA0205.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b6::18) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS7PR11MB6296:EE_ X-MS-Office365-Filtering-Correlation-Id: f4c63133-48e1-440e-25e8-08dbe75b97a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iZDGNQJr+XdkiiKKC1l0ysGyWtm+DNWJQEsJoCqRrg9rlkbjR+cYDtnNIU+7i+Ja0iOBgc/lPVOKbdU6NtF0N/ndEl0pYHq7qpQKmwlyNacvUCTsxe7VSJxP33+fTCS3ESEMTqufn5p6gMERbt26pXAVppy1CXOaitdTn2FEW1IJbnDFBPeQg4zOTV9aZ4MezCCQT540D4BXEGFXRp630VeY8Cr/4qzmq/o3F8+GUdaNZu2GilBOlLBBRjpSVn2CH6W+BvYmRrIHWUH0Hw9Fxh21AxpAvtCvKZN7MVvJiLfT2yges5LGsG0sFDwTLklRCAzOg9TZ2xevLg3me8i0XfX/ZgjbXfCN++SW2Cd9rEsHcM26kD9JAU+a5WDmyeQCeaxm85G4qlkT5fHqrPC/gCUvA1e5HUtPgsh/3I2j5APyEtjDS1ICphZTw8PeFfA0v0qw3k+SXC+UvWsU0LIbIMtNmEBL8a9H4ZuR1m7a0eyUO0JoHzAoASIO+aHfNnxcY3vZOMqHqPUGpOqTPrTt37XAYL8BdCyYQWEPsfLK0Eea0M8VviJhvHG6gM2oIRvUu7MUOxyil6zpUvKTSjsGtQ5tmuO14wrejPMjKYsbT1g= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(366004)(346002)(136003)(39860400002)(396003)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(54906003)(44832011)(66946007)(66476007)(66556008)(86362001)(66574015)(2906002)(8936002)(4326008)(8676002)(82960400001)(38100700002)(316002)(6916009)(5660300002)(6486002)(83380400001)(478600001)(26005)(41300700001)(6666004)(6512007)(53546011)(6506007)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUlRbDlveE0wYU5DM0VEaGtpQW9GMXNUaTJhMFlvc25MbWV3RlhKREVwZXhy?= =?utf-8?B?Y0hFbEpLMjl3S1h4VlpQMFpzd2YzbUxhbWdoWjBBWDJSN2l2ci81T2loajdh?= =?utf-8?B?UzhScnl5RFlyUkhDVFJxWk55d0Njc0tBYU9ha0dCUmpkMVowN0hOMWZsUlhX?= =?utf-8?B?T1gzelJOUC9OZEpZMTRPRHJlL1ZSS05naVhkY25HNkI2UFYyajExZDZiNXU2?= =?utf-8?B?Yy9mK1haWGtWNUIyREg1dkpGT1FRZVVsZ0dHU2NwMi9sREhEVjJ3RFRqRGJ1?= =?utf-8?B?cnIyVjZDZnQ4VWJTdU55YmtNbE1vNXBwOHRYWnZ6RkU3eGZqdFJTOWdwa1Y5?= =?utf-8?B?TFJ1dGYvbjVXNVRWS2M3K0dtQmFlVjkybTF6NXBKdmI3NUtkWlY0YkJJblZO?= =?utf-8?B?aUorckI1WmxadkM2T3pWK3VyR3p5eU54dG1zOCtPdXJIaDZ5aHFUemdhando?= =?utf-8?B?b3JPVnJDYkZLTmZPT2tTQlRNenFDNTY5cEl2WGpsbkF5ejh2aDMwUFdPSkhn?= =?utf-8?B?VmdjRENwWVJ1T0pjQU5WM0U0WnJkd2VWTk5CeXJqZFEyVjVSdW1sa2xRVVJJ?= =?utf-8?B?N3hXRTlNOFFqWW5XSzNNOHh5cUIzL2dTcDJCOUNoVkhHVm5QbExYL2ZxZDU4?= =?utf-8?B?WUR4UndjTnZselY1VSsxS0JMOUZBZHhQVHcvRXJyekRWVUVKNGpYUmx1RVBZ?= =?utf-8?B?RExIQ0Q2ZHFaSGlDYWgrNnlXd2ZpeGJVKzRHZ3FzMktMcEhWTGNlWW9lSzA3?= =?utf-8?B?cjJFK2QvSTZpV0tCWFlDaGJuRzVLZU9kN0ZCOWZaRUdUSlFydTJ4SUt0V21j?= =?utf-8?B?b1RSanhCYlRBVlZzeFl2czk4MGIzOUROWU56UlpLQkNYM01IMzIxUWhyV25l?= =?utf-8?B?WmhER1NBdC9PZlRqRFdkZHlIWWNUWVVPbWhFMG1BemYyeXVEQ3ZlTXdHYjFk?= =?utf-8?B?dUcrZG42a2syYnI1NkRzK0dWZlFvSWxzcjRwZWQ1WUNyYnIza0ZiajVXdEtW?= =?utf-8?B?Q1oxVVZOa0ZGUDNhbTZFczFnVm8wV2pMcXBVUFFZZWFNYlN6Yms4RjFPeFBo?= =?utf-8?B?QVcrRkFrOFk4QzVIcWFBTjBBaWdkODJ4K1RhbTFxRzRCZTJKekdzWjE3M0VF?= =?utf-8?B?SDJuRFBIZk1zZVNXcU5HT0dXY0o3dTVRMjdJNEc1YUM4K1d1U1IyRW9ZQnFN?= =?utf-8?B?S0ovc05pREZjWmNtbjlYVmJKd3RBT0JUNFhZYmpITWtlQzliNURTK0ZsdXRD?= =?utf-8?B?c0hJeDJKdVlLVWVvYW5HWDBZOVA0eDE0VWFHVXFIZEZESTE4LzRXck5jaXNk?= =?utf-8?B?NmQ4dlZTVVFjRG9nNFpsTUNXOWsva2RXNjdFR2pVWjNTS1hxV1FWSWhPQjUy?= =?utf-8?B?azhPbFdCSVBML1FCQTBKTG5ZS3BScWdaeXFoYTdmNGtwaElLekxwVU5NT1VF?= =?utf-8?B?RjRxUThvYUxSVHpIVmNxaG9mQzNqMDNIR3B6VVU0eWk5TTNJbUZmZVNvaytW?= =?utf-8?B?L0N0ZmxBUUttQlQxR0FIWHFkbHo0cG1ucEswSm1rWnJoeDFUNzJLc3VTM3lB?= =?utf-8?B?TXlmQmJIekhkUVQ1dldvWC95UGdZR3RLWXk5RnMwSHNUcWw1MHFOaG96elZz?= =?utf-8?B?OE5RNVVXMDhOVllIZmF0eFAyUFZPdWV6M2NURnpZTnczb1RXNVR0VlJpUFpE?= =?utf-8?B?ZGJBQVpDOEN4akV0RVFidmpPRkpFZmNwR3ljNEIzRVNJbzljdjhNdW9hSU9u?= =?utf-8?B?MGtySjRZRURTQnFCZXNjQldhUmNreDczUjdJLzlZcXhwUnlsdDZYWkRMUWMw?= =?utf-8?B?Z0FHZXZ4NVFwUi9vcjFFNkxiTFNkeWx4TS9iTkNib1FhOXRqZi9XbHFzZytR?= =?utf-8?B?S3p6cE5rVmJLQWdHVXZaNDFHZTVFVnQveEIxQ0tRaGFEbTBpcWUxWVhnclNU?= =?utf-8?B?SktLVG4yaGlwSzRuMjJYYWg0Y003Z1krQUhMK1RDUGRsOUZTbVl0Z3Z6V1d2?= =?utf-8?B?VTJYbTN1aTdwSFZHK2RWNzRlQ3ZhSVN6YTV6RDdRcmFHTlJXdjQ0NEQ4SC8y?= =?utf-8?B?cnhXazRqWkhEaGVsTnF0MWVTMnBDRDhPclZPNktTZHlOVGdTaXFQYlFPbFkv?= =?utf-8?B?UXhjMlZPdVN2TkttY2lGNzV5NEZ5RDNCOFZzNVBpT0JKTm54UWpjL2RCRWRE?= =?utf-8?B?Z1E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: f4c63133-48e1-440e-25e8-08dbe75b97a0 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 10:54:37.6291 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vt93G8BTVph6KwbX7Cd2r++deLDbXpGEBagCImJusF+XZdwHUOFizCL53FjGZSR3+YebAMEDlYG7LAvYQANCwJSf9YFHJYv87nujgNehXpA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6296 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 16, 2023 at 08:45:35AM +0100, Morten Brørup wrote: > > From: Stanisław Kardach [mailto:kda@semihalf.com] > > Sent: Thursday, 16 November 2023 00.21 > > > > On Wed, Nov 15, 2023 at 10:31 PM Morten Brørup > > wrote: > > > > > > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > > > Sent: Wednesday, 15 November 2023 22.17 > > > > > > > > Fix the alignment for rte_xmm_t it should be 16 instead of 8 bytes. > > > > > > > > Fixes: f22e705ebf12 ("eal/riscv: support RISC-V architecture") > > > > Cc: maz@semihalf.com > > > > Cc: stable@dpdk.org > > > > Signed-off-by: Tyler Retzlaff > > > > --- > > > > > > Reviewed-by: Morten Brørup > > > > > > As mentioned in the other thread: > > > > > > We need to urgently decide if this bug should live on in DPDK 23.11, > > or if the fix should be included although we are very late in the > > release process. > > > > > > Stanislaw, what do you think? > > Good catch! As for backporting I'm not sure of the urgency given that > > our examples still use scalar instructions for handling xmm_t. The > > question is whether there is a platform in use which has vector > > extensions enabled and that utilizes DPDK. I'm not that sure of it > > though I'd be happy to be proven wrong. > > Can we extrapolate this, and also conclude that postponing this bugfix until the next ABI/API breaking release, DPDK 24.11, is not really going to hurt anyone? > > Stanislaw, please confirm? > > Bruce, I don't feel 100 % confident in making this postponement recommendation. Could you please provide a second opinion regarding the timing of fixing this bug? Or rather: do you have any strong arguments *against* postponing it to DPDK 24.11? > Not sure I'm any better placed to make an argument either way! However, I would very much tend to say that we should include this in 23.11, on the basis that if it turns out to be important we can't backport it later without affecting ABI. Right now, the code looks broken to me, and I'm also struggling to find circumstances where increasing the alignment will actually stop something from working. There could well be performance implications of having extra padding, but things should still work, AFAIK. On the other hand, if we don't include the fix, it is possible that a system (possibly a future one) could break and segfault due to incorrect vector code. I'd take a possible slowdown over a segfault! Is my assessment correct, or perhaps I'm missing some detail. /Bruce