From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6834543354; Fri, 17 Nov 2023 14:27:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DCEE0410EE; Fri, 17 Nov 2023 14:27:27 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 7FCD140ED1 for ; Fri, 17 Nov 2023 14:27:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700227647; x=1731763647; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=pIwvIw2sqBNhX8Ajs9zqij+sd14E1XIbkpMQUyJxjL4=; b=fdat0qv5Hxj59D9LViwTIgD2phCr6Khng3vg1MqT6Z021TyHl3fSC/XI 70xRBVKVLHnAaA+odr/adbZmKWDFsdx1FqqzpXkx1utsp4592Op+wyHVY SzQIl0lTg+BRCj9g/KN3VHm6bLT7VqIr9qTqoQS5BPIa4w/iNRU+1qHIO 0AH3VGymEpVMqFn78eWMDT8a8h7x2GHfnqANBwRC7/Ik42jPSLN7eSauJ 5ifOwo8PE/olOaG02ApSjaWbJWJVPyptnXiZgNHlMRaCNpPkvv1zvJUh/ gl9UwdUvkW2EHhFQCaW9UAjTXWn1+R0PacgyCaphoMQQs8Kc7Ux5E27iT Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10896"; a="12845985" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="12845985" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 05:27:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10896"; a="800493926" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="800493926" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Nov 2023 05:27:23 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 17 Nov 2023 05:27:22 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 17 Nov 2023 05:27:22 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 17 Nov 2023 05:27:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZGmz3sBbNiuV14UDvMKKtVuQsqk61cDFEW6ykpH1mzdVrVNLt+mHDFwWh9M2UZMovKY4ogs1mzJXMdqJNdA5vo/W8zqYNzzeDB+xmActyfPmkQth3r/ZAVV8TvYFLQ98SJ0cX3RjwTTYKDu0L18qjj87GofjNuUV9ty1AWU0BfY4apBG6cr4DaFRR9UH3sVJPvtcbaSO1twa8gZx41S4KZRq9HhX81BdV4ZB5HGw63kTykxuF2zn1WOkj7MQPgu/K9VU57mIj4nWVjHGLEieQ0mUZU1yzcKs08N5IJ/tRl5dVjnw7aJsMsB+4ojeQszy52oPJSpRKlrLTcsJQ15LDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qD3ZKLbW+/yi0xOk6C1Fdo7x3D1v2GREL29xgQx+hPo=; b=J+rhiHtxgGgYiHtIQpHRs5c7SuqbB/dM/SSm9s8NHTvuOiT4Sus2IRJ2ooPD86/0HJ5vugsF94nulSHF5erP3dtdm3O8RrVVL95Qt2CP6vjlJ/lztmZeOjqAtchvmLDZdQBFmuFkpumg54vJxijhl8Gf4it8kM0PIpWPjpa0XRZ++BDN1AW+EQdEW4pQTIHEOh3ziw+Y/pJn/5kmJ8DOhH40sTDmg/KbkPMO6AvBM9S2S4w8TwIsNMBkj9JEvhGfeCO42LCQs6tfAZPMH/WqaNI9fZ/KGjtKbuRB125WXFHMI/UoZvj9/GNL0zvpXZBbhqnQz2wfiVCuBKUWsa4vIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ0PR11MB6573.namprd11.prod.outlook.com (2603:10b6:a03:44d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.21; Fri, 17 Nov 2023 13:27:19 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7002.021; Fri, 17 Nov 2023 13:27:19 +0000 Date: Fri, 17 Nov 2023 13:27:11 +0000 From: Bruce Richardson To: David Marchand CC: , , , Subject: Re: [RFC 0/3] Detect superfluous newline in logs Message-ID: References: <20231117131824.1977792-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231117131824.1977792-1-david.marchand@redhat.com> X-ClientProxiedBy: DUZPR01CA0100.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bb::8) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ0PR11MB6573:EE_ X-MS-Office365-Filtering-Correlation-Id: be0e2cc6-6de2-493c-762f-08dbe770ec5a X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sw2Y0bFDL0gvNcKon4KScgOZZwya+F38QSIlsblWywkjkq2Gqw647C12K9pp40TocCOKQtbIyPOnkd5d8uRsDocARrqy5CPmej3cx7EBY2TesmTvr9I7UdyoXwIiufS52/pC+lyjlRll15GAYs4RoJKpdkaRxuV8qASUtgp/hpUdTi8Db1TQO5XzNX8Id4H+dNyWUu8RcsrJtqW+63aPkoZo62yQzyeWU143uS2jPAm3PWX06DtKktdiAjihsbKp8cOEFtrPUo7+WfaQg44ltuyopTYPq6qPqd4L/uj8UJ25tEixyT8Uj1IZoKbvaWv6FiEO1gfK12eyWmbvFmyZWszQfa/IEPICJLkw29fv9Gk9HdrhrlSqAfjnriAPK5JhnZhz51TT4B2TXBFE9haoam1OJOFGQH/OgVu6bwbTy+ptwABUBFABuEtaLAzM698gWYrYQEpb+Ed2YkrTFv18F486qbWQQfDZG5BekSxzPNlj4CbI3tS9whqfqdJEIdv0KOb4IkbN8/pZlK9rK8dzG/YpgzFL14X4HAg/T1W0/h+i9aOs8GxX5CnnKhqlmKYg X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(39860400002)(136003)(396003)(376002)(366004)(230922051799003)(1800799009)(186009)(64100799003)(451199024)(38100700002)(83380400001)(82960400001)(6512007)(26005)(6506007)(6666004)(478600001)(6486002)(5660300002)(86362001)(41300700001)(66476007)(66946007)(6916009)(66556008)(316002)(8676002)(8936002)(4326008)(44832011)(2906002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bTQZ/pkiLHTV5IoYGI8wnMv70+D1C3Jw3WiOXLCde9HAPrQDjfFMdwivjReb?= =?us-ascii?Q?3Nh+rGXorVkygXeSBCGsrJUB4EUxXP+Mfi7q32sEoRGOhRSJI6K3/eZiSbLU?= =?us-ascii?Q?fKyDAtHcCN4gD8fL0vnbMlxL4w2TnUZkxpARHuBEyoqyFWhPW/gapybNNrMm?= =?us-ascii?Q?GHBJ5icC0zIwl8bDfGY9LOUhdwomYr4t99Ymo0CxUkymV/ypx1AdNUuqFVMA?= =?us-ascii?Q?YSG4PIRh2V4pKqvlgfx2PSQ6hIGCtWk39FffF2A8xQYwhshX286eiXlWwj9h?= =?us-ascii?Q?jGEo+YUaZfdhNZ95as4pf+1iWp03uqUXG8VoiYecR9k/U+VhAvADq97fRrCT?= =?us-ascii?Q?cdPYpC0FxZIxlwZyQGJyEDyQ23yPSx7SFjOn0QpYzw/MZiNeEwDqJsWPFmnm?= =?us-ascii?Q?foBSBTmdUyboUW2+X+GiViaThEhLVwYxhrU+Qvrr3WirsVfKOMl30rTYTP2I?= =?us-ascii?Q?AVa50uOmDENDVUgRPC+DkTEHvffspL+IWMcWWpBD6PIivYR/QBBUho73whc9?= =?us-ascii?Q?c2Y4ZMO2DF91INZKAA+wO9o6cVWDxG3nh/GiKFpH49nyoao5yda0jXjS4gGk?= =?us-ascii?Q?Q0Q7bWKOnynp/RbaBWXvy/0mNJgwd5p9vt4V3xyJBGowdTnTNZbv9bwMP8X2?= =?us-ascii?Q?xpGahJNrZGqEaVMjaWKzaeR6qrM3wuHjqsJx5gaO/caZ9kh1UVtOm21QTl++?= =?us-ascii?Q?2zB7+w5nE2gVwfmgRTbI2F/wYzv+IS8qQHcNbXFaEddOK96a+6weeevsYlKY?= =?us-ascii?Q?olT1RHUA/N0boMq+tnVogkZ2De7B4wzRMRHsyLDxN+P35WLiHDkZSDeMs4r7?= =?us-ascii?Q?nbyOQ50VpdbnnKYp9r5NFdX7pLtjTIQQjurzIEvPcSb70pLrfDi6XCDMw+bK?= =?us-ascii?Q?JDLR0AC/nNAOPABE/VzvxwH6+AwNmbvU+m7GgS86Wkcosp9J+/aHVYsqIl26?= =?us-ascii?Q?tmh3aAWOn+WQe9y8EyjLz+s2E/edJFUM8kjWK5xDF0QZthKr9mJx+fkM/gju?= =?us-ascii?Q?S4Y4Z58FFyw3zTv2t6r+Q9CE5resZZxaWEgRch+TKuGVmkDoRN9S/ZprE/5e?= =?us-ascii?Q?SyvUbAatLp6vKXP9TDAWXOd3nT4btDnIKZztnPI9Y3mOl7REZKwj7AgiZC7j?= =?us-ascii?Q?kOz3137LNHSpeY9nfj9vf9ZMoSdb8JzGw1wg4lXZE+jeHvMQcUQxu9/wWHPe?= =?us-ascii?Q?eJbJm3zBXD4rbthq96MAfuAcDHWdZb7cIMiZxXiBq5puQDXGv5CSq6FjgOJ5?= =?us-ascii?Q?SuBu+KPYtdoYQ5M5gyyGcz6PI9MpKlI+PRT5K9xXEvHUQxsBoZIe4KLN6WOI?= =?us-ascii?Q?NwDFtvaiiKTrNzANSJzPQWieks2CDNpwVXtUUC1onY0H/+PZwQ270oxIBstl?= =?us-ascii?Q?GC+d9UtjuB2Gs1jIOp69IYa4m+GKo9pGg1tVkK+enlM+DBBXJ3IU1uzVbyrG?= =?us-ascii?Q?OBK5sP2AmEg4b6ksJsBHfI4XaFt82hUdNaUwDha8cHxdsadeCi40gy2z6vBY?= =?us-ascii?Q?FU5qtaV40Wsj+QDv8b9HnciAxD79nkB8/pubZ9EB06fPTheuu94FVP5DE3JV?= =?us-ascii?Q?GgnjD+ww3iBowxQwu2p8PJw0WKDsGADVvrCNPQ2d1LYGgQvMnv8FgpwXrLy9?= =?us-ascii?Q?SA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: be0e2cc6-6de2-493c-762f-08dbe770ec5a X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 13:27:19.2040 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZFhllvSBMpIP4bExeQbCVUjFyap1BzwM3LsM5FLrEabA3EFBmkV1er7+kfpnPNDhgr4j4S1441KLm64if0HjzpZEed0NPQTVBgVQDkxZhGA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6573 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Nov 17, 2023 at 02:18:21PM +0100, David Marchand wrote: > Getting readable and consistent logs is important when running a DPDK > application, especially when troubleshooting. > A common issue with logs is when a DPDK change do not add (or on the > contrary add too many \n) in the format string. > > This issue would only get noticed when actually hitting this log (which > may be something difficult to do). > > This series proposes to introduce a new RTE_LOG helper that is > responsible for logging a one line message and spews a build error (with > gcc) if any \n is part of the format string. > > > Note: > - the first patch is intentionnally sent as a single block: splitting it > into per library commits with correct Fixes: tags is a tedious work. > I would split it for a non RFC series. For now, it is enough to show > case the idea. > - the last patch shows how an existing log macro is converted, > > very nice. I definitely think this should be implemented for 24.03 Thanks, /Bruce PS: I'm not even sure that the first patch needs to be split. I think it's fairly clear as-is.