From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5563043381; Mon, 20 Nov 2023 18:52:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07DCB42DD2; Mon, 20 Nov 2023 18:52:47 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id A4B6B4027A for ; Mon, 20 Nov 2023 18:52:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700502764; x=1732038764; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=2UauMWRhFdwfbpE9pfYADVyVePEIGISmiOkwK/i9z1o=; b=BOBkB8yxOncalO4fu33EvloTLKmLfDohwavkt2ci7WVUqQHtw2GcXFvl 706quzs6pW1cxpZRi9N37PFgj1gBfwWKQJSp14e2vlTk1VT8WZLUl/Lwo AxjtGtudrX3ICG4DkXI8VoME0DLWzcs0j9k0SIpp5CE95XhaAimTjKagC lCKM3szhId5ghlh1GsEHW6AJf23QDsx66/uPCuDIYR+D038/KVKJ35Q8N ZZMKPWrFjY6WD7QSRRQqTzE/QbcdrmfEKF96Mx14c0BZSGMeYrsx5b0NI KkWe51PiS2DA+IjD85v4HiPainVrJrOO/93Ze0eGyeFNSIE+X/8Db+dtS w==; X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="395600131" X-IronPort-AV: E=Sophos;i="6.04,214,1695711600"; d="scan'208";a="395600131" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2023 09:52:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="836793595" X-IronPort-AV: E=Sophos;i="6.04,214,1695711600"; d="scan'208";a="836793595" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Nov 2023 09:52:42 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 20 Nov 2023 09:52:41 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Mon, 20 Nov 2023 09:52:41 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Mon, 20 Nov 2023 09:52:40 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CALfaCIwx7/ATwiCsTOeBDWVC4I/Li/Mb3RqftF8oRO2SE/CqAfvjGuzOsBCRd1R4toxyYNSpai8yJAp7q9HniwzQDoy4V+i0P9AqQH+VBoFT+J+jZJxE9rIyE05/BzG41lHYDHosLxD+TXs8413aVo4TJEDE/GTM1TFY8GbEPvj0v9EgkoEZmaj1DT5GgmpB8AvJhNBpQEHstcOCcCmKxHKvxrQItGaauMyzJc1wDL2ZXikZpFg+KAuue4Xx4wMhI4JNgi3HQrxX5Owjy+o5FDfHgo7RRTiVgT+5yvNGWUO4C4oR7c3FJ/XTv62Og4LgeiUt37OESTIl3MuDkHqUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6UawU2Xnc95Z9a7zOgSwUP8fE7YWiRfZtbGIeSM2Xqw=; b=I/myPfqP76i4afPjfbwX7ExoHbPdqL92zP4O/H3OJZapwRuCsH64eV/bME0DL3Ts0a8rtQKO+uH/XKfIdhHMKx5biUiaF4eAxGQpLPN750QDye8U+S5VrzhKe/IYXwFISKMC+2EyDSwli9NROq/mADTfKP7Lx4cMJkEfeMbaASuSQcdkZmy4vb9CQP4T2Mv54t3+Bge57eUhzqWrtZnHAiStZE3PxleT0DHIbBkEfrC3vwJBUBlMkaSFLeAlzdXNGEYN1+f6xLEdHbXQHWAOUi/mwi9pFEmwt8dlbJjwrqEyP6kvmtETCjpRvNCX1ZXW8JRLAx5W5UhmMtS5ZY2k9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BL1PR11MB5398.namprd11.prod.outlook.com (2603:10b6:208:31c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.27; Mon, 20 Nov 2023 17:52:38 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7002.026; Mon, 20 Nov 2023 17:52:37 +0000 Date: Mon, 20 Nov 2023 17:52:31 +0000 From: Bruce Richardson To: Jerin Jacob CC: , Jerin Jacob Subject: Re: [PATCH 24.03 1/8] eventdev: add capability flags for supported sched types Message-ID: References: <20231120172606.505579-1-bruce.richardson@intel.com> <20231120172606.505579-2-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB7PR03CA0083.eurprd03.prod.outlook.com (2603:10a6:10:72::24) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BL1PR11MB5398:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f452200-40e7-4fde-6986-08dbe9f17bcc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CBLd5MCMQITjtywTWzRuo76EWWa7bMPCdW79poq8dWxkIAMSk7cQRlrikPYhYxSWA2RLdUFdCrOrZrJ9s528swM0N+u6fLPuLbyQeK/NAw+XDVbNTdBipQD/9fk5HfZFx4deqfT6sebudfDsy7GIWkCeOrhfiwpaHA7TgQAo8e7xZrsokrbnLqtbCfvI128tSXZFBlWC4LRqsKRXlIPb/M+foty/Sr6eqIkJEplPf2Yr3oBtYn6mqJRl6JYWC6O54tqEsEdEh4VMGuksw/S8ZYhLe9JdMkMdnOurN2qY7QuirjhLbScOCMwKxxvLmP35cHpzWbzxrV6uL2HgV5OducrCEuuk77Qsryn+/z1mLKvDzuDC8WBwy0nuuQpajnK1cFjlpHI8IDdUvfQIX3K7oPUP4dfYRTtkKgjmDnazyOCDFu0iyt4+LMgrBfGutpHrAGbKiYFzaw8EfqJPR+uZffzvX3izDUKIAqwpk02h2+uEbUp0FFt8WZ2S0GesSUjNQ9vxhzpr5hTnq/K165ZcoyVQXBp3b2/FvXbjHpQ5acesfX6qJsNwpV4v1S5nR3Z5 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(346002)(376002)(366004)(396003)(136003)(230922051799003)(64100799003)(186009)(1800799012)(451199024)(82960400001)(86362001)(6486002)(6666004)(6506007)(66476007)(6916009)(66556008)(316002)(66946007)(53546011)(6512007)(26005)(83380400001)(2906002)(44832011)(478600001)(5660300002)(38100700002)(8936002)(8676002)(4326008)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHg1ZGpheGNFR1hIWlZlazVxZFFqUzZuaS9od09NTTFFRi9GTkNsdkMwY01F?= =?utf-8?B?aTJuNStTWjlJL1JaaWZUTVFoc1pUSXljWkpQb3V6d3lUZDJDOWE1VFdZQkZ6?= =?utf-8?B?d0xsS1Z1Ui9jcTZCRE5sZWE5ODMwbHJMN2NXQlFmVzRlRFM3WDVOeFpJc1VI?= =?utf-8?B?Y0dENVNKNHZ3WHhVelRLRHBoTDdSKzZtTG5vSVJ2WFdBMUMwY0xXM0VnZDhj?= =?utf-8?B?OEhCQ3poWHVuK1VaWG83YkEyNXhMSjREL3Z4blE4Q2ZjWGJmU0pISjVzK0N1?= =?utf-8?B?TXp3b0d1KzcyQkd1UXU1S29nQXFneWJkVUtpcWVYNnZ2a3p3MDVMY0cwQWVP?= =?utf-8?B?Q1pQdzVPekZBSUpoVzFKem1URVloQmgzazhCZG5qTkprQzVER0YwNTE3eTFn?= =?utf-8?B?ZkcyR1lyc3VidHRMdEdzRGpwdDN3bU1SZEZzS0pJejdyTHd1azlNa2k1ajRY?= =?utf-8?B?ZytpZERNRS9aN3FiUkF0VWd2RWlNS3lBS0NjK0htK3Z0L0ZNd3F4cWUrK0Yv?= =?utf-8?B?anlkem9RSk1mRitSdWZndU91YmcxSm5pQ095Z0xDbGYzTHVCTnp6eUwxMExs?= =?utf-8?B?ejZIVVUrVkdlS1hxWjVrcW9WYWEwMmhGMnVkSktWSkkxZHRpbGhEcDMrZXRp?= =?utf-8?B?VFdOVk13Y1FMRGFjUkpjOVhMN1V2VWQ4Ymd0T2ttZ1hnUjI0Z1BrdjJpOGJo?= =?utf-8?B?MGJnTVlCbXIrWHNTb2lUci9ZZVF5ZnQ0VFRneisrMjZvNm5zYndMME82VFJZ?= =?utf-8?B?UUw5a3ArSi9ESlNuUnFwNGdleWpuRnJ2RVhxR1pHMFpJNTE4NXQ2a0RJYjNz?= =?utf-8?B?SE0vVUZJaWxKVVdNcjVoZE5jVUhQWUxReFhMZWFWeVhnM05TT1pxS0xMV0xq?= =?utf-8?B?cmg4ZStIK1FmUFlBRGlOOCt0TWlhQytFUnhuVmpPeDNXZ1pUS1lnbWd3b0xa?= =?utf-8?B?UWJLTytFcUVSM1YzMVRoMkdMTXI1NnI0eFJUdXZ4T0txMnoraFEwY0lNWDJw?= =?utf-8?B?Vzh5Y0wzYTdvREpVWXRmcjl6VkpUdHF2cHNQUkUvdzdWOG9DaDU5TnFVWmZY?= =?utf-8?B?SjI5Q0lwSjVyd1FDakFSNFhNL3k4ZyttQ2hJRzVkR3d0ZjRYTzFwMU0zdnA1?= =?utf-8?B?cUZLUnhyWUpKblg0dkVJSHJqVUxUSzI4YjhsdXdjaDlCVmlxc1dueUNPRDNn?= =?utf-8?B?cktFcWdIV01LR0pzZWpCMWl3NllNZTJ2ZnU2aGc1WTNjU2ZTRUlsZzRWWE1N?= =?utf-8?B?NnNWd2lqbW5QR3B4d3dSY0Rvcm5pNUwyWXJYaWFIaHFXSjFHalZBWE5sYi8x?= =?utf-8?B?NGV5MG9XaHlSUTBtQ2NiaU0xMkR2a0tLZlJGdHozTXZWUXF2UzVkVm1VL1Za?= =?utf-8?B?aUVtNllicHYwSjQwNXh2ME4yUndOZWE1R1FodzViMTQ5VDdnWHcwWjJyM2F6?= =?utf-8?B?QUF3SGpCb1lyNjlMVnRZTlRtdzREcGxCYjhVNzk1d1JlbVpHVmsxL09CMm1C?= =?utf-8?B?VVVjVkJjcjcvN3V5aDUxaFVENTVPaW5ndDBPajBQVEtkQUI2SVRaK3FkNFMz?= =?utf-8?B?bkx2L0xIQWNpVW4ycjk3MUg4T0tRUDV3RUxaZzQvUmZMSTFGekNBeFJhZXNx?= =?utf-8?B?NFljQVBrcmNWbVFhOEEybXZ5bVRRY0JlaEN6WjVxUCtMUkp2b3V1V001ZHky?= =?utf-8?B?ZjduS1ozK3l6dzU2VCtzdEtTdFRjWDVuU1RVa0hJTTY5WllYeHBtQm04S25w?= =?utf-8?B?aVZMUXZyR0tOcHp5UTIybWVrTEZqbDRMWHZvS09DbDJYdXc0akRiZklLODV1?= =?utf-8?B?ZGFjV2l1ZDVNNVFyOVdML0tSL09vRHB0Y3VqVld4dnRPUW9zZTkzaWpGRkJv?= =?utf-8?B?akVUUXpiMUQwb0tjdFdzcjVFQ2VPOUR4ZTJWRkRxUkJyZHQ2ZEsraFQ0U2Fx?= =?utf-8?B?UWpsMzRZN2ZXVkI4Ly85Y0E4RE9pUWtpSkI0enM0MEFwK2JhSTlTaWFraUFU?= =?utf-8?B?cmxHcHNkWjJEVkhLNmRxOFJpS1NGOGxvZ0RQTUU3ZlJwc3hkU3lHWXphb2JQ?= =?utf-8?B?RjVETlFBWWlFV3Zmdnh4b0htbVRKclZxWDhySi9nZFlhYXEzdVZLalNPdTRX?= =?utf-8?B?TmwwbllGdFBCK2lva3RnVklIRE9IZjh2a3R2aFEyN2UwdXJGOENBTmVoWmFD?= =?utf-8?B?eVE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7f452200-40e7-4fde-6986-08dbe9f17bcc X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 17:52:37.8042 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rKeTLqPSnLHtS47KEzhLgUKlZD7AWuIJeajArMwC7B8leh3ZLBNy8zvSkLzpodQQxBdd0BvyhZm44T3FzboseQY5qe0NeHda0F9mYN4kha4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5398 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 20, 2023 at 11:18:14PM +0530, Jerin Jacob wrote: > On Mon, Nov 20, 2023 at 11:08 PM Bruce Richardson > wrote: > > > > Not all eventdev's support all scheduling types, for example, some may > > only support atomic scheduling or others only support ordered > > scheduling. There is currently no clear indication for each driver what > > sched types it supports, so add capability flags to be indicated on > > return from rte_event_dev_info_get() API. > > > > Similarly add the possible scheduling types to the capabilities table in > > the docs. > > > > Signed-off-by: Bruce Richardson > > --- > > doc/guides/eventdevs/features/default.ini | 3 +++ > > lib/eventdev/rte_eventdev.h | 21 +++++++++++++++++++++ > > 2 files changed, 24 insertions(+) > > > > diff --git a/doc/guides/eventdevs/features/default.ini b/doc/guides/eventdevs/features/default.ini > > index e980ae134a..1cc4303fe5 100644 > > --- a/doc/guides/eventdevs/features/default.ini > > +++ b/doc/guides/eventdevs/features/default.ini > > @@ -6,6 +6,9 @@ > > ; the features table in the documentation. > > ; > > [Scheduling Features] > > +atomic_scheduling = > > +ordered_scheduling = > > +parallel_scheduling = > > queue_qos = > > event_qos = > > distributed_sched = > > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > > index ec9b02455d..9109de157e 100644 > > --- a/lib/eventdev/rte_eventdev.h > > +++ b/lib/eventdev/rte_eventdev.h > > @@ -326,6 +326,27 @@ struct rte_event; > > * than one. > > */ > > > > +#define RTE_EVENT_DEV_CAP_ATOMIC (1ULL << 13) > > +/**< Event device is capable of atomic scheduling. > > + * When this flag is set, the application can configure queues with scheduling type > > + * atomic on this event device. > > + * @see RTE_SCHED_TYPE_ATOMIC > > + */ > > + > > +#define RTE_EVENT_DEV_CAP_ORDERED (1ULL << 13) > > +/**< Event device is capable of ordered scheduling. > > + * When this flag is set, the application can configure queues with scheduling type > > + * ordered on this event device. > > + * @see RTE_SCHED_TYPE_ORDERED > > + */ > > + > > +#define RTE_EVENT_DEV_CAP_PARALLEL (1ULL << 13) > > +/**< Event device is capable of parallel scheduling. > > + * When this flag is set, the application can configure queues with scheduling type > > + * parallel on this event device. > > + * @see RTE_SCHED_TYPE_PARALLEL > > + */ > > All the caps definition is 1ULL << 13. It should be unique per capa. > Yep, good spot! Copy-paste error, naturally. :-( Will fix in a v2. /Bruce