From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6A394338D; Tue, 21 Nov 2023 10:44:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 398BC40298; Tue, 21 Nov 2023 10:44:50 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 2529D4025F for ; Tue, 21 Nov 2023 10:44:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700559887; x=1732095887; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=xZIPzpwD5+h2nB9RayXBXn/v6mxQbrE2v/AmqoOD3Ng=; b=JfGvWrTR49QgnEwHRArOK9IWddcAWSO97t3fHJ6UET5jX+IS+X0bjyIf l0EDq7lQhimSk58bkm3WzAgI882D4DJgotFHQLqz+qmpqo0PDttaWbkor 5q/MSA3AWdeyKg/86GpRn8YP7W3gCmCjKbPBwyHOBxrTiU4Mnr8OaFBD0 E5e1nsZSZFOZwT6lTH9sqwvCOdV1wp3tj45Azee22tqaWIYS1SQZyZoIh sDifA7C1bskOec/5d2KrKxgMfM0dxBHAKKb0aFq6M/SpAQ7Kq11wZ+ED/ 0kPZhr3iwsTlsF1uVywRVZqBH1ZiSusQSgd4OfNWG9e3NpPB/KHNpLETM A==; X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="456139585" X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="456139585" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2023 01:44:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="7845764" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Nov 2023 01:44:47 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 21 Nov 2023 01:44:46 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 21 Nov 2023 01:44:45 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Tue, 21 Nov 2023 01:44:45 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Tue, 21 Nov 2023 01:44:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TT9WDvYzXh3sUqP6fvFuHul6lB3LML9S7yaggLOZwIO1SD5TapSOEtQNX/pdivwnvZQis3X32s37kNkB4xQd25TGrXgxSeqTOeDc3HZVMRQmVRS/yMnhkt6uF8ERxt0/nQ0eClR5v9aMH/q5AeQ9GRI3k4chs3mo6WrUMtFadocRQYV5S1OFwKOITIzo5olexDYtgrOBpNnw1pbjL4uPKgERhayVp1moxiRNYCNhEDZUhFV+gsHWWukTI99+C4tCeq3l1ERHJ+FEFK+3nzA+ZoXxDYlIhBg6CUbBq7KDjdrJgU6XYTqmewzR6XOnyw5pvhqMPnORxT14Nl5OXpl70g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M+x/f+fDOFZ+2Fwx2eqA/6WiEaR2tMliOUquYA+vUN0=; b=W0qwSJgfML9KUEVm7jMz3Pag4Fy/nyezbdLwkb3CZjALUVm/W0ZFABdM0huw6SzQqFZtLvHHQIt39f52Yb/mpIpJlmiuqTzSWB3HWy1sMdZyfXJ6UL1zLoLBA1RJYirPC3XbRdWJHUh9/kDqQWu15QKunzV8IXkw1tlYWyTBGhp/xxEVIIZTPNAHgOT2uxuzbKpjUCF+C3NaxN83e5XDlheDNYHAPAQA39noCODT0l+TjOiJwJJzzTzIAD3hbheQAssRsxdphePVpiPEShgE4NXiZyT0zrt+qWIeX39LyBj+R72ZZgRdvdPEzllV7dZ4v6FPHOwqVrAvI75X97xRGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN2PR11MB4711.namprd11.prod.outlook.com (2603:10b6:208:24e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.28; Tue, 21 Nov 2023 09:44:43 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7002.028; Tue, 21 Nov 2023 09:44:43 +0000 Date: Tue, 21 Nov 2023 09:44:37 +0000 From: Bruce Richardson To: Mattias =?iso-8859-1?Q?R=F6nnblom?= CC: , Mattias =?iso-8859-1?Q?R=F6nnblom?= Subject: Re: [PATCH 24.03 5/8] event/dsw: add schedule-type capability flags Message-ID: References: <20231120172606.505579-1-bruce.richardson@intel.com> <20231120172606.505579-6-bruce.richardson@intel.com> <4cec531e-f3ee-41aa-ab58-0ec7abc32036@lysator.liu.se> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4cec531e-f3ee-41aa-ab58-0ec7abc32036@lysator.liu.se> X-ClientProxiedBy: DB8PR03CA0028.eurprd03.prod.outlook.com (2603:10a6:10:be::41) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN2PR11MB4711:EE_ X-MS-Office365-Filtering-Correlation-Id: a8910082-2e87-46d7-0be4-08dbea767c3f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Wk2pDqQho1DDP8IduiXqy15XxJ+DhJMXBAA/cddvtR+R2smk1nzQqlYpeA4XuRhloqqUNGT1cOegmeMjhV+8UJ1L9yGWqzmbrlQjAyEr7JvwlaA+Qyd+4MHjzfVAvbIVj9DDn9J5h1uByCY0hN1CcgmAu9EVKP+pthvMeKHq77OSAsxErXaaCGeuxm3HW7xZSlu1o362nKbH4tAWUl7lc3nE2UcqDgkNIBchpGcd1DbFT/+531rnezBVHknmZOyGDzVgN1DwlIGLjYGzCIVobiJ7UBGLn4mHoSs1QxZBvw7yTE7tBdiCFpoIzNvMKSqqQ5Sgpl3nkHyRG8CQxjSaNgsPlXTVLlz4LFFIG04dNUTTQwQGohc/bZO3AovfiHbM2F5uZNgo/wVqJCIR8/EVdvLDPzk6usjJmLeLzPCH8cfMSQd5zM55X2cC5msLC4r3cPCUefkwEPDgzuji4gvD0uo2NQCEFCI/fqYBPRbU7Fdqqr2ObGXfegSG2dWQt5m1kk9mqZqgFxHUyNpn5jkTV16dNnfjn0UlUqU4KW1muUTs+P1jvIgsKDnVSUvZpOZk X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(346002)(39860400002)(376002)(136003)(396003)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(4001150100001)(44832011)(5660300002)(4326008)(8676002)(41300700001)(8936002)(2906002)(296002)(316002)(6916009)(66946007)(66556008)(66476007)(86362001)(478600001)(26005)(6486002)(6512007)(6666004)(53546011)(6506007)(83380400001)(38100700002)(82960400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?yVWFQWWSKR1ZsxNVyDEvxiLo2bXja/VTzJs+bSVbqjG8Dkwo3nGQ/HAE9c?= =?iso-8859-1?Q?0pWibee8n3KHM1/0ovjpEBpTqXGP7fC4wnFmyuIX5N8SSRwdjq0fgHlS7R?= =?iso-8859-1?Q?w6VksHMRwVH5r1Yh7K3Nqr4Y0KaZYPoEZXbLmjahhnedFLul7t3Qk4zDRx?= =?iso-8859-1?Q?/iC69bxFZW+V6/xY+YjvekZc8NN1LwcbppC1DN0qzU7EiUIDl3ywKem2lf?= =?iso-8859-1?Q?1VXR5K1UMLbonIsg6rrlhAIkYCUH41HtghUeE2CC1wJvsklq8z799aGkKW?= =?iso-8859-1?Q?Vxuc2rpepAn+aZP5wY9nGLwZLW30BlcvNVF4nTOa3QPbTc/s7rRoqncDNU?= =?iso-8859-1?Q?0cjLd0jLgRZmnu5Ww46ONc7FhWXePFMDt/AZx+YF83ymESdwBZixEjlApA?= =?iso-8859-1?Q?3VpZvcGXIUvNOlolJe3pds6sGNdfz33uy8kSC3cjpkyZWsJKU912n45OjS?= =?iso-8859-1?Q?07pDDT72//mhOPt4ZcSXIOSuYdYlXvdH6ahXaqvobEjtQ2fBxmdalaWq3y?= =?iso-8859-1?Q?5QTdwYvAW4RdL9o8XJD1kAX2B+4yyewK+cfG1a46g89fObCfODLuU+6UTw?= =?iso-8859-1?Q?P+peK8YeDdIe/kMYnbIGap/t4vhFkIPT80NK07DDS5G1N8OVQ+7Vczcf+f?= =?iso-8859-1?Q?da/vuI8jAYFlaReii1pov+0Y+K7ZkN9wIycTQ8Us7xkO415Jgs6pjznVXL?= =?iso-8859-1?Q?HBdaAN/CgPyxS/BRwcv4/40B5dMd4/y732nY0nJU8x4i6FSSEKU169aWWO?= =?iso-8859-1?Q?MN9R3p+NjV4T5qf98GQujfGZF6Ffkl+hyNQVS+FBwWSO2mPE657aEUvzmI?= =?iso-8859-1?Q?uyG+DpKf4KIAcgo1tEqvuAw7m/deMFpRQajRrCopF9+ZV/quIPAWucq9Zv?= =?iso-8859-1?Q?YnnDR1R5jvzQ4igjJYpLukPMs92j6thXOO1f3zfxo59viIK5sTq3wBcQRw?= =?iso-8859-1?Q?MTN9t8gUTAQoJXZ2YUxxao1gKg6R5UorFzkJYjbgArhKildBQE73x6Qwof?= =?iso-8859-1?Q?R9XiteQ6f6v15nobwqllXcbQ9cc4SnCXKP7cS00LwwDYaS5fJ2+TXttye/?= =?iso-8859-1?Q?klVcb9AHi0Q3uwGyC6lgxFEajJGI6U7Vku22BK0cFe0c5eJE4P+0rROqzN?= =?iso-8859-1?Q?+0j91YuDMStxsw5P7kAYK/KbufuWN1XTdhfarSCiNw87GO4A0NoHbpAYLr?= =?iso-8859-1?Q?5FwMYExWYzIfE/GpTG+ZhMnjwYlQg2MecRsLNueIsHsJ/vvdnAlIv/RhBr?= =?iso-8859-1?Q?rEAJwr2a2wV6H+4WtN1/YzJNZrQUafFTLWXygvAQ2ze2f02efrMCsDKnc0?= =?iso-8859-1?Q?5/c+0be5LSd1bnyHuXsfKdIHym7gm7y8bwctuIc328F3ps4QZ01OugbGQy?= =?iso-8859-1?Q?vzZb9FiIC19ks0Orc3CNh2APTBQuLP4Y4hxB1igvOGWnkPPEcnbJTJWhry?= =?iso-8859-1?Q?7NyajfmHxuJxBvNupmFXRhPog+MQLqr1NPr0fJqPrRPI36rmWELYqgZ1QA?= =?iso-8859-1?Q?xHCYeEigfOwuhJ/n3IbMiVUYxpNO3NcgaLmpvBDuxwIL0t7QlOERazd7UR?= =?iso-8859-1?Q?v/+pvkSZGbB/+voDeGGJIchtxg8cn7l9ruWuSe35cJ6HuUxFz17Iq9tApg?= =?iso-8859-1?Q?Z7jSVw/1Cnd8jSJYGQ5f3V+a2sb4pJP8Om2LfCouRVIG7BmSZSwGtJqg?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a8910082-2e87-46d7-0be4-08dbea767c3f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 09:44:41.8424 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JNugvw+zziSF3mWHfywJjOyPhl4sJDhmVnjIGFD2fbZyMUg1Kf+iRCwDEuSywaw1SGh28MKe8D0Bs8KlrnxYJhT89ytu25RPxKSXp77USoI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4711 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 21, 2023 at 10:32:07AM +0100, Mattias Rönnblom wrote: > On 2023-11-21 10:30, Mattias Rönnblom wrote: > > On 2023-11-20 18:26, Bruce Richardson wrote: > > > Document explicitly the scheduling types supported by this driver, both > > > via info_get() function, and via table in the documentation. > > > > > > Signed-off-by: Bruce Richardson > > > --- > > >   doc/guides/eventdevs/features/dsw.ini | 1 + > > >   drivers/event/dsw/dsw_evdev.c         | 1 + > > >   2 files changed, 2 insertions(+) > > > > > > diff --git a/doc/guides/eventdevs/features/dsw.ini > > > b/doc/guides/eventdevs/features/dsw.ini > > > index c8bc6b3f1d..941d257e3d 100644 > > > --- a/doc/guides/eventdevs/features/dsw.ini > > > +++ b/doc/guides/eventdevs/features/dsw.ini > > > @@ -4,6 +4,7 @@ > > >   ; Refer to default.ini for the full list of available PMD features. > > >   ; > > >   [Scheduling Features] > > > +atomic_scheduling          = Y > > >   distributed_sched          = Y > > >   burst_mode                 = Y > > >   nonseq_mode                = Y > > > diff --git a/drivers/event/dsw/dsw_evdev.c > > > b/drivers/event/dsw/dsw_evdev.c > > > index 1209e73a9d..a68ca1fe30 100644 > > > --- a/drivers/event/dsw/dsw_evdev.c > > > +++ b/drivers/event/dsw/dsw_evdev.c > > > @@ -220,6 +220,7 @@ dsw_info_get(struct rte_eventdev *dev __rte_unused, > > >           .max_num_events = DSW_MAX_EVENTS, > > >           .max_profiles_per_port = 1, > > >           .event_dev_cap = RTE_EVENT_DEV_CAP_BURST_MODE| > > > +        RTE_EVENT_DEV_CAP_ATOMIC | > > >           RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED| > > >           RTE_EVENT_DEV_CAP_NONSEQ_MODE| > > >           RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT| > > > -- > > > 2.39.2 > > > > > > > Acked-by: Mattias Rönnblom > > Eh, hold on. PARALLEL is also supported. > Sorry, missed that. Will add in V2. > Do we need a capability for single link as well? I was wondering about that myself. For this v1 I decided against it because any ordered or atomic queue can be single link by just binding it to a single port. The actual single link flag is jut a hint allow the driver to be more efficient about resourcing. However, if you think it's worthwhile calling out explicitly I can certainly add it. /Bruce