From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B5B64338D; Tue, 21 Nov 2023 10:48:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A58042E93; Tue, 21 Nov 2023 10:48:03 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 0508240298 for ; Tue, 21 Nov 2023 10:48:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700560081; x=1732096081; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=riPE1hIoN5yb0vNrrz9e2/JgCJQ6PpLZ+oue5pph1NI=; b=IhYTlunhPbWLbjnyDW3ZKDvUiwhq70ag9nA355Ae1RldDJZ7b0ngazzt 5Zmo8E/rCoDC3SJ8ULK5cvvXKx9oTcKtkGwMiPv0jhgd8XL+U6MSFy+P+ TLx5BgO5twpIJQfmk9C+SjkZ2G8Ej1JADOXH6o5tTV4w7CdN53I0SPz/Q TIC++dbMPPTzf08fLqLxxr2rsCeAeduth0XzC/PbdP+ZLV4q+QexOo2IO BxMiuKB7c8QKYLRl/x6zg+nfwiQBtaEWUBWlWgTjBAHX1QJ+Mb34iVEYS dNs4X6SHVaSrcvzMfWHS6wHdUef+RWbwBHinf44dx63B9SHEnXIrubAlc A==; X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="371978894" X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="371978894" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2023 01:48:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="8030555" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Nov 2023 01:48:00 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 21 Nov 2023 01:47:59 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Tue, 21 Nov 2023 01:47:59 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Tue, 21 Nov 2023 01:47:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bAzrHm2pRU2Z/fAJsGSfqb6SJX7Ux7cDVKRltJ1KEAoRsptAK73sB+nz9G4Ay2sLS7zWWZ14pBPCDpBQrz8WPqKIAAVrMvofs5GOyqyRFXssWuPXygBKZGSiE6/aSPVZlZJtbkuGvhpvcIx3ZzBLA5mAK4nK0kSnGOOLKCrzndqeKRtWpd3yP42hlrcNYbW5C5Dqgbyp8BPfPOhl12NYah4d8Rindckygw4vclOggWYnkJzejNul8Nvbv+ADbJkrTqEn2g9JAiahKFUIP4Duc7nNQkFweqfFc88rsyXgd8m5vop2/w6LC0IKf1kMoADeWs+hTISRg6aNNMiW+qkHpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jdrDOJtGRt+hfcqFhJ4Lw2L08OW8C02Tq0jlyuqR2XQ=; b=Od5TH6DGZYwPEbjfL9dCKyKErtchJh/qZCphSdcrFruc4fA+m5kAErNi73kBxNkzF5FyZI/coyaoEqqig5VoLI+sQOFnXk7GV8uE0msKUNdUdu7gs8smQW8bE9da4eg8RqVY0pMfe+pYJokDpfcCXDcW/32frwfmtX+1FiD1vDUbkIie+t7/AjdxFA3fcYX7zjrDVI1gJTjETmRzxvb05CKNW9DuWLAsrchk3dEY8xyP2kQLAqJvXC0Rwa6mOnGn2CZ7w78TpZRvwIqaBb3T5gfIJwT+ByYT5b0tf3cXY6t+PVeI9gBXbycI7CVUdu6LM46vyAakZzGIIw2KT9Lbrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN2PR11MB4711.namprd11.prod.outlook.com (2603:10b6:208:24e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.28; Tue, 21 Nov 2023 09:47:57 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7002.028; Tue, 21 Nov 2023 09:47:57 +0000 Date: Tue, 21 Nov 2023 09:47:53 +0000 From: Bruce Richardson To: Mattias =?iso-8859-1?Q?R=F6nnblom?= CC: , Mattias =?iso-8859-1?Q?R=F6nnblom?= Subject: Re: [PATCH 24.03 5/8] event/dsw: add schedule-type capability flags Message-ID: References: <20231120172606.505579-1-bruce.richardson@intel.com> <20231120172606.505579-6-bruce.richardson@intel.com> <4cec531e-f3ee-41aa-ab58-0ec7abc32036@lysator.liu.se> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0243.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b5::11) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN2PR11MB4711:EE_ X-MS-Office365-Filtering-Correlation-Id: fbe83139-d6cc-4ad6-df20-08dbea76f0dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cs2Sz2XiPlqlfclursN4OoJCYdIrwqkULiUyLjyVC9F8UXuFF0U3tZjr3w6Otocb9fnIcJK+aXWZXw7EE6vobI5rRMuUB3nTiGq2CXt4eBfXbeKjqDxbyExBdnUpbJPgaC0M6zVCs5ASyY0iBZyZchGfHd99qDK5yzrTxFZUPrL3ihwh8qXvizRGvw8qPeL02o9EuwR2cwDDBXOD2faZgklXJqRmSMDLaA/lNebjJ+W/M4T5g4KhxSO+QU8sGGwyv5W/9h68YNnB9f0f5ylj0os6E5zUO/9byFUvcWvN5UnYor/Dd3/lE3U2/6lHeqolRmFICirompxeyZ/7ps/9nQsYHSPRH2hdB76F02Yi5AR093ky9GQq+a6+OmaNUdgN3c6H+0Ui3zBzAk5u8+u5V3AmtXwqNk6lx93vu2tb/ePHEoSt0MFa8W9use1nLuYaQnnbXEcKQTXKbnlWde2uPJp8YYTvljTxj4hSKgqt670jDkhtbjL6uKKLOiH3omyoUO117SJKGVwqeQ1MvH+UgXOI3zdcPPTDatwodzfZvz4RdKZF8b+aiRoDPFsfmlzj X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(346002)(39860400002)(376002)(136003)(396003)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(4001150100001)(44832011)(5660300002)(4326008)(8676002)(41300700001)(8936002)(2906002)(296002)(316002)(6916009)(66946007)(66556008)(66476007)(86362001)(478600001)(26005)(6486002)(6512007)(6666004)(53546011)(6506007)(83380400001)(38100700002)(82960400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?6uH8B2N8c5jy/8w7SQe0SvGH7y0LUFEoAmd2mkPh6ejiLr/p5TKMrIzYqY?= =?iso-8859-1?Q?jqW2cLiS6X5/5dbXDXQ5L+CvVbYL04+v0XIehQvQquqy4dwmMBa+WYkwL5?= =?iso-8859-1?Q?Yw8yiwMJdtbiAwAr0Y6mHTvvRWxz1fstI5fSaBc5HF6OltA8EO2XJzXyqw?= =?iso-8859-1?Q?kKTPzckre5LD7WFxoH9iMb+Tzspvba6lEPNTe9s9y35fR3/eXbxybVYmc5?= =?iso-8859-1?Q?6K2Vd0/WYfDf8NwNp5DEhOctaXsCDJITHMvIDgQwCZ+ROqkwyEod30FZIf?= =?iso-8859-1?Q?R7vnk1mRBck8TOqkKDxFkkuiGeVjckj6Q17diL5mwE/Vs8f3GwErl2oJc/?= =?iso-8859-1?Q?V46y/aqwiQVI/bRVtRYzAEhlZYUdqh15zobwQErjmZHJy923Gw7wzgJbUA?= =?iso-8859-1?Q?XV+xnIS9C83j3k+o4ihbbyk/i6BScE/KEdYBf/rR+YuvG9VOEu+ly7kbDl?= =?iso-8859-1?Q?HrpJQIuYYD5ektK7z4bMJSzvc2DcMnPi4wU5iOOaiH0QSele5k72ZVEmGr?= =?iso-8859-1?Q?/DayDCsg8H61+CaEtiNsUxJIHdNW8E97cCaSTsUiw9lerzmO+WqKFl8O0U?= =?iso-8859-1?Q?woZMdLXdf3sszoVMZcFDnqkiVXEpoYno+v8OKiL3IWhTHqYXn6jCgeyajk?= =?iso-8859-1?Q?yIW63MHm2+jBqVlKue02ULSqg1x+97pUk/3zruAiOCXHMZNzkPw98yeB7Z?= =?iso-8859-1?Q?k1J4IkfF3K95XDPNjcO22SFsQSLv+kR5caOKcFGxh9vx1pSikHwCOKiH63?= =?iso-8859-1?Q?o/vtjGnI+ge35xGqHcoMs0SCS+UkiCwfstn5K1RX/Vh2+qYt+GE414Lchs?= =?iso-8859-1?Q?KuVUQgMQ8btGhGcOK6TA30zI52GVh2PjFROsaRTq2BfRVgiBXcdxtXrKgF?= =?iso-8859-1?Q?fUvIjhjt6IAYD2/YaXrzcV/pRnNgXc0gIgw4QZsNpiPglNJVmbxYoNtK9B?= =?iso-8859-1?Q?9h6B2jGGJyriEOU5JpMzSLxpEc3RtNJr4YL/7QShyzwNeCGM/q8gquh3mV?= =?iso-8859-1?Q?PLW3q6lCNVDrljIPE9qCMdHc1/xIhyCXlibwkpcwOwP+RLcR+0QxRcg+m3?= =?iso-8859-1?Q?Z8SZczyAPBhAjzGAkFw9EUdoRTAIYN8cMVfgYkbzo2kHK0DlFaikFBV14A?= =?iso-8859-1?Q?LwVqHYKDXU6ThZuKKQY9DbcFIa/7aJq4m04YHOj7fMmjNU6a6ioPwOH4GY?= =?iso-8859-1?Q?j2lalOPz5u2y+ty5yT2flfLaYD792qHs0rmuZbcMQR7yxp58Y1mN59X8DA?= =?iso-8859-1?Q?vTbubFgorvXqxgazTsdEG9/I1NetvUFl08qSEa4GTNhFNNeqEI2bOhvan+?= =?iso-8859-1?Q?3DfmIQMn+fZnUroQAL/C+orFxRiTdFilN6tBSbEinqmCrbBaxetnnDWwfm?= =?iso-8859-1?Q?tbHMDxQ6LEDuV3BjzyE2HFgoF1HwkUJ4H+zWeOiOU4luIesZYoWNmpGZeM?= =?iso-8859-1?Q?alqAxfoINW2MsHiNwb6KTNfsdlmIgNLO53gO8BVRyIvrLZI8N7iwhounXF?= =?iso-8859-1?Q?rWaz9/ufTkAjqyEOSN7pdieGR+h+nHrDXB+5LQfdR7HbvEhSKst2LKsgJs?= =?iso-8859-1?Q?w35LoxpZvWM04vGmjzvaoZ6ms//dTDKxctEiNenRyADZv/+jqHqyTJhR1b?= =?iso-8859-1?Q?aMpsTrXMhKGbTgYweqzUCwh9E4gaX6JancihJAGeZZEa/Q9oD6AT+FVw?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: fbe83139-d6cc-4ad6-df20-08dbea76f0dc X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 09:47:57.4025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UEk8huBlMGABXrGNIX4Qt4nnjt7tBIE6NqajRL28+UKA5QPMpUVug8Jjf1HUR1+4NBAxiKHZPSoLowMMkz+jOAvx3R+qoBjB9ptoH3Mhzlc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4711 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 21, 2023 at 09:44:37AM +0000, Bruce Richardson wrote: > On Tue, Nov 21, 2023 at 10:32:07AM +0100, Mattias Rönnblom wrote: > > On 2023-11-21 10:30, Mattias Rönnblom wrote: > > > On 2023-11-20 18:26, Bruce Richardson wrote: > > > > Document explicitly the scheduling types supported by this driver, both > > > > via info_get() function, and via table in the documentation. > > > > > > > > Signed-off-by: Bruce Richardson > > > > --- > > > >   doc/guides/eventdevs/features/dsw.ini | 1 + > > > >   drivers/event/dsw/dsw_evdev.c         | 1 + > > > >   2 files changed, 2 insertions(+) > > > > > > > > diff --git a/doc/guides/eventdevs/features/dsw.ini > > > > b/doc/guides/eventdevs/features/dsw.ini > > > > index c8bc6b3f1d..941d257e3d 100644 > > > > --- a/doc/guides/eventdevs/features/dsw.ini > > > > +++ b/doc/guides/eventdevs/features/dsw.ini > > > > @@ -4,6 +4,7 @@ > > > >   ; Refer to default.ini for the full list of available PMD features. > > > >   ; > > > >   [Scheduling Features] > > > > +atomic_scheduling          = Y > > > >   distributed_sched          = Y > > > >   burst_mode                 = Y > > > >   nonseq_mode                = Y > > > > diff --git a/drivers/event/dsw/dsw_evdev.c > > > > b/drivers/event/dsw/dsw_evdev.c > > > > index 1209e73a9d..a68ca1fe30 100644 > > > > --- a/drivers/event/dsw/dsw_evdev.c > > > > +++ b/drivers/event/dsw/dsw_evdev.c > > > > @@ -220,6 +220,7 @@ dsw_info_get(struct rte_eventdev *dev __rte_unused, > > > >           .max_num_events = DSW_MAX_EVENTS, > > > >           .max_profiles_per_port = 1, > > > >           .event_dev_cap = RTE_EVENT_DEV_CAP_BURST_MODE| > > > > +        RTE_EVENT_DEV_CAP_ATOMIC | > > > >           RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED| > > > >           RTE_EVENT_DEV_CAP_NONSEQ_MODE| > > > >           RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT| > > > > -- > > > > 2.39.2 > > > > > > > > > > Acked-by: Mattias Rönnblom > > > > Eh, hold on. PARALLEL is also supported. > > > > Sorry, missed that. Will add in V2. > > > Do we need a capability for single link as well? > > I was wondering about that myself. For this v1 I decided against it > because any ordered or atomic queue can be single link by just binding it > to a single port. The actual single link flag is jut a hint allow the > driver to be more efficient about resourcing. > However, if you think it's worthwhile calling out explicitly I can > certainly add it. If we have such a flag, we should look to have eventdev "emulate" single-link via ordered or atomic queues for drivers that don't directly support it. I'm concerned that the number of different capability options makes it difficult to write truly portable apps. /Bruce